Fixing bug with ARRAY_CONTAINS in annotated queries. #31179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests to prevent further regressions.
trande4884
requested review from
kushagraThapar,
FabianMeiswinkel,
backwind1233,
chenrujun,
hui1110,
Netyyyy,
saragluna,
stliu,
yiliuTo,
xinlian12,
moarychan,
aayush3011,
simorenoh and
fangjian0423
as code owners
ghost
added
...os/src/main/java/com/azure/spring/data/cosmos/repository/support/StringBasedCosmosQuery.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Great work @trande4884 , however the PR description mentions the unit tests. Couldn't find them in the PR. Can you please point to those?
...os/src/main/java/com/azure/spring/data/cosmos/repository/support/StringBasedCosmosQuery.java
Outdated
Show resolved
Hide resolved
Fixing comment and code style check.
trande4884
commented
Sep 28, 2022
...test/src/test/java/com/azure/spring/data/cosmos/repository/integration/AnnotatedQueryIT.java
Show resolved
Hide resolved
kushagraThapar
approved these changes
Sep 28, 2022
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
Closed
3 tasks
|
Isn't the same fix required for StringBasedReactiveCosmosQuery.java ? |
|
@maximdomentii valid point, @trande4884 can you please port this for reactive repository as well, thanks! |
|
@maximdomentii I will get this done, it can be tracked here: #33764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing bug with ARRAY_CONTAINS in annotated queries. Adding more integration tests to prevent further regressions. This bug was introduced by fixing the IN clause with annotated queries. There are now integration tests for both IN and ARRAY_CONTAINS annotated queries to prevent future regressions.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines