Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding responseContinuationTokenLimitInKb support to the Spring SDK. #30980

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

trande4884
Copy link
Member

@trande4884 trande4884 commented Sep 15, 2022

Description

Adding responseContinuationTokenLimitInKb support to the Spring SDK.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trande4884 great work, looks good to me.
I think we should add some more documentation for this new setting in the readme.md section.
This documentation is helpful and I think spring users should know about this when setting it - https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosQueryRequestOptions.java#L274

Specially this section ->

The continuation token contains both required and optional fields. The
* required fields are necessary for resuming the execution from where it was
* stooped. The optional fields may contain serialized index lookup work that
* was done but not yet utilized. This avoids redoing the work again in
* subsequent continuations and hence improve the query performance. Setting the
* maximum continuation size to 1KB, the Azure Cosmos DB service will only
* serialize required fields. Starting from 2KB, the Azure Cosmos DB service
* would serialize as much as it could fit till it reaches the maximum specified
* size.

@kushagraThapar
Copy link
Member

/check-enforcer override

@kushagraThapar kushagraThapar enabled auto-merge (squash) September 20, 2022 05:31
@kushagraThapar
Copy link
Member

/check-enforcer reset

@kushagraThapar kushagraThapar merged commit c9d1e16 into Azure:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues Cosmos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]azure-spring-data-cosmos missing feature for user to set the ResponseContinuationTokenLimitInKb
2 participants