Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle build failure #8

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Fix Gradle build failure #8

merged 2 commits into from
Nov 17, 2017

Conversation

josmil1
Copy link
Contributor

@josmil1 josmil1 commented Nov 13, 2017

Requires upgrade to Android Studio 3.0

@HansKristian-Work
Copy link
Contributor

Requiring 3.0 is a bit much (lots of breakage in 3.0), can you try to update support for 2.3.3?

@josmil1
Copy link
Contributor Author

josmil1 commented Nov 13, 2017

Hi Hans-Kristian, what do you mean? All samples seemed to build and run fine

@HansKristian-Work
Copy link
Contributor

HansKristian-Work commented Nov 13, 2017

Does this also work out-of-the-box with a clean Android Studio 2.3.3 install? If it does, this is fine.

Also, 3.0.0 doesn't work for me with command line building which is not great.

@josmil1
Copy link
Contributor Author

josmil1 commented Nov 13, 2017

Unfortunately Gradle 3.0.0 requires Android Studio 3.0. I tried installing Android Studio 2.2.3 but this commit does not work, worth investigating further?
The reason I updated Android Studio was to solve this issue: #7

@HansKristian-Work
Copy link
Contributor

Gradle 2.3.3 should work on Android Studio 3.0 as well.

@josmil1
Copy link
Contributor Author

josmil1 commented Nov 13, 2017

Indeed, I checked that Gradle 2.3.3 works on Android Studio 3.0. However, would you like me to try some other version of Android Studio? It is incompatible with Android Studio 2.2.3 for example.

@HansKristian-Work
Copy link
Contributor

2.3.3 is good enough I think.

@JoseEmilio-ARM
Copy link
Contributor

OK sorry, I am getting a bit confused between Android Studio version, Gradle version, and Gradle Plugin version.
I can confirm that the Gradle Plugin version 2.3.3 (and Gradle version 4.1) works with Android Studio versions 2.3.3 and 3.0.

@JoseEmilio-ARM
Copy link
Contributor

Updated the Plugin version, anything else?

@JoseEmilio-ARM JoseEmilio-ARM merged commit 2a6d527 into master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants