Changeset 78

Timestamp:

May 28, 2001, 9:47:12 AM (24 years ago)

Author:

umoeller

Message:

Misc changes.

Location:

trunk/src/helpers

Files:

• apps.c (modified) (11 diffs)
• semaphores.c (modified) (4 diffs)

trunk/src/helpers/apps.c

@@ -102 +102 @@
  *
  *@@added V0.9.4 (2000-08-02) [umoeller]
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from dosh2.c to apps.c
  */
 
@@ -156 +157 @@
  *
  *@@added V0.9.4 (2000-07-19) [umoeller]
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from dosh2.c to apps.c
  */
 
@@ -196 +198 @@
  *@@added V0.9.4 (2000-07-19) [umoeller]
  *@@changed V0.9.12 (2001-05-21) [umoeller]: fixed memory leak
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from dosh2.c to apps.c
  */
 
 PSZ* appFindEnvironmentVar(PDOSENVIRONMENT pEnv,
-                            PSZ pszVarName)
+                           PSZ pszVarName)
 {
     PSZ *ppszRet = 0;
@@ -272 +275 @@
  *@@changed V0.9.12 (2001-05-21) [umoeller]: fixed memory leak
  *@@changed V0.9.12 (2001-05-26) [umoeller]: fixed crash if !fAddFirst
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from dosh2.c to apps.c
  */
 
@@ -363 +367 @@
  *
  *@@added V0.9.4 (2000-07-19) [umoeller]
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from dosh2.c to apps.c
  */
 
@@ -434 +439 @@
  *
  *@@added V0.9.4 (2000-07-19) [umoeller]
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from dosh2.c to apps.c
  */
 
@@ -486 +492 @@
  *@@added V0.9.6 (2000-10-16) [umoeller]
  *@@changed V0.9.7 (2001-01-15) [umoeller]: now using XSTRING
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from winh.c to apps.c
  */
 
@@ -564 +571 @@
  *
  *@@added V0.9.9 (2001-03-07) [umoeller]
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from winh.c to apps.c
  */
 
@@ -735 +743 @@
  *      --  If PROGDETAILS specifies a Win-OS/2 session
  *          and PROGDETAILS.pszEnvironment is empty,
- *          this merges the current process environment
- *          with the default Win-OS/2 environment.
+ *          this uses the default Win-OS/2 environment.
  *          See appQueryDefaultWin31Environment.
  *
@@ -756 +763 @@
  *@@changed V0.9.9 (2001-01-27) [umoeller]: crashed if PROGDETAILS.pszExecutable was NULL
  *@@changed V0.9.12 (2001-05-26) [umoeller]: fixed PROG_DEFAULT
+ *@@changed V0.9.12 (2001-05-27) [umoeller]: moved from winh.c to apps.c
  */
 
@@ -918 +926 @@
             PSZ pszTemp = appQueryDefaultWin31Environment();
 
-            /* if (!appParseEnvironment(pszTemp,
-                                     &Env)) */
+            if (!appParseEnvironment(pszTemp,
+                                     &Env))
             {
                 // now override KBD_CTRL_BYPASS=CTRL_ESC

trunk/src/helpers/semaphores.c

@@ -169 +169 @@
  *      I have created, this returns an APIRET.
  *
- *@@added V0.9.12 (2001-05-27) [umoeller]
  */
 
@@ -187 +186 @@
  *@@ UnlockGlobal:
  *
- *@@added V0.9.12 (2001-05-27) [umoeller]
  */
 
@@ -258 +256 @@
  *          was set to NULLHANDLE.
  *
- *      --  ERROR_SEM_BUSY: couldn't delete one
- *          of the member semaphores because they
- *          were held by some other thread.
- */
-
-APIRET semDeleteRWMutex(PHRW phrw)
+ *      --  ERROR_SEM_BUSY: semaphore is currently
+ *          requested.
+ */
+
+APIRET semDeleteRWMutex(PHRW phrw)      // in/out: rwsem handle
 {
     APIRET  arc = NO_ERROR;
@@ -274 +271 @@
            )
         {
-            if (    (!(arc = DosCloseEventSem(pMutex->hevWriterDone)))
-                 && (!(arc = DosCloseEventSem(pMutex->hevReadersDone)))
+            if (    (pMutex->cReaders)
+                 || (pMutex->cWriters)
                )
+                arc = ERROR_SEM_BUSY;
+            else
             {
-                ULONG cItems = pMutex->cReaderThreads;
-                TREE **papNodes = treeBuildArray(pMutex->ReaderThreadsTree,
-                                                 &cItems);
-                if (papNodes)
+                if (    (!(arc = DosCloseEventSem(pMutex->hevWriterDone)))
+                     && (!(arc = DosCloseEventSem(pMutex->hevReadersDone)))
+                   )
                 {
-                    ULONG ul;
-                    for (ul = 0; ul < cItems; ul++)
-                        free(papNodes[ul]);
-
-                    free(papNodes);
+                    ULONG cItems = pMutex->cReaderThreads;
+                    TREE **papNodes = treeBuildArray(pMutex->ReaderThreadsTree,
+                                                     &cItems);
+                    if (papNodes)
+                    {
+                        ULONG ul;
+                        for (ul = 0; ul < cItems; ul++)
+                            free(papNodes[ul]);
+
+                        free(papNodes);
+                    }
+
+                    free(pMutex);
+                    *phrw = NULLHANDLE;
                 }
-
-                free(pMutex);
-                *phrw = NULLHANDLE;
             }
         }