Changeset 47

Timestamp:

Mar 13, 2001, 1:20:46 PM (24 years ago)

Author:

umoeller

Message:

misc changes

Location:

trunk/src/helpers

Files:

• cctl_tooltip.c (modified) (4 diffs)
• configsys.c (modified) (1 diff)
• linklist.c (modified) (7 diffs)
• textview.c (modified) (2 diffs)
• tmsgfile.c (modified) (4 diffs)
• winh.c (modified) (2 diffs)
• xml.c (modified) (2 diffs)

trunk/src/helpers/cctl_tooltip.c

@@ -967 +967 @@
              *          of the window that contains the area, and the "rect" member must
              *          specify the client coordinates of the area's bounding
-             *          rectangle. ### not implemented yet
+             *          rectangle.
              *
              *      --  When you add a tool implemented as a window, the "hwndTool"
@@ -988 +988 @@
              *
              *      To retrieve the text for a tool, use the TTM_GETTEXT message.
+             *
+             *@@todo: add tool rectangles
              */
 
@@ -1286 +1288 @@
              *      Additional note: On input, if TOOLINFO.lpszText == PSZ_TEXTCALLBACK,
              *      this sends the TTN_NEEDTEXT notification to TOOLINFO.hwnd.
+             *
+             *@@todo add TTFMT_STRINGRES
              */
 
@@ -1318 +1322 @@
 
                         case TTFMT_STRINGRES:
-                            // ### not supported yet
+
                         break;
                     }

trunk/src/helpers/configsys.c

@@ -983 +983 @@
                     if (pszDeletedLine)
                     {
-                        // did we delete a line?  ###
+                        // did we delete a part?
                         xstrcat(pstrChanged, "DLP ", 0);
                         xstrcat(pstrChanged, pManip->pszNewLine, 0);

trunk/src/helpers/linklist.c

@@ -15 +15 @@
  *      <B>Usage:</B>
  *
+ *      Linked lists are implemented through the LINKLIST structure.
+ *      This can either be created on the stack or as a global variable
+ *      (and must then be initialized using lstInit) or from the heap
+ *      with lstCreate.
+ *
  *      Each list item is stored in a LISTNODE structure, which in
  *      turn has a pItemData field, which you can use to get your
- *      data. So a typical list would be coded like this:
- *
+ *      data. So a typical list would be coded like this (this is
+ *      a heap list):
+ *
+ +
+ +          typedef struct _YOURDATA
+ +          {
+ +              ULONG ulWhatever;
+ +          } YOURDATA, *PYOURDATA
+ +
  +          // fill the list
  +          PLINKLIST pll = lstCreate(TRUE or FALSE);
  +          while ...
  +          {
- +              PYOURDATA pYourData = ...
+ +              PYOURDATA pYourData = (PYOURDATA)malloc(sizeof(YOURDATA));
  +              lstAppendItem(pll, pYourData);  // store the data in a new node
  +          }
@@ -56 +68 @@
 
 /*
- *      Copyright (C) 1997-2000 Ulrich M”ller.
+ *      Copyright (C) 1997-2001 Ulrich M”ller.
  *      This file is part of the "XWorkplace helpers" source package.
  *      This is free software; you can redistribute it and/or modify
@@ -120 +132 @@
 /*
  *@@ lstInit:
- *      this initializes a given linked list.
+ *      this initializes a given LINKLIST structure.
+ *
  *      This is useful only if you have a static
- *      LINKLIST structure in your sources and don't
- *      use lstCreate/lstFree to have lists created
- *      dynamically. In that case, use this function
- *      as follows:
+ *      LINKLIST structure in your sources (either as
+ *      a global variable or as a stack variable) and
+ *      don't use lstCreate/lstFree to have lists created
+ *      from the heap.
+ *
+ *      In that case, use this function as follows:
  +
  +          LINKLIST llWhatever;
@@ -138 +153 @@
  *      invoked on list items automatically in lstClear,
  *      lstRemoveNode, and lstRemoveItem.
- *      Set this to TRUE if you have created the
- *      list items yourself. Set this to FALSE if
- *      you're storing other objects, such as numbers
- *      or other static items.
- *
- *      This of course will be a "flat" free(). If
- *      you store structures in the list using other
- *      heap pointers, auto-free would cause memory leaks.
- *
- *      Also, auto-free only works if the malloc() that
- *      has been used on the list item is in the same C
- *      runtime as with the linklist functions. If the
- *      caller uses a different runtime (e.g. from a DLL),
- *      it can use lstMalloc() for allocating the list
- *      item and still use auto-free.
+ *
+ *      --  Set this to TRUE if you have created the
+ *          list items yourself using malloc().
+ *
+ *          This of course will be a "flat" free(). If
+ *          you store structures in the list using other
+ *          heap pointers, auto-free would cause memory leaks.
+ *
+ *          Also, auto-free only works if the malloc() that
+ *          has been used on the list item is in the same C
+ *          runtime as with the linklist functions. If the
+ *          caller uses a different runtime (e.g. from a DLL),
+ *          it  can use lstMalloc() for allocating the list
+ *          item and still use auto-free.
+ *
+ *      --  Set this to FALSE if you're storing other
+ *          objects, such as numbers or other static items.
  *
  *      Note: You better call lstInit only once per list,
@@ -185 +202 @@
  *      when the list was initialized (lstInit), free()
  *      will be invoked on all data item pointers also.
- *      See the remarks there.
+ *      See the remarks for lstInit.
  *
  *      Returns FALSE only upon errors, e.g. because
@@ -259 +276 @@
  *      using lstFree.
  *
- *      If (fItemsFreeable == TRUE), free() will be
- *      invoked on list items automatically in lstFree,
- *      lstRemoveNode, and lstRemoveItem.
- *      Set this to TRUE if you have created the
- *      list items yourself. Set this to FALSE if
- *      you're storing other objects, such as numbers
- *      or other static items.
+ *      See lstInit for the description of fItemsFreeable.
  *
  *      Returns NULL upon errors.
@@ -298 +309 @@
  *      when the list was created (lstCreate), free()
  *      will be invoked on all data item pointers also.
- *      See the remarks there.
- *
- *      This must only be used with dynamic lists created
+ *      See the remarks for lstInit.
+ *
+ *      This must only be used with heap lists created
  *      with lstCreate.
  */

trunk/src/helpers/textview.c

@@ -810 +810 @@
         {
             // four characters with hex anchor index (>=1)
-            // or ####
+            // or "####"
             if (  *( (*ppCurrent)+2 )
                   == '#'
@@ -1071 +1071 @@
  *
  *@@changed V0.9.3 (2000-05-06) [umoeller]: largely rewritten; now handling paragraph and character formats
+ *@@todo TXVWORDF_GLUEWITHNEXT
  */
 

trunk/src/helpers/tmsgfile.c

@@ -292 +292 @@
         {
             // create a temporary buffer for replacements
-            PSZ             pszTemp = (PSZ)malloc(cbBuffer); // ### memory leak here!
+            PSZ             pszTemp = (PSZ)malloc(cbBuffer);
 
             if (!pszTemp)
@@ -373 +373 @@
 
                 ulBytesRead = ulTargetWritten;
-            }
+
+                free(pszTemp);      // V0.9.9 (2001-03-13) [umoeller]
+            } // if pszTemp
         }                           // end if (cTable)
 
@@ -478 +480 @@
  *@@changed V0.9.1 (99-12-12) [umoeller]: file last-write date is now reset when EAs are written
  *@@changed V0.9.1 (2000-02-01) [umoeller]: now skipping leading spaces in msg
+ *@@todo handle 64KB EA limit
  */
 
@@ -766 +769 @@
 
         // write new timestamp and table
-        // ### handle 64 kb limit here !!!
+        // @@todo handle 64 kb limit here !!!
         if (rc == NO_ERROR)
         {

trunk/src/helpers/winh.c

@@ -2873 +2873 @@
  *@@changed V0.9.7 (2000-12-17) [umoeller]: PROGDETAILS.pszEnvironment no longer zeroed
  *@@changed V0.9.9 (2001-01-27) [umoeller]: crashed if PROGDETAILS.pszExecutable was NULL
+ *@@todo PROG_DEFAULT ain't working; test winhQueryAppType
  */
 
@@ -2918 +2919 @@
             case ((ULONG)-1):       // we get that sometimes...
             case PROG_DEFAULT:
-                // ###
+                // @@todo
             break;
         }

trunk/src/helpers/xml.c

@@ -1848 +1848 @@
  *      @expat handler for @notation_declarations.
  *
- *      ###
+ *      @@todo
  *
  *@@added V0.9.9 (2001-02-14) [umoeller]
@@ -1950 +1950 @@
  *
  *      It is the application's responsibility to free this data
- *      structure. ###
+ *      structure. @@todo
  *
  *      The XML spec defines that no element may be declared more