Changeset 416 for branches/branch-1-0/src/helpers

Timestamp:

Aug 30, 2014, 8:24:36 PM (11 years ago)

Author:

pr

Message:

ACPI power off changes from David.

File:

• branches/branch-1-0/src/helpers/acpih.c (modified) (9 diffs)

branches/branch-1-0/src/helpers/acpih.c

@@ -17 +17 @@
 
 /*
- *      Copyright (C) 2006-2013 Paul Ratcliffe.
+ *      Copyright (C) 2006-2014 Paul Ratcliffe.
  *      This file is part of the "XWorkplace helpers" source package.
  *      This is free software; you can redistribute it and/or modify
@@ -79 +79 @@
  *@@ acpihOpen:
  *      resolves the ACPI entrypoints and loads the ACPI DLL.
+ *
+ *@@changed V1.0.10 (2014-08-30) [dazarewicz]: Call ACPI start API func.
  */
 
@@ -140 +142 @@
         G_ulCount++;
 
-        // @@added V1.0.9 (2012-12-10) [slevine]: use AcpiTkPrepareToSleep rather than workaround
-        /* This function does not exist in older versions of acpi
-         * As a result the shutdown attempt will usually hang because
-         * the required code has not been committed into memory.
-         */
-        if (pAcpiTkPrepareToSleep)
-            pAcpiTkPrepareToSleep(ACPI_STATE_S5);
-
         return(pAcpiStartApi(phACPI));
     }
+}
+
+/*
+ *@@ acpihPrepareToSleep:
+ *      Prepares the system to sleep or power off
+ *
+ *@@added V1.0.10 (2014-08-30) [dazarewicz]
+ */
+
+VOID acpihPrepareToSleep(UCHAR ucState)
+{
+    // @@added V1.0.9 (2012-12-10) [slevine]: use AcpiTkPrepareToSleep rather than workaround
+    /* This function does not exist in older versions of acpi
+     * As a result the shutdown attempt will usually hang because
+     * the required code has not been committed into memory.
+     */
+    if (pAcpiTkPrepareToSleep)
+        pAcpiTkPrepareToSleep(ucState);
 }
 
@@ -196 +208 @@
  *      Code provided by David Azarewicz
  *@@added V1.0.9 (2012-02-20) [slevine]: code from David Azarewicz
- */
-
-#define AE_DEPTH AE_OK
-
-ACPI_STATUS AcpiCallbackWidget( ACPI_HANDLE ObjHandle, UINT32 NestingLevel, void *Context, void **ReturnValue )
+ *@@changed V1.0.10 (2014-08-30) [dazarewicz]: release resources correctly
+ */
+
+ACPI_STATUS APIENTRY AcpiCallbackWidget( ACPI_HANDLE ObjHandle, UINT32 NestingLevel, void *Context, void **ReturnValue )
 {
     ACPI_DEVICE_INFO *pDevInfo = NULL;
-    ACPI_STATUS Status = pAcpiTkGetObjectInfoAlloc(ObjHandle, &pDevInfo);
-
-    if (Status == AE_OK)
+
+    if (pAcpiTkGetObjectInfoAlloc( ObjHandle, &pDevInfo ) != AE_OK)
+        return AE_OK;
+
+    do
     {
         if (pDevInfo->Type != ACPI_TYPE_DEVICE)
-            return AE_DEPTH;
+            break;
 
         if (!(pDevInfo->Valid & ACPI_VALID_HID))
-            return AE_DEPTH;
+            break;
 
         if (!pDevInfo->HardwareId.String)
-            return AE_DEPTH;
+            break;
 
         if (strncmp(pDevInfo->HardwareId.String, "ACPI0003", 8) == 0)
         { /* AC Power */
-            Status = pAcpiTkGetHandle(ObjHandle, "_PSR", &G_ahAC);
-            if (Status)
+            if (pAcpiTkGetHandle(ObjHandle, "_PSR", &G_ahAC))
                 G_ahAC = 0;
 
-            return AE_DEPTH;
+            break;
         }
 
@@ -230 +242 @@
                 G_ahBat[G_uiBatteryCount++] = ObjHandle;
 
-            return AE_DEPTH;
-        }
-    }
+            break;
+        }
+    } while (0);
 
     if (pDevInfo)
@@ -246 +258 @@
  *      Code provided by David Azarewicz
  *@@added V1.0.9 (2012-02-20) [slevine]: code from David Azarewicz
+ *@@changed V1.0.10 (2014-08-30) [dazarewicz]: tidies
  */
 
@@ -326 +339 @@
         Obj = (ACPI_OBJECT *)Obj[0].Package.Elements;   // Battery info package
         LastFull = (UINT32)OBJ_VALUE(2);
-        if (LastFull == 0xffffffff)
-        {
-            G_ahBat[uiI] = 0;
-            continue;
-        }
 
         Result.Length = sizeof(Object);
@@ -344 +352 @@
         Obj = Result.Pointer;
         Obj = (ACPI_OBJECT *)Obj[0].Package.Elements;   // Battery status package
-
-        // If voltage known
-        if ((UINT32)OBJ_VALUE(2) != 0xffffffff)
-            BRemaining = (UINT32)OBJ_VALUE(2);
+        BRemaining = (UINT32)OBJ_VALUE(2);
 
         // If battery units are mWh or mAh
         // If not, it is a percentage
-        if ((UINT32)OBJ_VALUE(0) != 0xffffffff)
+        if (    (LastFull != 0xffffffff)
+             && (BRemaining != 0xffffffff)
+           )
         {
             if (BRemaining > (LastFull >> 1)) // > 50% is high. < 50% is low
@@ -370 +377 @@
                 fChanged = TRUE;
             }
-        }
-
-        ulTmp = (BRemaining*100) / LastFull;
-        if (ulTmp > 100)
-            ulTmp = 100;
-
-        if (pApm->bBatteryLife != ulTmp)
-        {
-            pApm->bBatteryLife = (BYTE) ulTmp;
-            fChanged = TRUE;
+
+            ulTmp = (BRemaining*100) / LastFull;
+            if (ulTmp > 100)
+                ulTmp = 100;
+
+            if (pApm->bBatteryLife != ulTmp)
+            {
+                pApm->bBatteryLife = (BYTE) ulTmp;
+                fChanged = TRUE;
+            }
         }
     }