Changeset 130 for GPL/trunk/alsa-kernel/pci

Timestamp:

Jun 12, 2007, 11:32:16 PM (18 years ago)

Author:

stevenhl

Message:

Make a bunch of warnings go away

Location:

GPL/trunk/alsa-kernel/pci

Files:

• ac97/ac97_codec.c (modified) (2 diffs)
• ac97/ac97_patch.c (modified) (1 diff)
• emu10k1/emu10k1x.c (modified) (1 diff)
• emu10k1/emuproc.c (modified) (1 diff)
• emu10k1/irq.c (modified) (1 diff)
• hda/hda_intel.c (modified) (1 diff)

GPL/trunk/alsa-kernel/pci/ac97/ac97_codec.c

@@ -1931 +1931 @@
 }
 
+#if 0 // fixme to be gone?
 /* stop no dev release warning */
 static void ac97_device_release(struct device * dev)
 {
 }
+#endif // fixme to be gone?
 
 /* register ac97 codec to bus */
 static int snd_ac97_dev_register(struct snd_device *device)
 {
-#if 0
+#if 0 // fixme to be gone?
     struct snd_ac97 *ac97 = device->device_data;
         int err;
@@ -1954 +1956 @@
                 return err;
         }
-#endif
+#endif // fixme to be gone?
         return 0;
 }

GPL/trunk/alsa-kernel/pci/ac97/ac97_patch.c

@@ -2081 +2081 @@
         unsigned short val;
 
-        if (ucontrol->value.enumerated.item[0] > 3
-            || ucontrol->value.enumerated.item[0] < 0)
+        // if (ucontrol->value.enumerated.item[0] > 3   // 12 Jun 07 SHL
+        //    || ucontrol->value.enumerated.item[0] < 0)        // 12 Jun 07 SHL
+        if (ucontrol->value.enumerated.item[0] > 3)
                 return -EINVAL;
         val = ctrl2reg[ucontrol->value.enumerated.item[0]]

GPL/trunk/alsa-kernel/pci/emu10k1/emu10k1x.c

@@ -780 +780 @@
 }
 
-static irqreturn_t snd_emu10k1x_interrupt(int irq, void *dev_id)
+static irqreturn_t snd_emu10k1x_interrupt(int irq, void *dev_id, struct pt_regs *unused)
 {
     unsigned int status;

GPL/trunk/alsa-kernel/pci/emu10k1/emuproc.c

@@ -176 +176 @@
 
     struct snd_emu10k1 *emu = entry->private_data;
-    unsigned int val;
+    unsigned int val = 0;               // 11 Jun 07 SHL fixme to know why not used
     int nefx = emu->audigy ? 64 : 32;
     char **outputs = emu->audigy ? audigy_outs : creative_outs;

GPL/trunk/alsa-kernel/pci/emu10k1/irq.c

@@ -32 +32 @@
 #include <sound/emu10k1.h>
 
-irqreturn_t snd_emu10k1_interrupt(int irq, void *dev_id)
+irqreturn_t snd_emu10k1_interrupt(int irq, void *dev_id, struct pt_regs *notused)
 {
     struct snd_emu10k1 *emu = dev_id;

GPL/trunk/alsa-kernel/pci/hda/hda_intel.c

@@ -398 +398 @@
  * Compiler should optimize and eliminate the code if dma_addr_t is 32bit
  */
-#define upper_32bit(addr) (sizeof(addr) > 4 ? (u32)((addr) >> 32) : (u32)0)
+#define upper_32bit(addr) (sizeof(addr) > 4 ? (u32)(((unsigned long long)addr) >> 32) : (u32)0)
 
 static int azx_acquire_irq(struct azx *chip, int do_disconnect);