Changeset 745 for trunk/server/source3/printing

Timestamp:

Nov 27, 2012, 4:43:17 PM (13 years ago)

Author:

Silvan Scherrer

Message:

Samba Server: updated trunk to 3.6.0

Location:

trunk/server

Files:

• . (modified) (1 prop)
• source3/printing/load.c (modified) (2 diffs)
• source3/printing/load.h (copied) (copied from vendor/current/source3/printing/load.h )
• source3/printing/notify.c (modified) (8 diffs)
• source3/printing/notify.h (copied) (copied from vendor/current/source3/printing/notify.h )
• source3/printing/nt_printing.c (modified) (65 diffs)
• source3/printing/nt_printing_ads.c (copied) (copied from vendor/current/source3/printing/nt_printing_ads.c )
• source3/printing/nt_printing_migrate.c (copied) (copied from vendor/current/source3/printing/nt_printing_migrate.c )
• source3/printing/nt_printing_migrate.h (copied) (copied from vendor/current/source3/printing/nt_printing_migrate.h )
• source3/printing/nt_printing_migrate_internal.c (copied) (copied from vendor/current/source3/printing/nt_printing_migrate_internal.c )
• source3/printing/nt_printing_migrate_internal.h (copied) (copied from vendor/current/source3/printing/nt_printing_migrate_internal.h )
• source3/printing/nt_printing_os2.c (copied) (copied from vendor/current/source3/printing/nt_printing_os2.c )
• source3/printing/nt_printing_os2.h (copied) (copied from vendor/current/source3/printing/nt_printing_os2.h )
• source3/printing/nt_printing_tdb.c (copied) (copied from vendor/current/source3/printing/nt_printing_tdb.c )
• source3/printing/nt_printing_tdb.h (copied) (copied from vendor/current/source3/printing/nt_printing_tdb.h )
• source3/printing/pcap.c (modified) (10 diffs)
• source3/printing/pcap.h (copied) (copied from vendor/current/source3/printing/pcap.h )
• source3/printing/print_aix.c (modified) (3 diffs)
• source3/printing/print_cups.c (modified) (31 diffs)
• source3/printing/print_generic.c (modified) (5 diffs)
• source3/printing/print_iprint.c (modified) (11 diffs)
• source3/printing/print_standard.c (copied) (copied from vendor/current/source3/printing/print_standard.c )
• source3/printing/print_svid.c (modified) (2 diffs)
• source3/printing/printer_list.c (copied) (copied from vendor/current/source3/printing/printer_list.c )
• source3/printing/printer_list.h (copied) (copied from vendor/current/source3/printing/printer_list.h )
• source3/printing/printfsp.c (deleted)
• source3/printing/printing.c (modified) (118 diffs)
• source3/printing/printing_db.c (modified) (3 diffs)
• source3/printing/printspoolss.c (copied) (copied from vendor/current/source3/printing/printspoolss.c )
• source3/printing/spoolssd.c (copied) (copied from vendor/current/source3/printing/spoolssd.c )
• source3/printing/tests/vlp.c (modified) (1 diff)

trunk/server/source3/printing/load.c

@@ -19 +19 @@
 
 #include "includes.h"
-
+#include "printing/pcap.h"
+#include "printing/load.h"
 
 /***************************************************************************
@@ -56 +57 @@
 load automatic printer services from pre-populated pcap cache
 ***************************************************************************/
-void load_printers(void)
+void load_printers(struct tevent_context *ev,
+                   struct messaging_context *msg_ctx)
 {
+        SMB_ASSERT(pcap_cache_loaded());
+
         add_auto_printers();
 

trunk/server/source3/printing/notify.c

@@ -22 +22 @@
 #include "includes.h"
 #include "printing.h"
+#include "../librpc/gen_ndr/spoolss.h"
+#include "nt_printing.h"
+#include "printing/notify.h"
+#include "messages.h"
+#include "util_tdb.h"
 
 static TALLOC_CTX *send_ctx;
@@ -228 +233 @@
                                              void *private_data)
 {
+        struct messaging_context *msg_ctx = talloc_get_type_abort(
+                private_data, struct messaging_context);
         /* Remove this timed event handler. */
         TALLOC_FREE(notify_event);
 
         change_to_root_user();
-        print_notify_send_messages(smbd_messaging_context(), 0);
+        print_notify_send_messages(msg_ctx, 0);
 }
 
@@ -263 +270 @@
 *******************************************************************/
 
-static void send_spoolss_notify2_msg(SPOOLSS_NOTIFY_MSG *msg)
+static void send_spoolss_notify2_msg(struct tevent_context *ev,
+                                     struct messaging_context *msg_ctx,
+                                     SPOOLSS_NOTIFY_MSG *msg)
 {
         struct notify_queue *pnqueue, *tmp_ptr;
@@ -326 +335 @@
         num_messages++;
 
-        if ((notify_event == NULL) && (smbd_event_context() != NULL)) {
+        if ((notify_event == NULL) && (ev != NULL)) {
                 /* Add an event for 1 second's time to send this queue. */
-                notify_event = tevent_add_timer(smbd_event_context(), NULL,
-                                        timeval_current_ofs(1,0),
-                                        print_notify_event_send_messages, NULL);
-        }
-
-}
-
-static void send_notify_field_values(const char *sharename, uint32 type,
+                notify_event = tevent_add_timer(
+                        ev, NULL, timeval_current_ofs(1,0),
+                        print_notify_event_send_messages, msg_ctx);
+        }
+
+}
+
+static void send_notify_field_values(struct tevent_context *ev,
+                                     struct messaging_context *msg_ctx,
+                                     const char *sharename, uint32 type,
                                      uint32 field, uint32 id, uint32 value1, 
                                      uint32 value2, uint32 flags)
@@ -361 +372 @@
         msg->flags = flags;
 
-        send_spoolss_notify2_msg(msg);
-}
-
-static void send_notify_field_buffer(const char *sharename, uint32 type,
+        send_spoolss_notify2_msg(ev, msg_ctx, msg);
+}
+
+static void send_notify_field_buffer(struct tevent_context *ev,
+                                     struct messaging_context *msg_ctx,
+                                     const char *sharename, uint32 type,
                                      uint32 field, uint32 id, uint32 len,
                                      const char *buffer)
@@ -389 +402 @@
         msg->notify.data = CONST_DISCARD(char *,buffer);
 
-        send_spoolss_notify2_msg(msg);
+        send_spoolss_notify2_msg(ev, msg_ctx, msg);
 }
 
 /* Send a message that the printer status has changed */
 
-void notify_printer_status_byname(const char *sharename, uint32 status)
+void notify_printer_status_byname(struct tevent_context *ev,
+                                  struct messaging_context *msg_ctx,
+                                  const char *sharename, uint32 status)
 {
         /* Printer status stored in value1 */
@@ -400 +415 @@
         int snum = print_queue_snum(sharename);
 
-        send_notify_field_values(sharename, PRINTER_NOTIFY_TYPE, 
+        send_notify_field_values(ev, msg_ctx, sharename, PRINTER_NOTIFY_TYPE,
                                  PRINTER_NOTIFY_FIELD_STATUS, snum,
                                  status, 0, 0);
 }
 
-void notify_printer_status(int snum, uint32 status)
-{
-        const char *sharename = SERVICE(snum); 
+void notify_printer_status(struct tevent_context *ev,
+                           struct messaging_context *msg_ctx,
+                           int snum, uint32 status)
+{
+        const char *sharename = lp_servicename(snum);
 
         if (sharename)
-                notify_printer_status_byname(sharename, status);
-}
-
-void notify_job_status_byname(const char *sharename, uint32 jobid, uint32 status,
+                notify_printer_status_byname(ev, msg_ctx, sharename, status);
+}
+
+void notify_job_status_byname(struct tevent_context *ev,
+                              struct messaging_context *msg_ctx,
+                              const char *sharename, uint32 jobid,
+                              uint32 status,
                               uint32 flags)
 {
         /* Job id stored in id field, status in value1 */
 
-        send_notify_field_values(sharename, JOB_NOTIFY_TYPE,
+        send_notify_field_values(ev, msg_ctx,
+                                 sharename, JOB_NOTIFY_TYPE,
                                  JOB_NOTIFY_FIELD_STATUS, jobid,
                                  status, 0, flags);
 }
 
-void notify_job_status(const char *sharename, uint32 jobid, uint32 status)
-{
-        notify_job_status_byname(sharename, jobid, status, 0);
-}
-
-void notify_job_total_bytes(const char *sharename, uint32 jobid,
+void notify_job_status(struct tevent_context *ev,
+                       struct messaging_context *msg_ctx,
+                       const char *sharename, uint32 jobid, uint32 status)
+{
+        notify_job_status_byname(ev, msg_ctx, sharename, jobid, status, 0);
+}
+
+void notify_job_total_bytes(struct tevent_context *ev,
+                            struct messaging_context *msg_ctx,
+                            const char *sharename, uint32 jobid,
                             uint32 size)
 {
         /* Job id stored in id field, status in value1 */
 
-        send_notify_field_values(sharename, JOB_NOTIFY_TYPE,
+        send_notify_field_values(ev, msg_ctx,
+                                 sharename, JOB_NOTIFY_TYPE,
                                  JOB_NOTIFY_FIELD_TOTAL_BYTES, jobid,
                                  size, 0, 0);
 }
 
-void notify_job_total_pages(const char *sharename, uint32 jobid,
+void notify_job_total_pages(struct tevent_context *ev,
+                            struct messaging_context *msg_ctx,
+                            const char *sharename, uint32 jobid,
                             uint32 pages)
 {
         /* Job id stored in id field, status in value1 */
 
-        send_notify_field_values(sharename, JOB_NOTIFY_TYPE,
+        send_notify_field_values(ev, msg_ctx,
+                                 sharename, JOB_NOTIFY_TYPE,
                                  JOB_NOTIFY_FIELD_TOTAL_PAGES, jobid,
                                  pages, 0, 0);
 }
 
-void notify_job_username(const char *sharename, uint32 jobid, char *name)
-{
-        send_notify_field_buffer(
+void notify_job_username(struct tevent_context *ev,
+                         struct messaging_context *msg_ctx,
+                         const char *sharename, uint32 jobid, char *name)
+{
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, JOB_NOTIFY_TYPE, JOB_NOTIFY_FIELD_USER_NAME,
                 jobid, strlen(name) + 1, name);
 }
 
-void notify_job_name(const char *sharename, uint32 jobid, char *name)
-{
-        send_notify_field_buffer(
+void notify_job_name(struct tevent_context *ev,
+                     struct messaging_context *msg_ctx,
+                     const char *sharename, uint32 jobid, char *name)
+{
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, JOB_NOTIFY_TYPE, JOB_NOTIFY_FIELD_DOCUMENT,
                 jobid, strlen(name) + 1, name);
 }
 
-void notify_job_submitted(const char *sharename, uint32 jobid,
+void notify_job_submitted(struct tevent_context *ev,
+                          struct messaging_context *msg_ctx,
+                          const char *sharename, uint32 jobid,
                           time_t submitted)
 {
         send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, JOB_NOTIFY_TYPE, JOB_NOTIFY_FIELD_SUBMITTED,
                 jobid, sizeof(submitted), (char *)&submitted);
 }
 
-void notify_printer_driver(int snum, char *driver_name)
-{
-        const char *sharename = SERVICE(snum);
-
-        send_notify_field_buffer(
+void notify_printer_driver(struct tevent_context *ev,
+                           struct messaging_context *msg_ctx,
+                           int snum, const char *driver_name)
+{
+        const char *sharename = lp_servicename(snum);
+
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_FIELD_DRIVER_NAME,
                 snum, strlen(driver_name) + 1, driver_name);
 }
 
-void notify_printer_comment(int snum, char *comment)
-{
-        const char *sharename = SERVICE(snum);
-
-        send_notify_field_buffer(
+void notify_printer_comment(struct tevent_context *ev,
+                            struct messaging_context *msg_ctx,
+                            int snum, const char *comment)
+{
+        const char *sharename = lp_servicename(snum);
+
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_FIELD_COMMENT,
                 snum, strlen(comment) + 1, comment);
 }
 
-void notify_printer_sharename(int snum, char *share_name)
-{
-        const char *sharename = SERVICE(snum);
-
-        send_notify_field_buffer(
+void notify_printer_sharename(struct tevent_context *ev,
+                              struct messaging_context *msg_ctx,
+                              int snum, const char *share_name)
+{
+        const char *sharename = lp_servicename(snum);
+
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_FIELD_SHARE_NAME,
                 snum, strlen(share_name) + 1, share_name);
 }
 
-void notify_printer_printername(int snum, char *printername)
-{
-        const char *sharename = SERVICE(snum);
-
-        send_notify_field_buffer(
+void notify_printer_printername(struct tevent_context *ev,
+                                struct messaging_context *msg_ctx,
+                                int snum, const char *printername)
+{
+        const char *sharename = lp_servicename(snum);
+
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_FIELD_PRINTER_NAME,
                 snum, strlen(printername) + 1, printername);
 }
 
-void notify_printer_port(int snum, char *port_name)
-{
-        const char *sharename = SERVICE(snum);
-
-        send_notify_field_buffer(
+void notify_printer_port(struct tevent_context *ev,
+                         struct messaging_context *msg_ctx,
+                         int snum, const char *port_name)
+{
+        const char *sharename = lp_servicename(snum);
+
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_FIELD_PORT_NAME,
                 snum, strlen(port_name) + 1, port_name);
 }
 
-void notify_printer_location(int snum, char *location)
-{
-        const char *sharename = SERVICE(snum);
-
-        send_notify_field_buffer(
+void notify_printer_location(struct tevent_context *ev,
+                             struct messaging_context *msg_ctx,
+                             int snum, const char *location)
+{
+        const char *sharename = lp_servicename(snum);
+
+        send_notify_field_buffer(
+                ev, msg_ctx,
                 sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_FIELD_LOCATION,
                 snum, strlen(location) + 1, location);
 }
 
-void notify_printer_byname( const char *printername, uint32 change, const char *value )
+void notify_printer_sepfile(struct tevent_context *ev,
+                            struct messaging_context *msg_ctx,
+                            int snum, const char *sepfile)
+{
+        const char *sharename = lp_servicename(snum);
+
+        send_notify_field_buffer(
+                ev, msg_ctx,
+                sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_FIELD_SEPFILE,
+                snum, strlen(sepfile) + 1, sepfile);
+}
+
+
+void notify_printer_byname(struct tevent_context *ev,
+                           struct messaging_context *msg_ctx,
+                           const char *printername, uint32 change,
+                           const char *value)
 {
         int snum = print_queue_snum(printername);
@@ -532 +604 @@
                 return;
                 
-        send_notify_field_buffer( printername, type, change, snum, strlen(value)+1, value );
+        send_notify_field_buffer(
+                ev, msg_ctx,
+                printername, type, change, snum, strlen(value)+1, value );
 } 
 

trunk/server/source3/printing/nt_printing.c

@@ -21 +21 @@
 
 #include "includes.h"
-
-static TDB_CONTEXT *tdb_forms; /* used for forms files */
-static TDB_CONTEXT *tdb_drivers; /* used for driver files */
-static TDB_CONTEXT *tdb_printers; /* used for printers files */
-
-#define FORMS_PREFIX "FORMS/"
-#define DRIVERS_PREFIX "DRIVERS/"
-#define DRIVER_INIT_PREFIX "DRIVER_INIT/"
-#define PRINTERS_PREFIX "PRINTERS/"
-#define SECDESC_PREFIX "SECDESC/"
-#define GLOBAL_C_SETPRINTER "GLOBALS/c_setprinter"
-
-#define NTDRIVERS_DATABASE_VERSION_1 1
-#define NTDRIVERS_DATABASE_VERSION_2 2
-#define NTDRIVERS_DATABASE_VERSION_3 3 /* little endian version of v2 */
-#define NTDRIVERS_DATABASE_VERSION_4 4 /* fix generic bits in security descriptors */
-#define NTDRIVERS_DATABASE_VERSION_5 5 /* normalize keys in ntprinters.tdb */
+#include "printing/nt_printing_tdb.h"
+#include "../librpc/gen_ndr/ndr_spoolss.h"
+#include "rpc_server/spoolss/srv_spoolss_util.h"
+#include "nt_printing.h"
+#include "secrets.h"
+#include "../librpc/gen_ndr/netlogon.h"
+#include "../libcli/security/security.h"
+#include "passdb/machine_sid.h"
+#include "smbd/smbd.h"
+#include "auth.h"
+#include "messages.h"
+#include "rpc_server/spoolss/srv_spoolss_nt.h"
+#include "rpc_client/cli_winreg_spoolss.h"
 
 /* Map generic permissions to printer object specific permissions */
@@ -48 +44 @@
 };
 
-const struct standard_mapping printer_std_mapping = {
-        PRINTER_READ,
-        PRINTER_WRITE,
-        PRINTER_EXECUTE,
-        PRINTER_ALL_ACCESS
-};
-
 /* Map generic permissions to print server object specific permissions */
 
@@ -64 +53 @@
 };
 
-const struct generic_mapping printserver_std_mapping = {
-        SERVER_READ,
-        SERVER_WRITE,
-        SERVER_EXECUTE,
-        SERVER_ALL_ACCESS
-};
-
 /* Map generic permissions to job object specific permissions */
 
@@ -78 +60 @@
         JOB_EXECUTE,
         JOB_ALL_ACCESS
-};
-
-/* We need one default form to support our default printer. Msoft adds the
-forms it wants and in the ORDER it wants them (note: DEVMODE papersize is an
-array index). Letter is always first, so (for the current code) additions
-always put things in the correct order. */
-static const nt_forms_struct default_forms[] = {
-        {"Letter",0x1,0x34b5c,0x44368,0x0,0x0,0x34b5c,0x44368},
-        {"Letter Small",0x1,0x34b5c,0x44368,0x0,0x0,0x34b5c,0x44368},
-        {"Tabloid",0x1,0x44368,0x696b8,0x0,0x0,0x44368,0x696b8},
-        {"Ledger",0x1,0x696b8,0x44368,0x0,0x0,0x696b8,0x44368},
-        {"Legal",0x1,0x34b5c,0x56d10,0x0,0x0,0x34b5c,0x56d10},
-        {"Statement",0x1,0x221b4,0x34b5c,0x0,0x0,0x221b4,0x34b5c},
-        {"Executive",0x1,0x2cf56,0x411cc,0x0,0x0,0x2cf56,0x411cc},
-        {"A3",0x1,0x48828,0x668a0,0x0,0x0,0x48828,0x668a0},
-        {"A4",0x1,0x33450,0x48828,0x0,0x0,0x33450,0x48828},
-        {"A4 Small",0x1,0x33450,0x48828,0x0,0x0,0x33450,0x48828},
-        {"A5",0x1,0x24220,0x33450,0x0,0x0,0x24220,0x33450},
-        {"B4 (JIS)",0x1,0x3ebe8,0x58de0,0x0,0x0,0x3ebe8,0x58de0},
-        {"B5 (JIS)",0x1,0x2c6f0,0x3ebe8,0x0,0x0,0x2c6f0,0x3ebe8},
-        {"Folio",0x1,0x34b5c,0x509d8,0x0,0x0,0x34b5c,0x509d8},
-        {"Quarto",0x1,0x347d8,0x43238,0x0,0x0,0x347d8,0x43238},
-        {"10x14",0x1,0x3e030,0x56d10,0x0,0x0,0x3e030,0x56d10},
-        {"11x17",0x1,0x44368,0x696b8,0x0,0x0,0x44368,0x696b8},
-        {"Note",0x1,0x34b5c,0x44368,0x0,0x0,0x34b5c,0x44368},
-        {"Envelope #9",0x1,0x18079,0x37091,0x0,0x0,0x18079,0x37091},
-        {"Envelope #10",0x1,0x19947,0x3ae94,0x0,0x0,0x19947,0x3ae94},
-        {"Envelope #11",0x1,0x1be7c,0x40565,0x0,0x0,0x1be7c,0x40565},
-        {"Envelope #12",0x1,0x1d74a,0x44368,0x0,0x0,0x1d74a,0x44368},
-        {"Envelope #14",0x1,0x1f018,0x47504,0x0,0x0,0x1f018,0x47504},
-        {"C size sheet",0x1,0x696b8,0x886d0,0x0,0x0,0x696b8,0x886d0},
-        {"D size sheet",0x1,0x886d0,0xd2d70,0x0,0x0,0x886d0,0xd2d70},
-        {"E size sheet",0x1,0xd2d70,0x110da0,0x0,0x0,0xd2d70,0x110da0},
-        {"Envelope DL",0x1,0x1adb0,0x35b60,0x0,0x0,0x1adb0,0x35b60},
-        {"Envelope C5",0x1,0x278d0,0x37e88,0x0,0x0,0x278d0,0x37e88},
-        {"Envelope C3",0x1,0x4f1a0,0x6fd10,0x0,0x0,0x4f1a0,0x6fd10},
-        {"Envelope C4",0x1,0x37e88,0x4f1a0,0x0,0x0,0x37e88,0x4f1a0},
-        {"Envelope C6",0x1,0x1bd50,0x278d0,0x0,0x0,0x1bd50,0x278d0},
-        {"Envelope C65",0x1,0x1bd50,0x37e88,0x0,0x0,0x1bd50,0x37e88},
-        {"Envelope B4",0x1,0x3d090,0x562e8,0x0,0x0,0x3d090,0x562e8},
-        {"Envelope B5",0x1,0x2af80,0x3d090,0x0,0x0,0x2af80,0x3d090},
-        {"Envelope B6",0x1,0x2af80,0x1e848,0x0,0x0,0x2af80,0x1e848},
-        {"Envelope",0x1,0x1adb0,0x38270,0x0,0x0,0x1adb0,0x38270},
-        {"Envelope Monarch",0x1,0x18079,0x2e824,0x0,0x0,0x18079,0x2e824},
-        {"6 3/4 Envelope",0x1,0x167ab,0x284ec,0x0,0x0,0x167ab,0x284ec},
-        {"US Std Fanfold",0x1,0x5c3e1,0x44368,0x0,0x0,0x5c3e1,0x44368},
-        {"German Std Fanfold",0x1,0x34b5c,0x4a6a0,0x0,0x0,0x34b5c,0x4a6a0},
-        {"German Legal Fanfold",0x1,0x34b5c,0x509d8,0x0,0x0,0x34b5c,0x509d8},
-        {"B4 (ISO)",0x1,0x3d090,0x562e8,0x0,0x0,0x3d090,0x562e8},
-        {"Japanese Postcard",0x1,0x186a0,0x24220,0x0,0x0,0x186a0,0x24220},
-        {"9x11",0x1,0x37cf8,0x44368,0x0,0x0,0x37cf8,0x44368},
-        {"10x11",0x1,0x3e030,0x44368,0x0,0x0,0x3e030,0x44368},
-        {"15x11",0x1,0x5d048,0x44368,0x0,0x0,0x5d048,0x44368},
-        {"Envelope Invite",0x1,0x35b60,0x35b60,0x0,0x0,0x35b60,0x35b60},
-        {"Reserved48",0x1,0x1,0x1,0x0,0x0,0x1,0x1},
-        {"Reserved49",0x1,0x1,0x1,0x0,0x0,0x1,0x1},
-        {"Letter Extra",0x1,0x3ae94,0x4a6a0,0x0,0x0,0x3ae94,0x4a6a0},
-        {"Legal Extra",0x1,0x3ae94,0x5d048,0x0,0x0,0x3ae94,0x5d048},
-        {"Tabloid Extra",0x1,0x4a6a0,0x6f9f0,0x0,0x0,0x4a6a0,0x6f9f0},
-        {"A4 Extra",0x1,0x397c2,0x4eb16,0x0,0x0,0x397c2,0x4eb16},
-        {"Letter Transverse",0x1,0x34b5c,0x44368,0x0,0x0,0x34b5c,0x44368},
-        {"A4 Transverse",0x1,0x33450,0x48828,0x0,0x0,0x33450,0x48828},
-        {"Letter Extra Transverse",0x1,0x3ae94,0x4a6a0,0x0,0x0,0x3ae94,0x4a6a0},
-        {"Super A",0x1,0x376b8,0x56ea0,0x0,0x0,0x376b8,0x56ea0},
-        {"Super B",0x1,0x4a768,0x76e58,0x0,0x0,0x4a768,0x76e58},
-        {"Letter Plus",0x1,0x34b5c,0x4eb16,0x0,0x0,0x34b5c,0x4eb16},
-        {"A4 Plus",0x1,0x33450,0x50910,0x0,0x0,0x33450,0x50910},
-        {"A5 Transverse",0x1,0x24220,0x33450,0x0,0x0,0x24220,0x33450},
-        {"B5 (JIS) Transverse",0x1,0x2c6f0,0x3ebe8,0x0,0x0,0x2c6f0,0x3ebe8},
-        {"A3 Extra",0x1,0x4e9d0,0x6ca48,0x0,0x0,0x4e9d0,0x6ca48},
-        {"A5 Extra",0x1,0x2a7b0,0x395f8,0x0,0x0,0x2a7b0,0x395f8},
-        {"B5 (ISO) Extra",0x1,0x31128,0x43620,0x0,0x0,0x31128,0x43620},
-        {"A2",0x1,0x668a0,0x91050,0x0,0x0,0x668a0,0x91050},
-        {"A3 Transverse",0x1,0x48828,0x668a0,0x0,0x0,0x48828,0x668a0},
-        {"A3 Extra Transverse",0x1,0x4e9d0,0x6ca48,0x0,0x0,0x4e9d0,0x6ca48},
-        {"Japanese Double Postcard",0x1,0x30d40,0x24220,0x0,0x0,0x30d40,0x24220},
-        {"A6",0x1,0x19a28,0x24220,0x0,0x0,0x19a28,0x24220},
-        {"Japanese Envelope Kaku #2",0x1,0x3a980,0x510e0,0x0,0x0,0x3a980,0x510e0},
-        {"Japanese Envelope Kaku #3",0x1,0x34bc0,0x43a08,0x0,0x0,0x34bc0,0x43a08},
-        {"Japanese Envelope Chou #3",0x1,0x1d4c0,0x395f8,0x0,0x0,0x1d4c0,0x395f8},
-        {"Japanese Envelope Chou #4",0x1,0x15f90,0x320c8,0x0,0x0,0x15f90,0x320c8},
-        {"Letter Rotated",0x1,0x44368,0x34b5c,0x0,0x0,0x44368,0x34b5c},
-        {"A3 Rotated",0x1,0x668a0,0x48828,0x0,0x0,0x668a0,0x48828},
-        {"A4 Rotated",0x1,0x48828,0x33450,0x0,0x0,0x48828,0x33450},
-        {"A5 Rotated",0x1,0x33450,0x24220,0x0,0x0,0x33450,0x24220},
-        {"B4 (JIS) Rotated",0x1,0x58de0,0x3ebe8,0x0,0x0,0x58de0,0x3ebe8},
-        {"B5 (JIS) Rotated",0x1,0x3ebe8,0x2c6f0,0x0,0x0,0x3ebe8,0x2c6f0},
-        {"Japanese Postcard Rotated",0x1,0x24220,0x186a0,0x0,0x0,0x24220,0x186a0},
-        {"Double Japan Postcard Rotated",0x1,0x24220,0x30d40,0x0,0x0,0x24220,0x30d40},
-        {"A6 Rotated",0x1,0x24220,0x19a28,0x0,0x0,0x24220,0x19a28},
-        {"Japan Envelope Kaku #2 Rotated",0x1,0x510e0,0x3a980,0x0,0x0,0x510e0,0x3a980},
-        {"Japan Envelope Kaku #3 Rotated",0x1,0x43a08,0x34bc0,0x0,0x0,0x43a08, 0x34bc0},
-        {"Japan Envelope Chou #3 Rotated",0x1,0x395f8,0x1d4c0,0x0,0x0,0x395f8,0x1d4c0},
-        {"Japan Envelope Chou #4 Rotated",0x1,0x320c8,0x15f90,0x0,0x0,0x320c8,0x15f90},
-        {"B6 (JIS)",0x1,0x1f400,0x2c6f0,0x0,0x0,0x1f400,0x2c6f0},
-        {"B6 (JIS) Rotated",0x1,0x2c6f0,0x1f400,0x0,0x0,0x2c6f0,0x1f400},
-        {"12x11",0x1,0x4a724,0x443e1,0x0,0x0,0x4a724,0x443e1},
-        {"Japan Envelope You #4",0x1,0x19a28,0x395f8,0x0,0x0,0x19a28,0x395f8},
-        {"Japan Envelope You #4 Rotated",0x1,0x395f8,0x19a28,0x0,0x0,0x395f8,0x19a28},
-        {"PRC 16K",0x1,0x2de60,0x3f7a0,0x0,0x0,0x2de60,0x3f7a0},
-        {"PRC 32K",0x1,0x1fbd0,0x2cec0,0x0,0x0,0x1fbd0,0x2cec0},
-        {"PRC 32K(Big)",0x1,0x222e0,0x318f8,0x0,0x0,0x222e0,0x318f8},
-        {"PRC Envelope #1",0x1,0x18e70,0x28488,0x0,0x0,0x18e70,0x28488},
-        {"PRC Envelope #2",0x1,0x18e70,0x2af80,0x0,0x0,0x18e70,0x2af80},
-        {"PRC Envelope #3",0x1,0x1e848,0x2af80,0x0,0x0,0x1e848,0x2af80},
-        {"PRC Envelope #4",0x1,0x1adb0,0x32c80,0x0,0x0,0x1adb0,0x32c80},
-        {"PRC Envelope #5",0x1,0x1adb0,0x35b60,0x0,0x0,0x1adb0,0x35b60},
-        {"PRC Envelope #6",0x1,0x1d4c0,0x38270,0x0,0x0,0x1d4c0,0x38270},
-        {"PRC Envelope #7",0x1,0x27100,0x38270,0x0,0x0,0x27100,0x38270},
-        {"PRC Envelope #8",0x1,0x1d4c0,0x4b708,0x0,0x0,0x1d4c0,0x4b708},
-        {"PRC Envelope #9",0x1,0x37e88,0x4f1a0,0x0,0x0,0x37e88,0x4f1a0},
-        {"PRC Envelope #10",0x1,0x4f1a0,0x6fd10,0x0,0x0,0x4f1a0,0x6fd10},
-        {"PRC 16K Rotated",0x1,0x3f7a0,0x2de60,0x0,0x0,0x3f7a0,0x2de60},
-        {"PRC 32K Rotated",0x1,0x2cec0,0x1fbd0,0x0,0x0,0x2cec0,0x1fbd0},
-        {"PRC 32K(Big) Rotated",0x1,0x318f8,0x222e0,0x0,0x0,0x318f8,0x222e0},
-        {"PRC Envelope #1 Rotated",0x1,0x28488,0x18e70,0x0,0x0,0x28488,0x18e70},
-        {"PRC Envelope #2 Rotated",0x1,0x2af80,0x18e70,0x0,0x0,0x2af80,0x18e70},
-        {"PRC Envelope #3 Rotated",0x1,0x2af80,0x1e848,0x0,0x0,0x2af80,0x1e848},
-        {"PRC Envelope #4 Rotated",0x1,0x32c80,0x1adb0,0x0,0x0,0x32c80,0x1adb0},
-        {"PRC Envelope #5 Rotated",0x1,0x35b60,0x1adb0,0x0,0x0,0x35b60,0x1adb0},
-        {"PRC Envelope #6 Rotated",0x1,0x38270,0x1d4c0,0x0,0x0,0x38270,0x1d4c0},
-        {"PRC Envelope #7 Rotated",0x1,0x38270,0x27100,0x0,0x0,0x38270,0x27100},
-        {"PRC Envelope #8 Rotated",0x1,0x4b708,0x1d4c0,0x0,0x0,0x4b708,0x1d4c0},
-        {"PRC Envelope #9 Rotated",0x1,0x4f1a0,0x37e88,0x0,0x0,0x4f1a0,0x37e88},
-        {"PRC Envelope #10 Rotated",0x1,0x6fd10,0x4f1a0,0x0,0x0,0x6fd10,0x4f1a0}
 };
 
@@ -217 +74 @@
 };
 
-
-/****************************************************************************
- generate a new TDB_DATA key for storing a printer
-****************************************************************************/
-
-static TDB_DATA make_printer_tdbkey(TALLOC_CTX *ctx, const char *sharename )
-{
-        fstring share;
-        char *keystr = NULL;
-        TDB_DATA key;
-
-        fstrcpy(share, sharename);
-        strlower_m(share);
-
-        keystr = talloc_asprintf(ctx, "%s%s", PRINTERS_PREFIX, share);
-        key = string_term_tdb_data(keystr ? keystr : "");
-
-        return key;
-}
-
-/****************************************************************************
- generate a new TDB_DATA key for storing a printer security descriptor
-****************************************************************************/
-
-static TDB_DATA make_printers_secdesc_tdbkey(TALLOC_CTX *ctx,
-                                        const char* sharename  )
-{
-        fstring share;
-        char *keystr = NULL;
-        TDB_DATA key;
-
-        fstrcpy(share, sharename );
-        strlower_m(share);
-
-        keystr = talloc_asprintf(ctx, "%s%s", SECDESC_PREFIX, share);
-        key = string_term_tdb_data(keystr ? keystr : "");
-
-        return key;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-static bool upgrade_to_version_3(void)
-{
-        TDB_DATA kbuf, newkey, dbuf;
-
-        DEBUG(0,("upgrade_to_version_3: upgrading print tdb's to version 3\n"));
-
-        for (kbuf = tdb_firstkey(tdb_drivers); kbuf.dptr;
-                        newkey = tdb_nextkey(tdb_drivers, kbuf), free(kbuf.dptr), kbuf=newkey) {
-
-                dbuf = tdb_fetch(tdb_drivers, kbuf);
-
-                if (strncmp((const char *)kbuf.dptr, FORMS_PREFIX, strlen(FORMS_PREFIX)) == 0) {
-                        DEBUG(0,("upgrade_to_version_3:moving form\n"));
-                        if (tdb_store(tdb_forms, kbuf, dbuf, TDB_REPLACE) != 0) {
-                                SAFE_FREE(dbuf.dptr);
-                                DEBUG(0,("upgrade_to_version_3: failed to move form. Error (%s).\n", tdb_errorstr(tdb_forms)));
-                                return False;
-                        }
-                        if (tdb_delete(tdb_drivers, kbuf) != 0) {
-                                SAFE_FREE(dbuf.dptr);
-                                DEBUG(0,("upgrade_to_version_3: failed to delete form. Error (%s)\n", tdb_errorstr(tdb_drivers)));
-                                return False;
-                        }
-                }
-
-                if (strncmp((const char *)kbuf.dptr, PRINTERS_PREFIX, strlen(PRINTERS_PREFIX)) == 0) {
-                        DEBUG(0,("upgrade_to_version_3:moving printer\n"));
-                        if (tdb_store(tdb_printers, kbuf, dbuf, TDB_REPLACE) != 0) {
-                                SAFE_FREE(dbuf.dptr);
-                                DEBUG(0,("upgrade_to_version_3: failed to move printer. Error (%s)\n", tdb_errorstr(tdb_printers)));
-                                return False;
-                        }
-                        if (tdb_delete(tdb_drivers, kbuf) != 0) {
-                                SAFE_FREE(dbuf.dptr);
-                                DEBUG(0,("upgrade_to_version_3: failed to delete printer. Error (%s)\n", tdb_errorstr(tdb_drivers)));
-                                return False;
-                        }
-                }
-
-                if (strncmp((const char *)kbuf.dptr, SECDESC_PREFIX, strlen(SECDESC_PREFIX)) == 0) {
-                        DEBUG(0,("upgrade_to_version_3:moving secdesc\n"));
-                        if (tdb_store(tdb_printers, kbuf, dbuf, TDB_REPLACE) != 0) {
-                                SAFE_FREE(dbuf.dptr);
-                                DEBUG(0,("upgrade_to_version_3: failed to move secdesc. Error (%s)\n", tdb_errorstr(tdb_printers)));
-                                return False;
-                        }
-                        if (tdb_delete(tdb_drivers, kbuf) != 0) {
-                                SAFE_FREE(dbuf.dptr);
-                                DEBUG(0,("upgrade_to_version_3: failed to delete secdesc. Error (%s)\n", tdb_errorstr(tdb_drivers)));
-                                return False;
-                        }
-                }
-
-                SAFE_FREE(dbuf.dptr);
-        }
-
-        return True;
-}
-
-/*******************************************************************
- Fix an issue with security descriptors.  Printer sec_desc must
- use more than the generic bits that were previously used
- in <= 3.0.14a.  They must also have a owner and group SID assigned.
- Otherwise, any printers than have been migrated to a Windows
- host using printmig.exe will not be accessible.
-*******************************************************************/
-
-static int sec_desc_upg_fn( TDB_CONTEXT *the_tdb, TDB_DATA key,
-                            TDB_DATA data, void *state )
-{
-        NTSTATUS status;
-        SEC_DESC_BUF *sd_orig = NULL;
-        SEC_DESC_BUF *sd_new, *sd_store;
-        SEC_DESC *sec, *new_sec;
-        TALLOC_CTX *ctx = state;
-        int result, i;
-        uint32 sd_size;
-        size_t size_new_sec;
-
-        if (!data.dptr || data.dsize == 0) {
-                return 0;
-        }
-
-        if ( strncmp((const char *) key.dptr, SECDESC_PREFIX, strlen(SECDESC_PREFIX) ) != 0 ) {
-                return 0;
-        }
-
-        /* upgrade the security descriptor */
-
-        status = unmarshall_sec_desc_buf(ctx, data.dptr, data.dsize, &sd_orig);
-        if (!NT_STATUS_IS_OK(status)) {
-                /* delete bad entries */
-                DEBUG(0,("sec_desc_upg_fn: Failed to parse original sec_desc for %si.  Deleting....\n",
-                        (const char *)key.dptr ));
-                tdb_delete( tdb_printers, key );
-                return 0;
-        }
-
-        if (!sd_orig) {
-                return 0;
-        }
-        sec = sd_orig->sd;
-
-        /* is this even valid? */
-
-        if ( !sec->dacl ) {
-                return 0;
-        }
-
-        /* update access masks */
-
-        for ( i=0; i<sec->dacl->num_aces; i++ ) {
-                switch ( sec->dacl->aces[i].access_mask ) {
-                        case (GENERIC_READ_ACCESS | GENERIC_WRITE_ACCESS | GENERIC_EXECUTE_ACCESS):
-                                sec->dacl->aces[i].access_mask = PRINTER_ACE_PRINT;
-                                break;
-
-                        case GENERIC_ALL_ACCESS:
-                                sec->dacl->aces[i].access_mask = PRINTER_ACE_FULL_CONTROL;
-                                break;
-
-                        case READ_CONTROL_ACCESS:
-                                sec->dacl->aces[i].access_mask = PRINTER_ACE_MANAGE_DOCUMENTS;
-
-                        default:        /* no change */
-                                break;
-                }
-        }
-
-        /* create a new SEC_DESC with the appropriate owner and group SIDs */
-
-        new_sec = make_sec_desc( ctx, SEC_DESC_REVISION, SEC_DESC_SELF_RELATIVE,
-                                 &global_sid_Builtin_Administrators,
-                                 &global_sid_Builtin_Administrators,
-                                 NULL, NULL, &size_new_sec );
-        if (!new_sec) {
-                return 0;
-        }
-        sd_new = make_sec_desc_buf( ctx, size_new_sec, new_sec );
-        if (!sd_new) {
-                return 0;
-        }
-
-        if ( !(sd_store = sec_desc_merge( ctx, sd_new, sd_orig )) ) {
-                DEBUG(0,("sec_desc_upg_fn: Failed to update sec_desc for %s\n", key.dptr ));
-                return 0;
-        }
-
-        /* store it back */
-
-        sd_size = ndr_size_security_descriptor(sd_store->sd, NULL, 0)
-                + sizeof(SEC_DESC_BUF);
-
-        status = marshall_sec_desc_buf(ctx, sd_store, &data.dptr, &data.dsize);
-        if (!NT_STATUS_IS_OK(status)) {
-                DEBUG(0,("sec_desc_upg_fn: Failed to parse new sec_desc for %s\n", key.dptr ));
-                return 0;
-        }
-
-        result = tdb_store( tdb_printers, key, data, TDB_REPLACE );
-
-        /* 0 to continue and non-zero to stop traversal */
-
-        return (result == -1);
-}
-
-/*******************************************************************
-*******************************************************************/
-
-static bool upgrade_to_version_4(void)
-{
-        TALLOC_CTX *ctx;
-        int result;
-
-        DEBUG(0,("upgrade_to_version_4: upgrading printer security descriptors\n"));
-
-        if ( !(ctx = talloc_init( "upgrade_to_version_4" )) )
-                return False;
-
-        result = tdb_traverse( tdb_printers, sec_desc_upg_fn, ctx );
-
-        talloc_destroy( ctx );
-
-        return ( result != -1 );
-}
-
-/*******************************************************************
- Fix an issue with security descriptors.  Printer sec_desc must
- use more than the generic bits that were previously used
- in <= 3.0.14a.  They must also have a owner and group SID assigned.
- Otherwise, any printers than have been migrated to a Windows
- host using printmig.exe will not be accessible.
-*******************************************************************/
-
-static int normalize_printers_fn( TDB_CONTEXT *the_tdb, TDB_DATA key,
-                                  TDB_DATA data, void *state )
-{
-        TALLOC_CTX *ctx = talloc_tos();
-        TDB_DATA new_key;
-
-        if (!data.dptr || data.dsize == 0)
-                return 0;
-
-        /* upgrade printer records and security descriptors */
-
-        if ( strncmp((const char *) key.dptr, PRINTERS_PREFIX, strlen(PRINTERS_PREFIX) ) == 0 ) {
-                new_key = make_printer_tdbkey(ctx, (const char *)key.dptr+strlen(PRINTERS_PREFIX) );
-        }
-        else if ( strncmp((const char *) key.dptr, SECDESC_PREFIX, strlen(SECDESC_PREFIX) ) == 0 ) {
-                new_key = make_printers_secdesc_tdbkey(ctx, (const char *)key.dptr+strlen(SECDESC_PREFIX) );
-        }
-        else {
-                /* ignore this record */
-                return 0;
-        }
-
-        /* delete the original record and store under the normalized key */
-
-        if ( tdb_delete( the_tdb, key ) != 0 ) {
-                DEBUG(0,("normalize_printers_fn: tdb_delete for [%s] failed!\n",
-                        key.dptr));
-                return 1;
-        }
-
-        if ( tdb_store( the_tdb, new_key, data, TDB_REPLACE) != 0 ) {
-                DEBUG(0,("normalize_printers_fn: failed to store new record for [%s]!\n",
-                        key.dptr));
-                return 1;
-        }
-
-        return 0;
-}
-
-/*******************************************************************
-*******************************************************************/
-
-static bool upgrade_to_version_5(void)
-{
-        TALLOC_CTX *ctx;
-        int result;
-
-        DEBUG(0,("upgrade_to_version_5: normalizing printer keys\n"));
-
-        if ( !(ctx = talloc_init( "upgrade_to_version_5" )) )
-                return False;
-
-        result = tdb_traverse( tdb_printers, normalize_printers_fn, NULL );
-
-        talloc_destroy( ctx );
-
-        return ( result != -1 );
-}
-
 /****************************************************************************
  Open the NT printing tdbs. Done once before fork().
@@ -519 +80 @@
 bool nt_printing_init(struct messaging_context *msg_ctx)
 {
-        const char *vstring = "INFO/version";
         WERROR win_rc;
-        int32 vers_id;
-
-        if ( tdb_drivers && tdb_printers && tdb_forms )
-                return True;
-
-        if (tdb_drivers)
-                tdb_close(tdb_drivers);
-        tdb_drivers = tdb_open_log(state_path("ntdrivers.tdb"), 0, TDB_DEFAULT, O_RDWR|O_CREAT, 0600);
-        if (!tdb_drivers) {
-                DEBUG(0,("nt_printing_init: Failed to open nt drivers database %s (%s)\n",
-                        state_path("ntdrivers.tdb"), strerror(errno) ));
-                return False;
-        }
-
-        if (tdb_printers)
-                tdb_close(tdb_printers);
-        tdb_printers = tdb_open_log(state_path("ntprinters.tdb"), 0, TDB_DEFAULT, O_RDWR|O_CREAT, 0600);
-        if (!tdb_printers) {
-                DEBUG(0,("nt_printing_init: Failed to open nt printers database %s (%s)\n",
-                        state_path("ntprinters.tdb"), strerror(errno) ));
-                return False;
-        }
-
-        if (tdb_forms)
-                tdb_close(tdb_forms);
-        tdb_forms = tdb_open_log(state_path("ntforms.tdb"), 0, TDB_DEFAULT, O_RDWR|O_CREAT, 0600);
-        if (!tdb_forms) {
-                DEBUG(0,("nt_printing_init: Failed to open nt forms database %s (%s)\n",
-                        state_path("ntforms.tdb"), strerror(errno) ));
-                return False;
-        }
-
-        /* handle a Samba upgrade */
-
-        vers_id = tdb_fetch_int32(tdb_drivers, vstring);
-        if (vers_id == -1) {
-                DEBUG(10, ("Fresh database\n"));
-                tdb_store_int32( tdb_drivers, vstring, NTDRIVERS_DATABASE_VERSION_5 );
-                vers_id = NTDRIVERS_DATABASE_VERSION_5;
-        }
-
-        if ( vers_id != NTDRIVERS_DATABASE_VERSION_5 ) {
-
-                if ((vers_id == NTDRIVERS_DATABASE_VERSION_1) || (IREV(vers_id) == NTDRIVERS_DATABASE_VERSION_1)) {
-                        if (!upgrade_to_version_3())
-                                return False;
-                        tdb_store_int32(tdb_drivers, vstring, NTDRIVERS_DATABASE_VERSION_3);
-                        vers_id = NTDRIVERS_DATABASE_VERSION_3;
-                }
-
-                if ((vers_id == NTDRIVERS_DATABASE_VERSION_2) || (IREV(vers_id) == NTDRIVERS_DATABASE_VERSION_2)) {
-                        /* Written on a bigendian machine with old fetch_int code. Save as le. */
-                        /* The only upgrade between V2 and V3 is to save the version in little-endian. */
-                        tdb_store_int32(tdb_drivers, vstring, NTDRIVERS_DATABASE_VERSION_3);
-                        vers_id = NTDRIVERS_DATABASE_VERSION_3;
-                }
-
-                if (vers_id == NTDRIVERS_DATABASE_VERSION_3 ) {
-                        if ( !upgrade_to_version_4() )
-                                return False;
-                        tdb_store_int32(tdb_drivers, vstring, NTDRIVERS_DATABASE_VERSION_4);
-                        vers_id = NTDRIVERS_DATABASE_VERSION_4;
-                }
-
-                if (vers_id == NTDRIVERS_DATABASE_VERSION_4 ) {
-                        if ( !upgrade_to_version_5() )
-                                return False;
-                        tdb_store_int32(tdb_drivers, vstring, NTDRIVERS_DATABASE_VERSION_5);
-                        vers_id = NTDRIVERS_DATABASE_VERSION_5;
-                }
-
-
-                if ( vers_id != NTDRIVERS_DATABASE_VERSION_5 ) {
-                        DEBUG(0,("nt_printing_init: Unknown printer database version [%d]\n", vers_id));
-                        return False;
-                }
-        }
-
-        update_c_setprinter(True);
+
+        if (!nt_printing_tdb_upgrade()) {
+                return false;
+        }
 
         /*
@@ -605 +90 @@
          * drivers are installed
          */
-
         messaging_register(msg_ctx, NULL, MSG_PRINTER_DRVUPGRADE,
                            do_drv_upgrade_printer);
 
-        /*
-         * register callback to handle updating printer data
-         * when a driver is initialized
-         */
-
-        messaging_register(msg_ctx, NULL, MSG_PRINTERDATA_INIT_RESET,
-                           reset_all_printerdata);
-
         /* of course, none of the message callbacks matter if you don't
            tell messages.c that you interested in receiving PRINT_GENERAL
-           msgs.  This is done in claim_connection() */
-
+           msgs.  This is done in serverid_register() */
 
         if ( lp_security() == SEC_ADS ) {
-                win_rc = check_published_printers();
+                win_rc = check_published_printers(msg_ctx);
                 if (!W_ERROR_IS_OK(win_rc))
                         DEBUG(0, ("nt_printing_init: error checking published printers: %s\n", win_errstr(win_rc)));
         }
 
-        return True;
+        return true;
 }
 
@@ -661 +136 @@
 }
 
-/*******************************************************************
- tdb traversal function for counting printers.
-********************************************************************/
-
-static int traverse_counting_printers(TDB_CONTEXT *t, TDB_DATA key,
-                                      TDB_DATA data, void *context)
-{
-        int *printer_count = (int*)context;
-
-        if (memcmp(PRINTERS_PREFIX, key.dptr, sizeof(PRINTERS_PREFIX)-1) == 0) {
-                (*printer_count)++;
-                DEBUG(10,("traverse_counting_printers: printer = [%s]  printer_count = %d\n", key.dptr, *printer_count));
-        }
-
-        return 0;
-}
-
-/*******************************************************************
- Update the spooler global c_setprinter. This variable is initialized
- when the parent smbd starts with the number of existing printers. It
- is monotonically increased by the current number of printers *after*
- each add or delete printer RPC. Only Microsoft knows why... JRR020119
-********************************************************************/
-
-uint32 update_c_setprinter(bool initialize)
-{
-        int32 c_setprinter;
-        int32 printer_count = 0;
-
-        tdb_lock_bystring(tdb_printers, GLOBAL_C_SETPRINTER);
-
-        /* Traverse the tdb, counting the printers */
-        tdb_traverse(tdb_printers, traverse_counting_printers, (void *)&printer_count);
-
-        /* If initializing, set c_setprinter to current printers count
-         * otherwise, bump it by the current printer count
-         */
-        if (!initialize)
-                c_setprinter = tdb_fetch_int32(tdb_printers, GLOBAL_C_SETPRINTER) + printer_count;
-        else
-                c_setprinter = printer_count;
-
-        DEBUG(10,("update_c_setprinter: c_setprinter = %u\n", (unsigned int)c_setprinter));
-        tdb_store_int32(tdb_printers, GLOBAL_C_SETPRINTER, c_setprinter);
-
-        tdb_unlock_bystring(tdb_printers, GLOBAL_C_SETPRINTER);
-
-        return (uint32)c_setprinter;
-}
-
-/*******************************************************************
- Get the spooler global c_setprinter, accounting for initialization.
-********************************************************************/
-
-uint32 get_c_setprinter(void)
-{
-        int32 c_setprinter = tdb_fetch_int32(tdb_printers, GLOBAL_C_SETPRINTER);
-
-        if (c_setprinter == (int32)-1)
-                c_setprinter = update_c_setprinter(True);
-
-        DEBUG(10,("get_c_setprinter: c_setprinter = %d\n", c_setprinter));
-
-        return (uint32)c_setprinter;
-}
-
-/****************************************************************************
- Get builtin form struct list.
-****************************************************************************/
-
-int get_builtin_ntforms(nt_forms_struct **list)
-{
-        *list = (nt_forms_struct *)memdup(&default_forms[0], sizeof(default_forms));
-        if (!*list) {
-                return 0;
-        }
-        return ARRAY_SIZE(default_forms);
-}
-
-/****************************************************************************
- get a builtin form struct
-****************************************************************************/
-
-bool get_a_builtin_ntform_by_string(const char *form_name, nt_forms_struct *form)
-{
-        int i;
-        DEBUGADD(6,("Looking for builtin form %s \n", form_name));
-        for (i=0; i<ARRAY_SIZE(default_forms); i++) {
-                if (strequal(form_name,default_forms[i].name)) {
-                        DEBUGADD(6,("Found builtin form %s \n", form_name));
-                        memcpy(form,&default_forms[i],sizeof(*form));
-                        return true;
-                }
-        }
-
-        return false;
-}
-
-/****************************************************************************
- get a form struct list.
-****************************************************************************/
-
-int get_ntforms(nt_forms_struct **list)
-{
-        TDB_DATA kbuf, newkey, dbuf;
-        nt_forms_struct form;
-        int ret;
-        int i;
-        int n = 0;
-
-        *list = NULL;
-
-        for (kbuf = tdb_firstkey(tdb_forms);
-             kbuf.dptr;
-             newkey = tdb_nextkey(tdb_forms, kbuf), free(kbuf.dptr), kbuf=newkey)
-        {
-                if (strncmp((const char *)kbuf.dptr, FORMS_PREFIX, strlen(FORMS_PREFIX)) != 0)
-                        continue;
-
-                dbuf = tdb_fetch(tdb_forms, kbuf);
-                if (!dbuf.dptr)
-                        continue;
-
-                fstrcpy(form.name, (const char *)kbuf.dptr+strlen(FORMS_PREFIX));
-                ret = tdb_unpack(dbuf.dptr, dbuf.dsize, "dddddddd",
-                                 &i, &form.flag, &form.width, &form.length, &form.left,
-                                 &form.top, &form.right, &form.bottom);
-                SAFE_FREE(dbuf.dptr);
-                if (ret != dbuf.dsize)
-                        continue;
-
-                *list = SMB_REALLOC_ARRAY(*list, nt_forms_struct, n+1);
-                if (!*list) {
-                        DEBUG(0,("get_ntforms: Realloc fail.\n"));
-                        return 0;
-                }
-                (*list)[n] = form;
-                n++;
-        }
-
-
-        return n;
-}
-
-/****************************************************************************
-write a form struct list
-****************************************************************************/
-
-int write_ntforms(nt_forms_struct **list, int number)
-{
-        TALLOC_CTX *ctx = talloc_tos();
-        char *buf = NULL;
-        char *key = NULL;
-        int len;
-        TDB_DATA dbuf;
-        int i;
-
-        for (i=0;i<number;i++) {
-                /* save index, so list is rebuilt in correct order */
-                len = tdb_pack(NULL, 0, "dddddddd",
-                               i, (*list)[i].flag, (*list)[i].width, (*list)[i].length,
-                               (*list)[i].left, (*list)[i].top, (*list)[i].right,
-                               (*list)[i].bottom);
-                if (!len) {
-                        continue;
-                }
-                buf = TALLOC_ARRAY(ctx, char, len);
-                if (!buf) {
-                        return 0;
-                }
-                len = tdb_pack((uint8 *)buf, len, "dddddddd",
-                               i, (*list)[i].flag, (*list)[i].width, (*list)[i].length,
-                               (*list)[i].left, (*list)[i].top, (*list)[i].right,
-                               (*list)[i].bottom);
-                key = talloc_asprintf(ctx, "%s%s", FORMS_PREFIX, (*list)[i].name);
-                if (!key) {
-                        return 0;
-                }
-                dbuf.dsize = len;
-                dbuf.dptr = (uint8 *)buf;
-                if (tdb_store_bystring(tdb_forms, key, dbuf, TDB_REPLACE) != 0) {
-                        TALLOC_FREE(key);
-                        TALLOC_FREE(buf);
-                        break;
-                }
-                TALLOC_FREE(key);
-                TALLOC_FREE(buf);
-       }
-
-       return i;
-}
-
-/****************************************************************************
-add a form struct at the end of the list
-****************************************************************************/
-bool add_a_form(nt_forms_struct **list, struct spoolss_AddFormInfo1 *form, int *count)
-{
-        int n=0;
-        bool update;
-
-        /*
-         * NT tries to add forms even when
-         * they are already in the base
-         * only update the values if already present
-         */
-
-        update=False;
-
-        for (n=0; n<*count; n++) {
-                if ( strequal((*list)[n].name, form->form_name) ) {
-                        update=True;
-                        break;
-                }
-        }
-
-        if (update==False) {
-                if((*list=SMB_REALLOC_ARRAY(*list, nt_forms_struct, n+1)) == NULL) {
-                        DEBUG(0,("add_a_form: failed to enlarge forms list!\n"));
-                        return False;
-                }
-                fstrcpy((*list)[n].name, form->form_name);
-                (*count)++;
-        }
-
-        (*list)[n].flag         = form->flags;
-        (*list)[n].width        = form->size.width;
-        (*list)[n].length       = form->size.height;
-        (*list)[n].left         = form->area.left;
-        (*list)[n].top          = form->area.top;
-        (*list)[n].right        = form->area.right;
-        (*list)[n].bottom       = form->area.bottom;
-
-        DEBUG(6,("add_a_form: Successfully %s form [%s]\n",
-                update ? "updated" : "added", form->form_name));
-
-        return True;
-}
-
-/****************************************************************************
- Delete a named form struct.
-****************************************************************************/
-
-bool delete_a_form(nt_forms_struct **list, const char *del_name, int *count, WERROR *ret)
-{
-        char *key = NULL;
-        int n=0;
-
-        *ret = WERR_OK;
-
-        for (n=0; n<*count; n++) {
-                if (!strncmp((*list)[n].name, del_name, strlen(del_name))) {
-                        DEBUG(103, ("delete_a_form, [%s] in list\n", del_name));
-                        break;
-                }
-        }
-
-        if (n == *count) {
-                DEBUG(10,("delete_a_form, [%s] not found\n", del_name));
-                *ret = WERR_INVALID_PARAM;
-                return False;
-        }
-
-        if (asprintf(&key, "%s%s", FORMS_PREFIX, (*list)[n].name) < 0) {
-                *ret = WERR_NOMEM;
-                return false;
-        }
-        if (tdb_delete_bystring(tdb_forms, key) != 0) {
-                SAFE_FREE(key);
-                *ret = WERR_NOMEM;
-                return False;
-        }
-        SAFE_FREE(key);
-        return true;
-}
-
-/****************************************************************************
- Update a form struct.
-****************************************************************************/
-
-void update_a_form(nt_forms_struct **list, struct spoolss_AddFormInfo1 *form, int count)
-{
-        int n=0;
-
-        DEBUG(106, ("[%s]\n", form->form_name));
-        for (n=0; n<count; n++) {
-                DEBUGADD(106, ("n [%d]:[%s]\n", n, (*list)[n].name));
-                if (!strncmp((*list)[n].name, form->form_name, strlen(form->form_name)))
-                        break;
-        }
-
-        if (n==count) return;
-
-        (*list)[n].flag         = form->flags;
-        (*list)[n].width        = form->size.width;
-        (*list)[n].length       = form->size.height;
-        (*list)[n].left         = form->area.left;
-        (*list)[n].top          = form->area.top;
-        (*list)[n].right        = form->area.right;
-        (*list)[n].bottom       = form->area.bottom;
-}
-
-/****************************************************************************
- Get the nt drivers list.
- Traverse the database and look-up the matching names.
-****************************************************************************/
-int get_ntdrivers(fstring **list, const char *architecture, uint32 version)
-{
-        int total=0;
-        const char *short_archi;
-        char *key = NULL;
-        TDB_DATA kbuf, newkey;
-
-        short_archi = get_short_archi(architecture);
-        if (!short_archi) {
-                return 0;
-        }
-
-        if (asprintf(&key, "%s%s/%d/", DRIVERS_PREFIX,
-                                short_archi, version) < 0) {
-                return 0;
-        }
-
-        for (kbuf = tdb_firstkey(tdb_drivers);
-             kbuf.dptr;
-             newkey = tdb_nextkey(tdb_drivers, kbuf), free(kbuf.dptr), kbuf=newkey) {
-
-                if (strncmp((const char *)kbuf.dptr, key, strlen(key)) != 0)
-                        continue;
-
-                if((*list = SMB_REALLOC_ARRAY(*list, fstring, total+1)) == NULL) {
-                        DEBUG(0,("get_ntdrivers: failed to enlarge list!\n"));
-                        SAFE_FREE(key);
-                        return -1;
-                }
-
-                fstrcpy((*list)[total], (const char *)kbuf.dptr+strlen(key));
-                total++;
-        }
-
-        SAFE_FREE(key);
-        return(total);
-}
-
 /****************************************************************************
  Function to do the mapping between the long architecture name and
@@ -1013 +145 @@
         int i=-1;
 
-        DEBUG(107,("Getting architecture dependant directory\n"));
+        DEBUG(107,("Getting architecture dependent directory\n"));
         do {
                 i++;
@@ -1316 +448 @@
                 INTERNAL_OPEN_ONLY,                     /* oplock_request */
                 0,                                      /* allocation_size */
+                0,                                      /* private_flags */
                 NULL,                                   /* sd */
                 NULL,                                   /* ea_list */
@@ -1368 +501 @@
                 INTERNAL_OPEN_ONLY,                     /* oplock_request */
                 0,                                      /* allocation_size */
+                0,                                      /* private_flags */
                 NULL,                                   /* sd */
                 NULL,                                   /* ea_list */
@@ -1441 +575 @@
 Determine the correct cVersion associated with an architecture and driver
 ****************************************************************************/
-static uint32 get_correct_cversion(struct pipes_struct *p,
+static uint32 get_correct_cversion(struct auth_serversupplied_info *session_info,
                                    const char *architecture,
                                    const char *driverpath_in,
                                    WERROR *perr)
 {
-        int               cversion;
+        int cversion = -1;
         NTSTATUS          nt_status;
         struct smb_filename *smb_fname = NULL;
@@ -1452 +586 @@
         files_struct      *fsp = NULL;
         connection_struct *conn = NULL;
-        NTSTATUS status;
         char *oldcwd;
-        fstring printdollar;
+        char *printdollar = NULL;
         int printdollar_snum;
 
@@ -1473 +606 @@
         }
 
-        fstrcpy(printdollar, "print$");
-
-        printdollar_snum = find_service(printdollar);
+        printdollar_snum = find_service(talloc_tos(), "print$", &printdollar);
+        if (!printdollar) {
+                *perr = WERR_NOMEM;
+                return -1;
+        }
         if (printdollar_snum == -1) {
                 *perr = WERR_NO_SUCH_SHARE;
@@ -1483 +618 @@
         nt_status = create_conn_struct(talloc_tos(), &conn, printdollar_snum,
                                        lp_pathname(printdollar_snum),
-                                       p->server_info, &oldcwd);
+                                       session_info, &oldcwd);
         if (!NT_STATUS_IS_OK(nt_status)) {
                 DEBUG(0,("get_correct_cversion: create_conn_struct "
@@ -1489 +624 @@
                 *perr = ntstatus_to_werror(nt_status);
                 return -1;
+        }
+
+        nt_status = set_conn_force_user_group(conn, printdollar_snum);
+        if (!NT_STATUS_IS_OK(nt_status)) {
+                DEBUG(0, ("failed set force user / group\n"));
+                *perr = ntstatus_to_werror(nt_status);
+                goto error_free_conn;
+        }
+
+        if (!become_user_by_session(conn, session_info)) {
+                DEBUG(0, ("failed to become user\n"));
+                *perr = WERR_ACCESS_DENIED;
+                goto error_free_conn;
         }
 
@@ -1510 +658 @@
         nt_status = vfs_file_exist(conn, smb_fname);
         if (!NT_STATUS_IS_OK(nt_status)) {
+                DEBUG(3,("get_correct_cversion: vfs_file_exist failed\n"));
                 *perr = WERR_BADFILE;
                 goto error_exit;
         }
 
-        status = SMB_VFS_CREATE_FILE(
+        nt_status = SMB_VFS_CREATE_FILE(
                 conn,                                   /* conn */
                 NULL,                                   /* req */
@@ -1525 +674 @@
                 FILE_ATTRIBUTE_NORMAL,                  /* file_attributes */
                 INTERNAL_OPEN_ONLY,                     /* oplock_request */
+                0,                                      /* private_flags */
                 0,                                      /* allocation_size */
                 NULL,                                   /* sd */
@@ -1531 +681 @@
                 NULL);                                  /* pinfo */
 
-        if (!NT_STATUS_IS_OK(status)) {
+        if (!NT_STATUS_IS_OK(nt_status)) {
                 DEBUG(3,("get_correct_cversion: Can't open file [%s], errno = "
                          "%d\n", smb_fname_str_dbg(smb_fname), errno));
@@ -1542 +692 @@
 
                 ret = get_file_version(fsp, smb_fname->base_name, &major, &minor);
-                if (ret == -1) goto error_exit;
-
-                if (!ret) {
+                if (ret == -1) {
+                        *perr = WERR_INVALID_PARAM;
+                        goto error_exit;
+                } else if (!ret) {
                         DEBUG(6,("get_correct_cversion: Version info not "
                                  "found [%s]\n",
                                  smb_fname_str_dbg(smb_fname)));
+                        *perr = WERR_INVALID_PARAM;
                         goto error_exit;
                 }
@@ -1579 +731 @@
         DEBUG(10,("get_correct_cversion: Driver file [%s] cversion = %d\n",
                   smb_fname_str_dbg(smb_fname), cversion));
-
-        goto done;
+        *perr = WERR_OK;
 
  error_exit:
-        cversion = -1;
- done:
+        unbecome_user();
+ error_free_conn:
         TALLOC_FREE(smb_fname);
         if (fsp != NULL) {
@@ -1591 +742 @@
         if (conn != NULL) {
                 vfs_ChDir(conn, oldcwd);
+                SMB_VFS_DISCONNECT(conn);
                 conn_free(conn);
         }
-        if (cversion != -1) {
-                *perr = WERR_OK;
-        }
+        if (!NT_STATUS_IS_OK(*perr)) {
+                cversion = -1;
+        }
+
         return cversion;
 }
@@ -1610 +763 @@
 
 static WERROR clean_up_driver_struct_level(TALLOC_CTX *mem_ctx,
-                                           struct pipes_struct *rpc_pipe,
+                                           struct auth_serversupplied_info *session_info,
                                            const char *architecture,
                                            const char **driver_path,
@@ -1617 +770 @@
                                            const char **help_file,
                                            struct spoolss_StringArray *dependent_files,
-                                           uint32_t *version)
+                                           enum spoolss_DriverOSVersion *version)
 {
         const char *short_architecture;
@@ -1670 +823 @@
          */
 
-        *version = get_correct_cversion(rpc_pipe, short_architecture,
+        *version = get_correct_cversion(session_info, short_architecture,
                                         *driver_path, &err);
         if (*version == -1) {
@@ -1682 +835 @@
 ****************************************************************************/
 
-WERROR clean_up_driver_struct(struct pipes_struct *rpc_pipe,
+WERROR clean_up_driver_struct(TALLOC_CTX *mem_ctx,
+                              struct auth_serversupplied_info *session_info,
                               struct spoolss_AddDriverInfoCtr *r)
 {
         switch (r->level) {
         case 3:
-                return clean_up_driver_struct_level(r, rpc_pipe,
+                return clean_up_driver_struct_level(mem_ctx, session_info,
                                                     r->info.info3->architecture,
                                                     &r->info.info3->driver_path,
@@ -1696 +850 @@
                                                     &r->info.info3->version);
         case 6:
-                return clean_up_driver_struct_level(r, rpc_pipe,
+                return clean_up_driver_struct_level(mem_ctx, session_info,
                                                     r->info.info6->architecture,
                                                     &r->info.info6->driver_path,
@@ -1731 +885 @@
 
 /****************************************************************************
- This function sucks and should be replaced. JRA.
-****************************************************************************/
-
-static void convert_level_8_to_level3(TALLOC_CTX *mem_ctx,
-                                      struct spoolss_AddDriverInfo3 *dst,
-                                      const struct spoolss_DriverInfo8 *src)
-{
-        dst->version            = src->version;
-        dst->driver_name        = src->driver_name;
-        dst->architecture       = src->architecture;
-        dst->driver_path        = src->driver_path;
-        dst->data_file          = src->data_file;
-        dst->config_file        = src->config_file;
-        dst->help_file          = src->help_file;
-        dst->monitor_name       = src->monitor_name;
-        dst->default_datatype   = src->default_datatype;
-        if (src->dependent_files) {
-                dst->dependent_files = talloc_zero(mem_ctx, struct spoolss_StringArray);
-                if (!dst->dependent_files) return;
-                dst->dependent_files->string = src->dependent_files;
-        } else {
-                dst->dependent_files = NULL;
-        }
-}
-
-/****************************************************************************
 ****************************************************************************/
 
@@ -1827 +955 @@
 }
 
-WERROR move_driver_to_download_area(struct pipes_struct *p,
-                                    struct spoolss_AddDriverInfoCtr *r,
-                                    WERROR *perr)
+WERROR move_driver_to_download_area(struct auth_serversupplied_info *session_info,
+                                    struct spoolss_AddDriverInfoCtr *r)
 {
         struct spoolss_AddDriverInfo3 *driver;
@@ -1842 +969 @@
         int ver = 0;
         char *oldcwd;
-        fstring printdollar;
+        char *printdollar = NULL;
         int printdollar_snum;
-
-        *perr = WERR_OK;
+        WERROR err = WERR_OK;
 
         switch (r->level) {
@@ -1865 +991 @@
         }
 
-        fstrcpy(printdollar, "print$");
-
-        printdollar_snum = find_service(printdollar);
+        printdollar_snum = find_service(ctx, "print$", &printdollar);
+        if (!printdollar) {
+                return WERR_NOMEM;
+        }
         if (printdollar_snum == -1) {
-                *perr = WERR_NO_SUCH_SHARE;
                 return WERR_NO_SUCH_SHARE;
         }
@@ -1875 +1001 @@
         nt_status = create_conn_struct(talloc_tos(), &conn, printdollar_snum,
                                        lp_pathname(printdollar_snum),
-                                       p->server_info, &oldcwd);
+                                       session_info, &oldcwd);
         if (!NT_STATUS_IS_OK(nt_status)) {
                 DEBUG(0,("move_driver_to_download_area: create_conn_struct "
                          "returned %s\n", nt_errstr(nt_status)));
-                *perr = ntstatus_to_werror(nt_status);
-                return *perr;
+                err = ntstatus_to_werror(nt_status);
+                return err;
+        }
+
+        nt_status = set_conn_force_user_group(conn, printdollar_snum);
+        if (!NT_STATUS_IS_OK(nt_status)) {
+                DEBUG(0, ("failed set force user / group\n"));
+                err = ntstatus_to_werror(nt_status);
+                goto err_free_conn;
+        }
+
+        if (!become_user_by_session(conn, session_info)) {
+                DEBUG(0, ("failed to become user\n"));
+                err = WERR_ACCESS_DENIED;
+                goto err_free_conn;
         }
 
@@ -1888 +1027 @@
                                 driver->version);
         if (!new_dir) {
-                *perr = WERR_NOMEM;
+                err = WERR_NOMEM;
                 goto err_exit;
         }
         nt_status = driver_unix_convert(conn, new_dir, &smb_dname);
         if (!NT_STATUS_IS_OK(nt_status)) {
-                *perr = WERR_NOMEM;
+                err = WERR_NOMEM;
                 goto err_exit;
         }
@@ -1899 +1038 @@
         DEBUG(5,("Creating first directory: %s\n", smb_dname->base_name));
 
-        create_directory(conn, NULL, smb_dname);
+        nt_status = create_directory(conn, NULL, smb_dname);
+        if (!NT_STATUS_IS_OK(nt_status)
+         && !NT_STATUS_EQUAL(nt_status, NT_STATUS_OBJECT_NAME_COLLISION)) {
+                DEBUG(0, ("failed to create driver destination directory: %s\n",
+                          nt_errstr(nt_status)));
+                err = ntstatus_to_werror(nt_status);
+                goto err_exit;
+        }
 
         /* For each driver file, archi\filexxx.yyy, if there is a duplicate file
@@ -1922 +1068 @@
         if (driver->driver_path && strlen(driver->driver_path)) {
 
-                *perr = move_driver_file_to_download_area(ctx,
-                                                          conn,
-                                                          driver->driver_path,
-                                                          short_architecture,
-                                                          driver->version,
-                                                          ver);
-                if (!W_ERROR_IS_OK(*perr)) {
-                        if (W_ERROR_EQUAL(*perr, WERR_ACCESS_DENIED)) {
-                                ver = -1;
-                        }
+                err = move_driver_file_to_download_area(ctx,
+                                                        conn,
+                                                        driver->driver_path,
+                                                        short_architecture,
+                                                        driver->version,
+                                                        ver);
+                if (!W_ERROR_IS_OK(err)) {
                         goto err_exit;
                 }
@@ -1939 +1082 @@
                 if (!strequal(driver->data_file, driver->driver_path)) {
 
-                        *perr = move_driver_file_to_download_area(ctx,
-                                                                  conn,
-                                                                  driver->data_file,
-                                                                  short_architecture,
-                                                                  driver->version,
-                                                                  ver);
-                        if (!W_ERROR_IS_OK(*perr)) {
-                                if (W_ERROR_EQUAL(*perr, WERR_ACCESS_DENIED)) {
-                                        ver = -1;
-                                }
+                        err = move_driver_file_to_download_area(ctx,
+                                                                conn,
+                                                                driver->data_file,
+                                                                short_architecture,
+                                                                driver->version,
+                                                                ver);
+                        if (!W_ERROR_IS_OK(err)) {
                                 goto err_exit;
                         }
@@ -1958 +1098 @@
                     !strequal(driver->config_file, driver->data_file)) {
 
-                        *perr = move_driver_file_to_download_area(ctx,
-                                                                  conn,
-                                                                  driver->config_file,
-                                                                  short_architecture,
-                                                                  driver->version,
-                                                                  ver);
-                        if (!W_ERROR_IS_OK(*perr)) {
-                                if (W_ERROR_EQUAL(*perr, WERR_ACCESS_DENIED)) {
-                                        ver = -1;
-                                }
+                        err = move_driver_file_to_download_area(ctx,
+                                                                conn,
+                                                                driver->config_file,
+                                                                short_architecture,
+                                                                driver->version,
+                                                                ver);
+                        if (!W_ERROR_IS_OK(err)) {
                                 goto err_exit;
                         }
@@ -1978 +1115 @@
                     !strequal(driver->help_file, driver->config_file)) {
 
-                        *perr = move_driver_file_to_download_area(ctx,
-                                                                  conn,
-                                                                  driver->help_file,
-                                                                  short_architecture,
-                                                                  driver->version,
-                                                                  ver);
-                        if (!W_ERROR_IS_OK(*perr)) {
-                                if (W_ERROR_EQUAL(*perr, WERR_ACCESS_DENIED)) {
-                                        ver = -1;
-                                }
+                        err = move_driver_file_to_download_area(ctx,
+                                                                conn,
+                                                                driver->help_file,
+                                                                short_architecture,
+                                                                driver->version,
+                                                                ver);
+                        if (!W_ERROR_IS_OK(err)) {
                                 goto err_exit;
                         }
@@ -2006 +1140 @@
                                 }
 
-                                *perr = move_driver_file_to_download_area(ctx,
-                                                                          conn,
-                                                                          driver->dependent_files->string[i],
-                                                                          short_architecture,
-                                                                          driver->version,
-                                                                          ver);
-                                if (!W_ERROR_IS_OK(*perr)) {
-                                        if (W_ERROR_EQUAL(*perr, WERR_ACCESS_DENIED)) {
-                                                ver = -1;
-                                        }
+                                err = move_driver_file_to_download_area(ctx,
+                                                                        conn,
+                                                                        driver->dependent_files->string[i],
+                                                                        short_architecture,
+                                                                        driver->version,
+                                                                        ver);
+                                if (!W_ERROR_IS_OK(err)) {
                                         goto err_exit;
                                 }
@@ -2023 +1154 @@
         }
 
-  err_exit:
+        err = WERR_OK;
+ err_exit:
+        unbecome_user();
+ err_free_conn:
         TALLOC_FREE(smb_dname);
 
         if (conn != NULL) {
                 vfs_ChDir(conn, oldcwd);
+                SMB_VFS_DISCONNECT(conn);
                 conn_free(conn);
         }
 
-        if (W_ERROR_EQUAL(*perr, WERR_OK)) {
-                return WERR_OK;
-        }
-        if (ver == -1) {
-                return WERR_UNKNOWN_PRINTER_DRIVER;
-        }
-        return (*perr);
-}
-
-/****************************************************************************
-****************************************************************************/
-
-static uint32 add_a_printer_driver_3(struct spoolss_AddDriverInfo3 *driver)
-{
-        TALLOC_CTX *ctx = talloc_tos();
-        int len, buflen;
-        const char *architecture;
-        char *directory = NULL;
-        char *key = NULL;
-        uint8 *buf;
-        int i, ret;
-        TDB_DATA dbuf;
-
-        architecture = get_short_archi(driver->architecture);
-        if (!architecture) {
-                return (uint32)-1;
-        }
-
-        /* The names are relative. We store them in the form: \print$\arch\version\driver.xxx
-         * \\server is added in the rpc server layer.
-         * It does make sense to NOT store the server's name in the printer TDB.
-         */
-
-        directory = talloc_asprintf(ctx, "\\print$\\%s\\%d\\",
-                        architecture, driver->version);
-        if (!directory) {
-                return (uint32)-1;
-        }
-
-#define gen_full_driver_unc_path(ctx, directory, file) \
-        do { \
-                if (file && strlen(file)) { \
-                        file = talloc_asprintf(ctx, "%s%s", directory, file); \
-                } else { \
-                        file = talloc_strdup(ctx, ""); \
-                } \
-                if (!file) { \
-                        return (uint32_t)-1; \
-                } \
-        } while (0);
-
-        /* .inf files do not always list a file for each of the four standard files.
-         * Don't prepend a path to a null filename, or client claims:
-         *   "The server on which the printer resides does not have a suitable
-         *   <printer driver name> printer driver installed. Click OK if you
-         *   wish to install the driver on your local machine."
-         */
-
-        gen_full_driver_unc_path(ctx, directory, driver->driver_path);
-        gen_full_driver_unc_path(ctx, directory, driver->data_file);
-        gen_full_driver_unc_path(ctx, directory, driver->config_file);
-        gen_full_driver_unc_path(ctx, directory, driver->help_file);
-
-        if (driver->dependent_files && driver->dependent_files->string) {
-                for (i=0; driver->dependent_files->string[i]; i++) {
-                        gen_full_driver_unc_path(ctx, directory,
-                                driver->dependent_files->string[i]);
-                }
-        }
-
-        key = talloc_asprintf(ctx, "%s%s/%d/%s", DRIVERS_PREFIX,
-                        architecture, driver->version, driver->driver_name);
-        if (!key) {
-                return (uint32)-1;
-        }
-
-        DEBUG(5,("add_a_printer_driver_3: Adding driver with key %s\n", key ));
-
-        buf = NULL;
-        len = buflen = 0;
-
- again:
-        len = 0;
-        len += tdb_pack(buf+len, buflen-len, "dffffffff",
-                        driver->version,
-                        driver->driver_name,
-                        driver->architecture,
-                        driver->driver_path,
-                        driver->data_file,
-                        driver->config_file,
-                        driver->help_file,
-                        driver->monitor_name ? driver->monitor_name : "",
-                        driver->default_datatype ? driver->default_datatype : "");
-
-        if (driver->dependent_files && driver->dependent_files->string) {
-                for (i=0; driver->dependent_files->string[i]; i++) {
-                        len += tdb_pack(buf+len, buflen-len, "f",
-                                        driver->dependent_files->string[i]);
-                }
-        }
-
-        if (len != buflen) {
-                buf = (uint8 *)SMB_REALLOC(buf, len);
-                if (!buf) {
-                        DEBUG(0,("add_a_printer_driver_3: failed to enlarge buffer\n!"));
-                        ret = -1;
-                        goto done;
-                }
-                buflen = len;
-                goto again;
-        }
-
-        dbuf.dptr = buf;
-        dbuf.dsize = len;
-
-        ret = tdb_store_bystring(tdb_drivers, key, dbuf, TDB_REPLACE);
-
-done:
-        if (ret)
-                DEBUG(0,("add_a_printer_driver_3: Adding driver with key %s failed.\n", key ));
-
-        SAFE_FREE(buf);
-        return ret;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-static uint32_t add_a_printer_driver_8(struct spoolss_DriverInfo8 *driver)
-{
-        TALLOC_CTX *mem_ctx = talloc_new(talloc_tos());
-        struct spoolss_AddDriverInfo3 info3;
-        uint32_t ret;
-
-        convert_level_8_to_level3(mem_ctx, &info3, driver);
-
-        ret = add_a_printer_driver_3(&info3);
-        talloc_free(mem_ctx);
-
-        return ret;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-static WERROR get_a_printer_driver_3_default(TALLOC_CTX *mem_ctx,
-                                             struct spoolss_DriverInfo3 *info,
-                                             const char *driver, const char *arch)
-{
-        info->driver_name = talloc_strdup(mem_ctx, driver);
-        if (!info->driver_name) {
-                return WERR_NOMEM;
-        }
-
-        info->default_datatype = talloc_strdup(mem_ctx, "RAW");
-        if (!info->default_datatype) {
-                return WERR_NOMEM;
-        }
-
-        info->driver_path = talloc_strdup(mem_ctx, "");
-        info->data_file = talloc_strdup(mem_ctx, "");
-        info->config_file = talloc_strdup(mem_ctx, "");
-        info->help_file = talloc_strdup(mem_ctx, "");
-        if (!info->driver_path || !info->data_file || !info->config_file || !info->help_file) {
-                return WERR_NOMEM;
-        }
-
-        return WERR_OK;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-static WERROR get_a_printer_driver_3(TALLOC_CTX *mem_ctx,
-                                     struct spoolss_DriverInfo3 *driver,
-                                     const char *drivername, const char *arch,
-                                     uint32_t version)
-{
-        TDB_DATA dbuf;
-        const char *architecture;
-        int len = 0;
-        int i;
-        char *key = NULL;
-        fstring name, driverpath, environment, datafile, configfile, helpfile, monitorname, defaultdatatype;
-
-        architecture = get_short_archi(arch);
-        if ( !architecture ) {
-                return WERR_UNKNOWN_PRINTER_DRIVER;
-        }
-
-        /* Windows 4.0 (i.e. win9x) should always use a version of 0 */
-
-        if ( strcmp( architecture, SPL_ARCH_WIN40 ) == 0 )
-                version = 0;
-
-        DEBUG(8,("get_a_printer_driver_3: [%s%s/%d/%s]\n", DRIVERS_PREFIX, architecture, version, drivername));
-
-        if (asprintf(&key, "%s%s/%d/%s", DRIVERS_PREFIX,
-                                architecture, version, drivername) < 0) {
-                return WERR_NOMEM;
-        }
-
-        dbuf = tdb_fetch_bystring(tdb_drivers, key);
-        if (!dbuf.dptr) {
-                SAFE_FREE(key);
-                return WERR_UNKNOWN_PRINTER_DRIVER;
-        }
-
-        len += tdb_unpack(dbuf.dptr, dbuf.dsize, "dffffffff",
-                          &driver->version,
-                          name,
-                          environment,
-                          driverpath,
-                          datafile,
-                          configfile,
-                          helpfile,
-                          monitorname,
-                          defaultdatatype);
-
-        driver->driver_name     = talloc_strdup(mem_ctx, name);
-        driver->architecture    = talloc_strdup(mem_ctx, environment);
-        driver->driver_path     = talloc_strdup(mem_ctx, driverpath);
-        driver->data_file       = talloc_strdup(mem_ctx, datafile);
-        driver->config_file     = talloc_strdup(mem_ctx, configfile);
-        driver->help_file       = talloc_strdup(mem_ctx, helpfile);
-        driver->monitor_name    = talloc_strdup(mem_ctx, monitorname);
-        driver->default_datatype        = talloc_strdup(mem_ctx, defaultdatatype);
-
-        i=0;
-
-        while (len < dbuf.dsize) {
-
-                fstring file;
-
-                driver->dependent_files = talloc_realloc(mem_ctx, driver->dependent_files, const char *, i+2);
-                if (!driver->dependent_files ) {
-                        DEBUG(0,("get_a_printer_driver_3: failed to enlarge buffer!\n"));
-                        break;
-                }
-
-                len += tdb_unpack(dbuf.dptr+len, dbuf.dsize-len, "f",
-                                  &file);
-
-                driver->dependent_files[i] = talloc_strdup(mem_ctx, file);
-
-                i++;
-        }
-
-        if (driver->dependent_files)
-                driver->dependent_files[i] = NULL;
-
-        SAFE_FREE(dbuf.dptr);
-        SAFE_FREE(key);
-
-        if (len != dbuf.dsize) {
-                return get_a_printer_driver_3_default(mem_ctx, driver, drivername, arch);
-        }
-
-        return WERR_OK;
-}
-
-/****************************************************************************
-****************************************************************************/
-int pack_devicemode(NT_DEVICEMODE *nt_devmode, uint8 *buf, int buflen)
-{
-        int len = 0;
-
-        len += tdb_pack(buf+len, buflen-len, "p", nt_devmode);
-
-        if (!nt_devmode)
-                return len;
-
-        len += tdb_pack(buf+len, buflen-len, "ffwwwwwwwwwwwwwwwwwwddddddddddddddp",
-                        nt_devmode->devicename,
-                        nt_devmode->formname,
-
-                        nt_devmode->specversion,
-                        nt_devmode->driverversion,
-                        nt_devmode->size,
-                        nt_devmode->driverextra,
-                        nt_devmode->orientation,
-                        nt_devmode->papersize,
-                        nt_devmode->paperlength,
-                        nt_devmode->paperwidth,
-                        nt_devmode->scale,
-                        nt_devmode->copies,
-                        nt_devmode->defaultsource,
-                        nt_devmode->printquality,
-                        nt_devmode->color,
-                        nt_devmode->duplex,
-                        nt_devmode->yresolution,
-                        nt_devmode->ttoption,
-                        nt_devmode->collate,
-                        nt_devmode->logpixels,
-
-                        nt_devmode->fields,
-                        nt_devmode->bitsperpel,
-                        nt_devmode->pelswidth,
-                        nt_devmode->pelsheight,
-                        nt_devmode->displayflags,
-                        nt_devmode->displayfrequency,
-                        nt_devmode->icmmethod,
-                        nt_devmode->icmintent,
-                        nt_devmode->mediatype,
-                        nt_devmode->dithertype,
-                        nt_devmode->reserved1,
-                        nt_devmode->reserved2,
-                        nt_devmode->panningwidth,
-                        nt_devmode->panningheight,
-                        nt_devmode->nt_dev_private);
-
-        if (nt_devmode->nt_dev_private) {
-                len += tdb_pack(buf+len, buflen-len, "B",
-                                nt_devmode->driverextra,
-                                nt_devmode->nt_dev_private);
-        }
-
-        DEBUG(8,("Packed devicemode [%s]\n", nt_devmode->formname));
-
-        return len;
-}
-
-/****************************************************************************
- Pack all values in all printer keys
- ***************************************************************************/
-
-static int pack_values(NT_PRINTER_DATA *data, uint8 *buf, int buflen)
-{
-        int             len = 0;
-        int             i, j;
-        struct regval_blob      *val;
-        struct regval_ctr       *val_ctr;
-        char *path = NULL;
-        int             num_values;
-
-        if ( !data )
-                return 0;
-
-        /* loop over all keys */
-
-        for ( i=0; i<data->num_keys; i++ ) {
-                val_ctr = data->keys[i].values;
-                num_values = regval_ctr_numvals( val_ctr );
-
-                /* pack the keyname followed by a empty value */
-
-                len += tdb_pack(buf+len, buflen-len, "pPdB",
-                                &data->keys[i].name,
-                                data->keys[i].name,
-                                REG_NONE,
-                                0,
-                                NULL);
-
-                /* now loop over all values */
-
-                for ( j=0; j<num_values; j++ ) {
-                        /* pathname should be stored as <key>\<value> */
-
-                        val = regval_ctr_specific_value( val_ctr, j );
-                        if (asprintf(&path, "%s\\%s",
-                                        data->keys[i].name,
-                                        regval_name(val)) < 0) {
-                                return -1;
-                        }
-
-                        len += tdb_pack(buf+len, buflen-len, "pPdB",
-                                        val,
-                                        path,
-                                        regval_type(val),
-                                        regval_size(val),
-                                        regval_data_p(val) );
-
-                        DEBUG(8,("specific: [%s], len: %d\n", regval_name(val), regval_size(val)));
-                        SAFE_FREE(path);
-                }
-
-        }
-
-        /* terminator */
-
-        len += tdb_pack(buf+len, buflen-len, "p", NULL);
-
-        return len;
-}
-
-
-/****************************************************************************
- Delete a printer - this just deletes the printer info file, any open
- handles are not affected.
-****************************************************************************/
-
-uint32 del_a_printer(const char *sharename)
-{
-        TDB_DATA kbuf;
-        char *printdb_path = NULL;
-        TALLOC_CTX *ctx = talloc_tos();
-
-        kbuf = make_printer_tdbkey(ctx, sharename);
-        tdb_delete(tdb_printers, kbuf);
-
-        kbuf= make_printers_secdesc_tdbkey(ctx, sharename);
-        tdb_delete(tdb_printers, kbuf);
-
-        close_all_print_db();
-
-        if (geteuid() == sec_initial_uid()) {
-                if (asprintf(&printdb_path, "%s%s.tdb",
-                                cache_path("printing/"),
-                                sharename) < 0) {
-                        return (uint32)-1;
-                }
-                unlink(printdb_path);
-                SAFE_FREE(printdb_path);
-        }
-
-        return 0;
-}
-
-/****************************************************************************
-****************************************************************************/
-static WERROR update_a_printer_2(NT_PRINTER_INFO_LEVEL_2 *info)
-{
-        uint8 *buf;
-        int buflen, len;
-        int retlen;
-        WERROR ret;
-        TDB_DATA kbuf, dbuf;
-
-        /*
-         * in addprinter: no servername and the printer is the name
-         * in setprinter: servername is \\server
-         *                and printer is \\server\\printer
-         *
-         * Samba manages only local printers.
-         * we currently don't support things like i
-         * path=\\other_server\printer
-         *
-         * We only store the printername, not \\server\printername
-         */
-
-        if ( info->servername[0] != '\0' ) {
-                trim_string(info->printername, info->servername, NULL);
-                trim_char(info->printername, '\\', '\0');
-                info->servername[0]='\0';
-        }
-
-        /*
-         * JFM: one day I'll forget.
-         * below that's info->portname because that's the SAMBA sharename
-         * and I made NT 'thinks' it's the portname
-         * the info->sharename is the thing you can name when you add a printer
-         * that's the short-name when you create shared printer for 95/98
-         * So I've made a limitation in SAMBA: you can only have 1 printer model
-         * behind a SAMBA share.
-         */
-
-        buf = NULL;
-        buflen = 0;
-
- again:
-        len = 0;
-        len += tdb_pack(buf+len, buflen-len, "dddddddddddfffffPfffff",
-                        info->attributes,
-                        info->priority,
-                        info->default_priority,
-                        info->starttime,
-                        info->untiltime,
-                        info->status,
-                        info->cjobs,
-                        info->averageppm,
-                        info->changeid,
-                        info->c_setprinter,
-                        info->setuptime,
-                        info->servername,
-                        info->printername,
-                        info->sharename,
-                        info->portname,
-                        info->drivername,
-                        info->comment,
-                        info->location,
-                        info->sepfile,
-                        info->printprocessor,
-                        info->datatype,
-                        info->parameters);
-
-        len += pack_devicemode(info->devmode, buf+len, buflen-len);
-        retlen = pack_values( info->data, buf+len, buflen-len );
-        if (retlen == -1) {
-                ret = WERR_NOMEM;
-                goto done;
-        }
-        len += retlen;
-
-        if (buflen != len) {
-                buf = (uint8 *)SMB_REALLOC(buf, len);
-                if (!buf) {
-                        DEBUG(0,("update_a_printer_2: failed to enlarge buffer!\n"));
-                        ret = WERR_NOMEM;
-                        goto done;
-                }
-                buflen = len;
-                goto again;
-        }
-
-        kbuf = make_printer_tdbkey(talloc_tos(), info->sharename );
-
-        dbuf.dptr = buf;
-        dbuf.dsize = len;
-
-        ret = (tdb_store(tdb_printers, kbuf, dbuf, TDB_REPLACE) == 0? WERR_OK : WERR_NOMEM);
-
-done:
-        if (!W_ERROR_IS_OK(ret))
-                DEBUG(8, ("error updating printer to tdb on disk\n"));
-
-        SAFE_FREE(buf);
-
-        DEBUG(8,("packed printer [%s] with driver [%s] portname=[%s] len=%d\n",
-                 info->sharename, info->drivername, info->portname, len));
-
-        return ret;
-}
-
-
-/****************************************************************************
- Malloc and return an NT devicemode.
-****************************************************************************/
-
-NT_DEVICEMODE *construct_nt_devicemode(const fstring default_devicename)
-{
-
-        char adevice[MAXDEVICENAME];
-        NT_DEVICEMODE *nt_devmode = SMB_MALLOC_P(NT_DEVICEMODE);
-
-        if (nt_devmode == NULL) {
-                DEBUG(0,("construct_nt_devicemode: malloc fail.\n"));
-                return NULL;
-        }
-
-        ZERO_STRUCTP(nt_devmode);
-
-        slprintf(adevice, sizeof(adevice), "%s", default_devicename);
-        fstrcpy(nt_devmode->devicename, adevice);
-
-        fstrcpy(nt_devmode->formname, "Letter");
-
-        nt_devmode->specversion      = DMSPEC_NT4_AND_ABOVE;
-        nt_devmode->driverversion    = 0x0400;
-        nt_devmode->size             = 0x00DC;
-        nt_devmode->driverextra      = 0x0000;
-        nt_devmode->fields           = DEVMODE_FORMNAME |
-                                       DEVMODE_TTOPTION |
-                                       DEVMODE_PRINTQUALITY |
-                                       DEVMODE_DEFAULTSOURCE |
-                                       DEVMODE_COPIES |
-                                       DEVMODE_SCALE |
-                                       DEVMODE_PAPERSIZE |
-                                       DEVMODE_ORIENTATION;
-        nt_devmode->orientation      = DMORIENT_PORTRAIT;
-        nt_devmode->papersize        = DMPAPER_LETTER;
-        nt_devmode->paperlength      = 0;
-        nt_devmode->paperwidth       = 0;
-        nt_devmode->scale            = 0x64;
-        nt_devmode->copies           = 1;
-        nt_devmode->defaultsource    = DMBIN_FORMSOURCE;
-        nt_devmode->printquality     = DMRES_HIGH;           /* 0x0258 */
-        nt_devmode->color            = DMRES_MONOCHROME;
-        nt_devmode->duplex           = DMDUP_SIMPLEX;
-        nt_devmode->yresolution      = 0;
-        nt_devmode->ttoption         = DMTT_SUBDEV;
-        nt_devmode->collate          = DMCOLLATE_FALSE;
-        nt_devmode->icmmethod        = 0;
-        nt_devmode->icmintent        = 0;
-        nt_devmode->mediatype        = 0;
-        nt_devmode->dithertype       = 0;
-
-        /* non utilisés par un driver d'imprimante */
-        nt_devmode->logpixels        = 0;
-        nt_devmode->bitsperpel       = 0;
-        nt_devmode->pelswidth        = 0;
-        nt_devmode->pelsheight       = 0;
-        nt_devmode->displayflags     = 0;
-        nt_devmode->displayfrequency = 0;
-        nt_devmode->reserved1        = 0;
-        nt_devmode->reserved2        = 0;
-        nt_devmode->panningwidth     = 0;
-        nt_devmode->panningheight    = 0;
-
-        nt_devmode->nt_dev_private = NULL;
-        return nt_devmode;
-}
-
-/****************************************************************************
- Clean up and deallocate a (maybe partially) allocated NT_DEVICEMODE.
-****************************************************************************/
-
-void free_nt_devicemode(NT_DEVICEMODE **devmode_ptr)
-{
-        NT_DEVICEMODE *nt_devmode = *devmode_ptr;
-
-        if(nt_devmode == NULL)
-                return;
-
-        DEBUG(106,("free_nt_devicemode: deleting DEVMODE\n"));
-
-        SAFE_FREE(nt_devmode->nt_dev_private);
-        SAFE_FREE(*devmode_ptr);
-}
-
-/****************************************************************************
- Clean up and deallocate a (maybe partially) allocated NT_PRINTER_INFO_LEVEL_2.
-****************************************************************************/
-
-static void free_nt_printer_info_level_2(NT_PRINTER_INFO_LEVEL_2 **info_ptr)
-{
-        NT_PRINTER_INFO_LEVEL_2 *info = *info_ptr;
-
-        if ( !info )
-                return;
-
-        free_nt_devicemode(&info->devmode);
-
-        TALLOC_FREE( *info_ptr );
-}
-
-
-/****************************************************************************
-****************************************************************************/
-int unpack_devicemode(NT_DEVICEMODE **nt_devmode, const uint8 *buf, int buflen)
-{
-        int len = 0;
-        int extra_len = 0;
-        NT_DEVICEMODE devmode;
-
-        ZERO_STRUCT(devmode);
-
-        len += tdb_unpack(buf+len, buflen-len, "p", nt_devmode);
-
-        if (!*nt_devmode) return len;
-
-        len += tdb_unpack(buf+len, buflen-len, "ffwwwwwwwwwwwwwwwwwwddddddddddddddp",
-                          devmode.devicename,
-                          devmode.formname,
-
-                          &devmode.specversion,
-                          &devmode.driverversion,
-                          &devmode.size,
-                          &devmode.driverextra,
-                          &devmode.orientation,
-                          &devmode.papersize,
-                          &devmode.paperlength,
-                          &devmode.paperwidth,
-                          &devmode.scale,
-                          &devmode.copies,
-                          &devmode.defaultsource,
-                          &devmode.printquality,
-                          &devmode.color,
-                          &devmode.duplex,
-                          &devmode.yresolution,
-                          &devmode.ttoption,
-                          &devmode.collate,
-                          &devmode.logpixels,
-
-                          &devmode.fields,
-                          &devmode.bitsperpel,
-                          &devmode.pelswidth,
-                          &devmode.pelsheight,
-                          &devmode.displayflags,
-                          &devmode.displayfrequency,
-                          &devmode.icmmethod,
-                          &devmode.icmintent,
-                          &devmode.mediatype,
-                          &devmode.dithertype,
-                          &devmode.reserved1,
-                          &devmode.reserved2,
-                          &devmode.panningwidth,
-                          &devmode.panningheight,
-                          &devmode.nt_dev_private);
-
-        if (devmode.nt_dev_private) {
-                /* the len in tdb_unpack is an int value and
-                 * devmode.driverextra is only a short
-                 */
-                len += tdb_unpack(buf+len, buflen-len, "B", &extra_len, &devmode.nt_dev_private);
-                devmode.driverextra=(uint16)extra_len;
-
-                /* check to catch an invalid TDB entry so we don't segfault */
-                if (devmode.driverextra == 0) {
-                        devmode.nt_dev_private = NULL;
-                }
-        }
-
-        *nt_devmode = (NT_DEVICEMODE *)memdup(&devmode, sizeof(devmode));
-        if (!*nt_devmode) {
-                SAFE_FREE(devmode.nt_dev_private);
-                return -1;
-        }
-
-        DEBUG(8,("Unpacked devicemode [%s](%s)\n", devmode.devicename, devmode.formname));
-        if (devmode.nt_dev_private)
-                DEBUG(8,("with a private section of %d bytes\n", devmode.driverextra));
-
-        return len;
-}
-
-/****************************************************************************
- Allocate and initialize a new slot.
-***************************************************************************/
-
-int add_new_printer_key( NT_PRINTER_DATA *data, const char *name )
-{
-        NT_PRINTER_KEY  *d;
-        int             key_index;
-
-        if ( !name || !data )
-                return -1;
-
-        /* allocate another slot in the NT_PRINTER_KEY array */
-
-        if ( !(d = TALLOC_REALLOC_ARRAY( data, data->keys, NT_PRINTER_KEY, data->num_keys+1)) ) {
-                DEBUG(0,("add_new_printer_key: Realloc() failed!\n"));
-                return -1;
-        }
-
-        data->keys = d;
-
-        key_index = data->num_keys;
-
-        /* initialze new key */
-
-        data->keys[key_index].name = talloc_strdup( data, name );
-
-        if ( !(data->keys[key_index].values = TALLOC_ZERO_P( data, struct regval_ctr )) )
-                return -1;
-
-        data->num_keys++;
-
-        DEBUG(10,("add_new_printer_key: Inserted new data key [%s]\n", name ));
-
-        return key_index;
-}
-
-/****************************************************************************
- search for a registry key name in the existing printer data
- ***************************************************************************/
-
-int delete_printer_key( NT_PRINTER_DATA *data, const char *name )
-{
-        int i;
-
-        for ( i=0; i<data->num_keys; i++ ) {
-                if ( strequal( data->keys[i].name, name ) ) {
-
-                        /* cleanup memory */
-
-                        TALLOC_FREE( data->keys[i].name );
-                        TALLOC_FREE( data->keys[i].values );
-
-                        /* if not the end of the array, move remaining elements down one slot */
-
-                        data->num_keys--;
-                        if ( data->num_keys && (i < data->num_keys) )
-                                memmove( &data->keys[i], &data->keys[i+1], sizeof(NT_PRINTER_KEY)*(data->num_keys-i) );
-
-                        break;
-                }
-        }
-
-
-        return data->num_keys;
-}
-
-/****************************************************************************
- search for a registry key name in the existing printer data
- ***************************************************************************/
-
-int lookup_printerkey( NT_PRINTER_DATA *data, const char *name )
-{
-        int             key_index = -1;
-        int             i;
-
-        if ( !data || !name )
-                return -1;
-
-        DEBUG(12,("lookup_printerkey: Looking for [%s]\n", name));
-
-        /* loop over all existing keys */
-
-        for ( i=0; i<data->num_keys; i++ ) {
-                if ( strequal(data->keys[i].name, name) ) {
-                        DEBUG(12,("lookup_printerkey: Found [%s]!\n", name));
-                        key_index = i;
-                        break;
-
-                }
-        }
-
-        return key_index;
-}
-
-/****************************************************************************
- ***************************************************************************/
-
-int get_printer_subkeys( NT_PRINTER_DATA *data, const char* key, fstring **subkeys )
-{
-        int     i, j;
-        int     key_len;
-        int     num_subkeys = 0;
-        char    *p;
-        fstring *subkeys_ptr = NULL;
-        fstring subkeyname;
-
-        *subkeys = NULL;
-
-        if ( !data )
-                return 0;
-
-        if ( !key )
-                return -1;
-
-        /* special case of asking for the top level printer data registry key names */
-
-        if ( strlen(key) == 0 ) {
-                for ( i=0; i<data->num_keys; i++ ) {
-
-                        /* found a match, so allocate space and copy the name */
-
-                        if ( !(subkeys_ptr = SMB_REALLOC_ARRAY( subkeys_ptr, fstring, num_subkeys+2)) ) {
-                                DEBUG(0,("get_printer_subkeys: Realloc failed for [%d] entries!\n",
-                                        num_subkeys+1));
-                                return -1;
-                        }
-
-                        fstrcpy( subkeys_ptr[num_subkeys], data->keys[i].name );
-                        num_subkeys++;
-                }
-
-                goto done;
-        }
-
-        /* asking for the subkeys of some key */
-        /* subkey paths are stored in the key name using '\' as the delimiter */
-
-        for ( i=0; i<data->num_keys; i++ ) {
-                if ( StrnCaseCmp(data->keys[i].name, key, strlen(key)) == 0 ) {
-
-                        /* if we found the exact key, then break */
-                        key_len = strlen( key );
-                        if ( strlen(data->keys[i].name) == key_len )
-                                break;
-
-                        /* get subkey path */
-
-                        p = data->keys[i].name + key_len;
-                        if ( *p == '\\' )
-                                p++;
-                        fstrcpy( subkeyname, p );
-                        if ( (p = strchr( subkeyname, '\\' )) )
-                                *p = '\0';
-
-                        /* don't add a key more than once */
-
-                        for ( j=0; j<num_subkeys; j++ ) {
-                                if ( strequal( subkeys_ptr[j], subkeyname ) )
-                                        break;
-                        }
-
-                        if ( j != num_subkeys )
-                                continue;
-
-                        /* found a match, so allocate space and copy the name */
-
-                        if ( !(subkeys_ptr = SMB_REALLOC_ARRAY( subkeys_ptr, fstring, num_subkeys+2)) ) {
-                                DEBUG(0,("get_printer_subkeys: Realloc failed for [%d] entries!\n",
-                                        num_subkeys+1));
-                                return 0;
-                        }
-
-                        fstrcpy( subkeys_ptr[num_subkeys], subkeyname );
-                        num_subkeys++;
-                }
-
-        }
-
-        /* return error if the key was not found */
-
-        if ( i == data->num_keys ) {
-                SAFE_FREE(subkeys_ptr);
-                return -1;
-        }
-
-done:
-        /* tag off the end */
-
-        if (num_subkeys)
-                fstrcpy(subkeys_ptr[num_subkeys], "" );
-
-        *subkeys = subkeys_ptr;
-
-        return num_subkeys;
-}
-
-#ifdef HAVE_ADS
-static void map_sz_into_ctr(struct regval_ctr *ctr, const char *val_name,
-                            const char *sz)
-{
-        regval_ctr_delvalue(ctr, val_name);
-        regval_ctr_addvalue_sz(ctr, val_name, sz);
-}
-
-static void map_dword_into_ctr(struct regval_ctr *ctr, const char *val_name,
-                               uint32 dword)
-{
-        regval_ctr_delvalue(ctr, val_name);
-        regval_ctr_addvalue(ctr, val_name, REG_DWORD,
-                            (char *) &dword, sizeof(dword));
-}
-
-static void map_bool_into_ctr(struct regval_ctr *ctr, const char *val_name,
-                              bool b)
-{
-        uint8 bin_bool = (b ? 1 : 0);
-        regval_ctr_delvalue(ctr, val_name);
-        regval_ctr_addvalue(ctr, val_name, REG_BINARY,
-                            (char *) &bin_bool, sizeof(bin_bool));
-}
-
-static void map_single_multi_sz_into_ctr(struct regval_ctr *ctr, const char *val_name,
-                                         const char *multi_sz)
-{
-        const char *a[2];
-
-        a[0] = multi_sz;
-        a[1] = NULL;
-
-        regval_ctr_delvalue(ctr, val_name);
-        regval_ctr_addvalue_multi_sz(ctr, val_name, a);
-}
-
-/****************************************************************************
- * Map the NT_PRINTER_INFO_LEVEL_2 data into DsSpooler keys for publishing.
- *
- * @param info2 NT_PRINTER_INFO_LEVEL_2 describing printer - gets modified
- * @return bool indicating success or failure
- ***************************************************************************/
-
-static bool map_nt_printer_info2_to_dsspooler(NT_PRINTER_INFO_LEVEL_2 *info2)
-{
-        struct regval_ctr *ctr = NULL;
-        fstring longname;
-        const char *dnssuffix;
-        char *allocated_string = NULL;
-        const char *ascii_str;
-        int i;
-
-        if ((i = lookup_printerkey(info2->data, SPOOL_DSSPOOLER_KEY)) < 0)
-                i = add_new_printer_key(info2->data, SPOOL_DSSPOOLER_KEY);
-        ctr = info2->data->keys[i].values;
-
-        map_sz_into_ctr(ctr, SPOOL_REG_PRINTERNAME, info2->sharename);
-        map_sz_into_ctr(ctr, SPOOL_REG_SHORTSERVERNAME, global_myname());
-
-        /* we make the assumption that the netbios name is the same
-           as the DNS name sinc ethe former will be what we used to
-           join the domain */
-
-        dnssuffix = get_mydnsdomname(talloc_tos());
-        if (dnssuffix && *dnssuffix) {
-                fstr_sprintf( longname, "%s.%s", global_myname(), dnssuffix );
-        } else {
-                fstrcpy( longname, global_myname() );
-        }
-
-        map_sz_into_ctr(ctr, SPOOL_REG_SERVERNAME, longname);
-
-        if (asprintf(&allocated_string, "\\\\%s\\%s", longname, info2->sharename) == -1) {
-                return false;
-        }
-        map_sz_into_ctr(ctr, SPOOL_REG_UNCNAME, allocated_string);
-        SAFE_FREE(allocated_string);
-
-        map_dword_into_ctr(ctr, SPOOL_REG_VERSIONNUMBER, 4);
-        map_sz_into_ctr(ctr, SPOOL_REG_DRIVERNAME, info2->drivername);
-        map_sz_into_ctr(ctr, SPOOL_REG_LOCATION, info2->location);
-        map_sz_into_ctr(ctr, SPOOL_REG_DESCRIPTION, info2->comment);
-        map_single_multi_sz_into_ctr(ctr, SPOOL_REG_PORTNAME, info2->portname);
-        map_sz_into_ctr(ctr, SPOOL_REG_PRINTSEPARATORFILE, info2->sepfile);
-        map_dword_into_ctr(ctr, SPOOL_REG_PRINTSTARTTIME, info2->starttime);
-        map_dword_into_ctr(ctr, SPOOL_REG_PRINTENDTIME, info2->untiltime);
-        map_dword_into_ctr(ctr, SPOOL_REG_PRIORITY, info2->priority);
-
-        map_bool_into_ctr(ctr, SPOOL_REG_PRINTKEEPPRINTEDJOBS,
-                          (info2->attributes &
-                           PRINTER_ATTRIBUTE_KEEPPRINTEDJOBS));
-
-        switch (info2->attributes & 0x3) {
-        case 0:
-                ascii_str = SPOOL_REGVAL_PRINTWHILESPOOLING;
-                break;
-        case 1:
-                ascii_str = SPOOL_REGVAL_PRINTAFTERSPOOLED;
-                break;
-        case 2:
-                ascii_str = SPOOL_REGVAL_PRINTDIRECT;
-                break;
-        default:
-                ascii_str = "unknown";
-        }
-        map_sz_into_ctr(ctr, SPOOL_REG_PRINTSPOOLING, ascii_str);
-
-        return True;
-}
-
-/*****************************************************************
- ****************************************************************/
-
-static void store_printer_guid(NT_PRINTER_INFO_LEVEL_2 *info2,
-                               struct GUID guid)
-{
-        int i;
-        struct regval_ctr *ctr=NULL;
-
-        /* find the DsSpooler key */
-        if ((i = lookup_printerkey(info2->data, SPOOL_DSSPOOLER_KEY)) < 0)
-                i = add_new_printer_key(info2->data, SPOOL_DSSPOOLER_KEY);
-        ctr = info2->data->keys[i].values;
-
-        regval_ctr_delvalue(ctr, "objectGUID");
-
-        /* We used to store this as a REG_BINARY but that causes
-           Vista to whine */
-
-        regval_ctr_addvalue_sz(ctr, "objectGUID",
-                               GUID_string(talloc_tos(), &guid));
-}
-
-static WERROR nt_printer_publish_ads(ADS_STRUCT *ads,
-                                     NT_PRINTER_INFO_LEVEL *printer)
-{
-        ADS_STATUS ads_rc;
-        LDAPMessage *res;
-        char *prt_dn = NULL, *srv_dn, *srv_cn_0, *srv_cn_escaped, *sharename_escaped;
-        char *srv_dn_utf8, **srv_cn_utf8;
-        TALLOC_CTX *ctx;
-        ADS_MODLIST mods;
-        const char *attrs[] = {"objectGUID", NULL};
-        struct GUID guid;
-        WERROR win_rc = WERR_OK;
-        size_t converted_size;
-
-        /* build the ads mods */
-        ctx = talloc_init("nt_printer_publish_ads");
-        if (ctx == NULL) {
-                return WERR_NOMEM;
-        }
-
-        DEBUG(5, ("publishing printer %s\n", printer->info_2->printername));
-
-        /* figure out where to publish */
-        ads_find_machine_acct(ads, &res, global_myname());
-
-        /* We use ldap_get_dn here as we need the answer
-         * in utf8 to call ldap_explode_dn(). JRA. */
-
-        srv_dn_utf8 = ldap_get_dn((LDAP *)ads->ldap.ld, (LDAPMessage *)res);
-        if (!srv_dn_utf8) {
-                TALLOC_FREE(ctx);
-                return WERR_SERVER_UNAVAILABLE;
-        }
-        ads_msgfree(ads, res);
-        srv_cn_utf8 = ldap_explode_dn(srv_dn_utf8, 1);
-        if (!srv_cn_utf8) {
-                TALLOC_FREE(ctx);
-                ldap_memfree(srv_dn_utf8);
-                return WERR_SERVER_UNAVAILABLE;
-        }
-        /* Now convert to CH_UNIX. */
-        if (!pull_utf8_talloc(ctx, &srv_dn, srv_dn_utf8, &converted_size)) {
-                TALLOC_FREE(ctx);
-                ldap_memfree(srv_dn_utf8);
-                ldap_memfree(srv_cn_utf8);
-                return WERR_SERVER_UNAVAILABLE;
-        }
-        if (!pull_utf8_talloc(ctx, &srv_cn_0, srv_cn_utf8[0], &converted_size)) {
-                TALLOC_FREE(ctx);
-                ldap_memfree(srv_dn_utf8);
-                ldap_memfree(srv_cn_utf8);
-                TALLOC_FREE(srv_dn);
-                return WERR_SERVER_UNAVAILABLE;
-        }
-
-        ldap_memfree(srv_dn_utf8);
-        ldap_memfree(srv_cn_utf8);
-
-        srv_cn_escaped = escape_rdn_val_string_alloc(srv_cn_0);
-        if (!srv_cn_escaped) {
-                TALLOC_FREE(ctx);
-                return WERR_SERVER_UNAVAILABLE;
-        }
-        sharename_escaped = escape_rdn_val_string_alloc(printer->info_2->sharename);
-        if (!sharename_escaped) {
-                SAFE_FREE(srv_cn_escaped);
-                TALLOC_FREE(ctx);
-                return WERR_SERVER_UNAVAILABLE;
-        }
-
-        prt_dn = talloc_asprintf(ctx, "cn=%s-%s,%s", srv_cn_escaped, sharename_escaped, srv_dn);
-
-        SAFE_FREE(srv_cn_escaped);
-        SAFE_FREE(sharename_escaped);
-
-        mods = ads_init_mods(ctx);
-
-        if (mods == NULL) {
-                SAFE_FREE(prt_dn);
-                TALLOC_FREE(ctx);
-                return WERR_NOMEM;
-        }
-
-        get_local_printer_publishing_data(ctx, &mods, printer->info_2->data);
-        ads_mod_str(ctx, &mods, SPOOL_REG_PRINTERNAME,
-                    printer->info_2->sharename);
-
-        /* publish it */
-        ads_rc = ads_mod_printer_entry(ads, prt_dn, ctx, &mods);
-        if (ads_rc.err.rc == LDAP_NO_SUCH_OBJECT) {
-                int i;
-                for (i=0; mods[i] != 0; i++)
-                        ;
-                mods[i] = (LDAPMod *)-1;
-                ads_rc = ads_add_printer_entry(ads, prt_dn, ctx, &mods);
-        }
-
-        if (!ADS_ERR_OK(ads_rc))
-                DEBUG(3, ("error publishing %s: %s\n", printer->info_2->sharename, ads_errstr(ads_rc)));
-
-        /* retreive the guid and store it locally */
-        if (ADS_ERR_OK(ads_search_dn(ads, &res, prt_dn, attrs))) {
-                ZERO_STRUCT(guid);
-                ads_pull_guid(ads, res, &guid);
-                ads_msgfree(ads, res);
-                store_printer_guid(printer->info_2, guid);
-                win_rc = mod_a_printer(printer, 2);
-        }
-        TALLOC_FREE(ctx);
-
-        return win_rc;
-}
-
-static WERROR nt_printer_unpublish_ads(ADS_STRUCT *ads,
-                                       NT_PRINTER_INFO_LEVEL *printer)
-{
-        ADS_STATUS ads_rc;
-        LDAPMessage *res = NULL;
-        char *prt_dn = NULL;
-
-        DEBUG(5, ("unpublishing printer %s\n", printer->info_2->printername));
-
-        /* remove the printer from the directory */
-        ads_rc = ads_find_printer_on_server(ads, &res,
-                            printer->info_2->sharename, global_myname());
-
-        if (ADS_ERR_OK(ads_rc) && res && ads_count_replies(ads, res)) {
-                prt_dn = ads_get_dn(ads, talloc_tos(), res);
-                if (!prt_dn) {
-                        ads_msgfree(ads, res);
-                        return WERR_NOMEM;
-                }
-                ads_rc = ads_del_dn(ads, prt_dn);
-                TALLOC_FREE(prt_dn);
-        }
-
-        if (res) {
-                ads_msgfree(ads, res);
-        }
-        return WERR_OK;
-}
-
-/****************************************************************************
- * Publish a printer in the directory
- *
- * @param snum describing printer service
- * @return WERROR indicating status of publishing
- ***************************************************************************/
-
-WERROR nt_printer_publish(Printer_entry *print_hnd, int snum, int action)
-{
-        ADS_STATUS ads_rc;
-        ADS_STRUCT *ads = NULL;
-        NT_PRINTER_INFO_LEVEL *printer = NULL;
-        WERROR win_rc;
-
-        win_rc = get_a_printer(print_hnd, &printer, 2, lp_servicename(snum));
-        if (!W_ERROR_IS_OK(win_rc))
-                goto done;
-
-        switch (action) {
-        case DSPRINT_PUBLISH:
-        case DSPRINT_UPDATE:
-                /* set the DsSpooler info and attributes */
-                if (!(map_nt_printer_info2_to_dsspooler(printer->info_2))) {
-                        win_rc = WERR_NOMEM;
-                        goto done;
-                }
-
-                printer->info_2->attributes |= PRINTER_ATTRIBUTE_PUBLISHED;
-                break;
-        case DSPRINT_UNPUBLISH:
-                printer->info_2->attributes ^= PRINTER_ATTRIBUTE_PUBLISHED;
-                break;
-        default:
-                win_rc = WERR_NOT_SUPPORTED;
-                goto done;
-        }
-
-        win_rc = mod_a_printer(printer, 2);
-        if (!W_ERROR_IS_OK(win_rc)) {
-                DEBUG(3, ("err %d saving data\n", W_ERROR_V(win_rc)));
-                goto done;
-        }
-
-        ads = ads_init(lp_realm(), lp_workgroup(), NULL);
-        if (!ads) {
-                DEBUG(3, ("ads_init() failed\n"));
-                win_rc = WERR_SERVER_UNAVAILABLE;
-                goto done;
-        }
-        setenv(KRB5_ENV_CCNAME, "MEMORY:prtpub_cache", 1);
-        SAFE_FREE(ads->auth.password);
-        ads->auth.password = secrets_fetch_machine_password(lp_workgroup(),
-                NULL, NULL);
-
-        /* ads_connect() will find the DC for us */
-        ads_rc = ads_connect(ads);
-        if (!ADS_ERR_OK(ads_rc)) {
-                DEBUG(3, ("ads_connect failed: %s\n", ads_errstr(ads_rc)));
-                win_rc = WERR_ACCESS_DENIED;
-                goto done;
-        }
-
-        switch (action) {
-        case DSPRINT_PUBLISH:
-        case DSPRINT_UPDATE:
-                win_rc = nt_printer_publish_ads(ads, printer);
-                break;
-        case DSPRINT_UNPUBLISH:
-                win_rc = nt_printer_unpublish_ads(ads, printer);
-                break;
-        }
-
-done:
-        free_a_printer(&printer, 2);
-        ads_destroy(&ads);
-        return win_rc;
-}
-
-WERROR check_published_printers(void)
-{
-        ADS_STATUS ads_rc;
-        ADS_STRUCT *ads = NULL;
-        int snum;
-        int n_services = lp_numservices();
-        NT_PRINTER_INFO_LEVEL *printer = NULL;
-
-        ads = ads_init(lp_realm(), lp_workgroup(), NULL);
-        if (!ads) {
-                DEBUG(3, ("ads_init() failed\n"));
-                return WERR_SERVER_UNAVAILABLE;
-        }
-        setenv(KRB5_ENV_CCNAME, "MEMORY:prtpub_cache", 1);
-        SAFE_FREE(ads->auth.password);
-        ads->auth.password = secrets_fetch_machine_password(lp_workgroup(),
-                NULL, NULL);
-
-        /* ads_connect() will find the DC for us */
-        ads_rc = ads_connect(ads);
-        if (!ADS_ERR_OK(ads_rc)) {
-                DEBUG(3, ("ads_connect failed: %s\n", ads_errstr(ads_rc)));
-                ads_destroy(&ads);
-                ads_kdestroy("MEMORY:prtpub_cache");
-                return WERR_ACCESS_DENIED;
-        }
-
-        for (snum = 0; snum < n_services; snum++) {
-                if (!(lp_snum_ok(snum) && lp_print_ok(snum)))
-                        continue;
-
-                if (W_ERROR_IS_OK(get_a_printer(NULL, &printer, 2,
-                                                lp_servicename(snum))) &&
-                    (printer->info_2->attributes & PRINTER_ATTRIBUTE_PUBLISHED))
-                        nt_printer_publish_ads(ads, printer);
-
-                free_a_printer(&printer, 2);
-        }
-
-        ads_destroy(&ads);
-        ads_kdestroy("MEMORY:prtpub_cache");
-        return WERR_OK;
-}
-
-bool is_printer_published(Printer_entry *print_hnd, int snum,
-                          struct GUID *guid)
-{
-        NT_PRINTER_INFO_LEVEL *printer = NULL;
-        struct regval_ctr *ctr;
-        struct regval_blob *guid_val;
-        WERROR win_rc;
-        int i;
-        bool ret = False;
-        DATA_BLOB blob;
-
-        win_rc = get_a_printer(print_hnd, &printer, 2, lp_servicename(snum));
-
-        if (!W_ERROR_IS_OK(win_rc) ||
-            !(printer->info_2->attributes & PRINTER_ATTRIBUTE_PUBLISHED) ||
-            ((i = lookup_printerkey(printer->info_2->data, SPOOL_DSSPOOLER_KEY)) < 0) ||
-            !(ctr = printer->info_2->data->keys[i].values) ||
-            !(guid_val = regval_ctr_getvalue(ctr, "objectGUID")))
-        {
-                free_a_printer(&printer, 2);
-                return False;
-        }
-
-        /* fetching printer guids really ought to be a separate function. */
-
-        if ( guid ) {
-                char *guid_str;
-
-                /* We used to store the guid as REG_BINARY, then swapped
-                   to REG_SZ for Vista compatibility so check for both */
-
-                switch ( regval_type(guid_val) ){
-                case REG_SZ:
-                        blob = data_blob_const(regval_data_p(guid_val),
-                                               regval_size(guid_val));
-                        pull_reg_sz(talloc_tos(), &blob, (const char **)&guid_str);
-                        ret = NT_STATUS_IS_OK(GUID_from_string( guid_str, guid ));
-                        talloc_free(guid_str);
-                        break;
-                case REG_BINARY:
-                        if ( regval_size(guid_val) != sizeof(struct GUID) ) {
-                                ret = False;
-                                break;
-                        }
-                        memcpy(guid, regval_data_p(guid_val), sizeof(struct GUID));
-                        break;
-                default:
-                        DEBUG(0,("is_printer_published: GUID value stored as "
-                                 "invaluid type (%d)\n", regval_type(guid_val) ));
-                        break;
-                }
-        }
-
-        free_a_printer(&printer, 2);
-        return ret;
-}
-#else
-WERROR nt_printer_publish(Printer_entry *print_hnd, int snum, int action)
-{
-        return WERR_OK;
-}
-
-WERROR check_published_printers(void)
-{
-        return WERR_OK;
-}
-
-bool is_printer_published(Printer_entry *print_hnd, int snum,
-                          struct GUID *guid)
-{
-        return False;
-}
-#endif /* HAVE_ADS */
-
-/****************************************************************************
- ***************************************************************************/
-
-WERROR delete_all_printer_data( NT_PRINTER_INFO_LEVEL_2 *p2, const char *key )
-{
-        NT_PRINTER_DATA *data;
-        int             i;
-        int             removed_keys = 0;
-        int             empty_slot;
-
-        data = p2->data;
-        empty_slot = data->num_keys;
-
-        if ( !key )
-                return WERR_INVALID_PARAM;
-
-        /* remove all keys */
-
-        if ( !strlen(key) ) {
-
-                TALLOC_FREE( data );
-
-                p2->data = NULL;
-
-                DEBUG(8,("delete_all_printer_data: Removed all Printer Data from printer [%s]\n",
-                        p2->printername ));
-
-                return WERR_OK;
-        }
-
-        /* remove a specific key (and all subkeys) */
-
-        for ( i=0; i<data->num_keys; i++ ) {
-                if ( StrnCaseCmp( data->keys[i].name, key, strlen(key)) == 0 ) {
-                        DEBUG(8,("delete_all_printer_data: Removed all Printer Data from key [%s]\n",
-                                data->keys[i].name));
-
-                        TALLOC_FREE( data->keys[i].name );
-                        TALLOC_FREE( data->keys[i].values );
-
-                        /* mark the slot as empty */
-
-                        ZERO_STRUCTP( &data->keys[i] );
-                }
-        }
-
-        /* find the first empty slot */
-
-        for ( i=0; i<data->num_keys; i++ ) {
-                if ( !data->keys[i].name ) {
-                        empty_slot = i;
-                        removed_keys++;
-                        break;
-                }
-        }
-
-        if ( i == data->num_keys )
-                /* nothing was removed */
-                return WERR_INVALID_PARAM;
-
-        /* move everything down */
-
-        for ( i=empty_slot+1; i<data->num_keys; i++ ) {
-                if ( data->keys[i].name ) {
-                        memcpy( &data->keys[empty_slot], &data->keys[i], sizeof(NT_PRINTER_KEY) );
-                        ZERO_STRUCTP( &data->keys[i] );
-                        empty_slot++;
-                        removed_keys++;
-                }
-        }
-
-        /* update count */
-
-        data->num_keys -= removed_keys;
-
-        /* sanity check to see if anything is left */
-
-        if ( !data->num_keys ) {
-                DEBUG(8,("delete_all_printer_data: No keys left for printer [%s]\n", p2->printername ));
-
-                SAFE_FREE( data->keys );
-                ZERO_STRUCTP( data );
-        }
-
-        return WERR_OK;
-}
-
-/****************************************************************************
- ***************************************************************************/
-
-WERROR delete_printer_data( NT_PRINTER_INFO_LEVEL_2 *p2, const char *key, const char *value )
-{
-        WERROR          result = WERR_OK;
-        int             key_index;
-
-        /* we must have names on non-zero length */
-
-        if ( !key || !*key|| !value || !*value )
-                return WERR_INVALID_NAME;
-
-        /* find the printer key first */
-
-        key_index = lookup_printerkey( p2->data, key );
-        if ( key_index == -1 )
-                return WERR_OK;
-
-        /* make sure the value exists so we can return the correct error code */
-
-        if ( !regval_ctr_getvalue( p2->data->keys[key_index].values, value ) )
-                return WERR_BADFILE;
-
-        regval_ctr_delvalue( p2->data->keys[key_index].values, value );
-
-        DEBUG(8,("delete_printer_data: Removed key => [%s], value => [%s]\n",
-                key, value ));
-
-        return result;
-}
-
-/****************************************************************************
- ***************************************************************************/
-
-WERROR add_printer_data( NT_PRINTER_INFO_LEVEL_2 *p2, const char *key, const char *value,
-                           uint32 type, uint8 *data, int real_len )
-{
-        WERROR          result = WERR_OK;
-        int             key_index;
-
-        /* we must have names on non-zero length */
-
-        if ( !key || !*key|| !value || !*value )
-                return WERR_INVALID_NAME;
-
-        /* find the printer key first */
-
-        key_index = lookup_printerkey( p2->data, key );
-        if ( key_index == -1 )
-                key_index = add_new_printer_key( p2->data, key );
-
-        if ( key_index == -1 )
-                return WERR_NOMEM;
-
-        regval_ctr_addvalue( p2->data->keys[key_index].values, value,
-                type, (const char *)data, real_len );
-
-        DEBUG(8,("add_printer_data: Added key => [%s], value => [%s], type=> [%d], size => [%d]\n",
-                key, value, type, real_len  ));
-
-        return result;
-}
-
-/****************************************************************************
- ***************************************************************************/
-
-struct regval_blob* get_printer_data( NT_PRINTER_INFO_LEVEL_2 *p2, const char *key, const char *value )
-{
-        int             key_index;
-
-        if ( (key_index = lookup_printerkey( p2->data, key )) == -1 )
-                return NULL;
-
-        DEBUG(8,("get_printer_data: Attempting to lookup key => [%s], value => [%s]\n",
-                key, value ));
-
-        return regval_ctr_getvalue( p2->data->keys[key_index].values, value );
-}
-
-/****************************************************************************
- Unpack a list of registry values frem the TDB
- ***************************************************************************/
-
-static int unpack_values(NT_PRINTER_DATA *printer_data, const uint8 *buf, int buflen)
-{
-        int             len = 0;
-        uint32          type;
-        fstring string;
-        const char *valuename = NULL;
-        const char *keyname = NULL;
-        char            *str;
-        int             size;
-        uint8           *data_p;
-        struct regval_blob      *regval_p;
-        int             key_index;
-
-        /* add the "PrinterDriverData" key first for performance reasons */
-
-        add_new_printer_key( printer_data, SPOOL_PRINTERDATA_KEY );
-
-        /* loop and unpack the rest of the registry values */
-
-        while ( True ) {
-
-                /* check to see if there are any more registry values */
-
-                regval_p = NULL;
-                len += tdb_unpack(buf+len, buflen-len, "p", &regval_p);
-                if ( !regval_p )
-                        break;
-
-                /* unpack the next regval */
-
-                len += tdb_unpack(buf+len, buflen-len, "fdB",
-                                  string,
-                                  &type,
-                                  &size,
-                                  &data_p);
-
-                /* lookup for subkey names which have a type of REG_NONE */
-                /* there's no data with this entry */
-
-                if ( type == REG_NONE ) {
-                        if ( (key_index=lookup_printerkey( printer_data, string)) == -1 )
-                                add_new_printer_key( printer_data, string );
-                        continue;
-                }
-
-                /*
-                 * break of the keyname from the value name.
-                 * Valuenames can have embedded '\'s so be careful.
-                 * only support one level of keys.  See the
-                 * "Konica Fiery S300 50C-K v1.1. enu" 2k driver.
-                 * -- jerry
-                 */
-
-                str = strchr_m( string, '\\');
-
-                /* Put in "PrinterDriverData" is no key specified */
-
-                if ( !str ) {
-                        keyname = SPOOL_PRINTERDATA_KEY;
-                        valuename = string;
-                }
-                else {
-                        *str = '\0';
-                        keyname = string;
-                        valuename = str+1;
-                }
-
-                /* see if we need a new key */
-
-                if ( (key_index=lookup_printerkey( printer_data, keyname )) == -1 )
-                        key_index = add_new_printer_key( printer_data, keyname );
-
-                if ( key_index == -1 ) {
-                        DEBUG(0,("unpack_values: Failed to allocate a new key [%s]!\n",
-                                keyname));
-                        break;
-                }
-
-                DEBUG(8,("specific: [%s:%s], len: %d\n", keyname, valuename, size));
-
-                /* Vista doesn't like unknown REG_BINARY values in DsSpooler.
-                   Thanks to Martin Zielinski for the hint. */
-
-                if ( type == REG_BINARY &&
-                     strequal( keyname, SPOOL_DSSPOOLER_KEY ) &&
-                     strequal( valuename, "objectGUID" ) )
-                {
-                        struct GUID guid;
-
-                        /* convert the GUID to a UNICODE string */
-
-                        memcpy( &guid, data_p, sizeof(struct GUID) );
-
-                        regval_ctr_addvalue_sz(printer_data->keys[key_index].values,
-                                               valuename,
-                                               GUID_string(talloc_tos(), &guid));
-
-                } else {
-                        /* add the value */
-
-                        regval_ctr_addvalue( printer_data->keys[key_index].values,
-                                             valuename, type, (const char *)data_p,
-                                             size );
-                }
-
-                SAFE_FREE(data_p); /* 'B' option to tdbpack does a malloc() */
-
-        }
-
-        return len;
-}
-
-/****************************************************************************
- ***************************************************************************/
-
-static char *last_from;
-static char *last_to;
-
-static const char *get_last_from(void)
-{
-        if (!last_from) {
-                return "";
-        }
-        return last_from;
-}
-
-static const char *get_last_to(void)
-{
-        if (!last_to) {
-                return "";
-        }
-        return last_to;
-}
-
-static bool set_last_from_to(const char *from, const char *to)
-{
-        char *orig_from = last_from;
-        char *orig_to = last_to;
-
-        last_from = SMB_STRDUP(from);
-        last_to = SMB_STRDUP(to);
-
-        SAFE_FREE(orig_from);
-        SAFE_FREE(orig_to);
-
-        if (!last_from || !last_to) {
-                SAFE_FREE(last_from);
-                SAFE_FREE(last_to);
-                return false;
-        }
-        return true;
-}
-
-static void map_to_os2_driver(fstring drivername)
-{
-        char *mapfile = lp_os2_driver_map();
-        char **lines = NULL;
-        int numlines = 0;
-        int i;
-
-        if (!strlen(drivername))
-                return;
-
-        if (!*mapfile)
-                return;
-
-        if (strequal(drivername,get_last_from())) {
-                DEBUG(3,("Mapped Windows driver %s to OS/2 driver %s\n",
-                        drivername,get_last_to()));
-                fstrcpy(drivername,get_last_to());
-                return;
-        }
-
-        lines = file_lines_load(mapfile, &numlines,0,NULL);
-        if (numlines == 0 || lines == NULL) {
-                DEBUG(0,("No entries in OS/2 driver map %s\n",mapfile));
-                TALLOC_FREE(lines);
-                return;
-        }
-
-        DEBUG(4,("Scanning OS/2 driver map %s\n",mapfile));
-
-        for( i = 0; i < numlines; i++) {
-                char *nt_name = lines[i];
-                char *os2_name = strchr(nt_name,'=');
-
-                if (!os2_name)
-                        continue;
-
-                *os2_name++ = 0;
-
-                while (isspace(*nt_name))
-                        nt_name++;
-
-                if (!*nt_name || strchr("#;",*nt_name))
-                        continue;
-
-                {
-                        int l = strlen(nt_name);
-                        while (l && isspace(nt_name[l-1])) {
-                                nt_name[l-1] = 0;
-                                l--;
-                        }
-                }
-
-                while (isspace(*os2_name))
-                        os2_name++;
-
-                {
-                        int l = strlen(os2_name);
-                        while (l && isspace(os2_name[l-1])) {
-                                os2_name[l-1] = 0;
-                                l--;
-                        }
-                }
-
-                if (strequal(nt_name,drivername)) {
-                        DEBUG(3,("Mapped windows driver %s to os2 driver%s\n",drivername,os2_name));
-                        set_last_from_to(drivername,os2_name);
-                        fstrcpy(drivername,os2_name);
-                        TALLOC_FREE(lines);
-                        return;
-                }
-        }
-
-        TALLOC_FREE(lines);
-}
-
-/****************************************************************************
- Get a default printer info 2 struct.
-****************************************************************************/
-
-static WERROR get_a_printer_2_default(NT_PRINTER_INFO_LEVEL_2 *info,
-                                const char *servername,
-                                const char* sharename,
-                                bool get_loc_com)
-{
-        int snum = lp_servicenumber(sharename);
-
-        slprintf(info->servername, sizeof(info->servername)-1, "\\\\%s", servername);
-        slprintf(info->printername, sizeof(info->printername)-1, "\\\\%s\\%s",
-                servername, sharename);
-        fstrcpy(info->sharename, sharename);
-        fstrcpy(info->portname, SAMBA_PRINTER_PORT_NAME);
-
-        /* by setting the driver name to an empty string, a local NT admin
-           can now run the **local** APW to install a local printer driver
-           for a Samba shared printer in 2.2.  Without this, drivers **must** be
-           installed on the Samba server for NT clients --jerry */
-#if 0   /* JERRY --do not uncomment-- */
-        if (!*info->drivername)
-                fstrcpy(info->drivername, "NO DRIVER AVAILABLE FOR THIS PRINTER");
-#endif
-
-
-        DEBUG(10,("get_a_printer_2_default: driver name set to [%s]\n", info->drivername));
-
-        strlcpy(info->comment, "", sizeof(info->comment));
-        fstrcpy(info->printprocessor, "winprint");
-        fstrcpy(info->datatype, "RAW");
-
-#ifdef HAVE_CUPS
-        if (get_loc_com && (enum printing_types)lp_printing(snum) == PRINT_CUPS ) {
-                /* Pull the location and comment strings from cups if we don't
-                   already have one */
-                if ( !strlen(info->location) || !strlen(info->comment) )
-                        cups_pull_comment_location( info );
-        }
-#endif
-
-        info->attributes = PRINTER_ATTRIBUTE_SAMBA;
-
-        info->starttime = 0; /* Minutes since 12:00am GMT */
-        info->untiltime = 0; /* Minutes since 12:00am GMT */
-        info->priority = 1;
-        info->default_priority = 1;
-        info->setuptime = (uint32)time(NULL);
-
-        /*
-         * I changed this as I think it is better to have a generic
-         * DEVMODE than to crash Win2k explorer.exe   --jerry
-         * See the HP Deskjet 990c Win2k drivers for an example.
-         *
-         * However the default devmode appears to cause problems
-         * with the HP CLJ 8500 PCL driver.  Hence the addition of
-         * the "default devmode" parameter   --jerry 22/01/2002
-         */
-
-        if (lp_default_devmode(snum)) {
-                if ((info->devmode = construct_nt_devicemode(info->printername)) == NULL) {
-                        goto fail;
-                }
-        } else {
-                info->devmode = NULL;
-        }
-
-        if (!nt_printing_getsec(info, sharename, &info->secdesc_buf)) {
-                goto fail;
-        }
-
-        info->data = TALLOC_ZERO_P(info, NT_PRINTER_DATA);
-        if (!info->data) {
-                goto fail;
-        }
-
-        add_new_printer_key(info->data, SPOOL_PRINTERDATA_KEY);
-
-        return WERR_OK;
-
-fail:
-        if (info->devmode)
-                free_nt_devicemode(&info->devmode);
-
-        return WERR_ACCESS_DENIED;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-static WERROR get_a_printer_2(NT_PRINTER_INFO_LEVEL_2 *info,
-                                const char *servername,
-                                const char *sharename,
-                                bool get_loc_com)
-{
-        int len = 0;
-        int snum = lp_servicenumber(sharename);
-        TDB_DATA kbuf, dbuf;
-        fstring printername;
-        char adevice[MAXDEVICENAME];
-        char *comment = NULL;
-
-        kbuf = make_printer_tdbkey(talloc_tos(), sharename);
-
-        dbuf = tdb_fetch(tdb_printers, kbuf);
-        if (!dbuf.dptr) {
-                return get_a_printer_2_default(info, servername,
-                                        sharename, get_loc_com);
-        }
-
-        len += tdb_unpack(dbuf.dptr+len, dbuf.dsize-len, "dddddddddddfffffPfffff",
-                        &info->attributes,
-                        &info->priority,
-                        &info->default_priority,
-                        &info->starttime,
-                        &info->untiltime,
-                        &info->status,
-                        &info->cjobs,
-                        &info->averageppm,
-                        &info->changeid,
-                        &info->c_setprinter,
-                        &info->setuptime,
-                        info->servername,
-                        info->printername,
-                        info->sharename,
-                        info->portname,
-                        info->drivername,
-                        &comment,
-                        info->location,
-                        info->sepfile,
-                        info->printprocessor,
-                        info->datatype,
-                        info->parameters);
-
-        if (comment) {
-                strlcpy(info->comment, comment, sizeof(info->comment));
-                SAFE_FREE(comment);
-        }
-
-        /* Samba has to have shared raw drivers. */
-        info->attributes |= PRINTER_ATTRIBUTE_SAMBA;
-        info->attributes &= ~PRINTER_ATTRIBUTE_NOT_SAMBA;
-
-        /* Restore the stripped strings. */
-        slprintf(info->servername, sizeof(info->servername)-1, "\\\\%s", servername);
-
-        if ( lp_force_printername(snum) ) {
-                slprintf(printername, sizeof(printername)-1, "\\\\%s\\%s", servername, sharename );
-        } else {
-                slprintf(printername, sizeof(printername)-1, "\\\\%s\\%s", servername, info->printername);
-        }
-
-        fstrcpy(info->printername, printername);
-
-#ifdef HAVE_CUPS
-        if (get_loc_com && (enum printing_types)lp_printing(snum) == PRINT_CUPS ) {
-                /* Pull the location and comment strings from cups if we don't
-                   already have one */
-                if ( !strlen(info->location) || !strlen(info->comment) )
-                        cups_pull_comment_location( info );
-        }
-#endif
-
-        len += unpack_devicemode(&info->devmode,dbuf.dptr+len, dbuf.dsize-len);
-
-        /*
-         * Some client drivers freak out if there is a NULL devmode
-         * (probably the driver is not checking before accessing
-         * the devmode pointer)   --jerry
-         *
-         * See comments in get_a_printer_2_default()
-         */
-
-        if (lp_default_devmode(snum) && !info->devmode) {
-                DEBUG(8,("get_a_printer_2: Constructing a default device mode for [%s]\n",
-                        printername));
-                info->devmode = construct_nt_devicemode(printername);
-        }
-
-        slprintf( adevice, sizeof(adevice), "%s", info->printername );
-        if (info->devmode) {
-                fstrcpy(info->devmode->devicename, adevice);
-        }
-
-        if ( !(info->data = TALLOC_ZERO_P( info, NT_PRINTER_DATA )) ) {
-                DEBUG(0,("unpack_values: talloc() failed!\n"));
-                SAFE_FREE(dbuf.dptr);
-                return WERR_NOMEM;
-        }
-        len += unpack_values( info->data, dbuf.dptr+len, dbuf.dsize-len );
-
-        /* This will get the current RPC talloc context, but we should be
-           passing this as a parameter... fixme... JRA ! */
-
-        if (!nt_printing_getsec(info, sharename, &info->secdesc_buf)) {
-                SAFE_FREE(dbuf.dptr);
-                return WERR_NOMEM;
-        }
-
-        /* Fix for OS/2 drivers. */
-
-        if (get_remote_arch() == RA_OS2) {
-                map_to_os2_driver(info->drivername);
-        }
-
-        SAFE_FREE(dbuf.dptr);
-
-        DEBUG(9,("Unpacked printer [%s] name [%s] running driver [%s]\n",
-                 sharename, info->printername, info->drivername));
-
-        return WERR_OK;
-}
-
-/****************************************************************************
- Debugging function, dump at level 6 the struct in the logs.
-****************************************************************************/
-static uint32 dump_a_printer(NT_PRINTER_INFO_LEVEL *printer, uint32 level)
-{
-        uint32 result;
-        NT_PRINTER_INFO_LEVEL_2 *info2;
-
-        DEBUG(106,("Dumping printer at level [%d]\n", level));
-
-        switch (level) {
-                case 2:
-                {
-                        if (printer->info_2 == NULL)
-                                result=5;
-                        else
-                        {
-                                info2=printer->info_2;
-
-                                DEBUGADD(106,("attributes:[%d]\n", info2->attributes));
-                                DEBUGADD(106,("priority:[%d]\n", info2->priority));
-                                DEBUGADD(106,("default_priority:[%d]\n", info2->default_priority));
-                                DEBUGADD(106,("starttime:[%d]\n", info2->starttime));
-                                DEBUGADD(106,("untiltime:[%d]\n", info2->untiltime));
-                                DEBUGADD(106,("status:[%d]\n", info2->status));
-                                DEBUGADD(106,("cjobs:[%d]\n", info2->cjobs));
-                                DEBUGADD(106,("averageppm:[%d]\n", info2->averageppm));
-                                DEBUGADD(106,("changeid:[%d]\n", info2->changeid));
-                                DEBUGADD(106,("c_setprinter:[%d]\n", info2->c_setprinter));
-                                DEBUGADD(106,("setuptime:[%d]\n", info2->setuptime));
-
-                                DEBUGADD(106,("servername:[%s]\n", info2->servername));
-                                DEBUGADD(106,("printername:[%s]\n", info2->printername));
-                                DEBUGADD(106,("sharename:[%s]\n", info2->sharename));
-                                DEBUGADD(106,("portname:[%s]\n", info2->portname));
-                                DEBUGADD(106,("drivername:[%s]\n", info2->drivername));
-                                DEBUGADD(106,("comment:[%s]\n", info2->comment));
-                                DEBUGADD(106,("location:[%s]\n", info2->location));
-                                DEBUGADD(106,("sepfile:[%s]\n", info2->sepfile));
-                                DEBUGADD(106,("printprocessor:[%s]\n", info2->printprocessor));
-                                DEBUGADD(106,("datatype:[%s]\n", info2->datatype));
-                                DEBUGADD(106,("parameters:[%s]\n", info2->parameters));
-                                result=0;
-                        }
-                        break;
-                }
-                default:
-                        DEBUGADD(106,("dump_a_printer: Level %u not implemented\n", (unsigned int)level ));
-                        result=1;
-                        break;
-        }
-
-        return result;
-}
-
-/****************************************************************************
- Update the changeid time.
- This is SO NASTY as some drivers need this to change, others need it
- static. This value will change every second, and I must hope that this
- is enough..... DON'T CHANGE THIS CODE WITHOUT A TEST MATRIX THE SIZE OF
- UTAH ! JRA.
-****************************************************************************/
-
-static uint32 rev_changeid(void)
-{
-        struct timeval tv;
-
-        get_process_uptime(&tv);
-
-#if 1   /* JERRY */
-        /* Return changeid as msec since spooler restart */
-        return tv.tv_sec * 1000 + tv.tv_usec / 1000;
-#else
-        /*
-         * This setting seems to work well but is too untested
-         * to replace the above calculation.  Left in for experiementation
-         * of the reader            --jerry (Tue Mar 12 09:15:05 CST 2002)
-         */
-        return tv.tv_sec * 10 + tv.tv_usec / 100000;
-#endif
-}
-
-
-/*
- * The function below are the high level ones.
- * only those ones must be called from the spoolss code.
- * JFM.
- */
-
-/****************************************************************************
- Modify a printer. This is called from SETPRINTERDATA/DELETEPRINTERDATA.
-****************************************************************************/
-
-WERROR mod_a_printer(NT_PRINTER_INFO_LEVEL *printer, uint32 level)
-{
-        WERROR result;
-
-        dump_a_printer(printer, level);
-
-        switch (level) {
-                case 2:
-                {
-                        /*
-                         * Update the changestamp.  Emperical tests show that the
-                         * ChangeID is always updated,but c_setprinter is
-                         *  global spooler variable (not per printer).
-                         */
-
-                        /* ChangeID **must** be increasing over the lifetime
-                           of client's spoolss service in order for the
-                           client's cache to show updates */
-
-                        printer->info_2->changeid = rev_changeid();
-
-                        /*
-                         * Because one day someone will ask:
-                         * NT->NT       An admin connection to a remote
-                         *              printer show changes imeediately in
-                         *              the properities dialog
-                         *
-                         *              A non-admin connection will only show the
-                         *              changes after viewing the properites page
-                         *              2 times.  Seems to be related to a
-                         *              race condition in the client between the spooler
-                         *              updating the local cache and the Explorer.exe GUI
-                         *              actually displaying the properties.
-                         *
-                         *              This is fixed in Win2k.  admin/non-admin
-                         *              connections both display changes immediately.
-                         *
-                         * 14/12/01     --jerry
-                         */
-
-                        result=update_a_printer_2(printer->info_2);
-                        break;
-                }
-                default:
-                        result=WERR_UNKNOWN_LEVEL;
-                        break;
-        }
-
-        return result;
-}
-
-/****************************************************************************
- Initialize printer devmode & data with previously saved driver init values.
-****************************************************************************/
-
-static bool set_driver_init_2( NT_PRINTER_INFO_LEVEL_2 *info_ptr )
-{
-        int                     len = 0;
-        char *key = NULL;
-        TDB_DATA                dbuf;
-        NT_PRINTER_INFO_LEVEL_2 info;
-
-
-        ZERO_STRUCT(info);
-
-        /*
-         * Delete any printer data 'values' already set. When called for driver
-         * replace, there will generally be some, but during an add printer, there
-         * should not be any (if there are delete them).
-         */
-
-        if ( info_ptr->data )
-                delete_all_printer_data( info_ptr, "" );
-
-        if (asprintf(&key, "%s%s", DRIVER_INIT_PREFIX,
-                                info_ptr->drivername) < 0) {
-                return false;
-        }
-
-        dbuf = tdb_fetch_bystring(tdb_drivers, key);
-        if (!dbuf.dptr) {
-                /*
-                 * When changing to a driver that has no init info in the tdb, remove
-                 * the previous drivers init info and leave the new on blank.
-                 */
-                free_nt_devicemode(&info_ptr->devmode);
-                SAFE_FREE(key);
-                return false;
-        }
-
-        SAFE_FREE(key);
-        /*
-         * Get the saved DEVMODE..
-         */
-
-        len += unpack_devicemode(&info.devmode,dbuf.dptr+len, dbuf.dsize-len);
-
-        /*
-         * The saved DEVMODE contains the devicename from the printer used during
-         * the initialization save. Change it to reflect the new printer.
-         */
-
-        if ( info.devmode ) {
-                ZERO_STRUCT(info.devmode->devicename);
-                fstrcpy(info.devmode->devicename, info_ptr->printername);
-        }
-
-        /*
-         * NT/2k does not change out the entire DeviceMode of a printer
-         * when changing the driver.  Only the driverextra, private, &
-         * driverversion fields.   --jerry  (Thu Mar 14 08:58:43 CST 2002)
-         *
-         * Later examination revealed that Windows NT/2k does reset the
-         * the printer's device mode, bit **only** when you change a
-         * property of the device mode such as the page orientation.
-         * --jerry
-         */
-
-
-        /* Bind the saved DEVMODE to the new the printer */
-
-        free_nt_devicemode(&info_ptr->devmode);
-        info_ptr->devmode = info.devmode;
-
-        DEBUG(10,("set_driver_init_2: Set printer [%s] init %s DEVMODE for driver [%s]\n",
-                info_ptr->printername, info_ptr->devmode?"VALID":"NULL", info_ptr->drivername));
-
-        /* Add the printer data 'values' to the new printer */
-
-        if ( !(info_ptr->data = TALLOC_ZERO_P( info_ptr, NT_PRINTER_DATA )) ) {
-                DEBUG(0,("set_driver_init_2: talloc() failed!\n"));
-                return False;
-        }
-
-        len += unpack_values( info_ptr->data, dbuf.dptr+len, dbuf.dsize-len );
-
-        SAFE_FREE(dbuf.dptr);
-
-        return true;
-}
-
-/****************************************************************************
- Initialize printer devmode & data with previously saved driver init values.
- When a printer is created using AddPrinter, the drivername bound to the
- printer is used to lookup previously saved driver initialization info, which
- is bound to the new printer.
-****************************************************************************/
-
-bool set_driver_init(NT_PRINTER_INFO_LEVEL *printer, uint32 level)
-{
-        bool result = False;
-
-        switch (level) {
-                case 2:
-                        result = set_driver_init_2(printer->info_2);
-                        break;
-
-                default:
-                        DEBUG(0,("set_driver_init: Programmer's error!  Unknown driver_init level [%d]\n",
-                                level));
-                        break;
-        }
-
-        return result;
-}
-
-/****************************************************************************
- Delete driver init data stored for a specified driver
-****************************************************************************/
-
-bool del_driver_init(const char *drivername)
-{
-        char *key;
-        bool ret;
-
-        if (!drivername || !*drivername) {
-                DEBUG(3,("del_driver_init: No drivername specified!\n"));
-                return false;
-        }
-
-        if (asprintf(&key, "%s%s", DRIVER_INIT_PREFIX, drivername) < 0) {
-                return false;
-        }
-
-        DEBUG(6,("del_driver_init: Removing driver init data for [%s]\n",
-                                drivername));
-
-        ret = (tdb_delete_bystring(tdb_drivers, key) == 0);
-        SAFE_FREE(key);
-        return ret;
-}
-
-/****************************************************************************
- Pack up the DEVMODE and values for a printer into a 'driver init' entry
- in the tdb. Note: this is different from the driver entry and the printer
- entry. There should be a single driver init entry for each driver regardless
- of whether it was installed from NT or 2K. Technically, they should be
- different, but they work out to the same struct.
-****************************************************************************/
-
-static uint32 update_driver_init_2(NT_PRINTER_INFO_LEVEL_2 *info)
-{
-        char *key = NULL;
-        uint8 *buf;
-        int buflen, len, ret;
-        int retlen;
-        TDB_DATA dbuf;
-
-        buf = NULL;
-        buflen = 0;
-
- again:
-        len = 0;
-        len += pack_devicemode(info->devmode, buf+len, buflen-len);
-
-        retlen = pack_values( info->data, buf+len, buflen-len );
-        if (retlen == -1) {
-                ret = -1;
-                goto done;
-        }
-        len += retlen;
-
-        if (buflen < len) {
-                buf = (uint8 *)SMB_REALLOC(buf, len);
-                if (!buf) {
-                        DEBUG(0, ("update_driver_init_2: failed to enlarge buffer!\n"));
-                        ret = -1;
-                        goto done;
-                }
-                buflen = len;
-                goto again;
-        }
-
-        SAFE_FREE(key);
-        if (asprintf(&key, "%s%s", DRIVER_INIT_PREFIX, info->drivername) < 0) {
-                ret = (uint32)-1;
-                goto done;
-        }
-
-        dbuf.dptr = buf;
-        dbuf.dsize = len;
-
-        ret = tdb_store_bystring(tdb_drivers, key, dbuf, TDB_REPLACE);
-
-done:
-        if (ret == -1)
-                DEBUG(8, ("update_driver_init_2: error updating printer init to tdb on disk\n"));
-
-        SAFE_FREE(buf);
-
-        DEBUG(10,("update_driver_init_2: Saved printer [%s] init DEVMODE & values for driver [%s]\n",
-                 info->sharename, info->drivername));
-
-        return ret;
-}
-
-/****************************************************************************
- Update (i.e. save) the driver init info (DEVMODE and values) for a printer
-****************************************************************************/
-
-static uint32 update_driver_init(NT_PRINTER_INFO_LEVEL *printer, uint32 level)
-{
-        uint32 result;
-
-        dump_a_printer(printer, level);
-
-        switch (level) {
-                case 2:
-                        result = update_driver_init_2(printer->info_2);
-                        break;
-                default:
-                        result = 1;
-                        break;
-        }
-
-        return result;
-}
-
-/****************************************************************************
- Convert the printer data value, a REG_BINARY array, into an initialization
- DEVMODE. Note: the array must be parsed as if it was a DEVMODE in an rpc...
- got to keep the endians happy :).
-****************************************************************************/
-
-static bool convert_driver_init(TALLOC_CTX *mem_ctx, NT_DEVICEMODE *nt_devmode,
-                                const uint8_t *data, uint32_t data_len)
-{
-        struct spoolss_DeviceMode devmode;
-        enum ndr_err_code ndr_err;
-        DATA_BLOB blob;
-
-        ZERO_STRUCT(devmode);
-
-        blob = data_blob_const(data, data_len);
-
-        ndr_err = ndr_pull_struct_blob(&blob, mem_ctx, NULL, &devmode,
-                        (ndr_pull_flags_fn_t)ndr_pull_spoolss_DeviceMode);
-        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-                DEBUG(10,("convert_driver_init: error parsing spoolss_DeviceMode\n"));
-                return false;
-        }
-
-        return convert_devicemode("", &devmode, &nt_devmode);
-}
-
-/****************************************************************************
- Set the DRIVER_INIT info in the tdb. Requires Win32 client code that:
-
- 1. Use the driver's config DLL to this UNC printername and:
-    a. Call DrvPrintEvent with PRINTER_EVENT_INITIALIZE
-    b. Call DrvConvertDevMode with CDM_DRIVER_DEFAULT to get default DEVMODE
- 2. Call SetPrinterData with the 'magic' key and the DEVMODE as data.
-
- The last step triggers saving the "driver initialization" information for
- this printer into the tdb. Later, new printers that use this driver will
- have this initialization information bound to them. This simulates the
- driver initialization, as if it had run on the Samba server (as it would
- have done on NT).
-
- The Win32 client side code requirement sucks! But until we can run arbitrary
- Win32 printer driver code on any Unix that Samba runs on, we are stuck with it.
-
- It would have been easier to use SetPrinter because all the UNMARSHALLING of
- the DEVMODE is done there, but 2K/XP clients do not set the DEVMODE... think
- about it and you will realize why.  JRR 010720
-****************************************************************************/
-
-static WERROR save_driver_init_2(NT_PRINTER_INFO_LEVEL *printer, uint8 *data, uint32 data_len )
-{
-        WERROR        status       = WERR_OK;
-        TALLOC_CTX    *ctx         = NULL;
-        NT_DEVICEMODE *nt_devmode  = NULL;
-        NT_DEVICEMODE *tmp_devmode = printer->info_2->devmode;
-
-        /*
-         * When the DEVMODE is already set on the printer, don't try to unpack it.
-         */
-        DEBUG(8,("save_driver_init_2: Enter...\n"));
-
-        if ( !printer->info_2->devmode && data_len ) {
-                /*
-                 * Set devmode on printer info, so entire printer initialization can be
-                 * saved to tdb.
-                 */
-
-                if ((ctx = talloc_init("save_driver_init_2")) == NULL)
-                        return WERR_NOMEM;
-
-                if ((nt_devmode = SMB_MALLOC_P(NT_DEVICEMODE)) == NULL) {
-                        status = WERR_NOMEM;
-                        goto done;
-                }
-
-                ZERO_STRUCTP(nt_devmode);
-
-                /*
-                 * The DEVMODE is held in the 'data' component of the param in raw binary.
-                 * Convert it to to a devmode structure
-                 */
-                if ( !convert_driver_init( ctx, nt_devmode, data, data_len )) {
-                        DEBUG(10,("save_driver_init_2: error converting DEVMODE\n"));
-                        status = WERR_INVALID_PARAM;
-                        goto done;
-                }
-
-                printer->info_2->devmode = nt_devmode;
-        }
-
-        /*
-         * Pack up and add (or update) the DEVMODE and any current printer data to
-         * a 'driver init' element in the tdb
-         *
-         */
-
-        if ( update_driver_init(printer, 2) != 0 ) {
-                DEBUG(10,("save_driver_init_2: error updating DEVMODE\n"));
-                status = WERR_NOMEM;
-                goto done;
-        }
-
-        /*
-         * If driver initialization info was successfully saved, set the current
-         * printer to match it. This allows initialization of the current printer
-         * as well as the driver.
-         */
-        status = mod_a_printer(printer, 2);
-        if (!W_ERROR_IS_OK(status)) {
-                DEBUG(10,("save_driver_init_2: error setting DEVMODE on printer [%s]\n",
-                                  printer->info_2->printername));
-        }
-
-  done:
-        talloc_destroy(ctx);
-        free_nt_devicemode( &nt_devmode );
-
-        printer->info_2->devmode = tmp_devmode;
-
-        return status;
-}
-
-/****************************************************************************
- Update the driver init info (DEVMODE and specifics) for a printer
-****************************************************************************/
-
-WERROR save_driver_init(NT_PRINTER_INFO_LEVEL *printer, uint32 level, uint8 *data, uint32 data_len)
-{
-        WERROR status = WERR_OK;
-
-        switch (level) {
-                case 2:
-                        status = save_driver_init_2( printer, data, data_len );
-                        break;
-                default:
-                        status = WERR_UNKNOWN_LEVEL;
-                        break;
-        }
-
-        return status;
-}
-
-/****************************************************************************
- Get a NT_PRINTER_INFO_LEVEL struct. It returns malloced memory.
-
- Previously the code had a memory allocation problem because it always
- used the TALLOC_CTX from the Printer_entry*.   This context lasts
- as a long as the original handle is open.  So if the client made a lot
- of getprinter[data]() calls, the memory usage would climb.  Now we use
- a short lived TALLOC_CTX for printer_info_2 objects returned.  We
- still use the Printer_entry->ctx for maintaining the cache copy though
- since that object must live as long as the handle by definition.
-                                                    --jerry
-
-****************************************************************************/
-
-static WERROR get_a_printer_internal( Printer_entry *print_hnd, NT_PRINTER_INFO_LEVEL **pp_printer, uint32 level,
-                        const char *sharename, bool get_loc_com)
-{
-        WERROR result;
-        fstring servername;
-
-        DEBUG(10,("get_a_printer: [%s] level %u\n", sharename, (unsigned int)level));
-
-        if ( !(*pp_printer = TALLOC_ZERO_P(NULL, NT_PRINTER_INFO_LEVEL)) ) {
-                DEBUG(0,("get_a_printer: talloc() fail.\n"));
-                return WERR_NOMEM;
-        }
-
-        switch (level) {
-                case 2:
-                        if ( !((*pp_printer)->info_2 = TALLOC_ZERO_P(*pp_printer, NT_PRINTER_INFO_LEVEL_2)) ) {
-                                DEBUG(0,("get_a_printer: talloc() fail.\n"));
-                                TALLOC_FREE( *pp_printer );
-                                return WERR_NOMEM;
-                        }
-
-                        if ( print_hnd )
-                                fstrcpy( servername, print_hnd->servername );
-                        else {
-                                fstrcpy( servername, "%L" );
-                                standard_sub_basic( "", "", servername,
-                                                    sizeof(servername)-1 );
-                        }
-
-                        result = get_a_printer_2( (*pp_printer)->info_2,
-                                        servername, sharename, get_loc_com);
-
-                        /* we have a new printer now.  Save it with this handle */
-
-                        if ( !W_ERROR_IS_OK(result) ) {
-                                TALLOC_FREE( *pp_printer );
-                                DEBUG(10,("get_a_printer: [%s] level %u returning %s\n",
-                                        sharename, (unsigned int)level, win_errstr(result)));
-                                return result;
-                        }
-
-                        dump_a_printer( *pp_printer, level);
-
-                        break;
-
-                default:
-                        TALLOC_FREE( *pp_printer );
-                        return WERR_UNKNOWN_LEVEL;
-        }
-
-        return WERR_OK;
-}
-
-WERROR get_a_printer( Printer_entry *print_hnd,
-                        NT_PRINTER_INFO_LEVEL **pp_printer,
-                        uint32 level,
-                        const char *sharename)
-{
-        return get_a_printer_internal(print_hnd, pp_printer, level,
-                                        sharename, true);
-}
-
-WERROR get_a_printer_search( Printer_entry *print_hnd,
-                        NT_PRINTER_INFO_LEVEL **pp_printer,
-                        uint32 level,
-                        const char *sharename)
-{
-        return get_a_printer_internal(print_hnd, pp_printer, level,
-                                        sharename, false);
-}
-
-/****************************************************************************
- Deletes a NT_PRINTER_INFO_LEVEL struct.
-****************************************************************************/
-
-uint32 free_a_printer(NT_PRINTER_INFO_LEVEL **pp_printer, uint32 level)
-{
-        NT_PRINTER_INFO_LEVEL *printer = *pp_printer;
-
-        if ( !printer )
-                return 0;
-
-        switch (level) {
-                case 2:
-                        if ( printer->info_2 )
-                                free_nt_printer_info_level_2(&printer->info_2);
-                        break;
-
-                default:
-                        DEBUG(0,("free_a_printer: unknown level! [%d]\n", level ));
-                        return 1;
-        }
-
-        TALLOC_FREE(*pp_printer);
-
-        return 0;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-uint32_t add_a_printer_driver(TALLOC_CTX *mem_ctx,
-                              struct spoolss_AddDriverInfoCtr *r,
-                              char **driver_name,
-                              uint32_t *version)
-{
-        struct spoolss_DriverInfo8 info8;
-
-        ZERO_STRUCT(info8);
-
-        DEBUG(10,("adding a printer at level [%d]\n", r->level));
-
-        switch (r->level) {
-        case 3:
-                info8.version           = r->info.info3->version;
-                info8.driver_name       = r->info.info3->driver_name;
-                info8.architecture      = r->info.info3->architecture;
-                info8.driver_path       = r->info.info3->driver_path;
-                info8.data_file         = r->info.info3->data_file;
-                info8.config_file       = r->info.info3->config_file;
-                info8.help_file         = r->info.info3->help_file;
-                info8.monitor_name      = r->info.info3->monitor_name;
-                info8.default_datatype  = r->info.info3->default_datatype;
-                if (r->info.info3->dependent_files && r->info.info3->dependent_files->string) {
-                        info8.dependent_files   = r->info.info3->dependent_files->string;
-                }
-                break;
-        case 6:
-                info8.version           = r->info.info6->version;
-                info8.driver_name       = r->info.info6->driver_name;
-                info8.architecture      = r->info.info6->architecture;
-                info8.driver_path       = r->info.info6->driver_path;
-                info8.data_file         = r->info.info6->data_file;
-                info8.config_file       = r->info.info6->config_file;
-                info8.help_file         = r->info.info6->help_file;
-                info8.monitor_name      = r->info.info6->monitor_name;
-                info8.default_datatype  = r->info.info6->default_datatype;
-                if (r->info.info6->dependent_files && r->info.info6->dependent_files->string) {
-                        info8.dependent_files   = r->info.info6->dependent_files->string;
-                }
-                info8.driver_date       = r->info.info6->driver_date;
-                info8.driver_version    = r->info.info6->driver_version;
-                info8.manufacturer_name = r->info.info6->manufacturer_name;
-                info8.manufacturer_url  = r->info.info6->manufacturer_url;
-                info8.hardware_id       = r->info.info6->hardware_id;
-                info8.provider          = r->info.info6->provider;
-                break;
-        case 8:
-                info8.version           = r->info.info8->version;
-                info8.driver_name       = r->info.info8->driver_name;
-                info8.architecture      = r->info.info8->architecture;
-                info8.driver_path       = r->info.info8->driver_path;
-                info8.data_file         = r->info.info8->data_file;
-                info8.config_file       = r->info.info8->config_file;
-                info8.help_file         = r->info.info8->help_file;
-                info8.monitor_name      = r->info.info8->monitor_name;
-                info8.default_datatype  = r->info.info8->default_datatype;
-                if (r->info.info8->dependent_files && r->info.info8->dependent_files->string) {
-                        info8.dependent_files   = r->info.info8->dependent_files->string;
-                }
-                if (r->info.info8->previous_names && r->info.info8->previous_names->string) {
-                        info8.previous_names    = r->info.info8->previous_names->string;
-                }
-                info8.driver_date       = r->info.info8->driver_date;
-                info8.driver_version    = r->info.info8->driver_version;
-                info8.manufacturer_name = r->info.info8->manufacturer_name;
-                info8.manufacturer_url  = r->info.info8->manufacturer_url;
-                info8.hardware_id       = r->info.info8->hardware_id;
-                info8.provider          = r->info.info8->provider;
-                info8.print_processor   = r->info.info8->print_processor;
-                info8.vendor_setup      = r->info.info8->vendor_setup;
-                if (r->info.info8->color_profiles && r->info.info8->color_profiles->string) {
-                        info8.color_profiles = r->info.info8->color_profiles->string;
-                }
-                info8.inf_path          = r->info.info8->inf_path;
-                info8.printer_driver_attributes = r->info.info8->printer_driver_attributes;
-                if (r->info.info8->core_driver_dependencies && r->info.info8->core_driver_dependencies->string) {
-                        info8.core_driver_dependencies = r->info.info8->core_driver_dependencies->string;
-                }
-                info8.min_inbox_driver_ver_date = r->info.info8->min_inbox_driver_ver_date;
-                info8.min_inbox_driver_ver_version = r->info.info8->min_inbox_driver_ver_version;
-                break;
-        default:
-                return -1;
-        }
-
-        *driver_name = talloc_strdup(mem_ctx, info8.driver_name);
-        if (!*driver_name) {
-                return -1;
-        }
-        *version = info8.version;
-
-        return add_a_printer_driver_8(&info8);
-}
-
-/****************************************************************************
-****************************************************************************/
-
-WERROR get_a_printer_driver(TALLOC_CTX *mem_ctx,
-                            struct spoolss_DriverInfo8 **driver,
-                            const char *drivername, const char *architecture,
-                            uint32_t version)
-{
-        WERROR result;
-        struct spoolss_DriverInfo3 info3;
-        struct spoolss_DriverInfo8 *info8;
-
-        ZERO_STRUCT(info3);
-
-        /* Sometime we just want any version of the driver */
-
-        if (version == DRIVER_ANY_VERSION) {
-                /* look for Win2k first and then for NT4 */
-                result = get_a_printer_driver_3(mem_ctx,
-                                                &info3,
-                                                drivername,
-                                                architecture, 3);
-                if (!W_ERROR_IS_OK(result)) {
-                        result = get_a_printer_driver_3(mem_ctx,
-                                                        &info3,
-                                                        drivername,
-                                                        architecture, 2);
-                }
-        } else {
-                result = get_a_printer_driver_3(mem_ctx,
-                                                &info3,
-                                                drivername,
-                                                architecture,
-                                                version);
-        }
-
-        if (!W_ERROR_IS_OK(result)) {
-                return result;
-        }
-
-        info8 = talloc_zero(mem_ctx, struct spoolss_DriverInfo8);
-        if (!info8) {
-                return WERR_NOMEM;
-        }
-
-        info8->version          = info3.version;
-        info8->driver_name      = info3.driver_name;
-        info8->architecture     = info3.architecture;
-        info8->driver_path      = info3.driver_path;
-        info8->data_file        = info3.data_file;
-        info8->config_file      = info3.config_file;
-        info8->help_file        = info3.help_file;
-        info8->dependent_files  = info3.dependent_files;
-        info8->monitor_name     = info3.monitor_name;
-        info8->default_datatype = info3.default_datatype;
-
-        *driver = info8;
-
-        return WERR_OK;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-uint32_t free_a_printer_driver(struct spoolss_DriverInfo8 *driver)
-{
-        talloc_free(driver);
-        return 0;
-}
-
+        return err;
+}
 
 /****************************************************************************
@@ -4816 +1174 @@
 ****************************************************************************/
 
-bool printer_driver_in_use(const struct spoolss_DriverInfo8 *r)
+bool printer_driver_in_use(TALLOC_CTX *mem_ctx,
+                           const struct auth_serversupplied_info *session_info,
+                           struct messaging_context *msg_ctx,
+                           const struct spoolss_DriverInfo8 *r)
 {
         int snum;
         int n_services = lp_numservices();
-        NT_PRINTER_INFO_LEVEL *printer = NULL;
         bool in_use = False;
+        struct spoolss_PrinterInfo2 *pinfo2 = NULL;
+        WERROR result;
+        struct dcerpc_binding_handle *b = NULL;
 
         if (!r) {
@@ -4832 +1195 @@
 
         for (snum=0; snum<n_services && !in_use; snum++) {
-                if ( !(lp_snum_ok(snum) && lp_print_ok(snum) ) )
+                if (!lp_snum_ok(snum) || !lp_print_ok(snum)) {
                         continue;
-
-                if ( !W_ERROR_IS_OK(get_a_printer(NULL, &printer, 2, lp_servicename(snum))) )
-                        continue;
-
-                if (strequal(r->driver_name, printer->info_2->drivername))
+                }
+
+                if (b == NULL) {
+                        result = winreg_printer_binding_handle(mem_ctx,
+                                                               session_info,
+                                                               msg_ctx,
+                                                               &b);
+                        if (!W_ERROR_IS_OK(result)) {
+                                return false;
+                        }
+                }
+
+                result = winreg_get_printer(mem_ctx, b,
+                                            lp_servicename(snum),
+                                            &pinfo2);
+                if (!W_ERROR_IS_OK(result)) {
+                        continue; /* skip */
+                }
+
+                if (strequal(r->driver_name, pinfo2->drivername)) {
                         in_use = True;
-
-                free_a_printer( &printer, 2 );
+                }
+
+                TALLOC_FREE(pinfo2);
         }
 
@@ -4847 +1226 @@
 
         if ( in_use ) {
-                struct spoolss_DriverInfo8 *d;
+                struct spoolss_DriverInfo8 *driver;
                 WERROR werr;
 
@@ -4856 +1235 @@
 
                 if (!strequal("Windows NT x86", r->architecture)) {
-                        werr = get_a_printer_driver(talloc_tos(), &d, r->driver_name, "Windows NT x86", DRIVER_ANY_VERSION);
-                }
-                else {
-                        switch (r->version) {
-                        case 2:
-                                werr = get_a_printer_driver(talloc_tos(), &d, r->driver_name, "Windows NT x86", 3);
-                                break;
-                        case 3:
-                                werr = get_a_printer_driver(talloc_tos(), &d, r->driver_name, "Windows NT x86", 2);
-                                break;
-                        default:
-                                DEBUG(0,("printer_driver_in_use: ERROR! unknown driver version (%d)\n",
-                                        r->version));
-                                werr = WERR_UNKNOWN_PRINTER_DRIVER;
-                                break;
-                        }
+                        werr = winreg_get_driver(mem_ctx, b,
+                                                 "Windows NT x86",
+                                                 r->driver_name,
+                                                 DRIVER_ANY_VERSION,
+                                                 &driver);
+                } else if (r->version == 2) {
+                        werr = winreg_get_driver(mem_ctx, b,
+                                                 "Windows NT x86",
+                                                 r->driver_name,
+                                                 3, &driver);
+                } else if (r->version == 3) {
+                        werr = winreg_get_driver(mem_ctx, b,
+                                                 "Windows NT x86",
+                                                 r->driver_name,
+                                                 2, &driver);
+                } else {
+                        DEBUG(0, ("printer_driver_in_use: ERROR!"
+                                  " unknown driver version (%d)\n",
+                                  r->version));
+                        werr = WERR_UNKNOWN_PRINTER_DRIVER;
                 }
 
@@ -4879 +1262 @@
                         /* it's ok to remove the driver, we have other architctures left */
                         in_use = False;
-                        free_a_printer_driver(d);
+                        talloc_free(driver);
                 }
         }
@@ -5031 +1414 @@
 
 bool printer_driver_files_in_use(TALLOC_CTX *mem_ctx,
+                                 const struct auth_serversupplied_info *session_info,
+                                 struct messaging_context *msg_ctx,
                                  struct spoolss_DriverInfo8 *info)
 {
         int                             i;
-        int                             ndrivers;
         uint32                          version;
-        fstring                         *list = NULL;
         struct spoolss_DriverInfo8      *driver;
         bool in_use = false;
+        uint32_t num_drivers;
+        const char **drivers;
+        WERROR result;
+        struct dcerpc_binding_handle *b;
 
         if ( !info )
@@ -5047 +1434 @@
         /* loop over all driver versions */
 
-        DEBUG(5,("printer_driver_files_in_use: Beginning search through ntdrivers.tdb...\n"));
+        DEBUG(5,("printer_driver_files_in_use: Beginning search of drivers...\n"));
 
         /* get the list of drivers */
 
-        list = NULL;
-        ndrivers = get_ntdrivers(&list, info->architecture, version);
-
-        DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n",
-                ndrivers, info->architecture, version));
+        result = winreg_printer_binding_handle(mem_ctx,
+                                               session_info,
+                                               msg_ctx,
+                                               &b);
+        if (!W_ERROR_IS_OK(result)) {
+                return false;
+        }
+
+        result = winreg_get_driver_list(mem_ctx, b,
+                                        info->architecture, version,
+                                        &num_drivers, &drivers);
+        if (!W_ERROR_IS_OK(result)) {
+                return true;
+        }
+
+        DEBUGADD(4, ("we have:[%d] drivers in environment [%s] and version [%d]\n",
+                     num_drivers, info->architecture, version));
 
         /* check each driver for overlap in files */
 
-        for (i=0; i<ndrivers; i++) {
-                DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+        for (i = 0; i < num_drivers; i++) {
+                DEBUGADD(5,("\tdriver: [%s]\n", drivers[i]));
 
                 driver = NULL;
 
-                if (!W_ERROR_IS_OK(get_a_printer_driver(talloc_tos(), &driver, list[i], info->architecture, version))) {
-                        SAFE_FREE(list);
+                result = winreg_get_driver(mem_ctx, b,
+                                           info->architecture, drivers[i],
+                                           version, &driver);
+                if (!W_ERROR_IS_OK(result)) {
+                        talloc_free(drivers);
                         return True;
                 }
@@ -5081 +1483 @@
                 }
 
-                free_a_printer_driver(driver);
-        }
-
-        SAFE_FREE(list);
-
-        DEBUG(5,("printer_driver_files_in_use: Completed search through ntdrivers.tdb...\n"));
+                talloc_free(driver);
+        }
+
+        talloc_free(drivers);
+
+        DEBUG(5,("printer_driver_files_in_use: Completed search of drivers...\n"));
 
         return in_use;
@@ -5115 +1517 @@
 ****************************************************************************/
 
-static bool delete_driver_files(struct pipes_struct *rpc_pipe,
-                                const struct spoolss_DriverInfo8 *r)
+bool delete_driver_files(const struct auth_serversupplied_info *session_info,
+                         const struct spoolss_DriverInfo8 *r)
 {
         int i = 0;
@@ -5124 +1526 @@
         NTSTATUS nt_status;
         char *oldcwd;
-        fstring printdollar;
+        char *printdollar = NULL;
         int printdollar_snum;
         bool ret = false;
@@ -5135 +1537 @@
                 r->driver_name, r->version));
 
-        fstrcpy(printdollar, "print$");
-
-        printdollar_snum = find_service(printdollar);
+        printdollar_snum = find_service(talloc_tos(), "print$", &printdollar);
+        if (!printdollar) {
+                return false;
+        }
         if (printdollar_snum == -1) {
                 return false;
@@ -5144 +1547 @@
         nt_status = create_conn_struct(talloc_tos(), &conn, printdollar_snum,
                                        lp_pathname(printdollar_snum),
-                                       rpc_pipe->server_info, &oldcwd);
+                                       session_info, &oldcwd);
         if (!NT_STATUS_IS_OK(nt_status)) {
                 DEBUG(0,("delete_driver_files: create_conn_struct "
@@ -5151 +1554 @@
         }
 
+        nt_status = set_conn_force_user_group(conn, printdollar_snum);
+        if (!NT_STATUS_IS_OK(nt_status)) {
+                DEBUG(0, ("failed set force user / group\n"));
+                ret = false;
+                goto err_free_conn;
+        }
+
+        if (!become_user_by_session(conn, session_info)) {
+                DEBUG(0, ("failed to become user\n"));
+                ret = false;
+                goto err_free_conn;
+        }
+
         if ( !CAN_WRITE(conn) ) {
                 DEBUG(3,("delete_driver_files: Cannot delete print driver when [print$] is read-only\n"));
-                goto fail;
+                ret = false;
+                goto err_out;
         }
 
@@ -5209 +1626 @@
         }
 
-        goto done;
- fail:
-        ret = false;
- done:
+        ret = true;
+ err_out:
+        unbecome_user();
+ err_free_conn:
         if (conn != NULL) {
                 vfs_ChDir(conn, oldcwd);
+                SMB_VFS_DISCONNECT(conn);
                 conn_free(conn);
         }
         return ret;
-}
-
-/****************************************************************************
- Remove a printer driver from the TDB.  This assumes that the the driver was
- previously looked up.
- ***************************************************************************/
-
-WERROR delete_printer_driver(struct pipes_struct *rpc_pipe,
-                             const struct spoolss_DriverInfo8 *r,
-                             uint32 version, bool delete_files )
-{
-        char *key = NULL;
-        const char     *arch;
-        TDB_DATA        dbuf;
-
-        /* delete the tdb data first */
-
-        arch = get_short_archi(r->architecture);
-        if (!arch) {
-                return WERR_UNKNOWN_PRINTER_DRIVER;
-        }
-        if (asprintf(&key, "%s%s/%d/%s", DRIVERS_PREFIX,
-                        arch, version, r->driver_name) < 0) {
-                return WERR_NOMEM;
-        }
-
-        DEBUG(5,("delete_printer_driver: key = [%s] delete_files = %s\n",
-                key, delete_files ? "TRUE" : "FALSE" ));
-
-        /* check if the driver actually exists for this environment */
-
-        dbuf = tdb_fetch_bystring( tdb_drivers, key );
-        if ( !dbuf.dptr ) {
-                DEBUG(8,("delete_printer_driver: Driver unknown [%s]\n", key));
-                SAFE_FREE(key);
-                return WERR_UNKNOWN_PRINTER_DRIVER;
-        }
-
-        SAFE_FREE( dbuf.dptr );
-
-        /* ok... the driver exists so the delete should return success */
-
-        if (tdb_delete_bystring(tdb_drivers, key) == -1) {
-                DEBUG (0,("delete_printer_driver: fail to delete %s!\n", key));
-                SAFE_FREE(key);
-                return WERR_ACCESS_DENIED;
-        }
-
-        /*
-         * now delete any associated files if delete_files == True
-         * even if this part failes, we return succes because the
-         * driver doesn not exist any more
-         */
-
-        if ( delete_files )
-                delete_driver_files(rpc_pipe, r);
-
-        DEBUG(5,("delete_printer_driver: driver delete successful [%s]\n", key));
-        SAFE_FREE(key);
-
-        return WERR_OK;
-}
-
-/****************************************************************************
- Store a security desc for a printer.
-****************************************************************************/
-
-WERROR nt_printing_setsec(const char *sharename, SEC_DESC_BUF *secdesc_ctr)
-{
-        SEC_DESC_BUF *new_secdesc_ctr = NULL;
-        SEC_DESC_BUF *old_secdesc_ctr = NULL;
-        TALLOC_CTX *mem_ctx = NULL;
-        TDB_DATA kbuf;
-        TDB_DATA dbuf;
-        DATA_BLOB blob;
-        WERROR status;
-        NTSTATUS nt_status;
-
-        mem_ctx = talloc_init("nt_printing_setsec");
-        if (mem_ctx == NULL)
-                return WERR_NOMEM;
-
-        /* The old owner and group sids of the security descriptor are not
-           present when new ACEs are added or removed by changing printer
-           permissions through NT.  If they are NULL in the new security
-           descriptor then copy them over from the old one. */
-
-        if (!secdesc_ctr->sd->owner_sid || !secdesc_ctr->sd->group_sid) {
-                DOM_SID *owner_sid, *group_sid;
-                SEC_ACL *dacl, *sacl;
-                SEC_DESC *psd = NULL;
-                size_t size;
-
-                if (!nt_printing_getsec(mem_ctx, sharename, &old_secdesc_ctr)) {
-                        status = WERR_NOMEM;
-                        goto out;
-                }
-
-                /* Pick out correct owner and group sids */
-
-                owner_sid = secdesc_ctr->sd->owner_sid ?
-                        secdesc_ctr->sd->owner_sid :
-                        old_secdesc_ctr->sd->owner_sid;
-
-                group_sid = secdesc_ctr->sd->group_sid ?
-                        secdesc_ctr->sd->group_sid :
-                        old_secdesc_ctr->sd->group_sid;
-
-                dacl = secdesc_ctr->sd->dacl ?
-                        secdesc_ctr->sd->dacl :
-                        old_secdesc_ctr->sd->dacl;
-
-                sacl = secdesc_ctr->sd->sacl ?
-                        secdesc_ctr->sd->sacl :
-                        old_secdesc_ctr->sd->sacl;
-
-                /* Make a deep copy of the security descriptor */
-
-                psd = make_sec_desc(mem_ctx, secdesc_ctr->sd->revision, secdesc_ctr->sd->type,
-                                    owner_sid, group_sid,
-                                    sacl,
-                                    dacl,
-                                    &size);
-
-                if (!psd) {
-                        status = WERR_NOMEM;
-                        goto out;
-                }
-
-                new_secdesc_ctr = make_sec_desc_buf(mem_ctx, size, psd);
-        }
-
-        if (!new_secdesc_ctr) {
-                new_secdesc_ctr = secdesc_ctr;
-        }
-
-        /* Store the security descriptor in a tdb */
-
-        nt_status = marshall_sec_desc_buf(mem_ctx, new_secdesc_ctr,
-                                          &blob.data, &blob.length);
-        if (!NT_STATUS_IS_OK(nt_status)) {
-                status = ntstatus_to_werror(nt_status);
-                goto out;
-        }
-
-        kbuf = make_printers_secdesc_tdbkey(mem_ctx, sharename );
-
-        dbuf.dptr = (unsigned char *)blob.data;
-        dbuf.dsize = blob.length;
-
-        if (tdb_trans_store(tdb_printers, kbuf, dbuf, TDB_REPLACE)==0) {
-                status = WERR_OK;
-        } else {
-                DEBUG(1,("Failed to store secdesc for %s\n", sharename));
-                status = WERR_BADFUNC;
-        }
-
-        /* Free malloc'ed memory */
-        talloc_free(blob.data);
-
- out:
-
-        if (mem_ctx)
-                talloc_destroy(mem_ctx);
-        return status;
-}
-
-/****************************************************************************
- Construct a default security descriptor buffer for a printer.
-****************************************************************************/
-
-static SEC_DESC_BUF *construct_default_printer_sdb(TALLOC_CTX *ctx)
-{
-        SEC_ACE ace[5]; /* max number of ace entries */
-        int i = 0;
-        uint32_t sa;
-        SEC_ACL *psa = NULL;
-        SEC_DESC_BUF *sdb = NULL;
-        SEC_DESC *psd = NULL;
-        DOM_SID adm_sid;
-        size_t sd_size;
-
-        /* Create an ACE where Everyone is allowed to print */
-
-        sa = PRINTER_ACE_PRINT;
-        init_sec_ace(&ace[i++], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED,
-                     sa, SEC_ACE_FLAG_CONTAINER_INHERIT);
-
-        /* Add the domain admins group if we are a DC */
-
-        if ( IS_DC ) {
-                DOM_SID domadmins_sid;
-
-                sid_copy(&domadmins_sid, get_global_sam_sid());
-                sid_append_rid(&domadmins_sid, DOMAIN_GROUP_RID_ADMINS);
-
-                sa = PRINTER_ACE_FULL_CONTROL;
-                init_sec_ace(&ace[i++], &domadmins_sid,
-                        SEC_ACE_TYPE_ACCESS_ALLOWED, sa,
-                        SEC_ACE_FLAG_OBJECT_INHERIT | SEC_ACE_FLAG_INHERIT_ONLY);
-                init_sec_ace(&ace[i++], &domadmins_sid, SEC_ACE_TYPE_ACCESS_ALLOWED,
-                        sa, SEC_ACE_FLAG_CONTAINER_INHERIT);
-        }
-        else if (secrets_fetch_domain_sid(lp_workgroup(), &adm_sid)) {
-                sid_append_rid(&adm_sid, DOMAIN_USER_RID_ADMIN);
-
-                sa = PRINTER_ACE_FULL_CONTROL;
-                init_sec_ace(&ace[i++], &adm_sid,
-                        SEC_ACE_TYPE_ACCESS_ALLOWED, sa,
-                        SEC_ACE_FLAG_OBJECT_INHERIT | SEC_ACE_FLAG_INHERIT_ONLY);
-                init_sec_ace(&ace[i++], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED,
-                        sa, SEC_ACE_FLAG_CONTAINER_INHERIT);
-        }
-
-        /* add BUILTIN\Administrators as FULL CONTROL */
-
-        sa = PRINTER_ACE_FULL_CONTROL;
-        init_sec_ace(&ace[i++], &global_sid_Builtin_Administrators,
-                SEC_ACE_TYPE_ACCESS_ALLOWED, sa,
-                SEC_ACE_FLAG_OBJECT_INHERIT | SEC_ACE_FLAG_INHERIT_ONLY);
-        init_sec_ace(&ace[i++], &global_sid_Builtin_Administrators,
-                SEC_ACE_TYPE_ACCESS_ALLOWED,
-                sa, SEC_ACE_FLAG_CONTAINER_INHERIT);
-
-        /* Make the security descriptor owned by the BUILTIN\Administrators */
-
-        /* The ACL revision number in rpc_secdesc.h differs from the one
-           created by NT when setting ACE entries in printer
-           descriptors.  NT4 complains about the property being edited by a
-           NT5 machine. */
-
-        if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, i, ace)) != NULL) {
-                psd = make_sec_desc(ctx, SEC_DESC_REVISION, SEC_DESC_SELF_RELATIVE,
-                        &global_sid_Builtin_Administrators,
-                        &global_sid_Builtin_Administrators,
-                        NULL, psa, &sd_size);
-        }
-
-        if (!psd) {
-                DEBUG(0,("construct_default_printer_sd: Failed to make SEC_DESC.\n"));
-                return NULL;
-        }
-
-        sdb = make_sec_desc_buf(ctx, sd_size, psd);
-
-        DEBUG(4,("construct_default_printer_sdb: size = %u.\n",
-                 (unsigned int)sd_size));
-
-        return sdb;
-}
-
-/****************************************************************************
- Get a security desc for a printer.
-****************************************************************************/
-
-bool nt_printing_getsec(TALLOC_CTX *ctx, const char *sharename, SEC_DESC_BUF **secdesc_ctr)
-{
-        TDB_DATA kbuf;
-        TDB_DATA dbuf;
-        DATA_BLOB blob;
-        char *temp;
-        NTSTATUS status;
-
-        if (strlen(sharename) > 2 && (temp = strchr(sharename + 2, '\\'))) {
-                sharename = temp + 1;
-        }
-
-        /* Fetch security descriptor from tdb */
-
-        kbuf = make_printers_secdesc_tdbkey(ctx, sharename);
-
-        dbuf = tdb_fetch(tdb_printers, kbuf);
-        if (dbuf.dptr) {
-
-                status = unmarshall_sec_desc_buf(ctx, dbuf.dptr, dbuf.dsize,
-                                                 secdesc_ctr);
-                SAFE_FREE(dbuf.dptr);
-
-                if (NT_STATUS_IS_OK(status)) {
-                        return true;
-                }
-        }
-
-        *secdesc_ctr = construct_default_printer_sdb(ctx);
-        if (!*secdesc_ctr) {
-                return false;
-        }
-
-        status = marshall_sec_desc_buf(ctx, *secdesc_ctr,
-                                       &blob.data, &blob.length);
-        if (NT_STATUS_IS_OK(status)) {
-                dbuf.dptr = (unsigned char *)blob.data;
-                dbuf.dsize = blob.length;
-                tdb_trans_store(tdb_printers, kbuf, dbuf, TDB_REPLACE);
-                talloc_free(blob.data);
-        }
-
-        /* If security descriptor is owned by S-1-1-0 and winbindd is up,
-           this security descriptor has been created when winbindd was
-           down.  Take ownership of security descriptor. */
-
-        if (sid_equal((*secdesc_ctr)->sd->owner_sid, &global_sid_World)) {
-                DOM_SID owner_sid;
-
-                /* Change sd owner to workgroup administrator */
-
-                if (secrets_fetch_domain_sid(lp_workgroup(), &owner_sid)) {
-                        SEC_DESC_BUF *new_secdesc_ctr = NULL;
-                        SEC_DESC *psd = NULL;
-                        size_t size;
-
-                        /* Create new sd */
-
-                        sid_append_rid(&owner_sid, DOMAIN_USER_RID_ADMIN);
-
-                        psd = make_sec_desc(ctx, (*secdesc_ctr)->sd->revision, (*secdesc_ctr)->sd->type,
-                                            &owner_sid,
-                                            (*secdesc_ctr)->sd->group_sid,
-                                            (*secdesc_ctr)->sd->sacl,
-                                            (*secdesc_ctr)->sd->dacl,
-                                            &size);
-
-                        if (!psd) {
-                                return False;
-                        }
-
-                        new_secdesc_ctr = make_sec_desc_buf(ctx, size, psd);
-                        if (!new_secdesc_ctr) {
-                                return False;
-                        }
-
-                        /* Swap with other one */
-
-                        *secdesc_ctr = new_secdesc_ctr;
-
-                        /* Set it */
-
-                        nt_printing_setsec(sharename, *secdesc_ctr);
-                }
-        }
-
-        if (DEBUGLEVEL >= 10) {
-                SEC_ACL *the_acl = (*secdesc_ctr)->sd->dacl;
-                int i;
-
-                DEBUG(10, ("secdesc_ctr for %s has %d aces:\n",
-                           sharename, the_acl->num_aces));
-
-                for (i = 0; i < the_acl->num_aces; i++) {
-                        DEBUG(10, ("%s %d %d 0x%08x\n",
-                                   sid_string_dbg(&the_acl->aces[i].trustee),
-                                   the_acl->aces[i].type, the_acl->aces[i].flags,
-                                   the_acl->aces[i].access_mask));
-                }
-        }
-
-        return True;
 }
 
@@ -5617 +1678 @@
    NT5 the object specific ones. */
 
-void map_printer_permissions(SEC_DESC *sd)
+void map_printer_permissions(struct security_descriptor *sd)
 {
         int i;
@@ -5627 +1688 @@
 }
 
-void map_job_permissions(SEC_DESC *sd)
+void map_job_permissions(struct security_descriptor *sd)
 {
         int i;
@@ -5661 +1722 @@
 
  ****************************************************************************/
-bool print_access_check(struct auth_serversupplied_info *server_info, int snum,
+bool print_access_check(const struct auth_serversupplied_info *session_info,
+                        struct messaging_context *msg_ctx, int snum,
                         int access_type)
 {
-        SEC_DESC_BUF *secdesc = NULL;
+        struct spoolss_security_descriptor *secdesc = NULL;
         uint32 access_granted;
+        size_t sd_size;
         NTSTATUS status;
+        WERROR result;
         const char *pname;
         TALLOC_CTX *mem_ctx = NULL;
-        SE_PRIV se_printop = SE_PRINT_OPERATOR;
 
         /* If user is NULL then use the current_user structure */
@@ -5675 +1738 @@
         /* Always allow root or SE_PRINT_OPERATROR to do anything */
 
-        if (server_info->utok.uid == sec_initial_uid()
-            || user_has_privileges(server_info->ptok, &se_printop ) ) {
+        if (session_info->utok.uid == sec_initial_uid()
+            || security_token_has_privilege(session_info->security_token, SEC_PRIV_PRINT_OPERATOR)) {
                 return True;
         }
@@ -5682 +1745 @@
         /* Get printer name */
 
-        pname = PRINTERNAME(snum);
+        pname = lp_printername(snum);
 
         if (!pname || !*pname) {
@@ -5696 +1759 @@
         }
 
-        if (!nt_printing_getsec(mem_ctx, pname, &secdesc)) {
+        result = winreg_get_printer_secdesc_internal(mem_ctx,
+                                            get_session_info_system(),
+                                            msg_ctx,
+                                            pname,
+                                            &secdesc);
+        if (!W_ERROR_IS_OK(result)) {
                 talloc_destroy(mem_ctx);
                 errno = ENOMEM;
@@ -5703 +1771 @@
 
         if (access_type == JOB_ACCESS_ADMINISTER) {
-                SEC_DESC_BUF *parent_secdesc = secdesc;
+                struct spoolss_security_descriptor *parent_secdesc = secdesc;
 
                 /* Create a child security descriptor to check permissions
                    against.  This is because print jobs are child objects
                    objects of a printer. */
-
-                status = se_create_child_secdesc_buf(mem_ctx, &secdesc, parent_secdesc->sd, False);
-
+                status = se_create_child_secdesc(mem_ctx,
+                                                 &secdesc,
+                                                 &sd_size,
+                                                 parent_secdesc,
+                                                 parent_secdesc->owner_sid,
+                                                 parent_secdesc->group_sid,
+                                                 false);
                 if (!NT_STATUS_IS_OK(status)) {
                         talloc_destroy(mem_ctx);
@@ -5717 +1789 @@
                 }
 
-                map_job_permissions(secdesc->sd);
+                map_job_permissions(secdesc);
         } else {
-                map_printer_permissions(secdesc->sd);
+                map_printer_permissions(secdesc);
         }
 
         /* Check access */
-        status = se_access_check(secdesc->sd, server_info->ptok, access_type,
+        status = se_access_check(secdesc, session_info->security_token, access_type,
                                  &access_granted);
 
@@ -5731 +1803 @@
 
         if (!NT_STATUS_IS_OK(status) &&
-            (token_contains_name_in_list(uidtoname(server_info->utok.uid),
-                                         pdb_get_domain(server_info->sam_account),
-                                         NULL,
-                                         server_info->ptok,
+            (token_contains_name_in_list(uidtoname(session_info->utok.uid),
+                                         session_info->info3->base.domain.string,
+                                         NULL, session_info->security_token,
                                          lp_printer_admin(snum)))) {
                 talloc_destroy(mem_ctx);
@@ -5753 +1824 @@
 *****************************************************************************/
 
-bool print_time_access_check(const char *servicename)
-{
-        NT_PRINTER_INFO_LEVEL *printer = NULL;
+bool print_time_access_check(const struct auth_serversupplied_info *session_info,
+                             struct messaging_context *msg_ctx,
+                             const char *servicename)
+{
+        struct spoolss_PrinterInfo2 *pinfo2 = NULL;
+        WERROR result;
         bool ok = False;
         time_t now = time(NULL);
@@ -5761 +1835 @@
         uint32 mins;
 
-        if (!W_ERROR_IS_OK(get_a_printer(NULL, &printer, 2, servicename)))
+        result = winreg_get_printer_internal(NULL, session_info, msg_ctx,
+                                    servicename, &pinfo2);
+        if (!W_ERROR_IS_OK(result)) {
                 return False;
-
-        if (printer->info_2->starttime == 0 && printer->info_2->untiltime == 0)
+        }
+
+        if (pinfo2->starttime == 0 && pinfo2->untiltime == 0) {
                 ok = True;
+        }
 
         t = gmtime(&now);
         mins = (uint32)t->tm_hour*60 + (uint32)t->tm_min;
 
-        if (mins >= printer->info_2->starttime && mins <= printer->info_2->untiltime)
+        if (mins >= pinfo2->starttime && mins <= pinfo2->untiltime) {
                 ok = True;
-
-        free_a_printer(&printer, 2);
-
-        if (!ok)
+        }
+
+        TALLOC_FREE(pinfo2);
+
+        if (!ok) {
                 errno = EACCES;
+        }
 
         return ok;
 }
 
-/****************************************************************************
- Fill in the servername sent in the _spoolss_open_printer_ex() call
-****************************************************************************/
-
-char* get_server_name( Printer_entry *printer )
-{
-        return printer->servername;
-}
-
-
+void nt_printer_remove(TALLOC_CTX *mem_ctx,
+                        const struct auth_serversupplied_info *session_info,
+                        struct messaging_context *msg_ctx,
+                        const char *printer)
+{
+        WERROR result;
+
+        result = winreg_delete_printer_key_internal(mem_ctx, session_info, msg_ctx,
+                                           printer, "");
+        if (!W_ERROR_IS_OK(result)) {
+                DEBUG(0, ("nt_printer_remove: failed to remove rpinter %s",
+                          printer));
+        }
+}

trunk/server/source3/printing/pcap.c

@@ -27 +27 @@
 
 /*
- *  This module contains code to parse and cache printcap data, possibly
- *  in concert with the CUPS/SYSV/AIX-specific code found elsewhere.
- *
- *  The way this module looks at the printcap file is very simplistic.
- *  Only the local printcap file is inspected (no searching of NIS
- *  databases etc).
- *
- *  There are assumed to be one or more printer names per record, held
- *  as a set of sub-fields separated by vertical bar symbols ('|') in the
- *  first field of the record. The field separator is assumed to be a colon
- *  ':' and the record separator a newline.
- * 
- *  Lines ending with a backspace '\' are assumed to flag that the following
- *  line is a continuation line so that a set of lines can be read as one
- *  printcap entry.
- *
- *  A line stating with a hash '#' is assumed to be a comment and is ignored
- *  Comments are discarded before the record is strung together from the
- *  set of continuation lines.
- *
- *  Opening a pipe for "lpc status" and reading that would probably 
- *  be pretty effective. Code to do this already exists in the freely
- *  distributable PCNFS server code.
- *
  *  Modified to call SVID/XPG4 support if printcap name is set to "lpstat"
  *  in smb.conf under Solaris.
@@ -62 +38 @@
 
 #include "includes.h"
-
+#include "printing/pcap.h"
+#include "printer_list.h"
 
 struct pcap_cache {
         char *name;
         char *comment;
+        char *location;
         struct pcap_cache *next;
 };
 
-/* The systemwide printcap cache. */
-static struct pcap_cache *pcap_cache = NULL;
-
-bool pcap_cache_add_specific(struct pcap_cache **ppcache, const char *name, const char *comment)
+bool pcap_cache_add_specific(struct pcap_cache **ppcache, const char *name, const char *comment, const char *location)
 {
         struct pcap_cache *p;
@@ -82 +57 @@
         p->name = SMB_STRDUP(name);
         p->comment = (comment && *comment) ? SMB_STRDUP(comment) : NULL;
-
-        DEBUG(11,("pcap_cache_add_specific: Adding name %s info %s\n",
-                p->name, p->comment ? p->comment : ""));
+        p->location = (location && *location) ? SMB_STRDUP(location) : NULL;
+
+        DEBUG(11,("pcap_cache_add_specific: Adding name %s info %s, location: %s\n",
+                p->name, p->comment ? p->comment : "",
+                p->location ? p->location : ""));
 
         p->next = *ppcache;
@@ -101 +78 @@
                 SAFE_FREE(p->name);
                 SAFE_FREE(p->comment);
+                SAFE_FREE(p->location);
                 SAFE_FREE(p);
         }
@@ -106 +84 @@
 }
 
-bool pcap_cache_add(const char *name, const char *comment)
-{
-        return pcap_cache_add_specific(&pcap_cache, name, comment);
+bool pcap_cache_add(const char *name, const char *comment, const char *location)
+{
+        NTSTATUS status;
+        time_t t = time_mono(NULL);
+
+        status = printer_list_set_printer(talloc_tos(), name, comment, location, t);
+        return NT_STATUS_IS_OK(status);
 }
 
 bool pcap_cache_loaded(void)
 {
-        return (pcap_cache != NULL);
-}
-
-void pcap_cache_replace(const struct pcap_cache *pcache)
+        NTSTATUS status;
+        time_t last;
+
+        status = printer_list_get_last_refresh(&last);
+        return NT_STATUS_IS_OK(status);
+}
+
+bool pcap_cache_replace(const struct pcap_cache *pcache)
 {
         const struct pcap_cache *p;
-
-        pcap_cache_destroy_specific(&pcap_cache);
+        NTSTATUS status;
+
+        status = printer_list_mark_reload();
+        if (!NT_STATUS_IS_OK(status)) {
+                DEBUG(0, ("Failed to mark printer list for reload!\n"));
+                return false;
+        }
+
         for (p = pcache; p; p = p->next) {
-                pcap_cache_add(p->name, p->comment);
-        }
-}
-
-void pcap_cache_reload(void (*post_cache_fill_fn)(void))
+                pcap_cache_add(p->name, p->comment, p->location);
+        }
+
+        status = printer_list_clean_old();
+        if (!NT_STATUS_IS_OK(status)) {
+                DEBUG(0, ("Failed to cleanup printer list!\n"));
+                return false;
+        }
+
+        return true;
+}
+
+void pcap_cache_reload(struct tevent_context *ev,
+                       struct messaging_context *msg_ctx,
+                       void (*post_cache_fill_fn)(struct tevent_context *,
+                                                  struct messaging_context *))
 {
         const char *pcap_name = lp_printcapname();
         bool pcap_reloaded = False;
-        struct pcap_cache *tmp_cache = NULL;
-        XFILE *pcap_file;
-        char *pcap_line;
+        NTSTATUS status;
         bool post_cache_fill_fn_handled = false;
 
@@ -143 +144 @@
         }
 
-        tmp_cache = pcap_cache;
-        pcap_cache = NULL;
+        status = printer_list_mark_reload();
+        if (!NT_STATUS_IS_OK(status)) {
+                DEBUG(0, ("Failed to mark printer list for reload!\n"));
+                return;
+        }
 
 #ifdef HAVE_CUPS
         if (strequal(pcap_name, "cups")) {
-                pcap_reloaded = cups_cache_reload(post_cache_fill_fn);
+                pcap_reloaded = cups_cache_reload(ev, msg_ctx,
+                                                  post_cache_fill_fn);
                 /*
                  * cups_cache_reload() is async and calls post_cache_fill_fn()
@@ -179 +184 @@
 #endif
 
-        /* handle standard printcap - moved from pcap_printer_fn() */
-
-        if ((pcap_file = x_fopen(pcap_name, O_RDONLY, 0)) == NULL) {
-                DEBUG(0, ("Unable to open printcap file %s for read!\n", pcap_name));
-                goto done;
-        }
-
-        for (; (pcap_line = fgets_slash(NULL, 1024, pcap_file)) != NULL; free(pcap_line)) {
-                char name[MAXPRINTERLEN+1];
-                char comment[62];
-                char *p, *q;
-
-                if (*pcap_line == '#' || *pcap_line == 0)
-                        continue;
-
-                /* now we have a real printer line - cut at the first : */      
-                if ((p = strchr_m(pcap_line, ':')) != NULL)
-                        *p = 0;
-      
-                /*
-                 * now find the most likely printer name and comment 
-                 * this is pure guesswork, but it's better than nothing
-                 */
-                for (*name = *comment = 0, p = pcap_line; p != NULL; p = q) {
-                        bool has_punctuation;
-
-                        if ((q = strchr_m(p, '|')) != NULL)
-                                *q++ = 0;
-
-                        has_punctuation = (strchr_m(p, ' ') ||
-                                           strchr_m(p, '\t') ||
-                                           strchr_m(p, '"') ||
-                                           strchr_m(p, '\'') ||
-                                           strchr_m(p, ';') ||
-                                           strchr_m(p, ',') ||
-                                           strchr_m(p, '(') ||
-                                           strchr_m(p, ')'));
-
-                        if (strlen(p) > strlen(comment) && has_punctuation) {
-                                strlcpy(comment, p, sizeof(comment));
-                                continue;
-                        }
-
-                        if (strlen(p) <= MAXPRINTERLEN && *name == '\0' && !has_punctuation) {
-                                if (!*comment) {
-                                        strlcpy(comment, name, sizeof(comment));
-                                }
-                                strlcpy(name, p, sizeof(name));
-                                continue;
-                        }
-
-                        if (!strchr_m(comment, ' ') &&
-                            strlen(p) > strlen(comment)) {
-                                strlcpy(comment, p, sizeof(comment));
-                                continue;
-                        }
-                }
-
-                if (*name && !pcap_cache_add(name, comment)) {
-                        x_fclose(pcap_file);
-                        goto done;
-                }
-        }
-
-        x_fclose(pcap_file);
-        pcap_reloaded = True;
+        pcap_reloaded = std_pcap_cache_reload(pcap_name);
 
 done:
         DEBUG(3, ("reload status: %s\n", (pcap_reloaded) ? "ok" : "error"));
 
-        if (pcap_reloaded) {
-                pcap_cache_destroy_specific(&tmp_cache);
-                if ((post_cache_fill_fn_handled == false)
-                 && (post_cache_fill_fn != NULL)) {
-                        post_cache_fill_fn();
+        if ((pcap_reloaded) && (post_cache_fill_fn_handled == false)) {
+                /* cleanup old entries only if the operation was successful,
+                 * otherwise keep around the old entries until we can
+                 * successfuly reaload */
+                status = printer_list_clean_old();
+                if (!NT_STATUS_IS_OK(status)) {
+                        DEBUG(0, ("Failed to cleanup printer list!\n"));
                 }
-        } else {
-                pcap_cache_destroy_specific(&pcap_cache);
-                pcap_cache = tmp_cache;
+                if (post_cache_fill_fn != NULL) {
+                        post_cache_fill_fn(ev, msg_ctx);
+                }
         }
 
@@ -266 +208 @@
 bool pcap_printername_ok(const char *printername)
 {
-        struct pcap_cache *p;
-
-        for (p = pcap_cache; p != NULL; p = p->next)
-                if (strequal(p->name, printername))
-                        return True;
-
-        return False;
+        NTSTATUS status;
+
+        status = printer_list_get_printer(talloc_tos(), printername, NULL, NULL, 0);
+        return NT_STATUS_IS_OK(status);
 }
 
@@ -280 +219 @@
 
 void pcap_printer_fn_specific(const struct pcap_cache *pc,
-                        void (*fn)(const char *, const char *, void *),
+                        void (*fn)(const char *, const char *, const char *, void *),
                         void *pdata)
 {
@@ -286 +225 @@
 
         for (p = pc; p != NULL; p = p->next)
-                fn(p->name, p->comment, pdata);
+                fn(p->name, p->comment, p->location, pdata);
 
         return;
 }
 
-void pcap_printer_fn(void (*fn)(const char *, const char *, void *), void *pdata)
-{
-        pcap_printer_fn_specific(pcap_cache, fn, pdata);
-}
+void pcap_printer_fn(void (*fn)(const char *, const char *, const char *, void *), void *pdata)
+{
+        NTSTATUS status;
+
+        status = printer_list_run_fn(fn, pdata);
+        if (!NT_STATUS_IS_OK(status)) {
+                DEBUG(3, ("Failed to run fn for all printers!\n"));
+        }
+        return;
+}

trunk/server/source3/printing/print_aix.c

@@ -26 +26 @@
 
 #include "includes.h"
+#include "system/filesys.h"
+#include "printing/pcap.h"
 
 #ifdef AIX
@@ -85 +87 @@
                                 /* probably a good printer ???          */
                                 iEtat = 0;
-                                if (!pcap_cache_add(name, NULL)) {
+                                if (!pcap_cache_add(name, NULL, NULL)) {
                                         SAFE_FREE(line);
                                         x_fclose(pfile);
@@ -100 +102 @@
                                 /* it's a good virtual printer */
                                 iEtat = 0;
-                                if (!pcap_cache_add(name, NULL)) {
+                                if (!pcap_cache_add(name, NULL, NULL)) {
                                         SAFE_FREE(line);
                                         x_fclose(pfile);

trunk/server/source3/printing/print_cups.c

@@ -25 +25 @@
 #include "includes.h"
 #include "printing.h"
+#include "printing/pcap.h"
 #include "librpc/gen_ndr/ndr_printcap.h"
 
@@ -41 +42 @@
 ****************************************************************/
 
-static void gotalarm_sig(void)
+static void gotalarm_sig(int signum)
 {
         gotalarm = 1;
@@ -95 +96 @@
 
         if (timeout) {
-                CatchSignal(SIGALRM, SIGNAL_CAST gotalarm_sig);
+                CatchSignal(SIGALRM, gotalarm_sig);
                 alarm(timeout);
         }
@@ -106 +107 @@
 
 
-        CatchSignal(SIGALRM, SIGNAL_CAST SIG_IGN);
+        CatchSignal(SIGALRM, SIG_IGN);
         alarm(0);
 
@@ -131 +132 @@
         }
 
-        DEBUG(10, ("successfully sent blob of len %ld\n", (int64_t)ret));
+        DEBUG(10, ("successfully sent blob of len %d\n", (int)ret));
         return true;
 }
@@ -156 +157 @@
         }
 
-        DEBUG(10, ("successfully recvd blob of len %ld\n", (int64_t)ret));
+        DEBUG(10, ("successfully recvd blob of len %d\n", (int)ret));
         return true;
 }
@@ -167 +168 @@
         char *name;
         char *info;
+        char *location = NULL;
         struct pcap_printer *printer;
         bool ret_ok = false;
@@ -204 +206 @@
                                 if (!pull_utf8_talloc(mem_ctx,
                                                 &info,
+                                                attr->values[0].string.text,
+                                                &size)) {
+                                        goto err_out;
+                                }
+                        }
+
+                        if (strcmp(attr->name, "printer-location") == 0 &&
+                            attr->value_tag == IPP_TAG_TEXT) {
+                                if (!pull_utf8_talloc(mem_ctx,
+                                                &location,
                                                 attr->values[0].string.text,
                                                 &size)) {
@@ -233 +245 @@
                 pcap_data->printers[pcap_data->count].name = name;
                 pcap_data->printers[pcap_data->count].info = info;
+                pcap_data->printers[pcap_data->count].location = location;
                 pcap_data->count++;
         }
@@ -256 +269 @@
                         {
                           "printer-name",
-                          "printer-info"
+                          "printer-info",
+                          "printer-location"
                         };
         bool ret = False;
@@ -368 +382 @@
 
         ret = false;
-        ndr_ret = ndr_push_struct_blob(&pcap_blob, frame, NULL, &pcap_data,
+        ndr_ret = ndr_push_struct_blob(&pcap_blob, frame, &pcap_data,
                                        (ndr_push_flags_fn_t)ndr_push_pcap_data);
         if (ndr_ret == NDR_ERR_SUCCESS) {
@@ -378 +392 @@
 }
 
-static struct pcap_cache *local_pcap_copy;
-struct fd_event *cache_fd_event;
-
-static bool cups_pcap_load_async(int *pfd)
+static struct fd_event *cache_fd_event;
+
+static bool cups_pcap_load_async(struct tevent_context *ev,
+                                 struct messaging_context *msg_ctx,
+                                 int *pfd)
 {
         int fds[2];
         pid_t pid;
+        NTSTATUS status;
 
         *pfd = -1;
@@ -422 +438 @@
         close_all_print_db();
 
-        if (!NT_STATUS_IS_OK(reinit_after_fork(smbd_messaging_context(),
-                                               smbd_event_context(), true))) {
+        status = reinit_after_fork(msg_ctx, ev, procid_self(), true);
+        if (!NT_STATUS_IS_OK(status)) {
                 DEBUG(0,("cups_pcap_load_async: reinit_after_fork() failed\n"));
                 smb_panic("cups_pcap_load_async: reinit_after_fork() failed");
@@ -436 +452 @@
 struct cups_async_cb_args {
         int pipe_fd;
-        void (*post_cache_fill_fn)(void);
+        struct event_context *event_ctx;
+        struct messaging_context *msg_ctx;
+        void (*post_cache_fill_fn)(struct event_context *,
+                                   struct messaging_context *);
 };
 
@@ -462 +481 @@
         }
 
-        ndr_ret = ndr_pull_struct_blob(&pcap_blob, frame, NULL, &pcap_data,
+        ndr_ret = ndr_pull_struct_blob(&pcap_blob, frame, &pcap_data,
                                        (ndr_pull_flags_fn_t)ndr_pull_pcap_data);
         if (ndr_ret != NDR_ERR_SUCCESS) {
@@ -477 +496 @@
                 ret_ok = pcap_cache_add_specific(&tmp_pcap_cache,
                                                  pcap_data.printers[i].name,
-                                                 pcap_data.printers[i].info);
+                                                 pcap_data.printers[i].info,
+                                                 pcap_data.printers[i].location);
                 if (!ret_ok) {
                         DEBUG(0, ("failed to add to tmp pcap cache\n"));
-                        break;
+                        goto err_out;
                 }
         }
 
+        /* replace the system-wide pcap cache with a (possibly empty) new one */
+        ret_ok = pcap_cache_replace(tmp_pcap_cache);
         if (!ret_ok) {
-                DEBUG(0,("failed to read a new printer list\n"));
-                pcap_cache_destroy_specific(&tmp_pcap_cache);
-        } else {
-                /* We got a possibly empty namelist, replace our local cache. */
-                pcap_cache_destroy_specific(&local_pcap_copy);
-                local_pcap_copy = tmp_pcap_cache;
-
-                /* And the systemwide pcap cache. */
-                pcap_cache_replace(local_pcap_copy);
-
-                /* Caller may have requested post cache fill callback */
-                if (cb_args->post_cache_fill_fn) {
-                        cb_args->post_cache_fill_fn();
-                }
+                DEBUG(0, ("failed to replace pcap cache\n"));
+        } else if (cb_args->post_cache_fill_fn != NULL) {
+                /* Caller requested post cache fill callback */
+                cb_args->post_cache_fill_fn(cb_args->event_ctx,
+                                            cb_args->msg_ctx);
         }
 err_out:
+        pcap_cache_destroy_specific(&tmp_pcap_cache);
         TALLOC_FREE(frame);
         close(cb_args->pipe_fd);
@@ -507 +521 @@
 }
 
-bool cups_cache_reload(void (*post_cache_fill_fn)(void))
+bool cups_cache_reload(struct tevent_context *ev,
+                       struct messaging_context *msg_ctx,
+                       void (*post_cache_fill_fn)(struct tevent_context *,
+                                                  struct messaging_context *))
 {
         struct cups_async_cb_args *cb_args;
@@ -513 +530 @@
 
         cb_args = TALLOC_P(NULL, struct cups_async_cb_args);
-        if (!cb_args) {
+        if (cb_args == NULL) {
                 return false;
         }
+
         cb_args->post_cache_fill_fn = post_cache_fill_fn;
+        cb_args->event_ctx = ev;
+        cb_args->msg_ctx = msg_ctx;
         p_pipe_fd = &cb_args->pipe_fd;
         *p_pipe_fd = -1;
 
         /* Set up an async refresh. */
-        if (!cups_pcap_load_async(p_pipe_fd)) {
+        if (!cups_pcap_load_async(ev, msg_ctx, p_pipe_fd)) {
                 talloc_free(cb_args);
                 return false;
         }
-        if (!local_pcap_copy) {
-                /* We have no local cache, wait directly for
-                 * async refresh to complete.
-                 */
-                DEBUG(10,("cups_cache_reload: sync read on fd %d\n",
-                        *p_pipe_fd ));
-
-                cups_async_callback(smbd_event_context(),
-                                        NULL,
-                                        EVENT_FD_READ,
-                                        (void *)cb_args);
-                if (!local_pcap_copy) {
-                        return false;
-                }
-        } else {
-                /* Replace the system cache with our
-                 * local copy. */
-                pcap_cache_replace(local_pcap_copy);
-
-                DEBUG(10,("cups_cache_reload: async read on fd %d\n",
-                        *p_pipe_fd ));
-
-                /* Trigger an event when the pipe can be read. */
-                cache_fd_event = event_add_fd(smbd_event_context(),
-                                        NULL, *p_pipe_fd,
-                                        EVENT_FD_READ,
-                                        cups_async_callback,
-                                        (void *)cb_args);
-                if (!cache_fd_event) {
-                        close(*p_pipe_fd);
-                        talloc_free(cb_args);
-                        return false;
-                }
-        }
+
+        DEBUG(10,("cups_cache_reload: async read on fd %d\n",
+                *p_pipe_fd ));
+
+        /* Trigger an event when the pipe can be read. */
+        cache_fd_event = event_add_fd(ev,
+                                NULL, *p_pipe_fd,
+                                EVENT_FD_READ,
+                                cups_async_callback,
+                                (void *)cb_args);
+        if (!cache_fd_event) {
+                close(*p_pipe_fd);
+                TALLOC_FREE(cb_args);
+                return false;
+        }
+
         return true;
 }
@@ -865 +867 @@
         cups_lang_t     *language = NULL;       /* Default language */
         char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-        const char      *clientname = NULL;     /* hostname of client for job-originating-host attribute */
         char *new_jobname = NULL;
         int             num_options = 0;
@@ -876 +877 @@
         size_t size;
         uint32_t jobid = (uint32_t)-1;
-        char addr[INET6_ADDRSTRLEN];
 
         DEBUG(5,("cups_job_submit(%d, %p)\n", snum, pjob));
@@ -918 +918 @@
                      "attributes-natural-language", NULL, language->language);
 
-        if (!push_utf8_talloc(frame, &printername, PRINTERNAME(snum), &size)) {
+        if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+                              &size)) {
                 goto out;
         }
@@ -933 +934 @@
                      NULL, user);
 
-        clientname = client_name(get_client_fd());
-        if (strcmp(clientname, "UNKNOWN") == 0) {
-                clientname = client_addr(get_client_fd(),addr,sizeof(addr));
-        }
-
         ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
                      "job-originating-host-name", NULL,
-                      clientname);
+                     pjob->clientmachine);
 
         /* Get the jobid from the filename. */
@@ -989 +985 @@
         if ((response = cupsDoFileRequest(http, request, uri, pjob->filename)) != NULL) {
                 if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                        DEBUG(0,("Unable to print file to %s - %s\n", PRINTERNAME(snum),
+                        DEBUG(0,("Unable to print file to %s - %s\n",
+                                 lp_printername(snum),
                                  ippErrorString(cupsLastError())));
                 } else {
@@ -1002 +999 @@
                 }
         } else {
-                DEBUG(0,("Unable to print file to `%s' - %s\n", PRINTERNAME(snum),
+                DEBUG(0,("Unable to print file to `%s' - %s\n",
+                         lp_printername(snum),
                          ippErrorString(cupsLastError())));
         }
@@ -1427 +1425 @@
                      "attributes-natural-language", NULL, language->language);
 
-        if (!push_utf8_talloc(frame, &printername, PRINTERNAME(snum), &size)) {
+        if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+                              &size)) {
                 goto out;
         }
@@ -1447 +1446 @@
         if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
                 if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                        DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+                        DEBUG(0,("Unable to pause printer %s - %s\n",
+                                 lp_printername(snum),
                                 ippErrorString(cupsLastError())));
                 } else {
@@ -1453 +1453 @@
                 }
         } else {
-                DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+                DEBUG(0,("Unable to pause printer %s - %s\n",
+                         lp_printername(snum),
                         ippErrorString(cupsLastError())));
         }
@@ -1528 +1529 @@
                      "attributes-natural-language", NULL, language->language);
 
-        if (!push_utf8_talloc(frame, &printername, PRINTERNAME(snum), &size)) {
+        if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+                              &size)) {
                 goto out;
         }
@@ -1548 +1550 @@
         if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
                 if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                        DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+                        DEBUG(0,("Unable to resume printer %s - %s\n",
+                                 lp_printername(snum),
                                 ippErrorString(cupsLastError())));
                 } else {
@@ -1554 +1557 @@
                 }
         } else {
-                DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+                DEBUG(0,("Unable to resume printer %s - %s\n",
+                         lp_printername(snum),
                         ippErrorString(cupsLastError())));
         }
@@ -1588 +1592 @@
 };
 
-bool cups_pull_comment_location(NT_PRINTER_INFO_LEVEL_2 *printer)
-{
-        TALLOC_CTX *frame = talloc_stackframe();
-        http_t          *http = NULL;           /* HTTP connection to server */
-        ipp_t           *request = NULL,        /* IPP Request */
-                        *response = NULL;       /* IPP Response */
-        ipp_attribute_t *attr;          /* Current attribute */
-        cups_lang_t     *language = NULL;       /* Default language */
-        char            uri[HTTP_MAX_URI];
-        char *sharename = NULL;
-        char *name = NULL;
-        static const char *requested[] =/* Requested attributes */
-                        {
-                          "printer-name",
-                          "printer-info",
-                          "printer-location"
-                        };
-        bool ret = False;
-        size_t size;
-
-        DEBUG(5, ("pulling %s location\n", printer->sharename));
-
-        /*
-         * Make sure we don't ask for passwords...
-         */
-
-        cupsSetPasswordCB(cups_passwd_cb);
-
-        /*
-         * Try to connect to the server...
-         */
-
-        if ((http = cups_connect(frame)) == NULL) {
-                goto out;
-        }
-
-        request = ippNew();
-
-        request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
-        request->request.op.request_id   = 1;
-
-        language = cupsLangDefault();
-
-        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, "utf-8");
-
-        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
-                     "attributes-natural-language", NULL, language->language);
-
-        if (!push_utf8_talloc(frame, &sharename, printer->sharename, &size)) {
-                goto out;
-        }
-        slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                 sharename);
-
-        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
-                     "printer-uri", NULL, uri);
-
-        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
-                      "requested-attributes",
-                      (sizeof(requested) / sizeof(requested[0])),
-                      NULL, requested);
-
-        /*
-         * Do the request and get back a response...
-         */
-
-        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
-                DEBUG(0,("Unable to get printer attributes - %s\n",
-                         ippErrorString(cupsLastError())));
-                goto out;
-        }
-
-        for (attr = response->attrs; attr != NULL;) {
-                /*
-                 * Skip leading attributes until we hit a printer...
-                 */
-
-                while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                        attr = attr->next;
-
-                if (attr == NULL)
-                        break;
-
-                /*
-                 * Pull the needed attributes from this printer...
-                 */
-
-                while ( attr && (attr->group_tag == IPP_TAG_PRINTER) ) {
-                        if (strcmp(attr->name, "printer-name") == 0 &&
-                            attr->value_tag == IPP_TAG_NAME) {
-                                if (!pull_utf8_talloc(frame,
-                                                &name,
-                                                attr->values[0].string.text,
-                                                &size)) {
-                                        goto out;
-                                }
-                        }
-
-                        /* Grab the comment if we don't have one */
-                        if ( (strcmp(attr->name, "printer-info") == 0)
-                             && (attr->value_tag == IPP_TAG_TEXT)
-                             && !strlen(printer->comment) )
-                        {
-                                char *comment = NULL;
-                                if (!pull_utf8_talloc(frame,
-                                                &comment,
-                                                attr->values[0].string.text,
-                                                &size)) {
-                                        goto out;
-                                }
-                                DEBUG(5,("cups_pull_comment_location: Using cups comment: %s\n",
-                                         comment));
-                                strlcpy(printer->comment,
-                                        comment,
-                                        sizeof(printer->comment));
-                        }
-
-                        /* Grab the location if we don't have one */
-                        if ( (strcmp(attr->name, "printer-location") == 0)
-                             && (attr->value_tag == IPP_TAG_TEXT)
-                             && !strlen(printer->location) )
-                        {
-                                char *location = NULL;
-                                if (!pull_utf8_talloc(frame,
-                                                &location,
-                                                attr->values[0].string.text,
-                                                &size)) {
-                                        goto out;
-                                }
-                                DEBUG(5,("cups_pull_comment_location: Using cups location: %s\n",
-                                         location));
-                                strlcpy(printer->location,
-                                        location,
-                                        sizeof(printer->location));
-                        }
-
-                        attr = attr->next;
-                }
-
-                /*
-                 * We have everything needed...
-                 */
-
-                if (name != NULL)
-                        break;
-        }
-
-        ret = True;
-
- out:
-        if (response)
-                ippDelete(response);
-
-        if (language)
-                cupsLangFree(language);
-
-        if (http)
-                httpClose(http);
-
-        TALLOC_FREE(frame);
-        return ret;
-}
-
 #else
  /* this keeps fussy compilers happy */

trunk/server/source3/printing/print_generic.c

@@ -118 +118 @@
         /* need to pause the spooled entry */
         slprintf(jobstr, sizeof(jobstr)-1, "%d", pjob->sysjob);
-        return print_run_command(snum, PRINTERNAME(snum), True,
+        return print_run_command(snum, lp_printername(snum), True,
                                  lp_lppausecommand(snum), NULL,
                                  "%j", jobstr,
@@ -133 +133 @@
         /* need to pause the spooled entry */
         slprintf(jobstr, sizeof(jobstr)-1, "%d", pjob->sysjob);
-        return print_run_command(snum, PRINTERNAME(snum), True,
+        return print_run_command(snum, lp_printername(snum), True,
                                  lp_lpresumecommand(snum), NULL,
                                  "%j", jobstr,
@@ -195 +195 @@
 
         /* send it to the system spooler */
-        ret = print_run_command(snum, PRINTERNAME(snum), True,
+        ret = print_run_command(snum, lp_printername(snum), True,
                         lp_printcommand(snum), NULL,
                         "%s", p,
@@ -275 +275 @@
 static int generic_queue_pause(int snum)
 {
-        return print_run_command(snum, PRINTERNAME(snum), True, lp_queuepausecommand(snum), NULL, NULL);
+        return print_run_command(snum, lp_printername(snum), True,
+                                 lp_queuepausecommand(snum), NULL, NULL);
 }
 
@@ -283 +284 @@
 static int generic_queue_resume(int snum)
 {
-        return print_run_command(snum, PRINTERNAME(snum), True, lp_queueresumecommand(snum), NULL, NULL);
+        return print_run_command(snum, lp_printername(snum), True,
+                                 lp_queueresumecommand(snum), NULL, NULL);
 }
 

trunk/server/source3/printing/print_iprint.c

@@ -22 +22 @@
 #include "includes.h"
 #include "printing.h"
+#include "printing/pcap.h"
 
 #ifdef HAVE_IPRINT
@@ -297 +298 @@
 
                 if (name != NULL && !secure && smb_enabled) 
-                        pcap_cache_add(name, info);
+                        pcap_cache_add(name, info, NULL);
         }
 
@@ -575 +576 @@
                      "attributes-natural-language", NULL, language->language);
 
-        slprintf(uri, sizeof(uri) - 1, "ipp://%s/ipp/%s", iprint_server(), PRINTERNAME(snum));
+        slprintf(uri, sizeof(uri) - 1, "ipp://%s/ipp/%s", iprint_server(),
+                 lp_printername(snum));
 
         ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
@@ -588 +590 @@
         */
 
-        slprintf(httpPath, sizeof(httpPath) - 1, "/ipp/%s", PRINTERNAME(snum));
+        slprintf(httpPath, sizeof(httpPath) - 1, "/ipp/%s",
+                 lp_printername(snum));
 
         if ((response = cupsDoRequest(http, request, httpPath)) != NULL) {
@@ -673 +676 @@
                      "attributes-natural-language", NULL, language->language);
 
-        slprintf(uri, sizeof(uri) - 1, "ipp://%s/ipp/%s", iprint_server(), PRINTERNAME(snum));
+        slprintf(uri, sizeof(uri) - 1, "ipp://%s/ipp/%s", iprint_server(),
+                 lp_printername(snum));
 
         ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
@@ -686 +690 @@
         */
 
-        slprintf(httpPath, sizeof(httpPath) - 1, "/ipp/%s", PRINTERNAME(snum));
+        slprintf(httpPath, sizeof(httpPath) - 1, "/ipp/%s",
+                 lp_printername(snum));
 
         if ((response = cupsDoRequest(http, request, httpPath)) != NULL) {
@@ -727 +732 @@
         cups_lang_t     *language = NULL;       /* Default language */
         char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-        const char      *clientname = NULL;     /* hostname of client for job-originating-host attribute */
-        char addr[INET6_ADDRSTRLEN];
 
         DEBUG(5,("iprint_job_submit(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
@@ -772 +775 @@
                      "attributes-natural-language", NULL, language->language);
 
-        slprintf(uri, sizeof(uri) - 1, "ipp://%s/ipp/%s", iprint_server(), PRINTERNAME(snum));
+        slprintf(uri, sizeof(uri) - 1, "ipp://%s/ipp/%s", iprint_server(),
+                 lp_printername(snum));
 
         ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
@@ -780 +784 @@
                      NULL, pjob->user);
 
-        clientname = client_name(get_client_fd());
-        if (strcmp(clientname, "UNKNOWN") == 0) {
-                clientname = client_addr(get_client_fd(),addr,sizeof(addr));
-        }
-        
         ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
                      "job-originating-host-name", NULL,
-                     clientname);
+                     pjob->clientmachine);
 
         ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "job-name", NULL,
@@ -796 +795 @@
         */
 
-        slprintf(uri, sizeof(uri) - 1, "/ipp/%s", PRINTERNAME(snum));
+        slprintf(uri, sizeof(uri) - 1, "/ipp/%s", lp_printername(snum));
 
         if ((response = cupsDoFileRequest(http, request, uri, pjob->filename)) != NULL) {
                 if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                        DEBUG(0,("Unable to print file to %s - %s\n", PRINTERNAME(snum),
+                        DEBUG(0,("Unable to print file to %s - %s\n",
+                                 lp_printername(snum),
                                  ippErrorString(cupsLastError())));
                 } else {
@@ -806 +806 @@
                 }
         } else {
-                DEBUG(0,("Unable to print file to `%s' - %s\n", PRINTERNAME(snum),
+                DEBUG(0,("Unable to print file to `%s' - %s\n",
+                         lp_printername(snum),
                          ippErrorString(cupsLastError())));
         }

trunk/server/source3/printing/print_svid.c

@@ -33 +33 @@
 
 #include "includes.h"
+#include "printing/pcap.h"
 
 #if defined(SYSV) || defined(HPUX)
@@ -111 +112 @@
                 
                 /* add it to the cache */
-                if (!pcap_cache_add(name, NULL)) {
+                if (!pcap_cache_add(name, NULL, NULL)) {
                         TALLOC_FREE(lines);
                         return False;

trunk/server/source3/printing/printing.c

@@ -21 +21 @@
 
 #include "includes.h"
+#include "system/syslog.h"
+#include "system/filesys.h"
 #include "printing.h"
+#include "../librpc/gen_ndr/ndr_spoolss.h"
+#include "nt_printing.h"
+#include "../librpc/gen_ndr/netlogon.h"
+#include "printing/notify.h"
+#include "printing/pcap.h"
+#include "serverid.h"
+#include "smbd/smbd.h"
+#include "auth.h"
+#include "messages.h"
+#include "util_tdb.h"
 
 #ifdef __OS2__
@@ -31 +43 @@
 
 /* Current printer interface */
-static bool remove_from_jobs_changed(const char* sharename, uint32 jobid);
+static bool remove_from_jobs_added(const char* sharename, uint32 jobid);
 
 /*
@@ -138 +150 @@
 }
 
-static void rap_jobid_delete(const char* sharename, uint32 jobid)
+void rap_jobid_delete(const char* sharename, uint32 jobid)
 {
         TDB_DATA key, data;
@@ -279 +291 @@
 }
 
+/****************************************************************************
+ Pack the devicemode to store it in a tdb.
+****************************************************************************/
+static int pack_devicemode(struct spoolss_DeviceMode *devmode, uint8 *buf, int buflen)
+{
+        enum ndr_err_code ndr_err;
+        DATA_BLOB blob;
+        int len = 0;
+
+        if (devmode) {
+                ndr_err = ndr_push_struct_blob(&blob, talloc_tos(),
+                                               devmode,
+                                               (ndr_push_flags_fn_t)
+                                               ndr_push_spoolss_DeviceMode);
+                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                        DEBUG(10, ("pack_devicemode: "
+                                   "error encoding spoolss_DeviceMode\n"));
+                        goto done;
+                }
+        } else {
+                ZERO_STRUCT(blob);
+        }
+
+        len = tdb_pack(buf, buflen, "B", blob.length, blob.data);
+
+        if (devmode) {
+                DEBUG(8, ("Packed devicemode [%s]\n", devmode->formname));
+        }
+
+done:
+        return len;
+}
+
+/****************************************************************************
+ Unpack the devicemode to store it in a tdb.
+****************************************************************************/
+static int unpack_devicemode(TALLOC_CTX *mem_ctx,
+                      const uint8 *buf, int buflen,
+                      struct spoolss_DeviceMode **devmode)
+{
+        struct spoolss_DeviceMode *dm;
+        enum ndr_err_code ndr_err;
+        char *data = NULL;
+        int data_len = 0;
+        DATA_BLOB blob;
+        int len = 0;
+
+        *devmode = NULL;
+
+        len = tdb_unpack(buf, buflen, "B", &data_len, &data);
+        if (!data) {
+                return len;
+        }
+
+        dm = talloc_zero(mem_ctx, struct spoolss_DeviceMode);
+        if (!dm) {
+                goto done;
+        }
+
+        blob = data_blob_const(data, data_len);
+
+        ndr_err = ndr_pull_struct_blob(&blob, dm, dm,
+                        (ndr_pull_flags_fn_t)ndr_pull_spoolss_DeviceMode);
+        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                DEBUG(10, ("unpack_devicemode: "
+                           "error parsing spoolss_DeviceMode\n"));
+                goto done;
+        }
+
+        DEBUG(8, ("Unpacked devicemode [%s](%s)\n",
+                  dm->devicename, dm->formname));
+        if (dm->driverextra_data.data) {
+                DEBUG(8, ("with a private section of %d bytes\n",
+                          dm->__driverextra_length));
+        }
+
+        *devmode = dm;
+
+done:
+        SAFE_FREE(data);
+        return len;
+}
+
 /***********************************************************************
  unpack a pjob from a tdb buffer
 ***********************************************************************/
 
-int unpack_pjob( uint8 *buf, int buflen, struct printjob *pjob )
+static int unpack_pjob( uint8 *buf, int buflen, struct printjob *pjob )
 {
         int     len = 0;
@@ -293 +388 @@
                 return -1;
 
-        len += tdb_unpack(buf+len, buflen-len, "dddddddddffff",
+        len += tdb_unpack(buf+len, buflen-len, "dddddddddfffff",
                                 &pjpid,
                                 &pjsysjob,
@@ -306 +401 @@
                                 pjob->jobname,
                                 pjob->user,
+                                pjob->clientmachine,
                                 pjob->queuename);
 
@@ -311 +407 @@
                 return -1;
 
-        if ( (used = unpack_devicemode(&pjob->nt_devmode, buf+len, buflen-len)) == -1 )
+        used = unpack_devicemode(NULL, buf+len, buflen-len, &pjob->devmode);
+        if (used == -1) {
                 return -1;
+        }
 
         len += used;
@@ -356 +454 @@
         }
 
-        if ( pjob.nt_devmode ) {
-                free_nt_devicemode( &pjob.nt_devmode );
-        }
+        talloc_free(pjob.devmode);
 
         ZERO_STRUCT( pjob );
@@ -442 +538 @@
 
 static const struct {
-        uint32 lpq_status;
-        uint32 spoolss_status;
+        uint32_t lpq_status;
+        uint32_t spoolss_status;
 } lpq_to_spoolss_status_map[] = {
         { LPQ_QUEUED, JOB_STATUS_QUEUED },
@@ -456 +552 @@
         { LPQ_BLOCKED, JOB_STATUS_BLOCKED_DEVQ },
         { LPQ_USER_INTERVENTION, JOB_STATUS_USER_INTERVENTION },
-        { -1, 0 }
+        { (uint32_t)-1, 0 }
 };
 
@@ -475 +571 @@
 }
 
-static void pjob_store_notify(const char* sharename, uint32 jobid, struct printjob *old_data,
-                              struct printjob *new_data)
-{
-        bool new_job = False;
-
-        if (!old_data)
-                new_job = True;
-
-        /* Job attributes that can't be changed.  We only send
-           notification for these on a new job. */
+/***************************************************************************
+ Append a jobid to the 'jobs changed' list.
+***************************************************************************/
+
+static bool add_to_jobs_changed(struct tdb_print_db *pdb, uint32_t jobid)
+{
+        TDB_DATA data;
+        uint32_t store_jobid;
+
+        SIVAL(&store_jobid, 0, jobid);
+        data.dptr = (uint8 *) &store_jobid;
+        data.dsize = 4;
+
+        DEBUG(10,("add_to_jobs_added: Added jobid %u\n", (unsigned int)jobid ));
+
+        return (tdb_append(pdb->tdb, string_tdb_data("INFO/jobs_changed"),
+                           data) == 0);
+}
+
+/***************************************************************************
+ Remove a jobid from the 'jobs changed' list.
+***************************************************************************/
+
+static bool remove_from_jobs_changed(const char* sharename, uint32_t jobid)
+{
+        struct tdb_print_db *pdb = get_print_db_byname(sharename);
+        TDB_DATA data, key;
+        size_t job_count, i;
+        bool ret = False;
+        bool gotlock = False;
+
+        if (!pdb) {
+                return False;
+        }
+
+        ZERO_STRUCT(data);
+
+        key = string_tdb_data("INFO/jobs_changed");
+
+        if (tdb_chainlock_with_timeout(pdb->tdb, key, 5) == -1)
+                goto out;
+
+        gotlock = True;
+
+        data = tdb_fetch(pdb->tdb, key);
+
+        if (data.dptr == NULL || data.dsize == 0 || (data.dsize % 4 != 0))
+                goto out;
+
+        job_count = data.dsize / 4;
+        for (i = 0; i < job_count; i++) {
+                uint32 ch_jobid;
+
+                ch_jobid = IVAL(data.dptr, i*4);
+                if (ch_jobid == jobid) {
+                        if (i < job_count -1 )
+                                memmove(data.dptr + (i*4), data.dptr + (i*4) + 4, (job_count - i - 1)*4 );
+                        data.dsize -= 4;
+                        if (tdb_store(pdb->tdb, key, data, TDB_REPLACE) == -1)
+                                goto out;
+                        break;
+                }
+        }
+
+        ret = True;
+  out:
+
+        if (gotlock)
+                tdb_chainunlock(pdb->tdb, key);
+        SAFE_FREE(data.dptr);
+        release_print_db(pdb);
+        if (ret)
+                DEBUG(10,("remove_from_jobs_changed: removed jobid %u\n", (unsigned int)jobid ));
+        else
+                DEBUG(10,("remove_from_jobs_changed: Failed to remove jobid %u\n", (unsigned int)jobid ));
+        return ret;
+}
+
+static void pjob_store_notify(struct tevent_context *ev,
+                              struct messaging_context *msg_ctx,
+                              const char* sharename, uint32 jobid,
+                              struct printjob *old_data,
+                              struct printjob *new_data,
+                              bool *pchanged)
+{
+        bool new_job = false;
+        bool changed = false;
+
+        if (old_data == NULL) {
+                new_job = true;
+        }
 
         /* ACHTUNG!  Due to a bug in Samba's spoolss parsing of the
@@ -494 +671 @@
 
         if (new_job) {
-                notify_job_submitted(sharename, jobid, new_data->starttime);
-                notify_job_username(sharename, jobid, new_data->user);
-        }
-
-        if (new_job || !strequal(old_data->jobname, new_data->jobname))
-                notify_job_name(sharename, jobid, new_data->jobname);
-
-        /* Job attributes of a new job or attributes that can be
-           modified. */
-
-        if (new_job || !strequal(old_data->jobname, new_data->jobname))
-                notify_job_name(sharename, jobid, new_data->jobname);
-
-        if (new_job || old_data->status != new_data->status)
-                notify_job_status(sharename, jobid, map_to_spoolss_status(new_data->status));
-
-        if (new_job || old_data->size != new_data->size)
-                notify_job_total_bytes(sharename, jobid, new_data->size);
-
-        if (new_job || old_data->page_count != new_data->page_count)
-                notify_job_total_pages(sharename, jobid, new_data->page_count);
+                notify_job_submitted(ev, msg_ctx,
+                                     sharename, jobid, new_data->starttime);
+                notify_job_username(ev, msg_ctx,
+                                    sharename, jobid, new_data->user);
+                notify_job_name(ev, msg_ctx,
+                                sharename, jobid, new_data->jobname);
+                notify_job_status(ev, msg_ctx,
+                                  sharename, jobid, map_to_spoolss_status(new_data->status));
+                notify_job_total_bytes(ev, msg_ctx,
+                                       sharename, jobid, new_data->size);
+                notify_job_total_pages(ev, msg_ctx,
+                                       sharename, jobid, new_data->page_count);
+        } else {
+                if (!strequal(old_data->jobname, new_data->jobname)) {
+                        notify_job_name(ev, msg_ctx, sharename,
+                                        jobid, new_data->jobname);
+                        changed = true;
+                }
+
+                if (old_data->status != new_data->status) {
+                        notify_job_status(ev, msg_ctx,
+                                          sharename, jobid,
+                                          map_to_spoolss_status(new_data->status));
+                }
+
+                if (old_data->size != new_data->size) {
+                        notify_job_total_bytes(ev, msg_ctx,
+                                               sharename, jobid, new_data->size);
+                }
+
+                if (old_data->page_count != new_data->page_count) {
+                        notify_job_total_pages(ev, msg_ctx,
+                                               sharename, jobid,
+                                               new_data->page_count);
+                }
+        }
+
+        *pchanged = changed;
 }
 
@@ -521 +715 @@
 ****************************************************************************/
 
-static bool pjob_store(const char* sharename, uint32 jobid, struct printjob *pjob)
+static bool pjob_store(struct tevent_context *ev,
+                       struct messaging_context *msg_ctx,
+                       const char* sharename, uint32 jobid,
+                       struct printjob *pjob)
 {
         uint32_t tmp;
@@ -545 +742 @@
                 len = 0;
                 buflen = newlen;
-                len += tdb_pack(buf+len, buflen-len, "dddddddddffff",
+                len += tdb_pack(buf+len, buflen-len, "dddddddddfffff",
                                 (uint32)pjob->pid,
                                 (uint32)pjob->sysjob,
@@ -558 +755 @@
                                 pjob->jobname,
                                 pjob->user,
+                                pjob->clientmachine,
                                 pjob->queuename);
 
-                len += pack_devicemode(pjob->nt_devmode, buf+len, buflen-len);
+                len += pack_devicemode(pjob->devmode, buf+len, buflen-len);
 
                 if (buflen != len) {
@@ -580 +778 @@
                          TDB_REPLACE) == 0);
 
-        release_print_db(pdb);
-
         /* Send notify updates for what has changed */
 
         if ( ret ) {
+                bool changed = false;
                 struct printjob old_pjob;
 
@@ -591 +788 @@
                         if ( unpack_pjob( old_data.dptr, old_data.dsize, &old_pjob ) != -1 )
                         {
-                                pjob_store_notify( sharename, jobid, &old_pjob , pjob );
-                                free_nt_devicemode( &old_pjob.nt_devmode );
+                                pjob_store_notify(server_event_context(),
+                                                  msg_ctx,
+                                                  sharename, jobid, &old_pjob,
+                                                  pjob,
+                                                  &changed);
+                                talloc_free(old_pjob.devmode);
+
+                                if (changed) {
+                                        add_to_jobs_changed(pdb, jobid);
+                                }
                         }
+
                 }
                 else {
                         /* new job */
-                        pjob_store_notify( sharename, jobid, NULL, pjob );
-                }
-        }
-
+                        pjob_store_notify(server_event_context(), msg_ctx,
+                                          sharename, jobid, NULL, pjob,
+                                          &changed);
+                }
+        }
+
+        release_print_db(pdb);
 done:
         SAFE_FREE( old_data.dptr );
@@ -612 +821 @@
 ****************************************************************************/
 
-void pjob_delete(const char* sharename, uint32 jobid)
+static void pjob_delete(struct tevent_context *ev,
+                        struct messaging_context *msg_ctx,
+                        const char* sharename, uint32 jobid)
 {
         uint32_t tmp;
@@ -638 +849 @@
 
         job_status = JOB_STATUS_DELETING|JOB_STATUS_DELETED;
-        notify_job_status(sharename, jobid, job_status);
+        notify_job_status(ev, msg_ctx, sharename, jobid, job_status);
 
         /* Remove from printing.tdb */
 
         tdb_delete(pdb->tdb, print_key(jobid, &tmp));
-        remove_from_jobs_changed(sharename, jobid);
+        remove_from_jobs_added(sharename, jobid);
         release_print_db( pdb );
         rap_jobid_delete(sharename, jobid);
@@ -652 +863 @@
 ****************************************************************************/
 
-static void print_unix_job(const char *sharename, print_queue_struct *q, uint32 jobid)
+static void print_unix_job(struct tevent_context *ev,
+                           struct messaging_context *msg_ctx,
+                           const char *sharename, print_queue_struct *q,
+                           uint32 jobid)
 {
         struct printjob pj, *old_pj;
@@ -683 +897 @@
         fstrcpy(pj.queuename, old_pj ? old_pj->queuename : sharename );
 
-        pjob_store(sharename, jobid, &pj);
+        pjob_store(ev, msg_ctx, sharename, jobid, &pj);
 }
 
@@ -694 +908 @@
         const char *lprm_command;
         struct printif *print_if;
+        struct tevent_context *ev;
+        struct messaging_context *msg_ctx;
 };
 
@@ -713 +929 @@
         if ( unpack_pjob( data.dptr, data.dsize, &pjob ) == -1 )
                 return 0;
-        free_nt_devicemode( &pjob.nt_devmode );
+        talloc_free(pjob.devmode);
 
 
@@ -727 +943 @@
                         DEBUG(10,("traverse_fn_delete: pjob %u deleted due to !smbjob\n",
                                                 (unsigned int)jobid ));
-                        pjob_delete(ts->sharename, jobid);
+                        pjob_delete(ts->ev, ts->msg_ctx,
+                                    ts->sharename, jobid);
                         return 0;
                 }
@@ -743 +960 @@
                         DEBUG(10,("traverse_fn_delete: pjob %u deleted due to !process_exists (%u)\n",
                                                 (unsigned int)jobid, (unsigned int)pjob.pid ));
-                        pjob_delete(ts->sharename, jobid);
+                        pjob_delete(ts->ev, ts->msg_ctx,
+                                    ts->sharename, jobid);
                 } else
                         ts->total_jobs++;
@@ -773 +991 @@
                                                 /* if we can't delete, then reset the job status */
                                                 pjob.status = LPQ_QUEUED;
-                                                pjob_store(ts->sharename, jobid, &pjob);
+                                                pjob_store(ts->ev, ts->msg_ctx,
+                                                           ts->sharename, jobid, &pjob);
                                         }
                                         else {
                                                 /* if we deleted the job, the remove the tdb record */
-                                                pjob_delete(ts->sharename, jobid);
+                                                pjob_delete(ts->ev,
+                                                            ts->msg_ctx,
+                                                            ts->sharename, jobid);
                                                 pjob.status = LPQ_DELETED;
                                         }
@@ -805 +1026 @@
                                                 (unsigned int)pjob.starttime,
                                                 (unsigned int)ts->lpq_time ));
-                        pjob_delete(ts->sharename, jobid);
+                        pjob_delete(ts->ev, ts->msg_ctx,
+                                    ts->sharename, jobid);
                 } else
                         ts->total_jobs++;
@@ -1002 +1224 @@
 }
 
-static TDB_DATA get_jobs_changed_data(struct tdb_print_db *pdb)
+static TDB_DATA get_jobs_added_data(struct tdb_print_db *pdb)
 {
         TDB_DATA data;
@@ -1008 +1230 @@
         ZERO_STRUCT(data);
 
-        data = tdb_fetch(pdb->tdb, string_tdb_data("INFO/jobs_changed"));
+        data = tdb_fetch(pdb->tdb, string_tdb_data("INFO/jobs_added"));
         if (data.dptr == NULL || data.dsize == 0 || (data.dsize % 4 != 0)) {
                 SAFE_FREE(data.dptr);
@@ -1017 +1239 @@
 }
 
-static void check_job_changed(const char *sharename, TDB_DATA data, uint32 jobid)
+static void check_job_added(const char *sharename, TDB_DATA data, uint32 jobid)
 {
         unsigned int i;
@@ -1027 +1249 @@
                 ch_jobid = IVAL(data.dptr, i*4);
                 if (ch_jobid == jobid)
-                        remove_from_jobs_changed(sharename, jobid);
+                        remove_from_jobs_added(sharename, jobid);
         }
 }
@@ -1097 +1319 @@
 
 /****************************************************************************
- main work for updating the lpq cahe for a printer queue
-****************************************************************************/
-
-static void print_queue_update_internal( const char *sharename,
+ main work for updating the lpq cache for a printer queue
+****************************************************************************/
+
+static void print_queue_update_internal( struct tevent_context *ev,
+                                         struct messaging_context *msg_ctx,
+                                         const char *sharename,
                                          struct printif *current_printif,
                                          char *lpq_command, char *lprm_command )
@@ -1144 +1368 @@
            in hash order. */
 
-        qsort(queue, qcount, sizeof(print_queue_struct),
-                QSORT_CAST(printjob_comp));
+        TYPESAFE_QSORT(queue, qcount, printjob_comp);
 
         /*
@@ -1158 +1381 @@
         */
 
-        jcdata = get_jobs_changed_data(pdb);
+        jcdata = get_jobs_added_data(pdb);
 
         for (i=0; i<qcount; i++) {
@@ -1165 +1388 @@
                 if (jobid == (uint32)-1) {
                         /* assume its a unix print job */
-                        print_unix_job(sharename, &queue[i], jobid);
+                        print_unix_job(ev, msg_ctx,
+                                       sharename, &queue[i], jobid);
                         continue;
                 }
@@ -1175 +1399 @@
                            with jobs in the queue. All we can do is treat them
                            like unix jobs. Pity. */
-                        print_unix_job(sharename, &queue[i], jobid);
+                        print_unix_job(ev, msg_ctx,
+                                       sharename, &queue[i], jobid);
                         continue;
                 }
@@ -1186 +1411 @@
                         pjob->status = queue[i].status;
 
-                pjob_store(sharename, jobid, pjob);
-
-                check_job_changed(sharename, jcdata, jobid);
+                pjob_store(ev, msg_ctx, sharename, jobid, pjob);
+
+                check_job_added(sharename, jcdata, jobid);
         }
 
@@ -1203 +1428 @@
         tstruct.lprm_command = lprm_command;
         tstruct.print_if = current_printif;
+        tstruct.ev = ev;
+        tstruct.msg_ctx = msg_ctx;
 
         tdb_traverse(pdb->tdb, traverse_fn_delete, (void *)&tstruct);
@@ -1260 +1487 @@
 ****************************************************************************/
 
-static void print_queue_update_with_lock( const char *sharename,
+static void print_queue_update_with_lock( struct tevent_context *ev,
+                                          struct messaging_context *msg_ctx,
+                                          const char *sharename,
                                           struct printif *current_printif,
                                           char *lpq_command, char *lprm_command )
@@ -1329 +1558 @@
         /* do the main work now */
 
-        print_queue_update_internal( sharename, current_printif,
-                lpq_command, lprm_command );
+        print_queue_update_internal(ev, msg_ctx,
+                                    sharename, current_printif,
+                                    lpq_command, lprm_command);
 
         /* Delete our pid from the db. */
@@ -1340 +1570 @@
 this is the receive function of the background lpq updater
 ****************************************************************************/
-static void print_queue_receive(struct messaging_context *msg,
+void print_queue_receive(struct messaging_context *msg,
                                 void *private_data,
                                 uint32_t msg_type,
@@ -1364 +1594 @@
         }
 
-        print_queue_update_with_lock(sharename,
+        print_queue_update_with_lock(server_event_context(), msg, sharename,
                 get_printer_fns_from_type((enum printing_types)printing_type),
                 lpqcommand, lprmcommand );
@@ -1385 +1615 @@
 }
 
+extern struct child_pid *children;
+extern int num_children;
+
 static void add_child_pid(pid_t pid)
 {
-        extern struct child_pid *children;
         struct child_pid *child;
-        extern int num_children;
 
         child = SMB_MALLOC_P(struct child_pid);
@@ -1406 +1637 @@
 main thread of the background lpq updater
 ****************************************************************************/
-void start_background_queue(void)
+void start_background_queue(struct tevent_context *ev,
+                            struct messaging_context *msg_ctx)
 {
         /* Use local variables for this as we don't
@@ -1434 +1666 @@
                 struct tevent_fd *fde;
                 int ret;
+                NTSTATUS status;
 
                 /* Child. */
@@ -1441 +1674 @@
                 pause_pipe[0] = -1;
 
-                if (!NT_STATUS_IS_OK(reinit_after_fork(smbd_messaging_context(),
-                                                       smbd_event_context(),
-                                                       true))) {
+                status = reinit_after_fork(msg_ctx, ev, procid_self(), true);
+
+                if (!NT_STATUS_IS_OK(status)) {
                         DEBUG(0,("reinit_after_fork() failed\n"));
                         smb_panic("reinit_after_fork() failed");
@@ -1449 +1682 @@
 
                 smbd_setup_sig_term_handler();
-                smbd_setup_sig_hup_handler();
-
-                claim_connection( NULL, "smbd lpq backend",
-                        FLAG_MSG_GENERAL|FLAG_MSG_SMBD|FLAG_MSG_PRINT_GENERAL);
+                smbd_setup_sig_hup_handler(ev, msg_ctx);
+
+                if (!serverid_register(procid_self(),
+                                       FLAG_MSG_GENERAL|FLAG_MSG_SMBD
+                                       |FLAG_MSG_PRINT_GENERAL)) {
+                        exit(1);
+                }
 
                 if (!locking_init()) {
@@ -1458 +1694 @@
                 }
 
-                messaging_register(smbd_messaging_context(), NULL,
-                                   MSG_PRINTER_UPDATE, print_queue_receive);
-
-                fde = tevent_add_fd(smbd_event_context(), smbd_event_context(),
-                                    pause_pipe[1], TEVENT_FD_READ,
+                messaging_register(msg_ctx, NULL, MSG_PRINTER_UPDATE,
+                                   print_queue_receive);
+
+                fde = tevent_add_fd(ev, ev, pause_pipe[1], TEVENT_FD_READ,
                                     printing_pause_fd_handler,
                                     NULL);
@@ -1471 +1706 @@
 
                 DEBUG(5,("start_background_queue: background LPQ thread waiting for messages\n"));
-                ret = tevent_loop_wait(smbd_event_context());
+                ret = tevent_loop_wait(ev);
                 /* should not be reached */
                 DEBUG(0,("background_queue: tevent_loop_wait() exited with %d - %s\n",
@@ -1485 +1720 @@
 ****************************************************************************/
 
-static void print_queue_update(int snum, bool force)
+static void print_queue_update(struct messaging_context *msg_ctx,
+                               int snum, bool force)
 {
         fstring key;
@@ -1506 +1742 @@
                         lp_lpqcommand(snum),
                         "%p",
-                        PRINTERNAME(snum),
+                        lp_printername(snum),
                         false, false, false);
         if (!lpqcommand) {
@@ -1526 +1762 @@
                         lp_lprmcommand(snum),
                         "%p",
-                        PRINTERNAME(snum),
+                        lp_printername(snum),
                         false, false, false);
         if (!lprmcommand) {
@@ -1551 +1787 @@
                 DEBUG(4,("print_queue_update: updating queue [%s] myself\n", sharename));
                 current_printif = get_printer_fns( snum );
-                print_queue_update_with_lock( sharename, current_printif, lpqcommand, lprmcommand );
+                print_queue_update_with_lock(server_event_context(), msg_ctx,
+                                             sharename, current_printif,
+                                             lpqcommand, lprmcommand);
 
                 return;
@@ -1604 +1842 @@
         /* finally send the message */
 
-        messaging_send_buf(smbd_messaging_context(),
-                           pid_to_procid(background_lpq_updater_pid),
+        messaging_send_buf(msg_ctx, pid_to_procid(background_lpq_updater_pid),
                            MSG_PRINTER_UPDATE, (uint8 *)buffer, len);
 
@@ -1812 +2049 @@
 
 /****************************************************************************
- Give the fd used for a jobid.
-****************************************************************************/
-
-int print_job_fd(const char* sharename, uint32 jobid)
-{
-        struct printjob *pjob = print_job_find(sharename, jobid);
-        if (!pjob)
-                return -1;
-        /* don't allow another process to get this info - it is meaningless */
-        if (pjob->pid != sys_getpid())
-                return -1;
-        return pjob->fd;
-}
-
-/****************************************************************************
  Give the filename used for a jobid.
  Only valid for the process doing the spooling and when the job
@@ -1847 +2069 @@
 ****************************************************************************/
 
-NT_DEVICEMODE *print_job_devmode(const char* sharename, uint32 jobid)
+struct spoolss_DeviceMode *print_job_devmode(const char* sharename, uint32 jobid)
 {
         struct printjob *pjob = print_job_find(sharename, jobid);
@@ -1854 +2076 @@
                 return NULL;
 
-        return pjob->nt_devmode;
-}
-
-/****************************************************************************
- Set the place in the queue for a job.
-****************************************************************************/
-
-bool print_job_set_place(const char *sharename, uint32 jobid, int place)
-{
-        DEBUG(2,("print_job_set_place not implemented yet\n"));
-        return False;
+        return pjob->devmode;
 }
 
@@ -1871 +2083 @@
 ****************************************************************************/
 
-bool print_job_set_name(const char *sharename, uint32 jobid, char *name)
+bool print_job_set_name(struct tevent_context *ev,
+                        struct messaging_context *msg_ctx,
+                        const char *sharename, uint32 jobid, const char *name)
 {
         struct printjob *pjob;
@@ -1880 +2094 @@
 
         fstrcpy(pjob->jobname, name);
-        return pjob_store(sharename, jobid, pjob);
-}
+        return pjob_store(ev, msg_ctx, sharename, jobid, pjob);
+}
+
+/****************************************************************************
+ Get the name of a job. Only possible for owner.
+****************************************************************************/
+
+bool print_job_get_name(TALLOC_CTX *mem_ctx, const char *sharename, uint32_t jobid, char **name)
+{
+        struct printjob *pjob;
+
+        pjob = print_job_find(sharename, jobid);
+        if (!pjob || pjob->pid != sys_getpid()) {
+                return false;
+        }
+
+        *name = talloc_strdup(mem_ctx, pjob->jobname);
+        if (!*name) {
+                return false;
+        }
+
+        return true;
+}
+
 
 /***************************************************************************
- Remove a jobid from the 'jobs changed' list.
+ Remove a jobid from the 'jobs added' list.
 ***************************************************************************/
 
-static bool remove_from_jobs_changed(const char* sharename, uint32 jobid)
+static bool remove_from_jobs_added(const char* sharename, uint32 jobid)
 {
         struct tdb_print_db *pdb = get_print_db_byname(sharename);
@@ -1901 +2137 @@
         ZERO_STRUCT(data);
 
-        key = string_tdb_data("INFO/jobs_changed");
+        key = string_tdb_data("INFO/jobs_added");
 
         if (tdb_chainlock_with_timeout(pdb->tdb, key, 5) == -1)
@@ -1936 +2172 @@
         release_print_db(pdb);
         if (ret)
-                DEBUG(10,("remove_from_jobs_changed: removed jobid %u\n", (unsigned int)jobid ));
+                DEBUG(10,("remove_from_jobs_added: removed jobid %u\n", (unsigned int)jobid ));
         else
-                DEBUG(10,("remove_from_jobs_changed: Failed to remove jobid %u\n", (unsigned int)jobid ));
+                DEBUG(10,("remove_from_jobs_added: Failed to remove jobid %u\n", (unsigned int)jobid ));
         return ret;
 }
@@ -1946 +2182 @@
 ****************************************************************************/
 
-static bool print_job_delete1(int snum, uint32 jobid)
+static bool print_job_delete1(struct tevent_context *ev,
+                              struct messaging_context *msg_ctx,
+                              int snum, uint32 jobid)
 {
         const char* sharename = lp_const_servicename(snum);
@@ -1975 +2213 @@
 
         pjob->status = LPQ_DELETING;
-        pjob_store(sharename, jobid, pjob);
+        pjob_store(ev, msg_ctx, sharename, jobid, pjob);
 
         if (pjob->spooled && pjob->sysjob != -1)
         {
                 result = (*(current_printif->job_delete))(
-                        PRINTERNAME(snum),
+                        lp_printername(snum),
                         lp_lprmcommand(snum),
                         pjob);
@@ -1993 +2231 @@
                         if (!pdb)
                                 return False;
-                        pjob_delete(sharename, jobid);
+                        pjob_delete(ev, msg_ctx, sharename, jobid);
                         /* Ensure we keep a rough count of the number of total jobs... */
                         tdb_change_int32_atomic(pdb->tdb, "INFO/total_jobs", &njobs, -1);
@@ -2000 +2238 @@
         }
 
-        remove_from_jobs_changed( sharename, jobid );
+        remove_from_jobs_added( sharename, jobid );
 
         return (result == 0);
@@ -2009 +2247 @@
 ****************************************************************************/
 
-static bool is_owner(struct auth_serversupplied_info *server_info,
+static bool is_owner(const struct auth_serversupplied_info *server_info,
                      const char *servicename,
                      uint32 jobid)
@@ -2025 +2263 @@
 ****************************************************************************/
 
-bool print_job_delete(struct auth_serversupplied_info *server_info, int snum,
-                      uint32 jobid, WERROR *errcode)
-{
-        const char* sharename = lp_const_servicename( snum );
+WERROR print_job_delete(const struct auth_serversupplied_info *server_info,
+                        struct messaging_context *msg_ctx,
+                        int snum, uint32_t jobid)
+{
+        const char* sharename = lp_const_servicename(snum);
         struct printjob *pjob;
         bool    owner;
         char    *fname;
 
-        *errcode = WERR_OK;
-
         owner = is_owner(server_info, lp_const_servicename(snum), jobid);
 
@@ -2041 +2278 @@
 
         if (!owner &&
-            !print_access_check(server_info, snum, JOB_ACCESS_ADMINISTER)) {
+            !print_access_check(server_info, msg_ctx, snum,
+                                JOB_ACCESS_ADMINISTER)) {
                 DEBUG(3, ("delete denied by security descriptor\n"));
-                *errcode = WERR_ACCESS_DENIED;
 
                 /* BEGIN_ADMIN_LOG */
@@ -2050 +2287 @@
 pause, or resume print job. User name: %s. Printer name: %s.",
                               uidtoname(server_info->utok.uid),
-                              PRINTERNAME(snum) );
+                              lp_printername(snum) );
                 /* END_ADMIN_LOG */
 
-                return False;
+                return WERR_ACCESS_DENIED;
         }
 
@@ -2063 +2300 @@
          */
 
-        if ( (fname = print_job_fname( sharename, jobid )) != NULL )
-        {
+        fname = print_job_fname(sharename, jobid);
+        if (fname != NULL) {
                 /* remove the spool file */
-                DEBUG(10,("print_job_delete: Removing spool file [%s]\n", fname ));
-                if ( unlink( fname ) == -1 ) {
-                        *errcode = map_werror_from_unix(errno);
-                        return False;
-                }
-        }
-
-        if (!print_job_delete1(snum, jobid)) {
-                *errcode = WERR_ACCESS_DENIED;
-                return False;
+                DEBUG(10, ("print_job_delete: "
+                           "Removing spool file [%s]\n", fname));
+                if (unlink(fname) == -1) {
+                        return map_werror_from_unix(errno);
+                }
+        }
+
+        if (!print_job_delete1(server_event_context(), msg_ctx, snum, jobid)) {
+                return WERR_ACCESS_DENIED;
         }
 
@@ -2081 +2317 @@
            job still exists */
 
-        print_queue_update(snum, True);
+        print_queue_update(msg_ctx, snum, True);
 
         pjob = print_job_find(sharename, jobid);
-        if ( pjob && (pjob->status != LPQ_DELETING) )
-                *errcode = WERR_ACCESS_DENIED;
-
-        return (pjob == NULL );
+        if (pjob && (pjob->status != LPQ_DELETING)) {
+                return WERR_ACCESS_DENIED;
+        }
+
+        return WERR_PRINTER_HAS_JOBS_QUEUED;
 }
 
@@ -2094 +2331 @@
 ****************************************************************************/
 
-bool print_job_pause(struct auth_serversupplied_info *server_info, int snum,
-                     uint32 jobid, WERROR *errcode)
+bool print_job_pause(const struct auth_serversupplied_info *server_info,
+                     struct messaging_context *msg_ctx,
+                     int snum, uint32 jobid, WERROR *errcode)
 {
         const char* sharename = lp_const_servicename(snum);
@@ -2117 +2355 @@
 
         if (!is_owner(server_info, lp_const_servicename(snum), jobid) &&
-            !print_access_check(server_info, snum, JOB_ACCESS_ADMINISTER)) {
+            !print_access_check(server_info, msg_ctx, snum,
+                                JOB_ACCESS_ADMINISTER)) {
                 DEBUG(3, ("pause denied by security descriptor\n"));
 
@@ -2125 +2364 @@
 pause, or resume print job. User name: %s. Printer name: %s.",
                               uidtoname(server_info->utok.uid),
-                              PRINTERNAME(snum) );
+                              lp_printername(snum) );
                 /* END_ADMIN_LOG */
 
@@ -2145 +2384 @@
         /* Send a printer notify message */
 
-        notify_job_status(sharename, jobid, JOB_STATUS_PAUSED);
+        notify_job_status(server_event_context(), msg_ctx, sharename, jobid,
+                          JOB_STATUS_PAUSED);
 
         /* how do we tell if this succeeded? */
@@ -2156 +2396 @@
 ****************************************************************************/
 
-bool print_job_resume(struct auth_serversupplied_info *server_info, int snum,
-                      uint32 jobid, WERROR *errcode)
+bool print_job_resume(const struct auth_serversupplied_info *server_info,
+                      struct messaging_context *msg_ctx,
+                      int snum, uint32 jobid, WERROR *errcode)
 {
         const char *sharename = lp_const_servicename(snum);
@@ -2179 +2420 @@
 
         if (!is_owner(server_info, lp_const_servicename(snum), jobid) &&
-            !print_access_check(server_info, snum, JOB_ACCESS_ADMINISTER)) {
+            !print_access_check(server_info, msg_ctx, snum,
+                                JOB_ACCESS_ADMINISTER)) {
                 DEBUG(3, ("resume denied by security descriptor\n"));
                 *errcode = WERR_ACCESS_DENIED;
@@ -2188 +2430 @@
 pause, or resume print job. User name: %s. Printer name: %s.",
                               uidtoname(server_info->utok.uid),
-                              PRINTERNAME(snum) );
+                              lp_printername(snum) );
                 /* END_ADMIN_LOG */
                 return False;
@@ -2205 +2447 @@
         /* Send a printer notify message */
 
-        notify_job_status(sharename, jobid, JOB_STATUS_QUEUED);
+        notify_job_status(server_event_context(), msg_ctx, sharename, jobid,
+                          JOB_STATUS_QUEUED);
 
         return True;
@@ -2214 +2457 @@
 ****************************************************************************/
 
-ssize_t print_job_write(int snum, uint32 jobid, const char *buf, SMB_OFF_T pos, size_t size)
+ssize_t print_job_write(struct tevent_context *ev,
+                        struct messaging_context *msg_ctx,
+                        int snum, uint32 jobid, const char *buf, size_t size)
 {
         const char* sharename = lp_const_servicename(snum);
-        int return_code;
+        ssize_t return_code;
         struct printjob *pjob;
 
@@ -2228 +2473 @@
                 return -1;
 
-        return_code = write_data_at_offset(pjob->fd, buf, size, pos);
+        /* if SMBD is spooling this can't be allowed */
+        if (pjob->status == PJOB_SMBD_SPOOLING) {
+                return -1;
+        }
+
+        return_code = write_data(pjob->fd, buf, size);
 
         if (return_code>0) {
                 pjob->size += size;
-                pjob_store(sharename, jobid, pjob);
+                pjob_store(ev, msg_ctx, sharename, jobid, pjob);
         }
         return return_code;
@@ -2275 +2525 @@
 ****************************************************************************/
 
-int print_queue_length(int snum, print_status_struct *pstatus)
+int print_queue_length(struct messaging_context *msg_ctx, int snum,
+                       print_status_struct *pstatus)
 {
         const char* sharename = lp_const_servicename( snum );
@@ -2285 +2536 @@
         /* make sure the database is up to date */
         if (print_cache_expired(lp_const_servicename(snum), True))
-                print_queue_update(snum, False);
+                print_queue_update(msg_ctx, snum, False);
 
         /* also fetch the queue status */
@@ -2301 +2552 @@
 ***************************************************************************/
 
-static bool allocate_print_jobid(struct tdb_print_db *pdb, int snum, const char *sharename, uint32 *pjobid)
+static WERROR allocate_print_jobid(struct tdb_print_db *pdb, int snum,
+                                   const char *sharename, uint32 *pjobid)
 {
         int i;
         uint32 jobid;
+        enum TDB_ERROR terr;
+        int ret;
 
         *pjobid = (uint32)-1;
@@ -2310 +2564 @@
         for (i = 0; i < 3; i++) {
                 /* Lock the database - only wait 20 seconds. */
-                if (tdb_lock_bystring_with_timeout(pdb->tdb, "INFO/nextjob", 20) == -1) {
-                        DEBUG(0,("allocate_print_jobid: failed to lock printing database %s\n", sharename));
-                        return False;
+                ret = tdb_lock_bystring_with_timeout(pdb->tdb,
+                                                     "INFO/nextjob", 20);
+                if (ret == -1) {
+                        DEBUG(0, ("allocate_print_jobid: "
+                                  "Failed to lock printing database %s\n",
+                                  sharename));
+                        terr = tdb_error(pdb->tdb);
+                        return ntstatus_to_werror(map_nt_error_from_tdb(terr));
                 }
 
                 if (!tdb_fetch_uint32(pdb->tdb, "INFO/nextjob", &jobid)) {
-                        if (tdb_error(pdb->tdb) != TDB_ERR_NOEXIST) {
-                                DEBUG(0, ("allocate_print_jobid: failed to fetch INFO/nextjob for print queue %s\n",
-                                        sharename));
+                        terr = tdb_error(pdb->tdb);
+                        if (terr != TDB_ERR_NOEXIST) {
+                                DEBUG(0, ("allocate_print_jobid: "
+                                          "Failed to fetch INFO/nextjob "
+                                          "for print queue %s\n", sharename));
                                 tdb_unlock_bystring(pdb->tdb, "INFO/nextjob");
-                                return False;
+                                return ntstatus_to_werror(map_nt_error_from_tdb(terr));
                         }
-                        DEBUG(10,("allocate_print_jobid: no existing jobid in %s\n", sharename));
+                        DEBUG(10, ("allocate_print_jobid: "
+                                   "No existing jobid in %s\n", sharename));
                         jobid = 0;
                 }
 
-                DEBUG(10,("allocate_print_jobid: read jobid %u from %s\n", jobid, sharename));
+                DEBUG(10, ("allocate_print_jobid: "
+                           "Read jobid %u from %s\n", jobid, sharename));
 
                 jobid = NEXT_JOBID(jobid);
 
-                if (tdb_store_int32(pdb->tdb, "INFO/nextjob", jobid)==-1) {
-                        DEBUG(3, ("allocate_print_jobid: failed to store INFO/nextjob.\n"));
+                ret = tdb_store_int32(pdb->tdb, "INFO/nextjob", jobid);
+                if (ret == -1) {
+                        terr = tdb_error(pdb->tdb);
+                        DEBUG(3, ("allocate_print_jobid: "
+                                  "Failed to store INFO/nextjob.\n"));
                         tdb_unlock_bystring(pdb->tdb, "INFO/nextjob");
-                        return False;
+                        return ntstatus_to_werror(map_nt_error_from_tdb(terr));
                 }
 
@@ -2342 +2608 @@
                         break;
                 }
-                DEBUG(10,("allocate_print_jobid: found jobid %u in %s\n", jobid, sharename));
+                DEBUG(10, ("allocate_print_jobid: "
+                           "Found jobid %u in %s\n", jobid, sharename));
         }
 
         if (i > 2) {
-                DEBUG(0, ("allocate_print_jobid: failed to allocate a print job for queue %s\n",
-                        sharename));
+                DEBUG(0, ("allocate_print_jobid: "
+                          "Failed to allocate a print job for queue %s\n",
+                          sharename));
                 /* Probably full... */
-                errno = ENOSPC;
-                return False;
+                return WERR_NO_SPOOL_SPACE;
         }
 
@@ -2361 +2628 @@
                 if (tdb_store(pdb->tdb, print_key(jobid, &tmp), dum,
                               TDB_INSERT) == -1) {
-                        DEBUG(3, ("allocate_print_jobid: jobid (%d) failed to store placeholder.\n",
-                                jobid ));
-                        return False;
+                        DEBUG(3, ("allocate_print_jobid: "
+                                  "jobid (%d) failed to store placeholder.\n",
+                                  jobid ));
+                        terr = tdb_error(pdb->tdb);
+                        return ntstatus_to_werror(map_nt_error_from_tdb(terr));
                 }
         }
 
         *pjobid = jobid;
-        return True;
+        return WERR_OK;
 }
 
 /***************************************************************************
- Append a jobid to the 'jobs changed' list.
+ Append a jobid to the 'jobs added' list.
 ***************************************************************************/
 
-static bool add_to_jobs_changed(struct tdb_print_db *pdb, uint32 jobid)
+static bool add_to_jobs_added(struct tdb_print_db *pdb, uint32 jobid)
 {
         TDB_DATA data;
@@ -2384 +2653 @@
         data.dsize = 4;
 
-        DEBUG(10,("add_to_jobs_changed: Added jobid %u\n", (unsigned int)jobid ));
-
-        return (tdb_append(pdb->tdb, string_tdb_data("INFO/jobs_changed"),
+        DEBUG(10,("add_to_jobs_added: Added jobid %u\n", (unsigned int)jobid ));
+
+        return (tdb_append(pdb->tdb, string_tdb_data("INFO/jobs_added"),
                            data) == 0);
+}
+
+
+/***************************************************************************
+ Do all checks needed to determine if we can start a job.
+***************************************************************************/
+
+static WERROR print_job_checks(const struct auth_serversupplied_info *server_info,
+                               struct messaging_context *msg_ctx,
+                               int snum, int *njobs)
+{
+        const char *sharename = lp_const_servicename(snum);
+        uint64_t dspace, dsize;
+        uint64_t minspace;
+        int ret;
+
+        if (!print_access_check(server_info, msg_ctx, snum,
+                                PRINTER_ACCESS_USE)) {
+                DEBUG(3, ("print_job_checks: "
+                          "job start denied by security descriptor\n"));
+                return WERR_ACCESS_DENIED;
+        }
+
+        if (!print_time_access_check(server_info, msg_ctx, sharename)) {
+                DEBUG(3, ("print_job_checks: "
+                          "job start denied by time check\n"));
+                return WERR_ACCESS_DENIED;
+        }
+
+        /* see if we have sufficient disk space */
+        if (lp_minprintspace(snum)) {
+                minspace = lp_minprintspace(snum);
+                ret = sys_fsusage(lp_pathname(snum), &dspace, &dsize);
+                if (ret == 0 && dspace < 2*minspace) {
+                        DEBUG(3, ("print_job_checks: "
+                                  "disk space check failed.\n"));
+                        return WERR_NO_SPOOL_SPACE;
+                }
+        }
+
+        /* for autoloaded printers, check that the printcap entry still exists */
+        if (lp_autoloaded(snum) && !pcap_printername_ok(sharename)) {
+                DEBUG(3, ("print_job_checks: printer name %s check failed.\n",
+                          sharename));
+                return WERR_ACCESS_DENIED;
+        }
+
+        /* Insure the maximum queue size is not violated */
+        *njobs = print_queue_length(msg_ctx, snum, NULL);
+        if (*njobs > lp_maxprintjobs(snum)) {
+                DEBUG(3, ("print_job_checks: Queue %s number of jobs (%d) "
+                          "larger than max printjobs per queue (%d).\n",
+                          sharename, *njobs, lp_maxprintjobs(snum)));
+                return WERR_NO_SPOOL_SPACE;
+        }
+
+        return WERR_OK;
+}
+
+/***************************************************************************
+ Create a job file.
+***************************************************************************/
+
+static WERROR print_job_spool_file(int snum, uint32_t jobid,
+                                   const char *output_file,
+                                   struct printjob *pjob)
+{
+        WERROR werr;
+        SMB_STRUCT_STAT st;
+        const char *path;
+        int len;
+
+        /* if this file is within the printer path, it means that smbd
+         * is spooling it and will pass us control when it is finished.
+         * Verify that the file name is ok, within path, and it is
+         * already already there */
+        if (output_file) {
+                path = lp_pathname(snum);
+                len = strlen(path);
+                if (strncmp(output_file, path, len) == 0 &&
+                    (output_file[len - 1] == '/' || output_file[len] == '/')) {
+
+                        /* verify path is not too long */
+                        if (strlen(output_file) >= sizeof(pjob->filename)) {
+                                return WERR_INVALID_NAME;
+                        }
+
+                        /* verify that the file exists */
+                        if (sys_stat(output_file, &st, false) != 0) {
+                                return WERR_INVALID_NAME;
+                        }
+
+                        fstrcpy(pjob->filename, output_file);
+
+                        DEBUG(3, ("print_job_spool_file:"
+                                  "External spooling activated"));
+
+                        /* we do not open the file until spooling is done */
+                        pjob->fd = -1;
+                        pjob->status = PJOB_SMBD_SPOOLING;
+
+                        return WERR_OK;
+                }
+        }
+
+        slprintf(pjob->filename, sizeof(pjob->filename)-1,
+                 "%s/%s%.8u.XXXXXX", lp_pathname(snum),
+                 PRINT_SPOOL_PREFIX, (unsigned int)jobid);
+        pjob->fd = mkstemp(pjob->filename);
+
+        if (pjob->fd == -1) {
+                werr = map_werror_from_unix(errno);
+                if (W_ERROR_EQUAL(werr, WERR_ACCESS_DENIED)) {
+                        /* Common setup error, force a report. */
+                        DEBUG(0, ("print_job_spool_file: "
+                                  "insufficient permissions to open spool "
+                                  "file %s.\n", pjob->filename));
+                } else {
+                        /* Normal case, report at level 3 and above. */
+                        DEBUG(3, ("print_job_spool_file: "
+                                  "can't open spool file %s\n",
+                                  pjob->filename));
+                }
+                return werr;
+        }
+
+        return WERR_OK;
 }
 
@@ -2394 +2790 @@
 ***************************************************************************/
 
-uint32 print_job_start(struct auth_serversupplied_info *server_info, int snum,
-                       const char *jobname, NT_DEVICEMODE *nt_devmode )
-{
-        uint32 jobid;
+WERROR print_job_start(const struct auth_serversupplied_info *server_info,
+                       struct messaging_context *msg_ctx,
+                       const char *clientmachine,
+                       int snum, const char *docname, const char *filename,
+                       struct spoolss_DeviceMode *devmode, uint32_t *_jobid)
+{
+        uint32_t jobid;
         char *path;
         struct printjob pjob;
@@ -2403 +2802 @@
         struct tdb_print_db *pdb = get_print_db_byname(sharename);
         int njobs;
-
-        errno = 0;
-
-        if (!pdb)
-                return (uint32)-1;
-
-        if (!print_access_check(server_info, snum, PRINTER_ACCESS_USE)) {
-                DEBUG(3, ("print_job_start: job start denied by security descriptor\n"));
+        WERROR werr;
+
+        if (!pdb) {
+                return WERR_INTERNAL_DB_CORRUPTION;
+        }
+
+        path = lp_pathname(snum);
+
+        werr = print_job_checks(server_info, msg_ctx, snum, &njobs);
+        if (!W_ERROR_IS_OK(werr)) {
                 release_print_db(pdb);
-                return (uint32)-1;
-        }
-
-        if (!print_time_access_check(lp_servicename(snum))) {
-                DEBUG(3, ("print_job_start: job start denied by time check\n"));
-                release_print_db(pdb);
-                return (uint32)-1;
-        }
-
-        path = lp_pathname(snum);
-
-        /* see if we have sufficient disk space */
-        if (lp_minprintspace(snum)) {
-                uint64_t dspace, dsize;
-                if (sys_fsusage(path, &dspace, &dsize) == 0 &&
-                    dspace < 2*(uint64_t)lp_minprintspace(snum)) {
-                        DEBUG(3, ("print_job_start: disk space check failed.\n"));
-                        release_print_db(pdb);
-                        errno = ENOSPC;
-                        return (uint32)-1;
-                }
-        }
-
-        /* for autoloaded printers, check that the printcap entry still exists */
-        if (lp_autoloaded(snum) && !pcap_printername_ok(lp_const_servicename(snum))) {
-                DEBUG(3, ("print_job_start: printer name %s check failed.\n", lp_const_servicename(snum) ));
-                release_print_db(pdb);
-                errno = ENOENT;
-                return (uint32)-1;
-        }
-
-        /* Insure the maximum queue size is not violated */
-        if ((njobs = print_queue_length(snum,NULL)) > lp_maxprintjobs(snum)) {
-                DEBUG(3, ("print_job_start: Queue %s number of jobs (%d) larger than max printjobs per queue (%d).\n",
-                        sharename, njobs, lp_maxprintjobs(snum) ));
-                release_print_db(pdb);
-                errno = ENOSPC;
-                return (uint32)-1;
-        }
-
-        DEBUG(10,("print_job_start: Queue %s number of jobs (%d), max printjobs = %d\n",
-                sharename, njobs, lp_maxprintjobs(snum) ));
-
-        if (!allocate_print_jobid(pdb, snum, sharename, &jobid))
+                return werr;
+        }
+
+        DEBUG(10, ("print_job_start: "
+                   "Queue %s number of jobs (%d), max printjobs = %d\n",
+                   sharename, njobs, lp_maxprintjobs(snum)));
+
+        werr = allocate_print_jobid(pdb, snum, sharename, &jobid);
+        if (!W_ERROR_IS_OK(werr)) {
                 goto fail;
+        }
 
         /* create the database entry */
@@ -2470 +2837 @@
         pjob.spooled = False;
         pjob.smbjob = True;
-        pjob.nt_devmode = nt_devmode;
-
-        fstrcpy(pjob.jobname, jobname);
+        pjob.devmode = devmode;
+
+        fstrcpy(pjob.jobname, docname);
+
+        fstrcpy(pjob.clientmachine, clientmachine);
 
         fstrcpy(pjob.user, lp_printjob_username(snum));
@@ -2478 +2847 @@
                               path, server_info->utok.gid,
                               server_info->sanitized_username,
-                              pdb_get_domain(server_info->sam_account),
+                              server_info->info3->base.domain.string,
                               pjob.user, sizeof(pjob.user)-1);
         /* ensure NULL termination */
@@ -2486 +2855 @@
 
         /* we have a job entry - now create the spool file */
-        slprintf(pjob.filename, sizeof(pjob.filename)-1, "%s/%s%.8u.XXXXXX",
-                 path, PRINT_SPOOL_PREFIX, (unsigned int)jobid);
-        pjob.fd = mkstemp(pjob.filename);
-
-        if (pjob.fd == -1) {
-                if (errno == EACCES) {
-                        /* Common setup error, force a report. */
-                        DEBUG(0, ("print_job_start: insufficient permissions \
-to open spool file %s.\n", pjob.filename));
-                } else {
-                        /* Normal case, report at level 3 and above. */
-                        DEBUG(3, ("print_job_start: can't open spool file %s,\n", pjob.filename));
-                        DEBUGADD(3, ("errno = %d (%s).\n", errno, strerror(errno)));
-                }
+        werr = print_job_spool_file(snum, jobid, filename, &pjob);
+        if (!W_ERROR_IS_OK(werr)) {
                 goto fail;
         }
 
-        pjob_store(sharename, jobid, &pjob);
-
-        /* Update the 'jobs changed' entry used by print_queue_status. */
-        add_to_jobs_changed(pdb, jobid);
+        pjob_store(server_event_context(), msg_ctx, sharename, jobid, &pjob);
+
+        /* Update the 'jobs added' entry used by print_queue_status. */
+        add_to_jobs_added(pdb, jobid);
 
         /* Ensure we keep a rough count of the number of total jobs... */
@@ -2513 +2870 @@
         release_print_db(pdb);
 
-        return jobid;
-
- fail:
-        if (jobid != -1)
-                pjob_delete(sharename, jobid);
+        *_jobid = jobid;
+        return WERR_OK;
+
+fail:
+        if (jobid != -1) {
+                pjob_delete(server_event_context(), msg_ctx, sharename, jobid);
+        }
 
         release_print_db(pdb);
 
-        DEBUG(3, ("print_job_start: returning fail. Error = %s\n", strerror(errno) ));
-        return (uint32)-1;
+        DEBUG(3, ("print_job_start: returning fail. "
+                  "Error = %s\n", win_errstr(werr)));
+        return werr;
 }
 
@@ -2529 +2889 @@
 ****************************************************************************/
 
-void print_job_endpage(int snum, uint32 jobid)
+void print_job_endpage(struct messaging_context *msg_ctx,
+                       int snum, uint32 jobid)
 {
         const char* sharename = lp_const_servicename(snum);
@@ -2542 +2903 @@
 
         pjob->page_count++;
-        pjob_store(sharename, jobid, pjob);
+        pjob_store(server_event_context(), msg_ctx, sharename, jobid, pjob);
 }
 
@@ -2551 +2912 @@
 ****************************************************************************/
 
-bool print_job_end(int snum, uint32 jobid, enum file_close_type close_type)
+NTSTATUS print_job_end(struct messaging_context *msg_ctx, int snum,
+                       uint32 jobid, enum file_close_type close_type)
 {
         const char* sharename = lp_const_servicename(snum);
@@ -2558 +2920 @@
         SMB_STRUCT_STAT sbuf;
         struct printif *current_printif = get_printer_fns( snum );
+        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
 
         pjob = print_job_find(sharename, jobid);
 
-        if (!pjob)
-                return False;
-
-        if (pjob->spooled || pjob->pid != sys_getpid())
-                return False;
-
-        if ((close_type == NORMAL_CLOSE || close_type == SHUTDOWN_CLOSE) &&
-            (sys_fstat(pjob->fd, &sbuf, false) == 0)) {
+        if (!pjob) {
+                return NT_STATUS_PRINT_CANCELLED;
+        }
+
+        if (pjob->spooled || pjob->pid != sys_getpid()) {
+                return NT_STATUS_ACCESS_DENIED;
+        }
+
+        if (close_type == NORMAL_CLOSE || close_type == SHUTDOWN_CLOSE) {
+                if (pjob->status == PJOB_SMBD_SPOOLING) {
+                        /* take over the file now, smbd is done */
+                        if (sys_stat(pjob->filename, &sbuf, false) != 0) {
+                                status = map_nt_error_from_unix(errno);
+                                DEBUG(3, ("print_job_end: "
+                                          "stat file failed for jobid %d\n",
+                                          jobid));
+                                goto fail;
+                        }
+
+                        pjob->status = LPQ_SPOOLING;
+
+                } else {
+
+                        if ((sys_fstat(pjob->fd, &sbuf, false) != 0)) {
+                                status = map_nt_error_from_unix(errno);
+                                close(pjob->fd);
+                                DEBUG(3, ("print_job_end: "
+                                          "stat file failed for jobid %d\n",
+                                          jobid));
+                                goto fail;
+                        }
+
+                        close(pjob->fd);
+                }
+
                 pjob->size = sbuf.st_ex_size;
-                close(pjob->fd);
-                pjob->fd = -1;
         } else {
 
                 /*
-                 * Not a normal close or we couldn't stat the job file,
-                 * so something has gone wrong. Cleanup.
+                 * Not a normal close, something has gone wrong. Cleanup.
                  */
-                close(pjob->fd);
-                pjob->fd = -1;
-                DEBUG(3,("print_job_end: failed to stat file for jobid %d\n", jobid ));
+                if (pjob->fd != -1) {
+                        close(pjob->fd);
+                }
                 goto fail;
         }
@@ -2592 +2979 @@
                         pjob->filename, pjob->size ? "deleted" : "zero length" ));
                 unlink(pjob->filename);
-                pjob_delete(sharename, jobid);
-                return True;
+                pjob_delete(server_event_context(), msg_ctx, sharename, jobid);
+                return NT_STATUS_OK;
         }
 
         ret = (*(current_printif->job_submit))(snum, pjob);
 
-        if (ret)
+        if (ret) {
+                status = NT_STATUS_PRINT_CANCELLED;
                 goto fail;
+        }
 
         /* The print job has been successfully handed over to the back-end */
@@ -2605 +2994 @@
         pjob->spooled = True;
         pjob->status = LPQ_QUEUED;
-        pjob_store(sharename, jobid, pjob);
+        pjob_store(server_event_context(), msg_ctx, sharename, jobid, pjob);
 
         /* make sure the database is up to date */
         if (print_cache_expired(lp_const_servicename(snum), True))
-                print_queue_update(snum, False);
-
-        return True;
+                print_queue_update(msg_ctx, snum, False);
+
+        return NT_STATUS_OK;
 
 fail:
@@ -2617 +3006 @@
         /* The print job was not successfully started. Cleanup */
         /* Still need to add proper error return propagation! 010122:JRR */
+        pjob->fd = -1;
         unlink(pjob->filename);
-        pjob_delete(sharename, jobid);
-        return False;
+        pjob_delete(server_event_context(), msg_ctx, sharename, jobid);
+        return status;
 }
 
@@ -2626 +3016 @@
 ****************************************************************************/
 
-static bool get_stored_queue_info(struct tdb_print_db *pdb, int snum, int *pcount, print_queue_struct **ppqueue)
-{
-        TDB_DATA data, cgdata;
+static bool get_stored_queue_info(struct messaging_context *msg_ctx,
+                                  struct tdb_print_db *pdb, int snum,
+                                  int *pcount, print_queue_struct **ppqueue)
+{
+        TDB_DATA data, cgdata, jcdata;
         print_queue_struct *queue = NULL;
         uint32 qcount = 0;
         uint32 extra_count = 0;
+        uint32_t changed_count = 0;
         int total_count = 0;
         size_t len = 0;
@@ -2641 +3034 @@
         /* make sure the database is up to date */
         if (print_cache_expired(lp_const_servicename(snum), True))
-                print_queue_update(snum, False);
+                print_queue_update(msg_ctx, snum, False);
 
         *pcount = 0;
@@ -2655 +3048 @@
                 len += tdb_unpack(data.dptr + len, data.dsize - len, "d", &qcount);
 
-        /* Get the changed jobs list. */
-        cgdata = tdb_fetch(pdb->tdb, string_tdb_data("INFO/jobs_changed"));
+        /* Get the added jobs list. */
+        cgdata = tdb_fetch(pdb->tdb, string_tdb_data("INFO/jobs_added"));
         if (cgdata.dptr != NULL && (cgdata.dsize % 4 == 0))
                 extra_count = cgdata.dsize/4;
+
+        /* Get the changed jobs list. */
+        jcdata = tdb_fetch(pdb->tdb, string_tdb_data("INFO/jobs_changed"));
+        if (jcdata.dptr != NULL && (jcdata.dsize % 4 == 0))
+                changed_count = jcdata.dsize / 4;
 
         DEBUG(5,("get_stored_queue_info: qcount = %u, extra_count = %u\n", (unsigned int)qcount, (unsigned int)extra_count));
@@ -2692 +3090 @@
         total_count = qcount;
 
-        /* Add in the changed jobids. */
+        /* Add new jobids to the queue. */
         for( i  = 0; i < extra_count; i++) {
                 uint32 jobid;
@@ -2698 +3096 @@
 
                 jobid = IVAL(cgdata.dptr, i*4);
-                DEBUG(5,("get_stored_queue_info: changed job = %u\n", (unsigned int)jobid));
+                DEBUG(5,("get_stored_queue_info: added job = %u\n", (unsigned int)jobid));
                 pjob = print_job_find(lp_const_servicename(snum), jobid);
                 if (!pjob) {
-                        DEBUG(5,("get_stored_queue_info: failed to find changed job = %u\n", (unsigned int)jobid));
-                        remove_from_jobs_changed(sharename, jobid);
+                        DEBUG(5,("get_stored_queue_info: failed to find added job = %u\n", (unsigned int)jobid));
+                        remove_from_jobs_added(sharename, jobid);
                         continue;
                 }
@@ -2717 +3115 @@
         }
 
+        /* Update the changed jobids. */
+        for (i = 0; i < changed_count; i++) {
+                uint32_t jobid = IVAL(jcdata.dptr, i * 4);
+                uint32_t j;
+                bool found = false;
+
+                for (j = 0; j < total_count; j++) {
+                        if (queue[j].job == jobid) {
+                                found = true;
+                                break;
+                        }
+                }
+
+                if (found) {
+                        struct printjob *pjob;
+
+                        DEBUG(5,("get_stored_queue_info: changed job: %u\n",
+                                 (unsigned int) jobid));
+
+                        pjob = print_job_find(sharename, jobid);
+                        if (pjob == NULL) {
+                                DEBUG(5,("get_stored_queue_info: failed to find "
+                                         "changed job = %u\n",
+                                         (unsigned int) jobid));
+                                remove_from_jobs_changed(sharename, jobid);
+                                continue;
+                        }
+
+                        queue[j].job = jobid;
+                        queue[j].size = pjob->size;
+                        queue[j].page_count = pjob->page_count;
+                        queue[j].status = pjob->status;
+                        queue[j].priority = 1;
+                        queue[j].time = pjob->starttime;
+                        fstrcpy(queue[j].fs_user, pjob->user);
+                        fstrcpy(queue[j].fs_file, pjob->jobname);
+
+                        DEBUG(5,("get_stored_queue_info: updated queue[%u], jobid: %u, jobname: %s\n",
+                                 (unsigned int) j, (unsigned int) jobid, pjob->jobname));
+                }
+
+                remove_from_jobs_changed(sharename, jobid);
+        }
+
         /* Sort the queue by submission time otherwise they are displayed
            in hash order. */
 
-        qsort(queue, total_count, sizeof(print_queue_struct), QSORT_CAST(printjob_comp));
+        TYPESAFE_QSORT(queue, total_count, printjob_comp);
 
         DEBUG(5,("get_stored_queue_info: total_count = %u\n", (unsigned int)total_count));
@@ -2744 +3186 @@
 ****************************************************************************/
 
-int print_queue_status(int snum,
+int print_queue_status(struct messaging_context *msg_ctx, int snum,
                        print_queue_struct **ppqueue,
                        print_status_struct *status)
@@ -2757 +3199 @@
 
         if (print_cache_expired(lp_const_servicename(snum), True))
-                print_queue_update(snum, False);
+                print_queue_update(msg_ctx, snum, False);
 
         /* return if we are done */
@@ -2794 +3236 @@
          */
 
-        if (!get_stored_queue_info(pdb, snum, &count, ppqueue)) {
+        if (!get_stored_queue_info(msg_ctx, pdb, snum, &count, ppqueue)) {
                 release_print_db(pdb);
                 return 0;
@@ -2807 +3249 @@
 ****************************************************************************/
 
-WERROR print_queue_pause(struct auth_serversupplied_info *server_info, int snum)
+WERROR print_queue_pause(const struct auth_serversupplied_info *server_info,
+                         struct messaging_context *msg_ctx, int snum)
 {
         int ret;
         struct printif *current_printif = get_printer_fns( snum );
 
-        if (!print_access_check(server_info, snum,
+        if (!print_access_check(server_info, msg_ctx, snum,
                                 PRINTER_ACCESS_ADMINISTER)) {
                 return WERR_ACCESS_DENIED;
@@ -2833 +3276 @@
         /* Send a printer notify message */
 
-        notify_printer_status(snum, PRINTER_STATUS_PAUSED);
+        notify_printer_status(server_event_context(), msg_ctx, snum,
+                              PRINTER_STATUS_PAUSED);
 
         return WERR_OK;
@@ -2842 +3286 @@
 ****************************************************************************/
 
-WERROR print_queue_resume(struct auth_serversupplied_info *server_info, int snum)
+WERROR print_queue_resume(const struct auth_serversupplied_info *server_info,
+                          struct messaging_context *msg_ctx, int snum)
 {
         int ret;
         struct printif *current_printif = get_printer_fns( snum );
 
-        if (!print_access_check(server_info, snum,
+        if (!print_access_check(server_info, msg_ctx, snum,
                                 PRINTER_ACCESS_ADMINISTER)) {
                 return WERR_ACCESS_DENIED;
@@ -2864 +3309 @@
         /* make sure the database is up to date */
         if (print_cache_expired(lp_const_servicename(snum), True))
-                print_queue_update(snum, True);
+                print_queue_update(msg_ctx, snum, True);
 
         /* Send a printer notify message */
 
-        notify_printer_status(snum, PRINTER_STATUS_OK);
+        notify_printer_status(server_event_context(), msg_ctx, snum,
+                              PRINTER_STATUS_OK);
 
         return WERR_OK;
@@ -2877 +3323 @@
 ****************************************************************************/
 
-WERROR print_queue_purge(struct auth_serversupplied_info *server_info, int snum)
+WERROR print_queue_purge(const struct auth_serversupplied_info *server_info,
+                         struct messaging_context *msg_ctx, int snum)
 {
         print_queue_struct *queue;
@@ -2885 +3332 @@
 
         /* Force and update so the count is accurate (i.e. not a cached count) */
-        print_queue_update(snum, True);
-
-        can_job_admin = print_access_check(server_info, snum,
+        print_queue_update(msg_ctx, snum, True);
+
+        can_job_admin = print_access_check(server_info,
+                                           msg_ctx,
+                                           snum,
                                            JOB_ACCESS_ADMINISTER);
-        njobs = print_queue_status(snum, &queue, &status);
+        njobs = print_queue_status(msg_ctx, snum, &queue, &status);
 
         if ( can_job_admin )
@@ -2899 +3348 @@
 
                 if (owner || can_job_admin) {
-                        print_job_delete1(snum, queue[i].job);
+                        print_job_delete1(server_event_context(), msg_ctx,
+                                          snum, queue[i].job);
                 }
         }
@@ -2907 +3357 @@
 
         /* update the cache */
-        print_queue_update( snum, True );
+        print_queue_update(msg_ctx, snum, True);
 
         SAFE_FREE(queue);

trunk/server/source3/printing/printing_db.c

@@ -21 +21 @@
 
 #include "includes.h"
+#include "system/filesys.h"
 #include "printing.h"
+#include "util_tdb.h"
 
 static struct tdb_print_db *print_db_head;
@@ -99 +101 @@
         }
 
-        if (geteuid() != 0) {
+        if (geteuid() != sec_initial_uid()) {
                 become_root();
                 done_become_root = True;
@@ -159 +161 @@
 ****************************************************************************/
 
-TDB_DATA get_printer_notify_pid_list(TDB_CONTEXT *tdb, const char *printer_name, bool cleanlist)
+struct TDB_DATA get_printer_notify_pid_list(struct tdb_context *tdb, const char *printer_name, bool cleanlist)
 {
         TDB_DATA data;

trunk/server/source3/printing/tests/vlp.c

@@ -21 +21 @@
 
 #include "includes.h"
+#include "system/passwd.h"
+#include "system/filesys.h"
+#include "printing.h"
+#include "util_tdb.h"
 
 #ifdef malloc