1 | /*
|
---|
2 | Unix SMB/CIFS implementation.
|
---|
3 |
|
---|
4 | open benchmark
|
---|
5 |
|
---|
6 | Copyright (C) Andrew Tridgell 2007
|
---|
7 |
|
---|
8 | This program is free software; you can redistribute it and/or modify
|
---|
9 | it under the terms of the GNU General Public License as published by
|
---|
10 | the Free Software Foundation; either version 3 of the License, or
|
---|
11 | (at your option) any later version.
|
---|
12 |
|
---|
13 | This program is distributed in the hope that it will be useful,
|
---|
14 | but WITHOUT ANY WARRANTY; without even the implied warranty of
|
---|
15 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
---|
16 | GNU General Public License for more details.
|
---|
17 |
|
---|
18 | You should have received a copy of the GNU General Public License
|
---|
19 | along with this program. If not, see <http://www.gnu.org/licenses/>.
|
---|
20 | */
|
---|
21 |
|
---|
22 | #include "includes.h"
|
---|
23 | #include "torture/torture.h"
|
---|
24 | #include "libcli/raw/libcliraw.h"
|
---|
25 | #include "libcli/raw/raw_proto.h"
|
---|
26 | #include "system/time.h"
|
---|
27 | #include "system/filesys.h"
|
---|
28 | #include "libcli/libcli.h"
|
---|
29 | #include "torture/util.h"
|
---|
30 | #include "lib/events/events.h"
|
---|
31 | #include "lib/cmdline/popt_common.h"
|
---|
32 | #include "libcli/composite/composite.h"
|
---|
33 | #include "libcli/smb_composite/smb_composite.h"
|
---|
34 | #include "libcli/resolve/resolve.h"
|
---|
35 | #include "param/param.h"
|
---|
36 |
|
---|
37 | #define BASEDIR "\\benchopen"
|
---|
38 |
|
---|
39 | static int nprocs;
|
---|
40 | static int open_failed;
|
---|
41 | static int close_failed;
|
---|
42 | static char **fnames;
|
---|
43 | static int num_connected;
|
---|
44 | static struct tevent_timer *report_te;
|
---|
45 |
|
---|
46 | struct benchopen_state {
|
---|
47 | struct torture_context *tctx;
|
---|
48 | TALLOC_CTX *mem_ctx;
|
---|
49 | struct tevent_context *ev;
|
---|
50 | struct smbcli_state *cli;
|
---|
51 | struct smbcli_tree *tree;
|
---|
52 | int client_num;
|
---|
53 | int close_fnum;
|
---|
54 | int open_fnum;
|
---|
55 | int close_file_num;
|
---|
56 | int open_file_num;
|
---|
57 | int pending_file_num;
|
---|
58 | int next_file_num;
|
---|
59 | int count;
|
---|
60 | int lastcount;
|
---|
61 | union smb_open open_parms;
|
---|
62 | int open_retries;
|
---|
63 | union smb_close close_parms;
|
---|
64 | struct smbcli_request *req_open;
|
---|
65 | struct smbcli_request *req_close;
|
---|
66 | struct smb_composite_connect reconnect;
|
---|
67 | struct tevent_timer *te;
|
---|
68 |
|
---|
69 | /* these are used for reconnections */
|
---|
70 | const char **dest_ports;
|
---|
71 | const char *dest_host;
|
---|
72 | const char *called_name;
|
---|
73 | const char *service_type;
|
---|
74 | };
|
---|
75 |
|
---|
76 | static void next_open(struct benchopen_state *state);
|
---|
77 | static void reopen_connection(struct tevent_context *ev, struct tevent_timer *te,
|
---|
78 | struct timeval t, void *private_data);
|
---|
79 |
|
---|
80 |
|
---|
81 | /*
|
---|
82 | complete an async reconnect
|
---|
83 | */
|
---|
84 | static void reopen_connection_complete(struct composite_context *ctx)
|
---|
85 | {
|
---|
86 | struct benchopen_state *state = (struct benchopen_state *)ctx->async.private_data;
|
---|
87 | NTSTATUS status;
|
---|
88 | struct smb_composite_connect *io = &state->reconnect;
|
---|
89 |
|
---|
90 | status = smb_composite_connect_recv(ctx, state->mem_ctx);
|
---|
91 | if (!NT_STATUS_IS_OK(status)) {
|
---|
92 | talloc_free(state->te);
|
---|
93 | state->te = event_add_timed(state->ev, state->mem_ctx,
|
---|
94 | timeval_current_ofs(1,0),
|
---|
95 | reopen_connection, state);
|
---|
96 | return;
|
---|
97 | }
|
---|
98 |
|
---|
99 | state->tree = io->out.tree;
|
---|
100 |
|
---|
101 | num_connected++;
|
---|
102 |
|
---|
103 | DEBUG(0,("[%u] reconnect to %s finished (%u connected)\n",
|
---|
104 | state->client_num, state->dest_host, num_connected));
|
---|
105 |
|
---|
106 | state->open_fnum = -1;
|
---|
107 | state->close_fnum = -1;
|
---|
108 | next_open(state);
|
---|
109 | }
|
---|
110 |
|
---|
111 |
|
---|
112 |
|
---|
113 | /*
|
---|
114 | reopen a connection
|
---|
115 | */
|
---|
116 | static void reopen_connection(struct tevent_context *ev, struct tevent_timer *te,
|
---|
117 | struct timeval t, void *private_data)
|
---|
118 | {
|
---|
119 | struct benchopen_state *state = (struct benchopen_state *)private_data;
|
---|
120 | struct composite_context *ctx;
|
---|
121 | struct smb_composite_connect *io = &state->reconnect;
|
---|
122 | char *host, *share;
|
---|
123 |
|
---|
124 | state->te = NULL;
|
---|
125 |
|
---|
126 | if (!torture_get_conn_index(state->client_num, state->mem_ctx, state->tctx, &host, &share)) {
|
---|
127 | DEBUG(0,("Can't find host/share for reconnect?!\n"));
|
---|
128 | exit(1);
|
---|
129 | }
|
---|
130 |
|
---|
131 | io->in.dest_host = state->dest_host;
|
---|
132 | io->in.dest_ports = state->dest_ports;
|
---|
133 | io->in.socket_options = lpcfg_socket_options(state->tctx->lp_ctx);
|
---|
134 | io->in.called_name = state->called_name;
|
---|
135 | io->in.service = share;
|
---|
136 | io->in.service_type = state->service_type;
|
---|
137 | io->in.credentials = cmdline_credentials;
|
---|
138 | io->in.fallback_to_anonymous = false;
|
---|
139 | io->in.workgroup = lpcfg_workgroup(state->tctx->lp_ctx);
|
---|
140 | io->in.gensec_settings = lpcfg_gensec_settings(state->mem_ctx, state->tctx->lp_ctx);
|
---|
141 | lpcfg_smbcli_options(state->tctx->lp_ctx, &io->in.options);
|
---|
142 | lpcfg_smbcli_session_options(state->tctx->lp_ctx, &io->in.session_options);
|
---|
143 |
|
---|
144 | /* kill off the remnants of the old connection */
|
---|
145 | talloc_free(state->tree);
|
---|
146 | state->tree = NULL;
|
---|
147 | state->open_fnum = -1;
|
---|
148 | state->close_fnum = -1;
|
---|
149 |
|
---|
150 | ctx = smb_composite_connect_send(io, state->mem_ctx,
|
---|
151 | lpcfg_resolve_context(state->tctx->lp_ctx),
|
---|
152 | state->ev);
|
---|
153 | if (ctx == NULL) {
|
---|
154 | DEBUG(0,("Failed to setup async reconnect\n"));
|
---|
155 | exit(1);
|
---|
156 | }
|
---|
157 |
|
---|
158 | ctx->async.fn = reopen_connection_complete;
|
---|
159 | ctx->async.private_data = state;
|
---|
160 | }
|
---|
161 |
|
---|
162 | static void open_completed(struct smbcli_request *req);
|
---|
163 | static void close_completed(struct smbcli_request *req);
|
---|
164 |
|
---|
165 |
|
---|
166 | static void next_open(struct benchopen_state *state)
|
---|
167 | {
|
---|
168 | state->count++;
|
---|
169 |
|
---|
170 | state->pending_file_num = state->next_file_num;
|
---|
171 | state->next_file_num = (state->next_file_num+1) % (3*nprocs);
|
---|
172 |
|
---|
173 | DEBUG(2,("[%d] opening %u\n", state->client_num, state->pending_file_num));
|
---|
174 | state->open_parms.ntcreatex.level = RAW_OPEN_NTCREATEX;
|
---|
175 | state->open_parms.ntcreatex.in.flags = 0;
|
---|
176 | state->open_parms.ntcreatex.in.root_fid.fnum = 0;
|
---|
177 | state->open_parms.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
|
---|
178 | state->open_parms.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
|
---|
179 | state->open_parms.ntcreatex.in.alloc_size = 0;
|
---|
180 | state->open_parms.ntcreatex.in.share_access = 0;
|
---|
181 | state->open_parms.ntcreatex.in.open_disposition = NTCREATEX_DISP_OVERWRITE_IF;
|
---|
182 | state->open_parms.ntcreatex.in.create_options = 0;
|
---|
183 | state->open_parms.ntcreatex.in.impersonation = 0;
|
---|
184 | state->open_parms.ntcreatex.in.security_flags = 0;
|
---|
185 | state->open_parms.ntcreatex.in.fname = fnames[state->pending_file_num];
|
---|
186 |
|
---|
187 | state->req_open = smb_raw_open_send(state->tree, &state->open_parms);
|
---|
188 | state->req_open->async.fn = open_completed;
|
---|
189 | state->req_open->async.private_data = state;
|
---|
190 | }
|
---|
191 |
|
---|
192 |
|
---|
193 | static void next_close(struct benchopen_state *state)
|
---|
194 | {
|
---|
195 | if (state->close_fnum == -1) {
|
---|
196 | return;
|
---|
197 | }
|
---|
198 | DEBUG(2,("[%d] closing %d (fnum[%d])\n",
|
---|
199 | state->client_num, state->close_file_num, state->close_fnum));
|
---|
200 | state->close_parms.close.level = RAW_CLOSE_CLOSE;
|
---|
201 | state->close_parms.close.in.file.fnum = state->close_fnum;
|
---|
202 | state->close_parms.close.in.write_time = 0;
|
---|
203 |
|
---|
204 | state->req_close = smb_raw_close_send(state->tree, &state->close_parms);
|
---|
205 | state->req_close->async.fn = close_completed;
|
---|
206 | state->req_close->async.private_data = state;
|
---|
207 | }
|
---|
208 |
|
---|
209 | /*
|
---|
210 | called when a open completes
|
---|
211 | */
|
---|
212 | static void open_completed(struct smbcli_request *req)
|
---|
213 | {
|
---|
214 | struct benchopen_state *state = (struct benchopen_state *)req->async.private_data;
|
---|
215 | TALLOC_CTX *tmp_ctx = talloc_new(state->mem_ctx);
|
---|
216 | NTSTATUS status;
|
---|
217 |
|
---|
218 | status = smb_raw_open_recv(req, tmp_ctx, &state->open_parms);
|
---|
219 |
|
---|
220 | talloc_free(tmp_ctx);
|
---|
221 |
|
---|
222 | state->req_open = NULL;
|
---|
223 |
|
---|
224 | if (NT_STATUS_EQUAL(status, NT_STATUS_END_OF_FILE) ||
|
---|
225 | NT_STATUS_EQUAL(status, NT_STATUS_LOCAL_DISCONNECT) ||
|
---|
226 | NT_STATUS_EQUAL(status, NT_STATUS_CONNECTION_RESET)) {
|
---|
227 | talloc_free(state->tree);
|
---|
228 | talloc_free(state->cli);
|
---|
229 | state->tree = NULL;
|
---|
230 | state->cli = NULL;
|
---|
231 | num_connected--;
|
---|
232 | DEBUG(0,("[%u] reopening connection to %s\n",
|
---|
233 | state->client_num, state->dest_host));
|
---|
234 | talloc_free(state->te);
|
---|
235 | state->te = event_add_timed(state->ev, state->mem_ctx,
|
---|
236 | timeval_current_ofs(1,0),
|
---|
237 | reopen_connection, state);
|
---|
238 | return;
|
---|
239 | }
|
---|
240 |
|
---|
241 | if (NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION)) {
|
---|
242 | DEBUG(2,("[%d] retrying open %d\n",
|
---|
243 | state->client_num, state->pending_file_num));
|
---|
244 | state->open_retries++;
|
---|
245 | state->req_open = smb_raw_open_send(state->tree, &state->open_parms);
|
---|
246 | state->req_open->async.fn = open_completed;
|
---|
247 | state->req_open->async.private_data = state;
|
---|
248 | return;
|
---|
249 | }
|
---|
250 |
|
---|
251 | if (!NT_STATUS_IS_OK(status)) {
|
---|
252 | open_failed++;
|
---|
253 | DEBUG(0,("[%u] open failed %d - %s\n",
|
---|
254 | state->client_num, state->pending_file_num,
|
---|
255 | nt_errstr(status)));
|
---|
256 | return;
|
---|
257 | }
|
---|
258 |
|
---|
259 | state->close_file_num = state->open_file_num;
|
---|
260 | state->close_fnum = state->open_fnum;
|
---|
261 | state->open_file_num = state->pending_file_num;
|
---|
262 | state->open_fnum = state->open_parms.ntcreatex.out.file.fnum;
|
---|
263 |
|
---|
264 | DEBUG(2,("[%d] open completed %d (fnum[%d])\n",
|
---|
265 | state->client_num, state->open_file_num, state->open_fnum));
|
---|
266 |
|
---|
267 | if (state->close_fnum != -1) {
|
---|
268 | next_close(state);
|
---|
269 | }
|
---|
270 |
|
---|
271 | next_open(state);
|
---|
272 | }
|
---|
273 |
|
---|
274 | /*
|
---|
275 | called when a close completes
|
---|
276 | */
|
---|
277 | static void close_completed(struct smbcli_request *req)
|
---|
278 | {
|
---|
279 | struct benchopen_state *state = (struct benchopen_state *)req->async.private_data;
|
---|
280 | NTSTATUS status = smbcli_request_simple_recv(req);
|
---|
281 |
|
---|
282 | state->req_close = NULL;
|
---|
283 |
|
---|
284 | if (NT_STATUS_EQUAL(status, NT_STATUS_END_OF_FILE) ||
|
---|
285 | NT_STATUS_EQUAL(status, NT_STATUS_LOCAL_DISCONNECT) ||
|
---|
286 | NT_STATUS_EQUAL(status, NT_STATUS_CONNECTION_RESET)) {
|
---|
287 | talloc_free(state->tree);
|
---|
288 | talloc_free(state->cli);
|
---|
289 | state->tree = NULL;
|
---|
290 | state->cli = NULL;
|
---|
291 | num_connected--;
|
---|
292 | DEBUG(0,("[%u] reopening connection to %s\n",
|
---|
293 | state->client_num, state->dest_host));
|
---|
294 | talloc_free(state->te);
|
---|
295 | state->te = event_add_timed(state->ev, state->mem_ctx,
|
---|
296 | timeval_current_ofs(1,0),
|
---|
297 | reopen_connection, state);
|
---|
298 | return;
|
---|
299 | }
|
---|
300 |
|
---|
301 | if (!NT_STATUS_IS_OK(status)) {
|
---|
302 | close_failed++;
|
---|
303 | DEBUG(0,("[%u] close failed %d (fnum[%d]) - %s\n",
|
---|
304 | state->client_num, state->close_file_num,
|
---|
305 | state->close_fnum,
|
---|
306 | nt_errstr(status)));
|
---|
307 | return;
|
---|
308 | }
|
---|
309 |
|
---|
310 | DEBUG(2,("[%d] close completed %d (fnum[%d])\n",
|
---|
311 | state->client_num, state->close_file_num,
|
---|
312 | state->close_fnum));
|
---|
313 | }
|
---|
314 |
|
---|
315 | static void echo_completion(struct smbcli_request *req)
|
---|
316 | {
|
---|
317 | struct benchopen_state *state = (struct benchopen_state *)req->async.private_data;
|
---|
318 | NTSTATUS status = smbcli_request_simple_recv(req);
|
---|
319 | if (NT_STATUS_EQUAL(status, NT_STATUS_END_OF_FILE) ||
|
---|
320 | NT_STATUS_EQUAL(status, NT_STATUS_LOCAL_DISCONNECT) ||
|
---|
321 | NT_STATUS_EQUAL(status, NT_STATUS_CONNECTION_RESET)) {
|
---|
322 | talloc_free(state->tree);
|
---|
323 | state->tree = NULL;
|
---|
324 | num_connected--;
|
---|
325 | DEBUG(0,("[%u] reopening connection to %s\n",
|
---|
326 | state->client_num, state->dest_host));
|
---|
327 | talloc_free(state->te);
|
---|
328 | state->te = event_add_timed(state->ev, state->mem_ctx,
|
---|
329 | timeval_current_ofs(1,0),
|
---|
330 | reopen_connection, state);
|
---|
331 | }
|
---|
332 | }
|
---|
333 |
|
---|
334 | static void report_rate(struct tevent_context *ev, struct tevent_timer *te,
|
---|
335 | struct timeval t, void *private_data)
|
---|
336 | {
|
---|
337 | struct benchopen_state *state = talloc_get_type(private_data,
|
---|
338 | struct benchopen_state);
|
---|
339 | int i;
|
---|
340 | for (i=0;i<nprocs;i++) {
|
---|
341 | printf("%5u ", (unsigned)(state[i].count - state[i].lastcount));
|
---|
342 | state[i].lastcount = state[i].count;
|
---|
343 | }
|
---|
344 | printf("\r");
|
---|
345 | fflush(stdout);
|
---|
346 | report_te = event_add_timed(ev, state, timeval_current_ofs(1, 0),
|
---|
347 | report_rate, state);
|
---|
348 |
|
---|
349 | /* send an echo on each interface to ensure it stays alive - this helps
|
---|
350 | with IP takeover */
|
---|
351 | for (i=0;i<nprocs;i++) {
|
---|
352 | struct smb_echo p;
|
---|
353 | struct smbcli_request *req;
|
---|
354 |
|
---|
355 | if (!state[i].tree) {
|
---|
356 | continue;
|
---|
357 | }
|
---|
358 |
|
---|
359 | p.in.repeat_count = 1;
|
---|
360 | p.in.size = 0;
|
---|
361 | p.in.data = NULL;
|
---|
362 | req = smb_raw_echo_send(state[i].tree->session->transport, &p);
|
---|
363 | req->async.private_data = &state[i];
|
---|
364 | req->async.fn = echo_completion;
|
---|
365 | }
|
---|
366 | }
|
---|
367 |
|
---|
368 | /*
|
---|
369 | benchmark open calls
|
---|
370 | */
|
---|
371 | bool torture_bench_open(struct torture_context *torture)
|
---|
372 | {
|
---|
373 | bool ret = true;
|
---|
374 | TALLOC_CTX *mem_ctx = talloc_new(torture);
|
---|
375 | int i;
|
---|
376 | int timelimit = torture_setting_int(torture, "timelimit", 10);
|
---|
377 | struct timeval tv;
|
---|
378 | struct benchopen_state *state;
|
---|
379 | int total = 0;
|
---|
380 | int total_retries = 0;
|
---|
381 | int minops = 0;
|
---|
382 | bool progress=false;
|
---|
383 |
|
---|
384 | progress = torture_setting_bool(torture, "progress", true);
|
---|
385 |
|
---|
386 | nprocs = torture_setting_int(torture, "nprocs", 4);
|
---|
387 |
|
---|
388 | state = talloc_zero_array(mem_ctx, struct benchopen_state, nprocs);
|
---|
389 |
|
---|
390 | printf("Opening %d connections\n", nprocs);
|
---|
391 | for (i=0;i<nprocs;i++) {
|
---|
392 | state[i].tctx = torture;
|
---|
393 | state[i].mem_ctx = talloc_new(state);
|
---|
394 | state[i].client_num = i;
|
---|
395 | state[i].ev = torture->ev;
|
---|
396 | if (!torture_open_connection_ev(&state[i].cli, i, torture, torture->ev)) {
|
---|
397 | return false;
|
---|
398 | }
|
---|
399 | talloc_steal(mem_ctx, state);
|
---|
400 | state[i].tree = state[i].cli->tree;
|
---|
401 | state[i].dest_host = talloc_strdup(state[i].mem_ctx,
|
---|
402 | state[i].cli->tree->session->transport->socket->hostname);
|
---|
403 | state[i].dest_ports = talloc_array(state[i].mem_ctx,
|
---|
404 | const char *, 2);
|
---|
405 | state[i].dest_ports[0] = talloc_asprintf(state[i].dest_ports,
|
---|
406 | "%u", state[i].cli->tree->session->transport->socket->port);
|
---|
407 | state[i].dest_ports[1] = NULL;
|
---|
408 | state[i].called_name = talloc_strdup(state[i].mem_ctx,
|
---|
409 | state[i].cli->tree->session->transport->called.name);
|
---|
410 | state[i].service_type = talloc_strdup(state[i].mem_ctx,
|
---|
411 | state[i].cli->tree->device);
|
---|
412 | }
|
---|
413 |
|
---|
414 | num_connected = i;
|
---|
415 |
|
---|
416 | if (!torture_setup_dir(state[0].cli, BASEDIR)) {
|
---|
417 | goto failed;
|
---|
418 | }
|
---|
419 |
|
---|
420 | fnames = talloc_array(mem_ctx, char *, 3*nprocs);
|
---|
421 | for (i=0;i<3*nprocs;i++) {
|
---|
422 | fnames[i] = talloc_asprintf(fnames, "%s\\file%d.dat", BASEDIR, i);
|
---|
423 | }
|
---|
424 |
|
---|
425 | for (i=0;i<nprocs;i++) {
|
---|
426 | /* all connections start with the same file */
|
---|
427 | state[i].next_file_num = 0;
|
---|
428 | state[i].open_fnum = -1;
|
---|
429 | state[i].close_fnum = -1;
|
---|
430 | next_open(&state[i]);
|
---|
431 | }
|
---|
432 |
|
---|
433 | tv = timeval_current();
|
---|
434 |
|
---|
435 | if (progress) {
|
---|
436 | report_te = event_add_timed(torture->ev, state, timeval_current_ofs(1, 0),
|
---|
437 | report_rate, state);
|
---|
438 | }
|
---|
439 |
|
---|
440 | printf("Running for %d seconds\n", timelimit);
|
---|
441 | while (timeval_elapsed(&tv) < timelimit) {
|
---|
442 | event_loop_once(torture->ev);
|
---|
443 |
|
---|
444 | if (open_failed) {
|
---|
445 | DEBUG(0,("open failed\n"));
|
---|
446 | goto failed;
|
---|
447 | }
|
---|
448 | if (close_failed) {
|
---|
449 | DEBUG(0,("open failed\n"));
|
---|
450 | goto failed;
|
---|
451 | }
|
---|
452 | }
|
---|
453 |
|
---|
454 | talloc_free(report_te);
|
---|
455 | if (progress) {
|
---|
456 | for (i=0;i<nprocs;i++) {
|
---|
457 | printf(" ");
|
---|
458 | }
|
---|
459 | printf("\r");
|
---|
460 | }
|
---|
461 |
|
---|
462 | minops = state[0].count;
|
---|
463 | for (i=0;i<nprocs;i++) {
|
---|
464 | total += state[i].count;
|
---|
465 | total_retries += state[i].open_retries;
|
---|
466 | printf("[%d] %u ops (%u retries)\n",
|
---|
467 | i, state[i].count, state[i].open_retries);
|
---|
468 | if (state[i].count < minops) minops = state[i].count;
|
---|
469 | }
|
---|
470 | printf("%.2f ops/second (%d retries)\n",
|
---|
471 | total/timeval_elapsed(&tv), total_retries);
|
---|
472 | if (minops < 0.5*total/nprocs) {
|
---|
473 | printf("Failed: unbalanced open\n");
|
---|
474 | goto failed;
|
---|
475 | }
|
---|
476 |
|
---|
477 | for (i=0;i<nprocs;i++) {
|
---|
478 | talloc_free(state[i].req_open);
|
---|
479 | talloc_free(state[i].req_close);
|
---|
480 | smb_raw_exit(state[i].tree->session);
|
---|
481 | }
|
---|
482 |
|
---|
483 | smbcli_deltree(state[0].tree, BASEDIR);
|
---|
484 | talloc_free(mem_ctx);
|
---|
485 | return ret;
|
---|
486 |
|
---|
487 | failed:
|
---|
488 | talloc_free(mem_ctx);
|
---|
489 | return false;
|
---|
490 | }
|
---|