Changeset 635

Timestamp:

Jan 5, 2016, 11:11:45 PM (10 years ago)

Author:

Yuri Dario

Message:

rpm: replace fork() with popen() when redirecting output. fixes ticket#143.

File:

• rpm/trunk/cliutils.c (modified) (1 diff)

rpm/trunk/cliutils.c

@@ -56 +56 @@
 
     char cmdline[16*1024];
-    sprintf( cmdline, "sh -c %s", rpmcliPipeOutput);
+    // place command line inside quotes to allow sh to execute all commands
+    // itself (otherwise also cmd is involved)
+    sprintf( cmdline, "sh -c \"%s\"", rpmcliPipeOutput);
     // start child and redirect its input to us
     pipeFD = popen( cmdline, "w");
+    if (pipeFD == NULL) {
+        fprintf(stderr, "creating a pipe for --pipe failed: %s\n", cmdline);
+        return -1;
+    }
     // now redirect stdout to input handle
     dup2( fileno(pipeFD), STDOUT_FILENO);