Changeset 829

Timestamp:

Nov 19, 2010, 1:29:47 PM (15 years ago)

Author:

Dmitry A. Kuminov

Message:

gui: Return a correct system icon (folder or file) for a non-existent path based on some heuristics, instead of a default Qt icon which doesn't match the style.

File:

• trunk/src/gui/itemviews/qfileiconprovider.cpp (modified) (1 diff)

trunk/src/gui/itemviews/qfileiconprovider.cpp

@@ -340 +340 @@
         QDir::cleanPath(fileInfo.absoluteFilePath())).toLocal8Bit();
     HPOINTER hicon = WinLoadFileIcon(path, FALSE);
+    if (hicon == NULLHANDLE) {
+        // WinLoadFileIcon() fails on non-existing paths but we still want a
+        // system icon for it to be "in tune" with other icons. One known case
+        // is a directory on an NDFS SMB multi-resource share that links to a
+        // remote CD-ROM drive with no disk in it. This actually represents a
+        // more common problem when an icon for a non-existent path is
+        // requested. We will solve it by providing an icon of a known-to-exist
+        // path element instead. In order to differentiate between a
+        // non-existent folder and file we use a return code from
+        // DosQueryPathInfo() which appears to be ERROR_PATH_NOT_FOUND for the
+        // SMB multi-resource case and ERROR_FILE_NOT_FOUND otherwise. Note that
+        // a calling app may actually already know if it's a file or a directory
+        // from the listing of a parent directory (or we could do such a listing
+        // here) but it looks like too much hassle to use this approach here.
+        FILESTATUS3 info;
+        APIRET arc = DosQueryPathInfo(path, FIL_STANDARD, &info, sizeof(info));
+        if (arc == ERROR_PATH_NOT_FOUND) {
+            // a known-to-exist directory
+            hicon = WinLoadFileIcon("\\", FALSE);
+        } else {
+            // a known-to-exist file
+            static char kernelFilePath[] = "?:\\OS2KRNL";
+            if (kernelFilePath[0] == '?') {
+                ULONG bootDrive = 0;
+                DosQuerySysInfo(QSV_BOOT_DRIVE, QSV_BOOT_DRIVE,
+                                (PVOID)&bootDrive, sizeof(bootDrive));
+                kernelFilePath[0] = bootDrive + 'A' - 1;
+            }
+            hicon = WinLoadFileIcon(kernelFilePath, FALSE);
+        }
+    }
     if (hicon != NULLHANDLE) {
         // we're requesting the system (shared) icon handle which should be