Changeset 765

Timestamp:

Jul 29, 2010, 3:51:24 PM (15 years ago)

Author:

Dmitry A. Kuminov

Message:

gui: Fixed QFileDialog: Don't increase the item height in the side bar by increasing icon size as this causes ugly icon scaling; use the item size hint instead and make this increase dynamic (depending on the normal item height) [vendor bug].

Location:

trunk/src/gui/dialogs

Files:

• qsidebar.cpp (modified) (2 diffs)
• qsidebar_p.h (modified) (1 diff)

trunk/src/gui/dialogs/qsidebar.cpp

@@ -66 +66 @@
             option->state &= ~QStyle::State_Enabled;
     }
+}
+
+QSize QSideBarDelegate::sizeHint (const QStyleOptionViewItem &option,
+                                  const QModelIndex &index) const
+{
+    // Make the item height in the side bar little bit bigger than in the
+    // file list view (to emphasize it). Note that this is better than
+    // previously used enforcing the icon size on the list with setIconSize()
+    // because it doesn't cause icon scaling (whigh results in blurred images)
+    QSize size = QStyledItemDelegate::sizeHint(option, index);
+    int height = size.height();
+    size.setHeight(height + height / 4);
+    return size;
 }
 
@@ -375 +388 @@
 {
     // ### TODO make icon size dynamic
-    setIconSize(QSize(24,24));
+    //setIconSize(QSize(24,24));
+    //setSpacing(4);
     setUniformItemSizes(true);
     urlModel = new QUrlModel(this);

trunk/src/gui/dialogs/qsidebar_p.h

@@ -71 +71 @@
      void initStyleOption(QStyleOptionViewItem *option,
                           const QModelIndex &index) const;
+     QSize sizeHint (const QStyleOptionViewItem &option,
+                     const QModelIndex &index) const;
 };