Changeset 150 for trunk

Timestamp:

Nov 1, 2006, 10:55:03 PM (19 years ago)

Author:

dmik

Message:

Common: System Exceptions:

• Added exploring and writing the context and call stack of all other threads of the process.
• The 'Process/Module' tag is now a single line (for easier visual lookup with line wrapping turned off).

File:

• trunk/src/tools/qsysxcpt_pm.cpp (modified) (21 diffs)

trunk/src/tools/qsysxcpt_pm.cpp

@@ -42 +42 @@
  */
 
+/// @todo (r=dmik) use plain DosWrite() and friends instead of fprintf() and
+//  friends (LIBC may be in a inconsistent state at the point when an exception
+//  is thrown (see kLIBC's logstrict.c for some sprintf like stuff)
+ 
 #if !defined(QT_OS2_NO_SYSEXCEPTIONS)
  
@@ -54 +58 @@
 #include <errno.h>
 #include <sys/stat.h>
-
-/// @todo (r=dmik) add locking to:
-//  a) handle simultaneous independent exceptions from different threads
-//  b) raise (user) exceptions on all other threads in order to write their
-//     contexts to the trap file when a real exception happens on one thread
 
 /** @class QtOS2SysXcptMainHandler qt_os2.h
@@ -227 +226 @@
             {
                 fprintf (file, " flags=\"%08lX\"", ulFlags);
-                if (ulFlags & (PAG_COMMIT | PAG_READ) == (PAG_COMMIT | PAG_READ))
+                if ((ulFlags & (PAG_COMMIT | PAG_READ)) ==
+                    (PAG_COMMIT | PAG_READ))
                     fprintf (file, " word=\"%08lX\"/>\n", *(ULONG *) ulValue);
                 else
@@ -238 +238 @@
         {
             fprintf (file, ">\n");
-            qt_excWriteErrorMsg (file, 7, "DosQueryMem returned %lu"
+            qt_excWriteErrorMsg (file, 7, "DosQueryMem returned %lu "
                                  "and flags %08lX", arc, ulFlags);
             fprintf (file, "      </Register>\n");
@@ -266 +266 @@
 
     if (arc != NO_ERROR)
-        qt_excWriteErrorMsg (file, 8, "%s: DosQueryModFromEIP returned %lu",
-                             szMod, arc);
+        qt_excWriteErrorMsg (file, 8, "DosQueryModFromEIP returned %lu", arc);
     else
         fprintf (file, "        <Module ID=\"%04lX\" segment=\"%04lX\" "
@@ -303 +302 @@
             else if (arc == ERROR_INVALID_ADDRESS)
             {
-                if (((ULONG) pch) & 0xFFFFF000 == ulRegEip & 0xFFFFF000)
+                if ((((ULONG) pch) & 0xFFFFF000) == (ulRegEip & 0xFFFFF000))
                     break; /* the same page, ulAddress inaccessible */
                 pch = (UCHAR *) (ulRegEip & 0xFFFFF000);
@@ -310 +309 @@
         fprintf (file, "        <Dump address=\"%08lX\">\n         ", pch);
         if (arc == NO_ERROR &&
-            ulFlags & (PAG_COMMIT|PAG_READ) == (PAG_COMMIT | PAG_READ))
+            (ulFlags & (PAG_COMMIT | PAG_READ)) == (PAG_COMMIT | PAG_READ))
         {
             for (; pch < pchEnd; ++pch)
@@ -318 +317 @@
         }
         else
-            qt_excWriteErrorMsg (file, 0, "%08lX: DosQueryMem returned %lu"
+            qt_excWriteErrorMsg (file, 0, "%08lX: DosQueryMem returned %lu "
                                  "and flags %08lX", pch, arc, ulFlags);
         fprintf (file, "        </Dump>\n");
@@ -329 +328 @@
 /** \internal
  *  Walks the stack and writes information about stack frames.
- */
-static void qt_excWriteStackFrames (FILE *file, PTIB ptib,
+ *  @note This function should be in sync with qt_excWriteModulesOnStack()
+ *        because they share the same logic.
+ */
+static void qt_excWriteStackFrames (FILE *file, ULONG ulStackLimit,
                                     PCONTEXTRECORD pContextRec)
 {
@@ -345 +346 @@
      * trapping address itself even if EBP there is invalid. */
 
-    while (ulRegEbp != 0 && ulRegEbp < (ULONG) ptib->tib_pstacklimit)
+    while (ulRegEbp != 0 && ulRegEbp < ulStackLimit)
     {
         /* skip the trapping stack frame -- already written above */
@@ -359 +360 @@
             if (   (arc != NO_ERROR)
                 || (   arc == NO_ERROR
-                    && (ulFlags & (PAG_COMMIT|PAG_READ))
-                        != (PAG_COMMIT|PAG_READ)))
+                    && (ulFlags & (PAG_COMMIT | PAG_READ))
+                        != (PAG_COMMIT | PAG_READ)))
             {
                 fprintf (file, "      <Frame pointer=\"%08lX\">\n", ulRegEbp);
@@ -367 +368 @@
                 fprintf (file, "      </Frame>\n");
                 /* try go to the next page */
-                /// @todo (r=dmik) I don't know how much it is accurate,
+                /// @todo (r=dmik) I don't know how much is it accurate,
                 //  I've just taken the logic from xwphelpers sources.
                 ulRegEbp += 0x1000;
@@ -391 +392 @@
                                    PCONTEXTRECORD pContextRec)
 {
+    ULONG ulStackBase = 0, ulStackLimit = 0;
+    ULONG ulCount = 0, ulFlags = 0;
+    ULONG ul = 0;
+    APIRET arc = NO_ERROR;
+    
     if (ptib)
     {
@@ -449 +455 @@
     /* *** stack */
 
-    fprintf (file, "    <Stack base=\"%08lX\" limit=\"%08lX\">\n",
-             (ULONG) ptib->tib_pstack,
-             (ULONG) ptib->tib_pstacklimit);
-    
+    if (ptib)
+    {
+        ulStackBase = (ULONG) ptib->tib_pstack;
+        ulStackLimit = (ULONG) ptib->tib_pstacklimit;
+    }
+    else
     if (pContextRec->ContextFlags & CONTEXT_CONTROL)
     {
-        qt_excWriteStackFrames (file, ptib, pContextRec);
-    }    
-    
-    fprintf (file, "    </Stack>\n"
-                   "   </Thread>\n");
+        /* first, try to find the end of the stack object */
+        ulCount = 0xFFFFFFFF;
+        arc = DosQueryMem ((void *) pContextRec->ctx_RegEbp,
+                           &ulCount, &ulFlags);
+        if (arc == NO_ERROR)
+        {
+            ulStackLimit = pContextRec->ctx_RegEbp + ulCount;
+            /* next, try to find the start of the stack object */
+            ul = (pContextRec->ctx_RegEbp & 0xFFFFF000);
+            while (arc == NO_ERROR && !(ulFlags & PAG_BASE))
+            {
+                ulCount = 0x1000;
+                ul -= 0x1000;
+                arc = DosQueryMem ((void *) ul, &ulCount, &ulFlags);
+            }
+            if (arc == NO_ERROR)
+                ulStackBase = ul;
+        }
+    }
+
+    fprintf (file, "    <Stack");
+    if (ulStackBase)
+        fprintf (file, " base=\"%08lX\"", ulStackBase);
+    if (ulStackLimit)
+        fprintf (file, " limit=\"%08lX\"", ulStackLimit);
+    fprintf (file, ">\n");
+    
+    if (pContextRec->ContextFlags & CONTEXT_CONTROL)
+        qt_excWriteStackFrames (file, ulStackLimit, pContextRec);
+
+    fprintf (file, "    </Stack>\n");
+    fprintf (file, "   </Thread>\n");
 }
 
@@ -550 +585 @@
                 achBuf [1 + *achBuf] = 0;
                 /* write the description attribute */
-                fprintf (file, "\n           desc=\"%s\"", achBuf + 1);
+                fprintf (file, " desc=\"%s\"", achBuf + 1);
                 bFound = TRUE;
             }
@@ -582 +617 @@
     if ((ulOrigin >= 1 && ulOrigin <= 3) || arc == NO_ERROR)
     {
-        fprintf (file, "\n           ");
         if (ulOrigin >= 1 && ulOrigin <= 3)
             fprintf (file, " origin=\"%s\"",
@@ -647 +681 @@
  *  Used only when DosQuerySysState() fails (so qt_excWriteModules() is not
  *  applicable). We use recursiveness to avoid module record duplicates.
+ *  @note This function should be in sync with qt_excWriteStackFrames()
+ *        because they share the same logic.
  */
 static void qt_excWriteModulesOnStack (WMOS_STATE *pState)
@@ -701 +737 @@
                 if (   (arc != NO_ERROR)
                     || (   arc == NO_ERROR
-                        && (ulFlags & (PAG_COMMIT|PAG_READ))
-                            != (PAG_COMMIT|PAG_READ)))
+                        && (ulFlags & (PAG_COMMIT | PAG_READ))
+                            != (PAG_COMMIT | PAG_READ)))
                 {
                     /* try go to the next page */
-                    /// @todo (r=dmik) I don't know how much it is accurate,
+                    /// @todo (r=dmik) I don't know how much is it accurate,
                     //  I've just taken the logic from xwphelpers sources.
                     pState->ulRegEbp += 0x1000;
@@ -752 +788 @@
     ULONG ul = 0;
     ULONG aulBuf [3];
+
+    QSTREC *pThrdRec = NULL;
 
     /* *** application info */
@@ -843 +881 @@
     
     /* first, the current thread */
-    QSTREC *pThrdRec = pInfo->bHaveSysState ? pInfo->pProcRec->pThrdRec : NULL;
+    pThrdRec = pInfo->bHaveSysState ? pInfo->pProcRec->pThrdRec : NULL;
     if (pThrdRec)
     {
@@ -854 +892 @@
     }
     qt_excWriteThreadInfo (file, pInfo->ptib, pThrdRec, pContextRec);
+
+    /* then, all other threads */
+    pThrdRec = pInfo->bHaveSysState ? pInfo->pProcRec->pThrdRec : NULL;
+    if (pThrdRec)
+    {
+        /* important to set ContextFlags to CONTEXT_FULL, otherwise we'll
+         * get nothing */
+        CONTEXTRECORD ContextRec = {CONTEXT_FULL, 0};
+        APIRET arc = NO_ERROR;
+        /* enter the critical section to effectively suspend all other threads
+         * while reading their contexts and walking their stacks */
+        DosEnterCritSec();
+        for (ul = 0; ul < pInfo->pProcRec->cTCB; ++ ul, ++ pThrdRec)
+        {
+            if ((ULONG) pThrdRec->tid == pInfo->ptib->tib_ptib2->tib2_ultid)
+                continue;
+            arc = DosQueryThreadContext (pThrdRec->tid, CONTEXT_FULL,
+                                         &ContextRec);
+            if (arc == NO_ERROR)
+                qt_excWriteThreadInfo (file, NULL, pThrdRec, &ContextRec);
+            else
+            {
+                fprintf (file, "   <Thread ID=\"%04lX\">", pThrdRec->tid);
+                qt_excWriteErrorMsg (file, 3, "DosQueryThreadContext returned "
+                                              "%lu", arc);
+                fprintf (file, "   </Thread>\n");
+            }
+        }
+        /* exit the critical section */
+        DosExitCritSec();        
+    }
     
     fprintf (file, "  </Threads>\n");