Changeset 6612

Timestamp:

Aug 31, 2001, 9:46:45 PM (24 years ago)

Author:

phaller

Message:

fix UnregisterClass

Location:

trunk

Files:

• changelog (modified) (1 diff)
• src/user32/win32class.cpp (modified) (2 diffs)

trunk/changelog

@@ -1 @@
-/* $Id: changelog,v 1.1666 2001-08-31 00:20:04 phaller Exp $ */
+/* $Id: changelog,v 1.1667 2001-08-31 19:46:45 phaller Exp $ */
+
+ 2001-08-31: Patrick Haller <patrick.haller@innotek.de>
+    - KERNEL32: o Fix in MoveFileExW, MoveFileExA prevents stack corruption
+                  in MS ACMSETUP
+    - USER32:   o Fix in UnregisterClass for never reaching the destructor
+                  of Win32class. ACMSETUP now working.
 
  2001-08-30: Patrick Haller <patrick.haller@innotek.de>

trunk/src/user32/win32class.cpp

@@ -1 @@
-/* $Id: win32class.cpp,v 1.26 2001-08-07 21:35:36 sandervl Exp $ */
+/* $Id: win32class.cpp,v 1.27 2001-08-31 19:45:50 phaller Exp $ */
 /*
  * Win32 Window Class Managment Code for OS/2
@@ -572 +572 @@
             return FALSE;
         }
+    
+        // 2001-08-31 PH
+        // Note: RELEASE_CLASSOBJ sets the pointer to NULL,
+        // and as delete verifies the object pointer to unequal NULL,
+        // the destrutor is NEVER called, the class atom is NEVER released.
+        wndclass->markDeleted();
         RELEASE_CLASSOBJ(wndclass);
-        delete wndclass;
+    
         SetLastError(ERROR_SUCCESS);
         return TRUE;