Changeset 5666

Timestamp:

May 7, 2001, 12:07:40 PM (25 years ago)

Author:

phaller

Message:

.

Location:

trunk

Files:

• changelog (modified) (1 diff)
• src/kernel32/wprocess.cpp (modified) (2 diffs)

trunk/changelog

@@ -1 @@
-/* $Id: changelog,v 1.1398 2001-05-07 08:23:24 phaller Exp $ */
+/* $Id: changelog,v 1.1399 2001-05-07 10:07:29 phaller Exp $ */
 
  2001-05-07: Patrick Haller <patrick.haller@innotek.de>
     - WS2_32:   o created skeleton
     - WS2HELP:  o created skeleton
+    - KERNEL32: o CreateProcess error handling corrected, if
+                  O32_CreateProcess fails with specific reason
 
  2001-05-04: Dietrich Teickner <Dietrich_Teickner@t-online.de>

trunk/src/kernel32/wprocess.cpp

@@ -1 @@
-/* $Id: wprocess.cpp,v 1.119 2001-04-26 13:22:49 sandervl Exp $ */
+/* $Id: wprocess.cpp,v 1.120 2001-05-07 10:07:40 phaller Exp $ */
 
 /*
@@ -1602 +1602 @@
       return(TRUE);
     }
+
+    // PH 2001-05-07
+    // verify why O32_CreateProcess actually failed.
+    // If GetLastError() == 191 (ERROR_INVALID_EXE_SIGNATURE)
+    // we can continue to call "PE.EXE".
+    // Note: Open32 does not translate ERROR_INVALID_EXE_SIGNATURE,
+    // it is also valid in Win32.
+    DWORD dwError = GetLastError();
+    if (ERROR_INVALID_EXE_SIGNATURE != dwError)
+    {
+        dprintf(("CreateProcess: O32_CreateProcess failed with rc=%d, not PE-executable !",
+                dwError));
+
+        // the current value of GetLastError() is still valid.
+
+        return FALSE;
+    }
+
+    // else ...
+
     //probably a win32 exe, so run it in the pe loader
     if(lpApplicationName) {