Changeset 4176 for trunk/src/kernel32

Timestamp:

Sep 3, 2000, 10:22:32 PM (25 years ago)

Author:

phaller

Message:

Access check in ReadProcessMemory / WriteProcessMemory

File:

• trunk/src/kernel32/stubs.cpp (modified) (3 diffs)

trunk/src/kernel32/stubs.cpp

@@ -1697 +1697 @@
            cbRead,
            lpNumberOfBytesRead));
+
+  // do some (faked) access check
+  if (hProcess != GetCurrentProcess())
+  {
+    SetLastError(ERROR_ACCESS_DENIED);
+    return FALSE;
+  }
+
+  
   // FIXME: check this, if we ever run win32 binaries in different addressspaces
   //    ... and add a sizecheck
   memcpy(lpBuffer,lpBaseAddress,cbRead);
-  if (lpNumberOfBytesRead) *lpNumberOfBytesRead = cbRead;
+  if (lpNumberOfBytesRead) 
+    *lpNumberOfBytesRead = cbRead;
+  
   return TRUE;
 }
@@ -1722 +1733 @@
  *****************************************************************************/
 
-DWORD WIN32API WriteProcessMemory(HANDLE  hProcess,
-                                     LPCVOID lpBaseAddress,
-                                     LPVOID  lpBuffer,
-                                     DWORD   cbWrite,
-                                     LPDWORD lpNumberOfBytesWritten)
+BOOL WIN32API WriteProcessMemory(HANDLE  hProcess,
+                                 LPCVOID lpBaseAddress,
+                                 LPVOID  lpBuffer,
+                                 DWORD   cbWrite,
+                                 LPDWORD lpNumberOfBytesWritten)
 {
   dprintf(("Kernel32: WriteProcessMemory(%08xh,%08xh,%08xh,%08xh,%08xh) not implemented.\n",
@@ -1734 +1745 @@
            cbWrite,
            lpNumberOfBytesWritten));
-
+  
+  // do some (faked) access check
+  if (hProcess != GetCurrentProcess())
+  {
+    SetLastError(ERROR_ACCESS_DENIED);
+    return FALSE;
+  }
+  
   // FIXME: check this, if we ever run win32 binaries in different addressspaces
   //    ... and add a sizecheck
   memcpy((void*)lpBaseAddress,lpBuffer,cbWrite);
-  if (lpNumberOfBytesWritten) *lpNumberOfBytesWritten = cbWrite;
+  if (lpNumberOfBytesWritten) 
+    *lpNumberOfBytesWritten = cbWrite;
+  
   return TRUE;
 }