Changeset 3702 for trunk/src

Timestamp:

Jun 13, 2000, 11:26:30 PM (25 years ago)

Author:

sandervl

Message:

when registering a class, check if it already exists and return error

Location:

trunk/src/user32

Files:

• win32class.cpp (modified) (2 diffs)
• win32class.h (modified) (2 diffs)
• windowclass.cpp (modified) (6 diffs)

trunk/src/user32/win32class.cpp

@@ -1 @@
-/* $Id: win32class.cpp,v 1.16 2000-03-18 16:13:37 cbratschi Exp $ */
+/* $Id: win32class.cpp,v 1.17 2000-06-13 21:26:29 sandervl Exp $ */
 /*
  * Win32 Window Class Managment Code for OS/2
@@ -240 +240 @@
   dprintf(("Class %X (inst %X) not found!", id, hInstance));
   return(NULL);
+}
+//******************************************************************************
+//******************************************************************************
+Win32WndClass *Win32WndClass::FindClass(HINSTANCE hInstance, LPWSTR id)
+{
+ LPSTR          lpszClassName;
+ Win32WndClass *winclass;
+
+  if(HIWORD(id)) {
+        lpszClassName = UnicodeToAsciiString((LPWSTR)id);
+  }
+  else  lpszClassName = (LPSTR)id;
+
+  winclass = FindClass(hInstance, lpszClassName);
+
+  if(HIWORD(id)) {
+        FreeAsciiString((char *)lpszClassName);
+  }
+  return winclass;
 }
 //******************************************************************************

trunk/src/user32/win32class.h

@@ -1 @@
-/* $Id: win32class.h,v 1.11 2000-03-18 16:13:38 cbratschi Exp $ */
+/* $Id: win32class.h,v 1.12 2000-06-13 21:26:30 sandervl Exp $ */
 /*
  * Win32 Window Class Managment Code for OS/2
@@ -68 +68 @@
 
  static Win32WndClass *FindClass(HINSTANCE hinst, LPSTR id);
+ static Win32WndClass *FindClass(HINSTANCE hinst, LPWSTR id);
+
  static  void   DestroyAll();
 

trunk/src/user32/windowclass.cpp

@@ -1 @@
-/* $Id: windowclass.cpp,v 1.10 2000-05-28 16:43:48 sandervl Exp $ */
+/* $Id: windowclass.cpp,v 1.11 2000-06-13 21:26:30 sandervl Exp $ */
 /*
  * Win32 Window Class Code for OS/2
@@ -45 +45 @@
  Win32WndClass *wclass;
 
-    dprintf(("RegisterClassA\n"));
+   dprintf(("RegisterClassA\n"));
    //CB: size new in ex structure
    wc.cbSize = sizeof(wc);
@@ -51 +51 @@
    wc.hIconSm = 0;
 
+   if(Win32WndClass::FindClass(wc.hInstance, (LPSTR)wc.lpszClassName)) {
+        dprintf(("RegisterClassA %x %x already exists", wc.hInstance, wc.lpszClassName));
+        SetLastError(ERROR_CLASS_ALREADY_EXISTS);
+        return 0;
+   }
+
    wclass = new Win32WndClass(&wc,FALSE);
    if(wclass == NULL) {
-        dprintf(("RegisterClassA wclass == NULL!"));
+        dprintf(("ERROR: RegisterClassA winclass == NULL!"));
+        DebugInt3();
         return(0);
    }
@@ -63 +70 @@
 {
  Win32WndClass *wclass;
+
+   if(Win32WndClass::FindClass(lpWndClass->hInstance, (LPSTR)lpWndClass->lpszClassName)) {
+        dprintf(("RegisterClassExA %x %x already exists", lpWndClass->hInstance, lpWndClass->lpszClassName));
+        SetLastError(ERROR_CLASS_ALREADY_EXISTS);
+        return 0;
+   }
 
    dprintf(("RegisterClassExA\n"));
    wclass = new Win32WndClass((WNDCLASSEXA *)lpWndClass,FALSE);
    if(wclass == NULL) {
-        dprintf(("RegisterClassExA wclass == NULL!"));
+        dprintf(("ERROR: RegisterClassExA winclass == NULL!"));
+        DebugInt3();
         return(0);
    }
@@ -77 +91 @@
 {
  ATOM rc;
- WNDCLASSEXA wclass;
+ WNDCLASSEXA wc;
  Win32WndClass *winclass;
 
     dprintf(("RegisterClassW\n"));
     //CB: size new in ex structure
-    wclass.cbSize = sizeof(wclass);
-    memcpy(&wclass.style, lpwc, sizeof(WNDCLASSA));
-
-    winclass = new Win32WndClass((WNDCLASSEXA *)&wclass, TRUE);
+    wc.cbSize = sizeof(wc);
+    memcpy(&wc.style, lpwc, sizeof(WNDCLASSA));
+
+    if(Win32WndClass::FindClass(wc.hInstance, (LPWSTR)wc.lpszClassName)) {
+        dprintf(("RegisterClassW %x %x already exists", wc.hInstance, wc.lpszClassName));
+        SetLastError(ERROR_CLASS_ALREADY_EXISTS);
+        return 0;
+    }
+
+    winclass = new Win32WndClass((WNDCLASSEXA *)&wc, TRUE);
     if(winclass == NULL) {
-        dprintf(("RegisterClassW wclass == NULL!"));
-        return(0);
+        dprintf(("ERROR: RegisterClassW winclass == NULL!"));
+        DebugInt3();
+        return 0;
     }
     rc = winclass->getAtom();
@@ -99 +120 @@
 {
  ATOM rc;
- WNDCLASSEXA wclass;
+ WNDCLASSEXA wc;
  Win32WndClass *winclass;
 
     dprintf(("RegisterClassExW\n"));
-    memcpy(&wclass, lpwc, sizeof(WNDCLASSEXA));
-
-    winclass = new Win32WndClass((WNDCLASSEXA *)&wclass, TRUE);
+    memcpy(&wc, lpwc, sizeof(WNDCLASSEXA));
+
+    if(Win32WndClass::FindClass(wc.hInstance, (LPWSTR)wc.lpszClassName)) {
+        dprintf(("RegisterClassW %x %x already exists", wc.hInstance, wc.lpszClassName));
+        SetLastError(ERROR_CLASS_ALREADY_EXISTS);
+        return 0;
+    }
+
+    winclass = new Win32WndClass((WNDCLASSEXA *)&wc, TRUE);
     if(winclass == NULL) {
-        dprintf(("RegisterClassExW wclass == NULL!"));
+        dprintf(("ERROR: RegisterClassExW winclass == NULL!"));
+        DebugInt3();
         return(0);
     }