Changeset 3603 for trunk/src/user32

Timestamp:

May 24, 2000, 9:30:08 PM (25 years ago)

Author:

sandervl

Message:

experimental WM_NCHITTEST generation (disabled) + MDI fixes

Location:

trunk/src/user32

Files:

• oslibmsgtranslate.cpp (modified) (7 diffs)
• pmframe.cpp (modified) (2 diffs)
• pmwindow.cpp (modified) (5 diffs)
• win32wbase.cpp (modified) (5 diffs)
• win32wbase.h (modified) (2 diffs)
• win32wmdichild.cpp (modified) (7 diffs)
• win32wmdiclient.cpp (modified) (2 diffs)

trunk/src/user32/oslibmsgtranslate.cpp

@@ -1 @@
-/* $Id: oslibmsgtranslate.cpp,v 1.30 2000-05-12 18:09:40 sandervl Exp $ */
+/* $Id: oslibmsgtranslate.cpp,v 1.31 2000-05-24 19:30:05 sandervl Exp $ */
 /*
  * Window message translation functions for OS/2
@@ -189 +189 @@
         //WM_NC*BUTTON* is posted when the cursor is in a non-client area of the window
 
+#ifdef ODIN_HITTEST
+        //Send WM_HITTEST message
+        win32wnd->sendHitTest(MAKELONG(winMsg->pt.x,winMsg->pt.y));
+#endif
+
         //if a window is disabled, it's parent receives the mouse messages
         if(!win32wnd->IsWindowEnabled()) {
@@ -242 +247 @@
         //WM_NCMOUSEMOVE is posted when the cursor moves into a non-client area of the window
 
+#ifdef ODIN_HITTEST
+        //Send WM_HITTEST message
+        win32wnd->sendHitTest(MAKELONG(winMsg->pt.x,winMsg->pt.y));
+#endif
         //if a window is disabled, it's parent receives the mouse messages
         if(!win32wnd->IsWindowEnabled()) {
@@ -288 +297 @@
         winMsg->message = WINWM_NCACTIVATE;
         winMsg->wParam  = SHORT1FROMMP(os2Msg->mp1);
+
         return TRUE;
       }
@@ -417 +427 @@
       BOOL fMinimized = FALSE;
 
-        if(WinQueryWindowULong(hwndActivate, OFFSET_WIN32PM_MAGIC) != WIN32PM_MAGIC) {
+        hwndActivate = Win32BaseWindow::OS2ToWin32Handle(hwndActivate);
+        if(hwndActivate == 0) {
                 //another (non-win32) application's window
                 //set to desktop window handle
-                hwndActivate = windowDesktop->getWindowHandle();
-        }
-        else    hwndActivate = Win32BaseWindow::OS2ToWin32Handle(hwndActivate);
+                hwndActivate = windowDesktop->getWindowHandle();
+        }
 
         if(WinQueryWindowULong(os2Msg->hwnd, QWL_STYLE) & WS_MINIMIZED)
@@ -483 +493 @@
         //WM_NC*BUTTON* is posted when the cursor is in a non-client area of the window
 
+#ifdef ODIN_HITTEST
+        //Send WM_HITTEST message
+        win32wnd->sendHitTest(MAKELONG(winMsg->pt.x,winMsg->pt.y));
+#endif
+
         //if a window is disabled, it's parent receives the mouse messages
         if(!win32wnd->IsWindowEnabled()) {
@@ -535 +550 @@
     {
         //WM_NCMOUSEMOVE is posted when the cursor moves into a non-client area of the window
+
+#ifdef ODIN_HITTEST
+        //Send WM_HITTEST message
+        win32wnd->sendHitTest(MAKELONG(winMsg->pt.x,winMsg->pt.y));
+#endif
 
         //if a window is disabled, it's parent receives the mouse messages

trunk/src/user32/pmframe.cpp

@@ -1 @@
-/* $Id: pmframe.cpp,v 1.54 2000-05-22 17:21:10 cbratschi Exp $ */
+/* $Id: pmframe.cpp,v 1.55 2000-05-24 19:30:05 sandervl Exp $ */
 /*
  * Win32 Frame Managment Code for OS/2
@@ -464 +464 @@
         USHORT flags = WinQueryWindowUShort(hwnd,QWS_FLAGS);
 
-        dprintf(("PMFRAME: WM_ACTIVATE %x %x", hwnd, mp2));
+        dprintf(("PMFRAME: WM_ACTIVATE %x %x %x", hwnd, mp1, mp2));
         if(win32wnd->IsWindowCreated())
           win32wnd->DispatchMsgA(pWinMsg);

trunk/src/user32/pmwindow.cpp

@@ -1 @@
-/* $Id: pmwindow.cpp,v 1.90 2000-05-12 18:09:41 sandervl Exp $ */
+/* $Id: pmwindow.cpp,v 1.91 2000-05-24 19:30:06 sandervl Exp $ */
 /*
  * Win32 Window Managment Code for OS/2
@@ -96 +96 @@
      (PSZ)WIN32_STDCLASS,               /* Window class name            */
      (PFNWP)Win32WindowProc,            /* Address of window procedure  */
+#ifdef ODIN_HITTEST
+     0,
+#else
      CS_HITTEST,
+#endif
      NROF_WIN32WNDBYTES)) {
         dprintf(("WinRegisterClass Win32BaseWindow failed"));
@@ -105 +109 @@
      (PSZ)WIN32_STDCLASS2,              /* Window class name            */
      (PFNWP)Win32WindowProc,            /* Address of window procedure  */
+#ifdef ODIN_HITTEST
+     CS_SAVEBITS,
+#else
      CS_SAVEBITS | CS_HITTEST,
+#endif
      NROF_WIN32WNDBYTES)) {
         dprintf(("WinRegisterClass Win32BaseWindow failed"));
@@ -118 +126 @@
                           WIN32_INNERFRAME,
                           FrameClassInfo.pfnWindowProc,
+#ifdef ODIN_HITTEST
+                          FrameClassInfo.flClassStyle,
+#else
                           FrameClassInfo.flClassStyle | CS_HITTEST,
+#endif
                           FrameClassInfo.cbWindowData)) {
      dprintf (("WinRegisterClass Win32InnerFrame failed"));
@@ -263 +275 @@
     case WM_ACTIVATE:
     {
-        dprintf(("OS2: WM_ACTIVATE %x %x", hwnd, mp2));
+        dprintf(("OS2: WM_ACTIVATE %x %x %x", hwnd, mp1, mp2));
 
         if(win32wnd->IsWindowCreated())

trunk/src/user32/win32wbase.cpp

@@ -1 @@
-/* $Id: win32wbase.cpp,v 1.193 2000-05-22 19:05:58 sandervl Exp $ */
+/* $Id: win32wbase.cpp,v 1.194 2000-05-24 19:30:06 sandervl Exp $ */
 /*
  * Win32 Window Base Class for OS/2
@@ -1142 +1142 @@
 //******************************************************************************
 //******************************************************************************
+LONG Win32BaseWindow::sendHitTest(ULONG lParam)
+{
+    lastHitTestVal = SendInternalMessageA(WM_NCHITTEST, 0, lParam);
+    return lastHitTestVal;
+}
+//******************************************************************************
+//******************************************************************************
 BOOL Win32BaseWindow::isMDIClient()
 {
@@ -1387 +1394 @@
 
     case WM_ACTIVATE:
-      return 0;
+        /* The default action in Windows is to set the keyboard focus to
+         * the window, if it's being activated and not minimized */
+        if (LOWORD(wParam) != WA_INACTIVE) {
+                if(!(getStyle() & WS_MINIMIZE))
+                        SetFocus(getWindowHandle());
+        }
+        return 0;
 
     case WM_SETCURSOR:
@@ -2131 +2144 @@
    Win32BaseWindow *window;
    HWND hParent = 0;
-   BOOL fShow = FALSE;
 
     if (fuFlags &
@@ -2245 +2257 @@
     rc = OSLibWinSetMultWindowPos(&swp, 1);
 
-#ifdef DEBUG
-    if(fShow) {
-        dprintf(("Frame style 0x%08x, client style 0x%08x", OSLibQueryWindowStyle(OS2HwndFrame), OSLibQueryWindowStyle(OS2Hwnd)));
-    }
-#endif
-    if (rc == FALSE)
+    if(rc == FALSE)
     {
         dprintf(("OSLibWinSetMultWindowPos failed! Error %x",OSLibWinGetLastError()));
-    }
+        return 0;
+    }
+
     if((fuFlags & SWP_FRAMECHANGED) && (fuFlags & (SWP_NOMOVE | SWP_NOSIZE) == (SWP_NOMOVE | SWP_NOSIZE)))
     {

trunk/src/user32/win32wbase.h

@@ -1 @@
-/* $Id: win32wbase.h,v 1.94 2000-05-05 11:32:37 sandervl Exp $ */
+/* $Id: win32wbase.h,v 1.95 2000-05-24 19:30:07 sandervl Exp $ */
 /*
  * Win32 Window Base Class for OS/2
@@ -149 +149 @@
 
          LONG   getLastHitTestVal()             { return lastHitTestVal; }
+         LONG   sendHitTest(ULONG lParam);
 
          DWORD  getWindowContextHelpId()        { return contextHelpId; };

trunk/src/user32/win32wmdichild.cpp

@@ -1 @@
-/* $Id: win32wmdichild.cpp,v 1.22 2000-02-16 14:28:24 sandervl Exp $ */
+/* $Id: win32wmdichild.cpp,v 1.23 2000-05-24 19:30:08 sandervl Exp $ */
 /*
  * Win32 MDI Child Window Class for OS/2
@@ -99 +99 @@
 
     case WM_CHILDACTIVATE:
-        client->childActivate(this);
+        client->childActivate(this);
         return 0;
 
@@ -295 +295 @@
 
     /* this menu is needed to set a check mark in MDI_ChildActivate */
-    AppendMenuA(client->getMDIMenu(), MF_STRING ,wIDmenu, lpstrDef );
+    if(client->getMDIMenu())
+        AppendMenuA(client->getMDIMenu(), MF_STRING ,wIDmenu, lpstrDef );
 
     client->incNrActiveChildren();
@@ -347 +348 @@
     if(newchild && GetLastError() == 0)
     {
+        /* All MDI child windows have the WS_EX_MDICHILD style */
+        newchild->setExStyle(newchild->getExStyle() | WS_EX_MDICHILD);
+
         newchild->menuModifyItem();
 
@@ -363 +367 @@
              * the SWP_SHOWWINDOW command.
              */
-            newchild->SetWindowLongA(GWL_STYLE, newchild->getStyle() & ~WS_VISIBLE);
+            newchild->setStyle(newchild->getStyle() & ~WS_VISIBLE);
+
             if(showflag){
-                newchild->SetWindowPos(0, 0, 0, 0, 0, SWP_SHOWWINDOW | SWP_NOSIZE | SWP_NOMOVE );
+                dprintf(("newchild->SetWindowPos active window %x", GetActiveWindow()));
+                newchild->SetWindowPos(HWND_TOP, 0, 0, 0, 0, SWP_SHOWWINDOW | SWP_NOSIZE | SWP_NOMOVE );
+                dprintf(("newchild->SetWindowPos active window %x", GetActiveWindow()));
 
                 /* Set maximized state here in case hwnd didn't receive WM_SIZE
@@ -382 +389 @@
             else
                 /* needed, harmless ? */
-                newchild->SetWindowPos(0, 0, 0, 0, 0, SWP_NOACTIVATE | SWP_NOSIZE | SWP_NOMOVE );
+                newchild->SetWindowPos(HWND_TOP, 0, 0, 0, 0, SWP_NOACTIVATE | SWP_NOSIZE | SWP_NOMOVE );
 
         }
@@ -389 +396 @@
     {
         client->decNrActiveChildren();
-        DeleteMenu(client->getMDIMenu(), wIDmenu,MF_BYCOMMAND);
+        if(client->getMDIMenu()) {
+                DeleteMenu(client->getMDIMenu(), wIDmenu,MF_BYCOMMAND);
+        }
 
         maximizedChild = client->getMaximizedChild();

trunk/src/user32/win32wmdiclient.cpp

@@ -1 @@
-/* $Id: win32wmdiclient.cpp,v 1.26 2000-03-18 16:13:40 cbratschi Exp $ */
+/* $Id: win32wmdiclient.cpp,v 1.27 2000-05-24 19:30:08 sandervl Exp $ */
 /*
  * Win32 MDI Client Window Class for OS/2
@@ -333 +333 @@
     }
 
+    /* Don't activate if it is already active. Might happen 
+       since ShowWindow DOES activate MDI children */
+    if(activeChild == child)
+    {
+        return 0;
+    }
+
     if( GetActiveWindow() == getParent()->getWindowHandle())
         isActiveFrameWnd = TRUE;