Changeset 2835 for trunk/src

Timestamp:

Feb 20, 2000, 7:29:58 PM (26 years ago)

Author:

cbratschi

Message:

* empty log message *

Location:

trunk/src/comctl32

Files:

• tooltips.c (modified) (2 diffs)
• trackbar.c (modified) (3 diffs)
• treeview.c (modified) (76 diffs)

trunk/src/comctl32/tooltips.c

@@ -1 @@
-/* $Id: tooltips.c,v 1.21 2000-02-16 17:22:18 cbratschi Exp $ */
+/* $Id: tooltips.c,v 1.22 2000-02-20 18:29:56 cbratschi Exp $ */
 /*
  * Tool tip control
@@ -244 +244 @@
 
     *lpRect = rc;
-
 }
 

trunk/src/comctl32/trackbar.c

@@ -1 @@
-/* $Id: trackbar.c,v 1.25 2000-02-17 17:26:50 cbratschi Exp $ */
+/* $Id: trackbar.c,v 1.26 2000-02-20 18:29:57 cbratschi Exp $ */
 /*
  * Trackbar control
@@ -1737 +1737 @@
       ti.hwnd     = hwnd;
       ti.uId      = 0;
-      ti.lpszText = ""; /* LPSTR_TEXTCALLBACK */
+      ti.lpszText = "";
       SetRectEmpty(&ti.rect);
 
@@ -1883 +1883 @@
            ti.uId      = 0;
            ti.hwnd     = (UINT)hwnd;
-           ti.hinst = 0;
+           ti.hinst    = 0;
            sprintf (buf,"%d",infoPtr->nPos);
            ti.lpszText = (LPSTR)buf;

trunk/src/comctl32/treeview.c

@@ -1 @@
-/* $Id: treeview.c,v 1.28 2000-02-18 17:13:39 cbratschi Exp $ */
+/* $Id: treeview.c,v 1.29 2000-02-20 18:29:58 cbratschi Exp $ */
 /* Treeview control
  *
@@ -6 +6 @@
  * Copyright 1999 Sylvain St-Germain
  * Copyright 1999 Achim Hasenmueller
- * Copyright 1999-2000 Christoph Bratschi
+ * Copyright 1999-2000 Christoph Bratschi (cbratschi@datacomm.ch)
  *
  *
@@ -12 +12 @@
  *   Using DPA to store the item ptr would be good.
  *  -check custom draw
- *   FIXME: check fontsize. (uRealItemHeight)
                         uHotItem
  *   use separate routine to get item text/image.
@@ -32 +31 @@
 
 /* CB: todo
-
  - bug in SetScrollInfo/ShowScrollBar: WM_SIZE and WM_NCPAINT problems (i.e. RegEdit)
+ - tooltips not finished
+ - expand not finished
  - TVS_FULLROWSELECT
- - TVS_SINGLEEXPAND
  - TVS_TRACKSELECT (called hottrack)
- - TVS_INFOTIP, TVS_NOTOOLTIPS and tooltip support
  - WM_ENABLE: draw disabled control
 */
 
+#include <stdlib.h>
 #include <string.h>
+#include <math.h>
 #include "winbase.h"
 #include "wingdi.h"
@@ -71 +71 @@
 static BOOL    TREEVIEW_SendCustomDrawItemNotify (HWND hwnd, HDC hdc, TREEVIEW_ITEM *tvItem, UINT uItemDrawState);
 static LRESULT TREEVIEW_SelectItem (HWND hwnd, WPARAM wParam, LPARAM lParam);
-static LRESULT TREEVIEW_DoSelectItem (HWND hwnd, INT action, HTREEITEM newSelect, INT cause);
+static LRESULT TREEVIEW_DoSelectItem(HWND hwnd,INT action,HTREEITEM newSelect,INT cause);
 static void    TREEVIEW_Refresh(HWND hwnd);
 static void    TREEVIEW_Draw(HWND hwnd,HDC hdc,RECT *updateRect);
@@ -409 +409 @@
         infoPtr->uNumPtrsAlloced=0;
         infoPtr->uMaxHandle=0;
-        infoPtr->cx = infoPtr->cy = 0;
+        infoPtr->lefttop.x = infoPtr->lefttop.y = 0;
     }
 }
@@ -456 +456 @@
   INT cx,cy,prevHeight = infoPtr->uItemHeight;
 
-  if (wParam==-1)
+  if (wParam == -1)
   {
     infoPtr->uItemHeight = -1;
@@ -469 +469 @@
 
   if (!(GetWindowLongA(hwnd, GWL_STYLE) & TVS_NONEVENHEIGHT))
-    if (infoPtr->uItemHeight & 0x1) infoPtr->uItemHeight += 1;
+    if (infoPtr->uItemHeight & 0x1) infoPtr->uItemHeight++;
 
   return prevHeight;
@@ -645 +645 @@
                    item->rect.bottom-3:  /* is linked to an icon       */
                    item->rect.bottom+1;  /* is linked to a +/- box     */
-    points[1].x = points[0].x = 28+20*item->iLevel-infoPtr->cx;
+    points[1].x = points[0].x = 28+20*item->iLevel-infoPtr->lefttop.x;
     points[1].y = (lastItem->rect.top+lastItem->rect.bottom)/2;  /* is linked to a +/- box     */
 #ifdef OS2LINEHACK
@@ -677 +677 @@
   }
 
-  //CB: what does COMCTL 5.0 with CDRF_NEWFONT? recalc items?
+  //CDRF_NEWFONT: CCM_SETVERSION < 5 clips text (what we do now)
+  //                             > 5 ??? recalc?
 
   /*
@@ -727 +728 @@
       } else
       {
-        points[1].x = 8+(20*item->iLevel)-infoPtr->cx;
+        points[1].x = 8+(20*item->iLevel)-infoPtr->lefttop.x;
         points[1].y = points[0].y = center;
         points[0].x = points[1].x + 10;
@@ -815 +816 @@
     }
 
-    if (himlp)
+    if (himlp && (imageIndex != I_IMAGENONE))
     {
       int ovlIdx = 0;
@@ -1316 +1317 @@
   BOOL ownDC = FALSE,changedLeftTop = FALSE;
   DWORD dwStyle = GetWindowLongA(hwnd,GWL_STYLE);
-  INT maxCX,maxCY;
-  INT xDiff = 0,yDiff = 0;
+  INT maxXScroll,maxYScroll;
+  INT xDiff,yDiff;
+  HFONT oldFont;
 
   GetClientRect(hwnd,&rect);
   infoPtr->uVisibleHeight = rect.bottom-rect.top;
   infoPtr->uVisibleWidth = rect.right-rect.left;
+
+  if (infoPtr->uInternalStatus & TV_CALCALL)
+  {
+    itemHeight = 0;
+    ImageList_GetIconSize (infoPtr->himlNormal, &x, &itemHeight);
+    itemHeight = MAX(infoPtr->uItemHeight,itemHeight);
+
+    if (!hdc)
+    {
+      ownDC = TRUE;
+      hdc = GetDC(hwnd);
+    }
+
+    oldFont = SelectObject(hdc,infoPtr->hFont);
+    GetTextMetricsA(hdc,&tm);
+    itemHeight = MAX(tm.tmHeight+tm.tmExternalLeading,itemHeight);
+    SelectObject(hdc,infoPtr->hBoldFont);
+    GetTextMetricsA(hdc,&tm);
+    itemHeight = MAX(tm.tmHeight+tm.tmExternalLeading,itemHeight);
+    SelectObject(hdc,oldFont);
+    if (!(dwStyle & TVS_NONEVENHEIGHT))
+      if (itemHeight & 0x1) itemHeight++; //important for PS_DOT pen!
+    infoPtr->uRealItemHeight = itemHeight;
+    infoPtr->uVScrollStep = itemHeight+ITEM_VSPACE;
+  } else
+  {
+    itemHeight = infoPtr->uRealItemHeight;
+  }
+  infoPtr->uTotalWidth = 0;
+
   view = rect;
-  OffsetRect(&view,infoPtr->cx,infoPtr->cy);
-
-  itemHeight = 0;
-  ImageList_GetIconSize (infoPtr->himlNormal, &x, &itemHeight);
-  itemHeight = MAX(infoPtr->uItemHeight,itemHeight);
-
-  if (!hdc)
-  {
-    ownDC = TRUE;
-    hdc = GetDC(hwnd);
-  }
-
-  GetTextMetricsA (hdc, &tm);
-  itemHeight = MAX(tm.tmHeight+tm.tmExternalLeading,itemHeight);
-  if (!(dwStyle & TVS_NONEVENHEIGHT))
-    if (itemHeight & 0x1) itemHeight += 1; //important for PS_DOT pen!
-  infoPtr->uRealItemHeight = itemHeight;
-  infoPtr->uTotalWidth = 0;
+  OffsetRect(&view,infoPtr->lefttop.x,infoPtr->lefttop.y);
 
   iItem = (INT)infoPtr->TopRootItem;
@@ -1352 +1367 @@
     item->iLevel = indent;
 
-    height = itemHeight * item->iIntegral +1;
+    height = itemHeight*item->iIntegral+ITEM_VSPACE;
 
     //calculate size and fill rects
     if ((infoPtr->uInternalStatus & TV_CALCALL) || !item->calculated)
     {
-      item->rect.top    = y-infoPtr->cy;
+      item->rect.top    = y-view.top;
       item->rect.bottom = item->rect.top+height;
-      item->rect.left   = x-infoPtr->cx;
+      item->rect.left   = x-view.left;
       item->rect.right  = rect.right; //dummy
+      if (!hdc)
+      {
+        ownDC = TRUE;
+        hdc = GetDC(hwnd);
+      }
       TREEVIEW_CalcItem(hwnd,hdc,dwStyle,infoPtr,item);
     } else
@@ -1366 +1386 @@
       INT xOffset,yOffset;
 
-      xOffset = (x-infoPtr->cx)-item->rect.left;
-      yOffset = (y-infoPtr->cy)-item->rect.top;
+      xOffset = (x-view.left)-item->rect.left;
+      yOffset = (y-view.top)-item->rect.top;
       OffsetRect(&item->rect,xOffset,yOffset);
       OffsetRect(&item->text,xOffset,yOffset);
@@ -1374 +1394 @@
       OffsetRect(&item->statebitmap,xOffset,yOffset);
     }
-    infoPtr->uTotalWidth = MAX(infoPtr->uTotalWidth,item->rect.right+infoPtr->cx);
-
-    if (((y >= view.top) && (y <= view.bottom)) || ((y+height >= view.top) && (y+height <= view.bottom)))
+    infoPtr->uTotalWidth = MAX(infoPtr->uTotalWidth,item->rect.right+infoPtr->lefttop.x);
+
+    if (((y >= view.top) && (y < view.bottom)) || ((y+height > view.top) && (y+height <= view.bottom)))
     {
       item->visible = TRUE;
@@ -1410 +1430 @@
 
   //check cx and cy
-  maxCY = infoPtr->uTotalHeight-infoPtr->uVisibleHeight;
-  if (maxCY < 0) maxCY = 0;
-  if (infoPtr->cy > maxCY)
-  {
-    yDiff = maxCY-infoPtr->cy;
-    infoPtr->cy = maxCY;
-  }
-
-  maxCX = infoPtr->uTotalWidth-infoPtr->uVisibleWidth;
-  if (maxCX < 0) maxCX = 0;
-  if (infoPtr->cx > maxCX)
-  {
-    xDiff = maxCX-infoPtr->cx;
-    infoPtr->cx = maxCX;
+  yDiff = xDiff = 0;
+
+  maxYScroll = infoPtr->uTotalHeight-infoPtr->uVisibleHeight;
+  if (maxYScroll < 0) maxYScroll = 0;
+  if (infoPtr->lefttop.y > maxYScroll)
+  {
+    INT mod = maxYScroll % infoPtr->uVScrollStep;
+
+    if (mod > 0) maxYScroll += infoPtr->uVScrollStep-mod;
+    yDiff = infoPtr->lefttop.y-maxYScroll;
+    infoPtr->lefttop.y = maxYScroll;
+  }
+
+  maxXScroll = infoPtr->uTotalWidth-infoPtr->uVisibleWidth;
+  if (maxXScroll < 0) maxXScroll = 0;
+  if (infoPtr->lefttop.x > maxXScroll)
+  {
+    xDiff = infoPtr->lefttop.x-maxXScroll;
+    infoPtr->lefttop.x = maxXScroll;
   }
 
@@ -1432 +1457 @@
     item = NULL;
     indent = 0;
+    infoPtr->firstVisible = 0;
 
     while (iItem)
@@ -1441 +1467 @@
       OffsetRect(&item->bitmap,xDiff,yDiff);
       OffsetRect(&item->statebitmap,xDiff,yDiff);
+
+      y = view.top+item->rect.top;
+      if (((y >= view.top) && (y < view.bottom)) || ((y+height > view.top) && (y+height <= view.bottom)))
+      {
+        item->visible = TRUE;
+        if (!infoPtr->firstVisible)
+          infoPtr->firstVisible = item->hItem;
+      } else item->visible = FALSE;
 
       if ((item->firstChild) && (item->state & TVIS_EXPANDED))
@@ -1468 +1502 @@
       info.nMin   = 0;
       info.nMax   = infoPtr->uTotalHeight-1;
-      info.nPos   = infoPtr->cy;
+      info.nPos   = infoPtr->lefttop.y;
       info.nPage  = MAX(infoPtr->uVisibleHeight,1);
       info.fMask = SIF_RANGE | SIF_POS | SIF_PAGE;
@@ -1486 +1520 @@
       info.nMin   = 0;
       info.nMax   = infoPtr->uTotalWidth-1;
-      info.nPos   = infoPtr->cx;
+      info.nPos   = infoPtr->lefttop.x;
       info.nPage  = MAX(infoPtr->uVisibleWidth,1);
       info.fMask  = SIF_RANGE | SIF_POS | SIF_PAGE;
@@ -1678 +1712 @@
 
   if (tvItem->mask & TVIF_HANDLE)
-    tvItem->hItem=wineItem->hItem;
+    tvItem->hItem = wineItem->hItem;
 
   if (tvItem->mask & TVIF_IMAGE)
-    tvItem->iImage=wineItem->iImage;
+    tvItem->iImage = wineItem->iImage;
 
   if (tvItem->mask & TVIF_INTEGRAL)
-    tvItem->iIntegral=wineItem->iIntegral;
+    tvItem->iIntegral = wineItem->iIntegral;
 
   // undocumented: windows ignores TVIF_PARAM and
@@ -1691 +1725 @@
 
   if (tvItem->mask & TVIF_SELECTEDIMAGE)
-    tvItem->iSelectedImage=wineItem->iSelectedImage;
+    tvItem->iSelectedImage = wineItem->iSelectedImage;
 
   if (tvItem->mask & TVIF_STATE)
-    tvItem->state=wineItem->state & tvItem->stateMask;
+    tvItem->state = wineItem->state & tvItem->stateMask;
 
   if (tvItem->mask & TVIF_TEXT)
@@ -1916 +1950 @@
  * Forward the DPA local callback to the treeview owner callback
  */
-static INT WINAPI TREEVIEW_CallBackCompare(
-  LPVOID first,
-  LPVOID second,
-  LPARAM tvInfoPtr)
+static INT WINAPI TREEVIEW_CallBackCompare(LPVOID first,LPVOID second,LPARAM tvInfoPtr)
 {
   /* Forward the call to the client define callback */
   TREEVIEW_INFO *infoPtr = TREEVIEW_GetInfoPtr((HWND)tvInfoPtr);
+
   return (infoPtr->pCallBackSort->lpfnCompare)(
     ((TREEVIEW_ITEM*)first)->lParam,
@@ -1932 +1964 @@
  * Treeview native sort routine: sort on item text.
  */
-static INT WINAPI TREEVIEW_SortOnName (
-  LPVOID first,
-  LPVOID second,
-  LPARAM tvInfoPtr)
-{
-  HWND hwnd=(HWND) tvInfoPtr;
-  WCHAR *txt1, *txt2;
+static INT WINAPI TREEVIEW_SortOnName(LPVOID first,LPVOID second,LPARAM tvInfoPtr)
+{
+  HWND hwnd = (HWND)tvInfoPtr;
+  WCHAR *txt1,*txt2;
   TREEVIEW_ITEM *item;
 
-
-  item=(TREEVIEW_ITEM *) first;
-  if (item->pszText == LPSTR_TEXTCALLBACKW)  {
-         TREEVIEW_SendDispInfoNotify (hwnd, item, TVN_GETDISPINFO, TVIF_TEXT);
-        }
-  txt1=item->pszText;
-
-  item=(TREEVIEW_ITEM *) second;
-  if (item->pszText == LPSTR_TEXTCALLBACKW)  {
-         TREEVIEW_SendDispInfoNotify (hwnd, item, TVN_GETDISPINFO, TVIF_TEXT);
-        }
-  txt2=item->pszText;
-
-  return -lstrcmpW(txt1,txt2);
+  item = (TREEVIEW_ITEM *) first;
+  if (item->pszText == LPSTR_TEXTCALLBACKW)
+    TREEVIEW_SendDispInfoNotify (hwnd, item, TVN_GETDISPINFO, TVIF_TEXT);
+
+  txt1 = item->pszText;
+
+  item = (TREEVIEW_ITEM *) second;
+  if (item->pszText == LPSTR_TEXTCALLBACKW)
+    TREEVIEW_SendDispInfoNotify (hwnd, item, TVN_GETDISPINFO, TVIF_TEXT);
+
+  txt2 = item->pszText;
+
+  return lstrcmpW(txt1,txt2);
 }
 
@@ -1968 +1996 @@
  */
 
-static LRESULT WINAPI TREEVIEW_Sort (
-  HWND   hwnd,
-  BOOL   fRecurse,
-  HTREEITEM parent,
-  LPTVSORTCB pSort
-  )
+static LRESULT WINAPI TREEVIEW_Sort(HWND hwnd,BOOL fRecurse,HTREEITEM parent,LPTVSORTCB pSort)
 {
   TREEVIEW_INFO *infoPtr = TREEVIEW_GetInfoPtr(hwnd);
@@ -1979 +2002 @@
   INT            cChildren;
   HTREEITEM      hti;
+  BOOL root;
 
   /* Obtain the TVSORTBC struct */
@@ -1985 +2009 @@
   /* undocumented feature: TVI_ROOT means `sort the whole tree' */
 
-  if (parent==TVI_ROOT)
-    parent=infoPtr->TopRootItem;
+  if ((parent == TVI_ROOT) || (parent == 0))
+  {
+    root = TRUE;
+    parent = infoPtr->TopRootItem;
+  }
 
   /* Check for a valid handle to the parent item */
-  if (!TREEVIEW_ValidItem(infoPtr, parent))
-  {
-    //ERR ("invalid item hParent=%x\n", (INT)parent);
+  sortMe = TREEVIEW_ValidItem(infoPtr,parent);
+  if (!sortMe)
     return FALSE;
-  }
-
-  /* Obtain the parent node to sort */
-  sortMe = &infoPtr->items[ (INT)parent ];
 
   cChildren = 0;
-  for(hti = sortMe->firstChild; hti; hti = infoPtr->items[(INT)hti].sibling)
+  for(hti = root ? sortMe->hItem:sortMe->firstChild; hti; hti = infoPtr->items[(INT)hti].sibling)
       cChildren++;
 
   /* Make sure there is something to sort */
-  if ( cChildren > 1 )
+  if (cChildren > 1)
   {
     /* pointer organization */
     HDPA          sortList   = DPA_Create(cChildren);
-    HTREEITEM     itemHandle = sortMe->firstChild;
-    TREEVIEW_ITEM *itemPtr   = & infoPtr->items[ (INT)itemHandle ];
+    HTREEITEM     itemHandle = root ? sortMe->hItem:sortMe->firstChild;
+    TREEVIEW_ITEM *itemPtr   = &infoPtr->items[(INT)itemHandle];
 
     /* TREEVIEW_ITEM rechaining */
@@ -2019 +2041 @@
     do
     {
+      itemPtr    = &infoPtr->items[(INT)itemHandle];
       DPA_InsertPtr(
-        sortList,              /* the list */
+        sortList,      /* the list */
         cChildren+1,   /* force the insertion to be an append */
-        itemPtr);              /* the ptr to store */
+        itemPtr);      /* the ptr to store */
 
       /* Get the next sibling */
       itemHandle = itemPtr->sibling;
-      itemPtr    = & infoPtr->items[ (INT)itemHandle ];
-    } while ( itemHandle != NULL );
+    } while (itemHandle != NULL);
 
     /* let DPA perform the sort activity */
@@ -2037 +2059 @@
         else
                 DPA_Sort (
-                        sortList,                  /* what  */
-                TREEVIEW_SortOnName,       /* how   */
-                        hwnd);                     /* owner */
+                        sortList,            /* what  */
+                        TREEVIEW_SortOnName, /* how   */
+                        hwnd);               /* owner */
 
     /*
@@ -2048 +2070 @@
     /* Get the first item and get ready to start... */
     item = DPA_GetPtr(sortList, count++);
-    while ( (nextItem = DPA_GetPtr(sortList, count++)) != NULL )
+    while ((nextItem = DPA_GetPtr(sortList, count++)) != NULL)
     {
       /* link the two current item toghether */
@@ -2056 +2078 @@
       if (prevItem == NULL) /* this is the first item, update the parent */
       {
-        sortMe->firstChild                = ((TREEVIEW_ITEM*)item)->hItem;
+        if (root)
+          infoPtr->TopRootItem = ((TREEVIEW_ITEM*)item)->hItem;
+        else
+          sortMe->firstChild = ((TREEVIEW_ITEM*)item)->hItem;
         ((TREEVIEW_ITEM*)item)->upsibling = NULL;
       }
@@ -2073 +2098 @@
 
     DPA_Destroy(sortList);
+    TREEVIEW_QueueRefresh(hwnd);
 
     return TRUE;
@@ -2083 +2109 @@
  * and sort the children of the TV item specified in lParam
  */
-static LRESULT WINAPI TREEVIEW_SortChildrenCB(
-  HWND   hwnd,
-  WPARAM wParam,
-  LPARAM lParam
-  )
-{
-  LPTVSORTCB pSort=(LPTVSORTCB) lParam;
+static LRESULT WINAPI TREEVIEW_SortChildrenCB(HWND hwnd,WPARAM wParam,LPARAM lParam)
+{
+  LPTVSORTCB pSort = (LPTVSORTCB) lParam;
 
   return TREEVIEW_Sort (hwnd, wParam, pSort->hParent, pSort);
@@ -2098 +2120 @@
  * Sort the children of the TV item specified in lParam.
  */
-static LRESULT WINAPI TREEVIEW_SortChildren (
-  HWND   hwnd,
-  WPARAM wParam,
-  LPARAM lParam)
+static LRESULT WINAPI TREEVIEW_SortChildren(HWND hwnd,WPARAM wParam,LPARAM lParam)
 {
   return TREEVIEW_Sort (hwnd, (BOOL) wParam, (HTREEITEM) lParam, NULL);
@@ -2380 +2399 @@
    }
 
-
-   /* Fill in info structure */
-
-   wineItem->mask=tvItem->mask;
-   wineItem->iIntegral=1;
-
-   if (tvItem->mask & TVIF_CHILDREN)
-     wineItem->cChildren=tvItem->cChildren;
-
+  /* Fill in info structure */
+
+  wineItem->mask = tvItem->mask;
+  wineItem->iIntegral = 1;
+
+  if (tvItem->mask & TVIF_CHILDREN)
+    wineItem->cChildren=tvItem->cChildren;
 
   wineItem->expandBox.left   = 0; /* Initialize the expandBox */
@@ -2395 +2412 @@
   wineItem->expandBox.bottom = 0;
 
-   if (tvItem->mask & TVIF_IMAGE)
-        wineItem->iImage=tvItem->iImage;
-
-                /* If the application sets TVIF_INTEGRAL without
-                        supplying a TVITEMEX structure, it's toast */
-
-   if (tvItem->mask & TVIF_INTEGRAL)
-                wineItem->iIntegral=tvItem->iIntegral;
-
-   if (tvItem->mask & TVIF_SELECTEDIMAGE)
-        wineItem->iSelectedImage=tvItem->iSelectedImage;
-
-   if (tvItem->mask & TVIF_STATE) {
-        wineItem->state=tvItem->state;
-        wineItem->stateMask=tvItem->stateMask;
-   }
-
-   wineItem->calculated = FALSE;
-   TREEVIEW_QueueRefresh(hwnd);
-
-   return (LRESULT) iItem;
+  if (tvItem->mask & TVIF_IMAGE)
+   wineItem->iImage = tvItem->iImage;
+
+  /* If the application sets TVIF_INTEGRAL without
+     supplying a TVITEMEX structure, it's toast */
+
+  if (tvItem->mask & TVIF_INTEGRAL)
+    wineItem->iIntegral = tvItem->iIntegral;
+
+  if (tvItem->mask & TVIF_SELECTEDIMAGE)
+    wineItem->iSelectedImage = tvItem->iSelectedImage;
+
+  if (tvItem->mask & TVIF_STATE)
+  {
+    wineItem->state = tvItem->state;
+    wineItem->stateMask = tvItem->stateMask;
+  }
+
+  wineItem->calculated = FALSE;
+  TREEVIEW_QueueRefresh(hwnd);
+
+  return (LRESULT) iItem;
 }
 
@@ -2634 +2652 @@
 
   if (wParam == SIZE_RESTORED)
-  {
     if (TREEVIEW_CalcItems(hwnd,0,infoPtr))
-#if 1 //CB: synchron update conflicts with Odin32 implementation -> check and fix
-      TREEVIEW_QueueRefresh(hwnd);
-#else
-      TREEVIEW_Refresh(hwnd); //because size redraw isn't set
-#endif
-  }
+      TREEVIEW_Refresh(hwnd);
 
   return TRUE;
@@ -2689 +2701 @@
 
   /* set default settings */
-  infoPtr->uInternalStatus = 0;
+  infoPtr->uInternalStatus = TV_CALCALL;
   if (IsWindowUnicode(hwnd)) infoPtr->uInternalStatus |= TV_UNICODE;
   infoPtr->uNumItems = 0;
@@ -2695 +2707 @@
   infoPtr->clrLine = GetSysColor (COLOR_WINDOWTEXT);
   infoPtr->clrInsertMark = GetSysColor (COLOR_BTNTEXT);
-  infoPtr->cy = 0;
-  infoPtr->cx = 0;
+  infoPtr->lefttop.y = 0;
+  infoPtr->lefttop.x = 0;
   infoPtr->uIndent = 15;
   infoPtr->himlNormal = NULL;
@@ -2702 +2714 @@
   infoPtr->uItemHeight = -1;
   infoPtr->uRealItemHeight = 0;
+  infoPtr->uVScrollStep = 1;
   infoPtr->uVisibleHeight = lpcs->cy;
   infoPtr->uTotalHeight = 0;
@@ -2725 +2738 @@
   infoPtr->uISearchLen = 0;
 
+  infoPtr->tipItem = 0;
   infoPtr->hwndToolTip = 0;
   if (!(dwStyle & TVS_NOTOOLTIPS))
@@ -2752 +2766 @@
     ZeroMemory (&ti, sizeof(TTTOOLINFOA));
     ti.cbSize   = sizeof(TTTOOLINFOA);
-    ti.uFlags   = TTF_IDISHWND | TTF_TRACK | TTF_TRANSPARENT;
+    ti.uFlags   = TTF_TRACK | TTF_ABSOLUTE;
     ti.hwnd     = hwnd;
     ti.uId      = 0;
-    ti.lpszText = "Test"; /* LPSTR_TEXTCALLBACK; */
+    ti.lpszText = "";
     SetRectEmpty (&ti.rect);
 
@@ -2887 +2901 @@
 TREEVIEW_SendTreeviewNotify (HWND hwnd, UINT code, UINT action,
                         HTREEITEM oldItem, HTREEITEM newItem)
-
 {
   TREEVIEW_INFO *infoPtr = TREEVIEW_GetInfoPtr(hwnd);
@@ -2895 +2908 @@
   BOOL unicode = IsWindowUnicode(parent),rc;
   CHAR *oldText = NULL,*newText = NULL;
-
-//  TRACE (treeview,"code:%x action:%x olditem:%x newitem:%x\n",
-//                code,action,(INT)oldItem,(INT)newItem);
 
   ZeroMemory(&nmhdr,sizeof(NMTREEVIEWW));
@@ -2979 +2989 @@
   TREEVIEW_ITEM  *wineItem;
 
-//  TRACE (treeview,"code:%x dragitem:%x\n", code,(INT)dragItem);
-
   nmhdr.hdr.hwndFrom = hwnd;
   nmhdr.hdr.idFrom =  GetWindowLongA( hwnd, GWL_ID);
@@ -3078 +3086 @@
   LPNMCUSTOMDRAW nmcd;
 
-//  TRACE (treeview,"drawstage:%lx hdc:%x\n", dwDrawStage, hdc);
-
   nmcd= & nmcdhdr.nmcd;
   nmcd->hdr.hwndFrom = hwnd;
@@ -3085 +3091 @@
   nmcd->hdr.code   = NM_CUSTOMDRAW;
   nmcd->dwDrawStage= dwDrawStage;
-  nmcd->hdc                = hdc;
+  nmcd->hdc        = hdc;
   nmcd->rc.left    = rc.left;
   nmcd->rc.right   = rc.right;
@@ -3219 +3225 @@
       if (flag & TVE_EXPANDPARTIAL)
       {
-        //TRACE(treeview, "  case TVE_EXPANDPARTIAL\n");
-        //FIXME (treeview, "TVE_EXPANDPARTIAL not implemented\n");
 return FALSE; //CB: to check
         wineItem->state ^=TVIS_EXPANDED;
@@ -3623 +3627 @@
   ht.pt.y = (INT)HIWORD(lParam);
 
-  if (!TREEVIEW_HitTest(hwnd,&ht)) return 0;
+  TREEVIEW_HitTest(hwnd,&ht);
 
   if (ht.hItem)
   {
+    DWORD dwStyle = GetWindowLongA(hwnd,GWL_STYLE);
+
     item = &infoPtr->items[(INT)ht.hItem];
+
+    if (infoPtr->hwndToolTip && ((item->text.left < 0) || (item->text.right > infoPtr->uVisibleWidth)) && (infoPtr->tipItem != item->hItem))
+    {
+      DWORD dwStyle = GetWindowLongA(hwnd,GWL_STYLE);
+      LPWSTR text;
+      TTTOOLINFOW ti;
+      POINT pt;
+
+      if(dwStyle & TVS_INFOTIP)
+      {
+        NMTVGETINFOTIPW tvgit;
+        HWND parent = GetParent(hwnd);
+        BOOL unicode = IsWindowUnicode(parent);
+
+        tvgit.hdr.hwndFrom = hwnd;
+        tvgit.hdr.idFrom   =  GetWindowLongA(hwnd,GWL_ID);
+        tvgit.hdr.code     = unicode ? TVN_GETINFOTIPW:TVN_GETINFOTIPA;
+        tvgit.pszText    = COMCTL32_Alloc(unicode ? INFOTIPSIZE*sizeof(WCHAR):INFOTIPSIZE*sizeof(CHAR));
+        tvgit.cchTextMax = INFOTIPSIZE;
+        tvgit.hItem      = item->hItem;
+        tvgit.lParam     = item->lParam;
+
+        if (unicode)
+        {
+          SendMessageW(parent,WM_NOTIFY,(WPARAM)tvgit.hdr.idFrom,(LPARAM)&tvgit);
+          text = tvgit.pszText;
+        } else
+        {
+          SendMessageA(parent,WM_NOTIFY,(WPARAM)tvgit.hdr.idFrom,(LPARAM)&tvgit);
+          text = COMCTL32_Alloc(tvgit.cchTextMax*sizeof(WCHAR));
+          lstrcpyAtoW(text,(LPSTR)tvgit.pszText);
+        }
+      } else
+      {
+        if (item->pszText == LPSTR_TEXTCALLBACKW)
+          TREEVIEW_SendDispInfoNotify(hwnd,item,TVN_GETDISPINFO,TVIF_TEXT);
+
+        text = item->pszText;
+      }
+#if 0 //CB: not yet
+      infoPtr->tipItem = item->hItem;
+      ti.cbSize   = sizeof(ti);
+      ti.uId      = 0;
+      ti.hwnd     = hwnd;
+      ti.hinst    = 0;
+      ti.lpszText = text;
+      pt.x = ti.rect.left;
+      pt.y = ti.rect.top;
+      ClientToScreen(hwnd,&pt);
+      SendMessageA(infoPtr->hwndToolTip,TTM_TRACKPOSITION,0,(LPARAM)MAKELPARAM(pt.x,pt.y));
+      SendMessageA(infoPtr->hwndToolTip,TTM_UPDATETIPTEXTW,0,(LPARAM)&ti);
+      SendMessageA(infoPtr->hwndToolTip,TTM_TRACKACTIVATE,(WPARAM)TRUE,(LPARAM)&ti);
+#endif
+      if (text != item->pszText) COMCTL32_Free(text);
+    }
+
+    if (dwStyle & TVS_TRACKSELECT)
+    {
+      //CB: todo: hottracking
+    }
   }
 
@@ -3666 +3732 @@
   if (ht.flags & TVHT_ONITEMBUTTON)
   {
-     TREEVIEW_Expand (hwnd, (WPARAM) TVE_TOGGLE, (LPARAM) ht.hItem);
-     goto setfocus;
-  }
-  else if (bTrack)
-  {
-     if (TREEVIEW_TrackMouse(hwnd, ht.pt))
-     {
-        TREEVIEW_SendTreeviewDnDNotify (hwnd, TVN_BEGINDRAG, ht.hItem, ht.pt);
-        infoPtr->dropItem = ht.hItem;
-        return 0;
-     }
+    TREEVIEW_Expand (hwnd, (WPARAM) TVE_TOGGLE, (LPARAM) ht.hItem);
+    goto setfocus;
+  } else if (bTrack)
+  {
+    if (TREEVIEW_TrackMouse(hwnd, ht.pt))
+    {
+      TREEVIEW_SendTreeviewDnDNotify (hwnd, TVN_BEGINDRAG, ht.hItem, ht.pt);
+      infoPtr->dropItem = ht.hItem;
+      return 0;
+    }
   }
 
@@ -3686 +3751 @@
    * and the click occured on the item label...
    */
-  if ( ( dwStyle & TVS_EDITLABELS ) &&
-       ( ht.flags & TVHT_ONITEMLABEL ) &&
-       ( infoPtr->selectedItem == ht.hItem ) )
-  {
-       if (infoPtr->Timer & TV_EDIT_TIMER_SET)
-          KillTimer (hwnd, TV_EDIT_TIMER);
-
-       infoPtr->editItem = ht.hItem;
-       SetTimer (hwnd, TV_EDIT_TIMER, GetDoubleClickTime(), 0);
-       infoPtr->Timer|=TV_EDIT_TIMER_SET;
+  if ((dwStyle & TVS_EDITLABELS) && (ht.flags & TVHT_ONITEMLABEL) && (infoPtr->selectedItem == ht.hItem))
+  {
+    if (infoPtr->Timer & TV_EDIT_TIMER_SET)
+      KillTimer (hwnd, TV_EDIT_TIMER);
+
+    infoPtr->editItem = ht.hItem;
+    SetTimer (hwnd, TV_EDIT_TIMER, GetDoubleClickTime(), 0);
+    infoPtr->Timer|=TV_EDIT_TIMER_SET;
+  } else if (ht.flags & (TVHT_ONITEMLABEL | TVHT_ONITEMICON))
+  {
+    TREEVIEW_DoSelectItem(hwnd,TVGN_CARET,ht.hItem,TVC_BYMOUSE);
+  } else if (ht.flags & TVHT_ONITEMSTATEICON)
+  {
+    if (dwStyle & TVS_CHECKBOXES)  /* TVS_CHECKBOXES requires _us_ */
+    {                              /* to toggle the current state  */
+      int state;
+      TREEVIEW_ITEM *wineItem;
+
+      wineItem = TREEVIEW_ValidItem(infoPtr, ht.hItem);
+
+      state = 1-(wineItem->state>>12);
+      wineItem->state &= ~TVIS_STATEIMAGEMASK;
+      wineItem->state |= state<<12;
+      if (wineItem->visible)
+      {
+        TREEVIEW_UnqueueRefresh(hwnd,TRUE,TRUE);
+        InvalidateRect(hwnd,&wineItem->statebitmap,TRUE);
       }
-  else if ( ht.flags & (TVHT_ONITEMLABEL | TVHT_ONITEMICON))
-  {
-     TREEVIEW_DoSelectItem ( hwnd, TVGN_CARET, ht.hItem, TVC_BYMOUSE);
-  }
-  else if (ht.flags & TVHT_ONITEMSTATEICON)
-  {
-     if (dwStyle & TVS_CHECKBOXES)  /* TVS_CHECKBOXES requires _us_ */
-     {                              /* to toggle the current state  */
-       int state;
-       TREEVIEW_ITEM *wineItem;
-
-       wineItem = TREEVIEW_ValidItem(infoPtr, ht.hItem);
-
-       state = 1-(wineItem->state>>12);
-       wineItem->state &= ~TVIS_STATEIMAGEMASK;
-       wineItem->state |= state<<12;
-       if (wineItem->visible)
-       {
-         TREEVIEW_UnqueueRefresh(hwnd,TRUE,TRUE);
-         InvalidateRect(hwnd,&wineItem->statebitmap,TRUE);
-       }
-     }
+    }
   }
 
 setfocus:
   SetFocus (hwnd);
+
   return 0;
 }
@@ -3799 +3861 @@
  hOldFont=SelectObject (hdc, infoPtr->hFont);
  GetTextExtentPoint32W (hdc, itemtxt, lstrlenW (itemtxt), &size);
-// TRACE (treeview,"%d %d %s %d\n",size.cx,size.cy,itemtxt,lstrlenA(itemtxt));
+
  hbmp=CreateCompatibleBitmap (htopdc, size.cx, size.cy);
  hOldbmp=SelectObject (hdc, hbmp);
@@ -3837 +3899 @@
   TREEVIEW_INFO *infoPtr = TREEVIEW_GetInfoPtr(hwnd);
   TREEVIEW_ITEM *prevItem,*wineItem;
+  DWORD dwStyle = GetWindowLongA(hwnd,GWL_STYLE);
   INT prevSelect;
 
@@ -3867 +3930 @@
 
       if (newSelect)
-        if (TREEVIEW_SendTreeviewNotify(
-              hwnd,
-              TVN_SELCHANGING,
-              cause,
-              (HTREEITEM)prevSelect,
-              (HTREEITEM)newSelect))
+        if (TREEVIEW_SendTreeviewNotify(hwnd,TVN_SELCHANGING,cause,(HTREEITEM)prevSelect,(HTREEITEM)newSelect))
           return FALSE;       /* FIXME: OK? */
 
@@ -3882 +3940 @@
       infoPtr->selectedItem = (HTREEITEM)newSelect;
 
+      if ((cause == TVC_BYMOUSE) && (dwStyle & TVS_SINGLEEXPAND))
+      {
+        BOOL control = GetKeyState(VK_CONTROL) & 0x8000;
+        UINT rc = TREEVIEW_SendTreeviewNotify(hwnd,TVN_SINGLEEXPAND,0,prevItem->hItem,wineItem->hItem);
+
+        if (!(rc & TVNRET_SKIPOLD) && !control && prevItem->state & TVIS_EXPANDED)
+          TREEVIEW_Expand(hwnd,TVE_COLLAPSE,(LPARAM)prevItem->hItem);
+        if (!(rc & TVNRET_SKIPNEW) && TREEVIEW_HasChildren(hwnd,wineItem))
+          TREEVIEW_Expand(hwnd,TVE_TOGGLE,(LPARAM)wineItem->hItem);
+      }
+
       TREEVIEW_UnqueueRefresh(hwnd,TRUE,TRUE);
       TREEVIEW_RefreshItem(hwnd,prevItem,FALSE);
       TREEVIEW_RefreshItem(hwnd,wineItem,FALSE);
 
-      TREEVIEW_SendTreeviewNotify(
-        hwnd,
-        TVN_SELCHANGED,
-        cause,
-        (HTREEITEM)prevSelect,
-        (HTREEITEM)newSelect);
+      TREEVIEW_SendTreeviewNotify(hwnd,TVN_SELCHANGED,cause,(HTREEITEM)prevSelect,(HTREEITEM)newSelect);
 
       break;
@@ -3914 +3978 @@
     case TVGN_FIRSTVISIBLE:
     {
+      TREEVIEW_ITEM *firstVis;
       INT scrollY;
+
+      if (!infoPtr->firstVisible) return FALSE;
+
+      firstVis = &infoPtr->items[(INT)infoPtr->firstVisible];
 
       if (wineItem->rect.top < 0)
@@ -3920 +3989 @@
       else
       {
-        scrollY = MIN(wineItem->rect.top,infoPtr->uTotalHeight-infoPtr->uVisibleHeight);
-        if (scrollY < 0) scrollY = 0;
+        scrollY = MIN(wineItem->rect.top,(infoPtr->uTotalHeight-infoPtr->uVisibleHeight)-infoPtr->lefttop.y);
+        scrollY -= scrollY % infoPtr->uVScrollStep;
       }
 
       if (scrollY != 0)
       {
-        infoPtr->cy += scrollY;
+        infoPtr->lefttop.y += scrollY;
         if (!TREEVIEW_UnqueueRefresh(hwnd,TRUE,TRUE))
           TREEVIEW_CalcItems(hwnd,0,infoPtr);
@@ -3974 +4043 @@
   infoPtr->hBoldFont = CreateFontIndirectA (&logFont);
 
-  hdc = GetDC(hwnd);
-  hOldFont = SelectObject (hdc, hFont);
-  GetTextMetricsA (hdc, &tm);
-  height= tm.tmHeight + tm.tmExternalLeading;
-  if (height > infoPtr->uRealItemHeight)
-    infoPtr->uRealItemHeight = height;
-  SelectObject (hdc, hOldFont);
-  ReleaseDC(hwnd,hdc);
+  infoPtr->uInternalStatus |= TV_CALCALL;
+  TREEVIEW_CalcItems(hwnd,0,infoPtr);
 
   if (lParam)
   {
     TREEVIEW_UnqueueRefresh(hwnd,FALSE,FALSE);
-    infoPtr->uInternalStatus |= TV_CALCALL;
-    TREEVIEW_CalcItems(hwnd,0,infoPtr);
     TREEVIEW_Refresh(hwnd);
-  } else infoPtr->uInternalStatus |= TV_CALCALL;
+  }
 
   return 0;
 }
-
 
 static LRESULT
@@ -3999 +4059 @@
 {
   TREEVIEW_INFO *infoPtr = TREEVIEW_GetInfoPtr(hwnd);
-  int maxHeight;
-  int lastPos = infoPtr->cy;
+  INT scrollY;
+  INT maxY = infoPtr->uTotalHeight-infoPtr->uVisibleHeight;
 
   if (!(infoPtr->uInternalStatus & TV_VSCROLL)) return FALSE;
@@ -4007 +4067 @@
   {
     case SB_LINEUP:
-      if (!infoPtr->cy) return FALSE;
-      infoPtr->cy -= infoPtr->uRealItemHeight;
-      if (infoPtr->cy < 0) infoPtr->cy = 0;
+      scrollY = MIN(infoPtr->uVScrollStep,infoPtr->lefttop.y);
       break;
 
     case SB_LINEDOWN:
-      maxHeight = infoPtr->uTotalHeight-infoPtr->uVisibleHeight;
-      if (maxHeight <= 0) return FALSE;
-      if (infoPtr->cy == maxHeight) return FALSE;
-      infoPtr->cy += infoPtr->uRealItemHeight;
-      if (infoPtr->cy > maxHeight)
-        infoPtr->cy = maxHeight;
+      scrollY = -infoPtr->uVScrollStep;
+      if (infoPtr->lefttop.y-scrollY > maxY) scrollY = -(maxY-infoPtr->lefttop.y);
       break;
 
     case SB_PAGEUP:
-      if (!infoPtr->cy) return FALSE;
-      infoPtr->cy -= infoPtr->uVisibleHeight;
-      if (infoPtr->cy < 0) infoPtr->cy = 0;
+      scrollY = MIN(infoPtr->uVisibleHeight,infoPtr->lefttop.y);
       break;
 
     case SB_PAGEDOWN:
-      maxHeight = infoPtr->uTotalHeight-infoPtr->uVisibleHeight;
-      if (maxHeight <= 0) return FALSE;
-      if (infoPtr->cy == maxHeight) return FALSE;
-      infoPtr->cy += infoPtr->uVisibleHeight;
-      if (infoPtr->cy > maxHeight)
-        infoPtr->cy = maxHeight;
+      scrollY = -infoPtr->uVisibleHeight;
+      if (infoPtr->lefttop.y-scrollY > maxY) scrollY = -(maxY-infoPtr->lefttop.y);
+      if (scrollY > 0) scrollY = 0;
       break;
 
     case SB_THUMBTRACK:
-      maxHeight = infoPtr->uTotalHeight-infoPtr->uVisibleHeight;
-      if (maxHeight <= 0) return FALSE;
-      infoPtr->cy = HIWORD(wParam);
-      if (infoPtr->cy < 0) infoPtr->cy = 0;
-      if (infoPtr->cy > maxHeight) infoPtr->cy = maxHeight;
+      scrollY = infoPtr->lefttop.y-HIWORD(wParam);
       break;
 
@@ -4048 +4093 @@
   }
 
-  if (lastPos != infoPtr->cy)
-  {
+  scrollY -= scrollY % infoPtr->uVScrollStep; //CB: todo
+
+  if (scrollY != 0)
+  {
+    infoPtr->lefttop.y -= scrollY;
     if (!TREEVIEW_UnqueueRefresh(hwnd,TRUE,TRUE))
       TREEVIEW_CalcItems(hwnd,0,infoPtr);
-    ScrollWindowEx(hwnd,0,lastPos-infoPtr->cy,NULL,NULL,0,NULL,SW_INVALIDATE | SW_SCROLLCHILDREN | (infoPtr->uScrollTime << 16));
+    ScrollWindowEx(hwnd,0,scrollY,NULL,NULL,0,NULL,SW_INVALIDATE | SW_SCROLLCHILDREN | (infoPtr->uScrollTime << 16));
 
     return TRUE;
@@ -4065 +4113 @@
   TREEVIEW_INFO *infoPtr = TREEVIEW_GetInfoPtr(hwnd);
   int maxWidth;
-  int lastPos = infoPtr->cx;
+  int lastPos = infoPtr->lefttop.x;
 
   if (!(infoPtr->uInternalStatus & TV_HSCROLL)) return FALSE;
@@ -4072 +4120 @@
   {
     case SB_LINEUP:
-      if (!infoPtr->cx) return FALSE;
-      infoPtr->cx -= infoPtr->uRealItemHeight;
-      if (infoPtr->cx < 0) infoPtr->cx = 0;
+      if (!infoPtr->lefttop.x) return FALSE;
+      infoPtr->lefttop.x -= infoPtr->uRealItemHeight;
+      if (infoPtr->lefttop.x < 0) infoPtr->lefttop.x = 0;
       break;
 
@@ -4080 +4128 @@
       maxWidth = infoPtr->uTotalWidth-infoPtr->uVisibleWidth;
       if (maxWidth <= 0) return FALSE;
-      if (infoPtr->cx == maxWidth) return FALSE;
-      infoPtr->cx += infoPtr->uRealItemHeight; /*FIXME */
-      if (infoPtr->cx > maxWidth)
-        infoPtr->cx = maxWidth;
+      if (infoPtr->lefttop.x == maxWidth) return FALSE;
+      infoPtr->lefttop.x += infoPtr->uRealItemHeight; /*FIXME */
+      if (infoPtr->lefttop.x > maxWidth)
+        infoPtr->lefttop.x = maxWidth;
       break;
 
     case SB_PAGEUP:
-      if (!infoPtr->cx) return FALSE;
-      infoPtr->cx -= infoPtr->uVisibleWidth;
-      if (infoPtr->cx < 0) infoPtr->cx = 0;
+      if (!infoPtr->lefttop.x) return FALSE;
+      infoPtr->lefttop.x -= infoPtr->uVisibleWidth;
+      if (infoPtr->lefttop.x < 0) infoPtr->lefttop.x = 0;
       break;
 
@@ -4095 +4143 @@
       maxWidth = infoPtr->uTotalWidth-infoPtr->uVisibleWidth;
       if (maxWidth <= 0) return FALSE;
-      if (infoPtr->cx == maxWidth) return FALSE;
-      infoPtr->cx += infoPtr->uVisibleWidth;
-      if (infoPtr->cx > maxWidth)
-        infoPtr->cx = maxWidth;
+      if (infoPtr->lefttop.x == maxWidth) return FALSE;
+      infoPtr->lefttop.x += infoPtr->uVisibleWidth;
+      if (infoPtr->lefttop.x > maxWidth)
+        infoPtr->lefttop.x = maxWidth;
       break;
 
@@ -4104 +4152 @@
       maxWidth = infoPtr->uTotalWidth-infoPtr->uVisibleWidth;
       if (maxWidth <= 0) return FALSE;
-      infoPtr->cx = HIWORD(wParam);
-      if (infoPtr->cx < 0) infoPtr->cx = 0;
-      if (infoPtr->cx > maxWidth) infoPtr->cx = maxWidth;
+      infoPtr->lefttop.x = HIWORD(wParam);
+      if (infoPtr->lefttop.x < 0) infoPtr->lefttop.x = 0;
+      if (infoPtr->lefttop.x > maxWidth) infoPtr->lefttop.x = maxWidth;
       break;
 
@@ -4113 +4161 @@
   }
 
-  if (lastPos != infoPtr->cx)
+  if (lastPos != infoPtr->lefttop.x)
   {
     if (!TREEVIEW_UnqueueRefresh(hwnd,TRUE,TRUE))
       TREEVIEW_CalcItems(hwnd,0,infoPtr);
-    ScrollWindowEx(hwnd,lastPos-infoPtr->cx,0,NULL,NULL,0,NULL,SW_INVALIDATE | SW_SCROLLCHILDREN | (infoPtr->uScrollTime << 16));
+    ScrollWindowEx(hwnd,lastPos-infoPtr->lefttop.x,0,NULL,NULL,0,NULL,SW_INVALIDATE | SW_SCROLLCHILDREN | (infoPtr->uScrollTime << 16));
 
     return TRUE;
@@ -4144 +4192 @@
     {
         int wheelDy = pulScrollLines * infoPtr->uRealItemHeight;
-        int newDy = infoPtr->cy + wheelDy;
-        int maxDy = infoPtr->uTotalHeight - infoPtr->uVisibleHeight;
+        int newDy = infoPtr->lefttop.y + wheelDy;
+        int maxDy = infoPtr->uTotalHeight-infoPtr->uVisibleHeight;
 
         if (newDy > maxDy) newDy = maxDy;
         if (newDy < 0) newDy = 0;
 
-        if (newDy == infoPtr->cy) return TRUE;
+        if (newDy == infoPtr->lefttop.y) return TRUE;
 
         TREEVIEW_VScroll(hwnd, MAKEWPARAM(SB_THUMBTRACK,newDy),0);
@@ -4329 +4377 @@
   if (hNewSelection)
   {
-    if ( TREEVIEW_DoSelectItem(
-           hwnd,
-           TVGN_CARET,
-           (HTREEITEM)hNewSelection,
-           TVC_BYKEYBOARD))
+    if (TREEVIEW_DoSelectItem(hwnd,TVGN_CARET,(HTREEITEM)hNewSelection,TVC_BYKEYBOARD))
     {
       TREEVIEW_EnsureVisible(hwnd,hNewSelection);
@@ -4397 +4441 @@
     scrollY = item->rect.top;
   else if (item->rect.bottom > rect.bottom)
+  {
+    INT mod;
+
     scrollY = item->rect.bottom-rect.bottom;
-  else return FALSE;
+    mod = scrollY % infoPtr->uVScrollStep;
+    if (mod) scrollY += infoPtr->uVScrollStep-mod;
+  } else return FALSE;
 
   if (scrollY != 0)
   {
-    infoPtr->cy += scrollY;
+    infoPtr->lefttop.y += scrollY;
     TREEVIEW_CalcItems(hwnd,0,infoPtr);
     ScrollWindowEx(hwnd,0,-scrollY,NULL,NULL,0,NULL,SW_INVALIDATE | SW_SCROLLCHILDREN | (infoPtr->uScrollTime << 16));
@@ -4422 +4471 @@
 }
 
-static TREEVIEW_ITEM* TREEVIEW_SearchChildren(HWND hwnd,TREEVIEW_INFO *infoPtr,TREEVIEW_ITEM *item,TREEVIEW_ITEM *stop,LPWSTR text,INT textlen)
-{
-  TREEVIEW_ITEM *child,*child2;
-
-  if (!(item->firstChild && (item->state & TVIS_EXPANDED))) return NULL;
-
-  child = &infoPtr->items[(INT)item->firstChild];
-  while (child)
-  {
-    if (child == stop) return NULL;
-    if (TREEVIEW_Compare(hwnd,child,text,textlen)) return child;
-    child2 = TREEVIEW_SearchChildren(hwnd,infoPtr,child,stop,text,textlen);
-    if (child2) return child2;
-    if (child->sibling) child = &infoPtr->items[(INT)child->sibling];
-    else return NULL;
-  }
-
-  return NULL;
-}
-
 static TREEVIEW_ITEM* TREEVIEW_Search(HWND hwnd,TREEVIEW_INFO *infoPtr,INT iItem,LPWSTR text,INT textlen)
 {
@@ -4449 +4478 @@
   item = start = &infoPtr->items[iItem];
 
-  if (TREEVIEW_Compare(hwnd,item,text,textlen)) found = TRUE; else
-  {
-    //search start to end
-    while (item->sibling || item->parent)
-    {
-      TREEVIEW_ITEM *child = TREEVIEW_SearchChildren(hwnd,infoPtr,item,NULL,text,textlen);
-
-      if (child)
-      {
-        found = TRUE;
-        item = child;
-        break;
-      }
-
+  //search start to end
+  while (item)
+  {
+    if (TREEVIEW_Compare(hwnd,item,text,textlen)) return item;
+    item = TREEVIEW_GetNextListItem(hwnd,infoPtr,item);
+  }
+  if (!found)
+  {
+    iItem = (INT)infoPtr->TopRootItem;
+    item = &infoPtr->items[iItem];
+
+    //search first to start
+    while (item != start)
+    {
+      if (TREEVIEW_Compare(hwnd,item,text,textlen)) return item;
       item = TREEVIEW_GetNextListItem(hwnd,infoPtr,item);
-      if (item && TREEVIEW_Compare(hwnd,item,text,textlen))
-      {
-        found = TRUE;
-        break;
-      }
     }
-    if (!found)
-    {
-      iItem = (INT)infoPtr->TopRootItem;
-      item = &infoPtr->items[iItem];
-      //search first to start
-      while (item != start)
-      {
-        TREEVIEW_ITEM *child;
-
-        if (TREEVIEW_Compare(hwnd,item,text,textlen))
-        {
-          found = TRUE;
-          break;
-        }
-        child = TREEVIEW_SearchChildren(hwnd,infoPtr,item,start,text,textlen);
-
-        if (child)
-        {
-          found = TRUE;
-          item = child;
-          break;
-        }
-        if (item->sibling) item = &infoPtr->items[(INT)item->sibling];
-        else break;
-      }
-    }
-  }
-
-  return found ? item:NULL;
-}
+  }
+
+  return NULL;
+}
+
+//CB: this method is CPU intense: optimize it and use a secondary thread
 
 static VOID TREEVIEW_ISearch(HWND hwnd,CHAR ch)
@@ -4534 +4535 @@
 
   iItem = infoPtr->selectedItem ? (INT)infoPtr->selectedItem:(INT)infoPtr->TopRootItem;
+
+  if (infoPtr->selectedItem)
+  {
+    item = &infoPtr->items[iItem];
+    item = TREEVIEW_GetNextListItem(hwnd,infoPtr,item);
+    if (!item) item = &infoPtr->items[(INT)infoPtr->TopRootItem];
+    iItem = (INT)item->hItem;
+  } else iItem = (INT)infoPtr->TopRootItem;
+
   item = TREEVIEW_Search(hwnd,infoPtr,iItem,newString,len);
-  if (!item && infoPtr->pszISearch)
+  if (!item && infoPtr->selectedItem && infoPtr->pszISearch)
   {
     TREEVIEW_ITEM *next;
-//CB: todo: must press key twice to go to the next item
+
     item = &infoPtr->items[iItem];
-    next = TREEVIEW_GetNextListItem(hwnd,infoPtr,item);
-    if (!next) next = &infoPtr->items[(INT)infoPtr->TopRootItem];
-    if (next && (next != item))
-    {
-      next = TREEVIEW_Search(hwnd,infoPtr,(INT)next->hItem,infoPtr->pszISearch,infoPtr->uISearchLen);
-      if (next)
-        TREEVIEW_SelectItem(hwnd,(WPARAM)TVGN_CARET,(LPARAM)next->hItem);
+    next = TREEVIEW_Search(hwnd,infoPtr,(INT)item->hItem,infoPtr->pszISearch,infoPtr->uISearchLen);
+    if (next)
+    {
+      TREEVIEW_SelectItem(hwnd,(WPARAM)TVGN_CARET,(LPARAM)next->hItem);
+      TREEVIEW_EnsureVisible(hwnd,next->hItem);
     }
     COMCTL32_Free(newString);
@@ -4559 +4567 @@
     infoPtr->uISearchLen = len;
     TREEVIEW_SelectItem(hwnd,(WPARAM)TVGN_CARET,(LPARAM)item->hItem);
+    TREEVIEW_EnsureVisible(hwnd,item->hItem);
     SetTimer(hwnd,TV_ISEARCH_TIMER,TV_ISEARCH_DELAY,0);
     infoPtr->Timer |= TV_ISEARCH_TIMER_SET;
@@ -4687 +4696 @@
 
         case TVM_SORTCHILDREN:
-                //@@@PH 1999/10/25 TREEVIEW_SortChildrenCB is wrong
                 return TREEVIEW_SortChildren(hwnd, wParam, lParam);