Changeset 2211 for trunk/src

Timestamp:

Dec 27, 1999, 6:08:09 PM (26 years ago)

Author:

cbratschi

Message:

SetWindowPos fixed, edit: refresh only if visible

Location:

trunk/src/user32

Files:

• edit.cpp (modified) (2 diffs)
• oslibwin.cpp (modified) (2 diffs)
• oslibwin.h (modified) (2 diffs)
• win32wbase.cpp (modified) (8 diffs)
• window.cpp (modified) (2 diffs)

trunk/src/user32/edit.cpp

@@ -1 @@
-/* $Id: edit.cpp,v 1.25 1999-12-26 17:30:14 cbratschi Exp $ */
+/* $Id: edit.cpp,v 1.26 1999-12-27 17:08:07 cbratschi Exp $ */
 /*
  *      Edit control
@@ -3725 +3725 @@
   RECT rect;
 
+  if (!IsWindowVisible(hwnd)) return;
+
   //CB: original controls redraws many times, cache drawing
   HideCaret(hwnd);

trunk/src/user32/oslibwin.cpp

@@ -1 @@
-/* $Id: oslibwin.cpp,v 1.52 1999-12-26 17:30:15 cbratschi Exp $ */
+/* $Id: oslibwin.cpp,v 1.53 1999-12-27 17:08:08 cbratschi Exp $ */
 /*
  * Window API wrappers for OS/2
@@ -1200 +1200 @@
   return WinEnableWindowUpdate(hwnd,fEnable);
 }
+//******************************************************************************
+//******************************************************************************
+ULONG OSLibWinGetLastError()
+{
+  return WinGetLastError(GetThreadHAB()) & 0xFFFF;
+}

trunk/src/user32/oslibwin.h

@@ -1 @@
-/* $Id: oslibwin.h,v 1.28 1999-12-26 17:30:16 cbratschi Exp $ */
+/* $Id: oslibwin.h,v 1.29 1999-12-27 17:08:08 cbratschi Exp $ */
 /*
  * Window API wrappers for OS/2
@@ -290 +290 @@
 #define HTOS_ERROR                    (-3)
 
-BOOL OSLibWinEnableWindowUpdate(HWND hwnd,BOOL fEnable);
+BOOL  OSLibWinEnableWindowUpdate(HWND hwnd,BOOL fEnable);
+ULONG OSLibWinGetLastError();
 
 #endif //__OSLIBWIN_H__

trunk/src/user32/win32wbase.cpp

@@ -1 @@
-/* $Id: win32wbase.cpp,v 1.120 1999-12-27 14:41:42 sandervl Exp $ */
+/* $Id: win32wbase.cpp,v 1.121 1999-12-27 17:08:08 cbratschi Exp $ */
 /*
  * Win32 Window Base Class for OS/2
@@ -548 +548 @@
   OSLibWinConvertStyle(dwStyle, &dwExStyle, &dwOSWinStyle, &dwOSFrameStyle, &borderWidth, &borderHeight);
 
-  rectWindow.left   = cs->x;
-  rectWindow.top    = cs->y;
-  rectWindow.right  = cs->x + cs->cx;
-  rectWindow.bottom = cs->y + cs->cy;
-  rectClient        = rectWindow;
-
   if(HIWORD(cs->lpszName))
   {
@@ -613 +607 @@
  POINT maxPos;
  CREATESTRUCTA  *cs = tmpcs;  //pointer to CREATESTRUCT used in CreateWindowExA method
- RECT rectWndTmp, rectClientTmp;
 
   OS2Hwnd      = hwndClient;
   OS2HwndFrame = hwndFrame;
-
-  //make backup copy of rectangles (some calls below result in WM_WINDOWPOSCHANGED with weird values since we haven't
-  //set our window size just yet)
-  rectWndTmp   = rectWindow;
-  rectClientTmp = rectClient;
 
   fNoSizeMsg = TRUE;
@@ -700 +688 @@
   if (isChild()) FrameSetBorderSize(this,TRUE);
 
-  //restore rectangles (some calls below result in WM_WINDOWPOSCHANGED with weird values since we haven't
-  //set our window size just yet)
-  rectWindow = rectWndTmp;
-  rectClient = rectClientTmp;
-
   /* Send the WM_CREATE message
    * Perhaps we shouldn't allow width/height changes as well.
@@ -711 +694 @@
   maxPos.x = rectWindow.left; maxPos.y = rectWindow.top;
 
-  if(getParent()) {
-        SetWindowPos(hwndLinkAfter, rectClient.left, rectClient.top,
-                     rectClient.right-rectClient.left,
-                     rectClient.bottom-rectClient.top,
-                     SWP_NOACTIVATE | SWP_NOREDRAW);
-  }
-  else {
-        SetWindowPos(hwndLinkAfter, rectClient.left, rectClient.top,
-                     rectClient.right-rectClient.left,
-                     rectClient.bottom-rectClient.top,
-                     SWP_NOACTIVATE | SWP_NOREDRAW);
-  }
+  SetWindowPos(hwndLinkAfter,cs->x,cs->y,cs->cx,cs->cy,SWP_NOACTIVATE | SWP_NOREDRAW);
+
   //Note: Solitaire crashes when receiving WM_SIZE messages before WM_CREATE
   fNoSizeMsg = FALSE;
@@ -731 +704 @@
 
         SendNCCalcSize(FALSE, &rectWindow, NULL, NULL, 0, &rectClient );
-
 //        OffsetRect(&rectWindow, maxPos.x - rectWindow.left, maxPos.y - rectWindow.top);
         if( (SendInternalMessageA(WM_CREATE, 0, (LPARAM)cs )) != -1 )
@@ -2470 +2442 @@
         Win32BaseWindow *wndBehind = Win32BaseWindow::GetWindowFromHandle(swp.hwndInsertBehind);
         if(wndBehind) {
-            swp.hwndInsertBehind   = wndBehind->getOS2WindowHandle();
+            swp.hwndInsertBehind   = wndBehind->getOS2FrameWindowHandle();
         }
         else {
@@ -2503 +2475 @@
     if (rc == FALSE)
     {
-        dprintf(("OSLibWinSetMultWindowPos failed!"));
-    }
-    else
-    {
-        if (fuFlags & SWP_FRAMECHANGED_W)
-            OSLibSendMessage (OS2HwndFrame, 0x42 /*WM_UPDATEFRAME*/, -1, 0);
-    }
+        dprintf(("OSLibWinSetMultWindowPos failed! Error %x",OSLibWinGetLastError()));
+    }
+
+    //SWP_FRAMECHANGED is ignored, not necessary for OS/2
 
     return (rc);

trunk/src/user32/window.cpp

@@ -1 @@
-/* $Id: window.cpp,v 1.44 1999-12-24 18:39:13 sandervl Exp $ */
+/* $Id: window.cpp,v 1.45 1999-12-27 17:08:09 cbratschi Exp $ */
 /*
  * Win32 window apis for OS/2
@@ -847 +847 @@
     dprintf(("USER32: MapWindowPoints %x to %x (%d,%d) (%d)", hwndFrom, hwndTo, lpPoints->x, lpPoints->y, cPoints));
     point.x = lpPoints->x;
-    point.y = wndfrom->getWindowHeight() - lpPoints->y;
+    point.y = wndfrom->getWindowHeight()-1-lpPoints->y;
 
     OSLibWinMapWindowPoints(wndfrom->getOS2WindowHandle(), wndto->getOS2WindowHandle(), &point, 1);
-    point.y = wndto->getWindowHeight() - point.y;
+    point.y = wndto->getWindowHeight()-1-point.y;
 
     short int xinc = point.x - lpPoints->x;