Changeset 22006

Timestamp:

Jul 19, 2012, 12:19:55 AM (13 years ago)

Author:

dmik

Message:

iphlpapi: Fix possible crash in GetAdaptersInfo() and friends.

This could happen under some circumstances due to invalid casting
from int to char. Regression of the switch to GCC (which performs
conversions differently compared to VAC).

File:

• trunk/src/iphlpapi/iphlpapi.cpp (modified) (1 diff)

trunk/src/iphlpapi/iphlpapi.cpp

@@ -79 +79 @@
 {
     sprintf(dst, "%u.%u.%u.%u",
-            (char)data,
-            (char)(*(((char*)&data) + 1)),
-            (char)(*(((char*)&data) + 2)),
-            (char)(*(((char*)&data) + 3)));
+            data & 0xFF,
+            (data >> 8) & 0xFF,
+            (data >> 16) & 0xFF,
+            (data >> 24) & 0xFF);
 }