Changeset 21619 for trunk/src

Timestamp:

Apr 15, 2011, 2:57:02 AM (14 years ago)

Author:

dmik

Message:

kernel32: Removed the dirty hack that would reset the exception handler chain before calling DosExit(). This prevented exception handlers in the chain from being called at thread termination and performing the necessary cleanup which is sometimes vital (like releasing locked resources etc).

Location:

trunk/src/kernel32

Files:

• exceptions.cpp (modified) (5 diffs)
• exceptutil.h (modified) (1 diff)
• wprocess.cpp (modified) (1 diff)

trunk/src/kernel32/exceptions.cpp

@@ -707 +707 @@
     RestoreOS2FS();
 
-    SetExceptionChain((ULONG)-1);
     DosExit(EXIT_PROCESS, 666);
 }
@@ -718 +717 @@
     RestoreOS2FS();
 
-    SetExceptionChain((ULONG)-1);
     DosExit(EXIT_THREAD, 666);
 }
@@ -1263 +1261 @@
         PrintExceptionChain();
 #endif
-        SetExceptionChain((ULONG)-1);
         goto continuesearch;
 
@@ -1672 +1669 @@
 
             case XCPT_SIGNAL_KILLPROC:  /* resolve signal information */
-                SetExceptionChain((ULONG)-1);
                 goto continuesearch;
         }
@@ -1881 +1877 @@
 //*****************************************************************************
 //*****************************************************************************
-void SetOS2ExceptionChain(ULONG val)
-{
- USHORT sel = GetFS();
-
-    SetExceptionChain(val);
-    SetFS(sel);
-}
-//*****************************************************************************
-//*****************************************************************************
 int _System CheckCurFS()
 {

trunk/src/kernel32/exceptutil.h

@@ -24 +24 @@
 void  OS2SetExceptionHandler(void *exceptframe);
 void  OS2UnsetExceptionHandler(void *exceptframe);
-void  SetOS2ExceptionChain(ULONG val);
 
 #ifdef DEBUG

trunk/src/kernel32/wprocess.cpp

@@ -625 +625 @@
     teb = GetThreadTEB();
     if(teb) DestroyTEB(teb);
-    SetExceptionChain((ULONG)-1);
 
     //avoid crashes since win32 & OS/2 exception handler aren't identical