Changeset 1622 for trunk/src

Timestamp:

Nov 5, 1999, 6:50:30 PM (26 years ago)

Author:

achimha

Message:

source code cleanup, fix warnings

Location:

trunk/src/user32

Files:

• spy.cpp (modified) (3 diffs)
• win32dlg.cpp (modified) (2 diffs)
• windlg.cpp (modified) (4 diffs)

trunk/src/user32/spy.cpp

@@ -1 @@
-/* $Id: spy.cpp,v 1.6 1999-09-15 23:18:55 sandervl Exp $ */
+/* $Id: spy.cpp,v 1.7 1999-11-05 17:50:29 achimha Exp $ */
 
 /*
@@ -38 +38 @@
  APIRET rc;
 
-   if (rc = DosOpenQueue(&pidServer, &hqQueue, "\\queues\\"Q_NAME))
+   if ((rc = DosOpenQueue(&pidServer, &hqQueue, "\\queues\\"Q_NAME)) != 0)
    {
         dprintf(("InitSpyQueue: couldn't open spy queue rc=%d!", rc));
         return FALSE;
    }
-   if (rc = DosAllocSharedMem((VOID **)&pvdQMemory,
+   if ((rc = DosAllocSharedMem((VOID **)&pvdQMemory,
                          NULL,
                          Q_BUFFER_SIZE,
-                         fALLOCSHR))
+                         fALLOCSHR)) != 0)
    {
         dprintf(("InitSpyQueue: DosAllocSharedMem failed rc=%d", rc));
@@ -94 +94 @@
    pvdQMemory[msgIndex].lParam = lParam;
 
-   if (rc = DosWriteQueue(hqQueue,
+   if ((rc = DosWriteQueue(hqQueue,
                      Q_SPYMSG_WNDMSG,
                      sizeof(Q_SPYMSG),
                      &pvdQMemory[msgIndex],
-                     0))
+                     0)) != 0)
    {
         hqQueue = 0; //give up, server probably died

trunk/src/user32/win32dlg.cpp

@@ -1 @@
-/* $Id: win32dlg.cpp,v 1.31 1999-11-04 18:53:11 sandervl Exp $ */
+/* $Id: win32dlg.cpp,v 1.32 1999-11-05 17:50:30 achimha Exp $ */
 /*
  * Win32 Dialog Code for OS/2
@@ -756 +756 @@
         if (idResult)
             return MAKELONG( idResult, DC_HASDEFID );
-        if ((hwndDefId = findDefButton()))
+        if ((hwndDefId = findDefButton()) != 0)
             return MAKELONG( GetDlgCtrlID( hwndDefId ), DC_HASDEFID);
 

trunk/src/user32/windlg.cpp

@@ -1 @@
-/* $Id: windlg.cpp,v 1.10 1999-10-31 01:14:44 sandervl Exp $ */
+/* $Id: windlg.cpp,v 1.11 1999-11-05 17:50:30 achimha Exp $ */
 /*
  * Win32 dialog apis for OS/2
@@ -463 +463 @@
                   item, (LPARAM)buffer );
 
-    if ((ret = (buffer[0] == '[')))  /* drive or directory */
+    if ((ret = (buffer[0] == '[')) != 0)  /* drive or directory */
     {
         if (buffer[1] == '-')  /* drive */
@@ -517 +517 @@
         char *p, *p2;
         p = spec;
-        if ((p2 = strrchr( p, '\\' ))) p = p2;
-        if ((p2 = strrchr( p, '/' ))) p = p2;
+        if ((p2 = strrchr( p, '\\' )) != 0) p = p2;
+        if ((p2 = strrchr( p, '/' )) != 0) p = p2;
         if (p != spec)
         {
@@ -573 +573 @@
         /* Update the original file spec */
         char *p = spec;
-        while ((*orig_spec++ = *p++));
+        while ((*orig_spec++ = *p++) != 0);
     }