Changeset 947

Timestamp:

Jan 11, 2004, 5:51:02 PM (22 years ago)

Author:

bird

Message:

do close on exec stuff (paranoia and such).

File:

• trunk/src/binutils/libiberty/pex-os2.c (modified) (5 diffs, 1 prop)

trunk/src/binutils/libiberty/pex-os2.c

@@ -47 +47 @@
 #define INCL_BASE
 #include <os2.h>
+#include <sys/fcntl.h>
 
 int
@@ -93 +94 @@
       output_desc = pdes[WRITE_PORT];
       last_pipe_input = pdes[READ_PORT];
+      /* we don't wanna have an extra handles in the child. */
+      fcntl (pdes[READ_PORT], F_SETFD, FD_CLOEXEC);
+      fcntl (pdes[WRITE_PORT], F_SETFD, FD_CLOEXEC);
     }
   else
@@ -99 +103 @@
     {
       org_stdin = dup (STDIN_FILE_NO);
+      fcntl (org_stdin, F_SETFD, FD_CLOEXEC);
       dup2 (input_desc, STDIN_FILE_NO);
+      fcntl (STDIN_FILE_NO, F_SETFD, 0); /* paranoia. but what's the deal with this flag over dup? */
       close (input_desc);
     }
@@ -105 +111 @@
     {
       org_stdout = dup (STDOUT_FILE_NO);
+      fcntl (org_stdout, F_SETFD, FD_CLOEXEC);
       dup2 (output_desc, STDOUT_FILE_NO);
+      fcntl (STDOUT_FILE_NO, F_SETFD, 0); /* paranoia. but what's the deal with this flag over dup? */
       close (output_desc);
     }
+
   pid = (flags & PEXECUTE_SEARCH ? spawnvp : spawnv) (P_NOWAIT, program, argv);
+
   if (pipes_supported && input_desc != STDIN_FILE_NO)
     {
       dup2 (org_stdin, STDIN_FILE_NO);
+      fcntl (STDIN_FILE_NO, F_SETFD, 0); /* paranoia. but what's the deal with this flag over dup? */
       close (org_stdin);
     }
@@ -117 +128 @@
     {
       dup2 (org_stdout, STDOUT_FILE_NO);
+      fcntl (STDOUT_FILE_NO, F_SETFD, 0); /* paranoia. but what's the deal with this flag over dup? */
       close (org_stdout);
     }