Changeset 3753

Timestamp:

Mar 4, 2012, 10:23:36 PM (13 years ago)

Author:

bird

Message:

Backported r3751: weakld.c: Put exported names in a different symbol table since they need to be considered seperately. Fixed bugs reading IMPORTS from .def files. Fixes #254.

File:

• branches/libc-0.6/src/emx/src/emxomf/weakld.c (modified) (33 diffs)

branches/libc-0.6/src/emx/src/emxomf/weakld.c

@@ -223 +223 @@
          */
         WLDSF_WKEXT     = 0x0005,
+        /** Exported name.
+         * This is used when the exported name differs from the internal one.
+         * This name is not considered in the linking, only the internal one. */
+        WLDSF_EXP_NM    = 0x0006,
         /** @} */
 
@@ -249 +253 @@
         WLDSF_ALIAS     = 0x0800,
 
-        /** Exported symbol.
-         * This symbol is to be exported. */
-        WLDSF_EXPORT    = 0x1000,
-
         /** Internal flags which indicates that the symbol was exported in
          * the definition file. This to select symbols which only appears in
@@ -260 +260 @@
 
         /** Internal flag to say that we've already aliased this weak
-         * in the definition file.
-         */
+         * in the definition file. */
         WLDSF_WEAKALIASDONE = 0x8000
     }                   fFlags;
@@ -309 +308 @@
 
     /** Symbol this is an alias for.
-     * Valid when WLDSF_ALIAS is set. */
+     * Valid when WLDSF_ALIAS or WLDSF_EXP_NM are set. */
     struct wldsym *     pAliasFor;
 
     /** @group Export Attributes
-     * Valid when WLDSF_EXPORT is set.
+     * Valid when WLDSF_EXP_NM is set.
      * @{ */
     /** Export flags. */
@@ -369 +368 @@
     /** Global symbols. */
     WLDSYMTAB           Global;
+    /** Exported symbols. */
+    WLDSYMTAB           Exported;
 
     /** Module definition file. */
@@ -469 +470 @@
 static void         symDumpReferers(PWLDSYM pSym);
 static void         symDbg(PWLDSYM pSym, const char *pszMsg);
-static PWLDSYM      symAdd(PWLD pWld, PWLDMOD pMod, unsigned fFlags, const char *pachName, int cchName, PWLDSYMACTION peAction);
+static PWLDSYM      symAdd(PWLD pWld, PWLDMOD pMod, unsigned fFlags, const char *pachName, int cchName, PWLDSYMTAB pSymTab, PWLDSYMACTION peAction);
 static PWLDSYM      symAddImport(PWLD pWld, PWLDMOD pMod, int fLibSearch,
                                  const char *pachName, int cchName,
@@ -1251 +1252 @@
  * @param   pWld    Linker Instance.
  * @param   pszName Name of the symbol to find.
- */
-static PWLDSYM      symLookup(PWLD pWld, const char *pszName)
+ * @param   pSymTab The symbol table to look it up in.
+ */
+static PWLDSYM      symLookupCommon(PWLD pWld, const char *pszName, PWLDSYMTAB pSymTab)
 {
     PWLDSYM     pSym;
@@ -1285 +1287 @@
 
     /* look it up */
-    for (pSym = pWld->Global.ap[uHash % WLDSYM_HASH_SIZE]; pSym; pSym = pSym->pHashNext)
+    for (pSym = pSymTab->ap[uHash % WLDSYM_HASH_SIZE]; pSym; pSym = pSym->pHashNext)
        if (SYM_EQUAL(pWld, pSym, pszName, fFlags, uHash, cchName))
            return pSym;
@@ -1293 +1295 @@
 
 
+/**
+ * Find the symbol by the name pszName.
+ *
+ * @returns Pointer to matching symbol.
+ * @returns NULL if not found.
+ * @param   pWld    Linker Instance.
+ * @param   pszName Name of the symbol to find.
+ */
+static PWLDSYM      symLookup(PWLD pWld, const char *pszName)
+{
+    return symLookupCommon(pWld, pszName, &pWld->Global);
+}
+
+
+/**
+ * Find the export symbol by the name pszName.
+ *
+ * @returns Pointer to matching symbol.
+ * @returns NULL if not found.
+ * @param   pWld    Linker Instance.
+ * @param   pszName Name of the symbol to find.
+ */
+static PWLDSYM      symLookupExport(PWLD pWld, const char *pszName)
+{
+    return symLookupCommon(pWld, pszName, &pWld->Exported);
+}
 
 
@@ -1487 +1515 @@
         case WLDSF_UNDEF:   psz += sprintf(psz, "UNDEF"); break;
         case WLDSF_WKEXT:   psz += sprintf(psz, "WKEXT"); break;
+        case WLDSF_EXP_NM:  psz += sprintf(psz, "EXPORT"); break;
         default:            psz += sprintf(psz, "!!!internal error!!! "); asm("int $3"); break;
     }
@@ -1493 +1522 @@
     if (pSym->fFlags & WLDSF_ALIAS)
         psz += sprintf(psz, " ALIAS");
-    if (pSym->fFlags & WLDSF_EXPORT)
-        psz += sprintf(psz, " EXPORT");
     if (pSym->fFlags & WLDSF_UNCERTAIN)
         psz += sprintf(psz, " UNCERTAIN");
@@ -1556 +1583 @@
  * @param   fFlags      Symbol flags.
  *                      All the flags in WLDSF_TYPEMASK, WLDSF_WEAK and WLDSF_LIBSEARCH.
- *                      WLDSF_EXPORT isn't handled and should not be defined.
  *                      WLDSF_ALIAS and WLDSF_UNCERTAIN is ignored as they have no
  *                      sideeffects when resolving symbols.
  * @param   pachName    Pointer to symbol name.
  * @param   cchName     Length to add, use -1 if zeroterminated.
+ * @param   pSymTab     The symbol table to add it to.
  * @param   pflAction   What we actually did.
  *                      WLDSA_NEW, WLDSA_UP, WLDSA_OLD, WLDSA_ERR.
@@ -1595 +1622 @@
  *
  */
-static PWLDSYM      symAdd(PWLD pWld, PWLDMOD pMod, unsigned fFlags, const char *pachName, int cchName, PWLDSYMACTION peAction)
+static PWLDSYM      symAdd(PWLD pWld, PWLDMOD pMod, unsigned fFlags, const char *pachName, int cchName, 
+                           PWLDSYMTAB pSymTab, PWLDSYMACTION peAction)
 {
     PWLDSYM     pSym;                   /* The symbol. */
@@ -1632 +1660 @@
 
     /* search for existing symbol  */
-    for (pSym = pWld->Global.ap[uHash % WLDSYM_HASH_SIZE]; pSym; pSym = pSym->pHashNext)
+    for (pSym = pSymTab->ap[uHash % WLDSYM_HASH_SIZE]; pSym; pSym = pSym->pHashNext)
         if (SYM_EQUAL(pWld, pSym, pszName, fFlags, uHash, cchName))
             break;
@@ -1652 +1680 @@
             WLDINFO(pWld, ("Weak symbol '%s'.", pSym->pszWeakName));
         }
-        pSym->pHashNext = pWld->Global.ap[uHash % WLDSYM_HASH_SIZE];
-        pWld->Global.ap[uHash % WLDSYM_HASH_SIZE] = pSym;
+        pSym->pHashNext = pSymTab->ap[uHash % WLDSYM_HASH_SIZE];
+        pSymTab->ap[uHash % WLDSYM_HASH_SIZE] = pSym;
         if (peAction) *peAction = WLDSA_NEW;
         WLDDBG2(("symAdd: New symbol '%s'", pSym->pszName));
@@ -1668 +1696 @@
          *      5. adding a WEAK PUBLIC or WEAK COMM where a PUBLIC or COMM exists.
          *      6. adding a WEAK UNDEF where WEAK UNDEF exists.
+         *      7. adding a EXP_NM that already exists.
          */
         if ( (     /* 1 */
@@ -1688 +1717 @@
                 ((fFlags & (WLDSF_TYPEMASK | WLDSF_WEAK)) == (WLDSF_UNDEF | WLDSF_WEAK))
              && ((pSym->fFlags & (WLDSF_TYPEMASK | WLDSF_WEAK)) == (WLDSF_UNDEF | WLDSF_WEAK))
+            ) || ( /* 7 */
+                ((fFlags & WLDSF_TYPEMASK) == WLDSF_EXP_NM)
+             && ((pSym->fFlags & WLDSF_TYPEMASK) == WLDSF_EXP_NM)
             ))
         {
@@ -1838 +1870 @@
 
     pSym = symAdd(pWld, pMod, WLDSF_IMPORT | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                  pachName, cchName, &eAction);
+                  pachName, cchName, &pWld->Global, &eAction);
     if (!pSym)
         return NULL;
@@ -1867 +1899 @@
         case WLDSA_NEW:
         case WLDSA_UP:
-            pSym->u.import.pszImpMod = pszImpMod;
+            pSym->u.import.pszImpMod  = pszImpMod;
             pSym->u.import.pszImpName = pszImpName;
-            pSym->u.import.uImpOrd   = uOrdinal;
+            pSym->u.import.uImpOrd    = uOrdinal;
             break;
 
@@ -1946 +1978 @@
                             unsigned uOrdinal)
 {
-    PWLDSYM         pSym;
+    PWLDSYM         pSymExp;
+    PWLDSYM         pSymInt;
 
     /* set default name */
@@ -1954 +1987 @@
         cchIntName = cchExpName;
     }
+
+    /*
+     * Add the internal name.
+     */
+    pSymInt = symAdd(pWld, pMod, WLDSF_UNDEF | (fLibSearch ? WLDSF_LIBSEARCH : 0),
+                     pachIntName, cchIntName, &pWld->Global, NULL);
+    if (!pSymInt)
+        return NULL;
 
     /*
      * Add external name.
      */
-    pSym = symAdd(pWld, pMod, WLDSF_UNDEF | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                  pachExpName, cchExpName, NULL);
-    if (!pSym)
+    pSymExp = symAdd(pWld, pMod, WLDSF_EXP_NM | (fLibSearch ? WLDSF_LIBSEARCH : 0),
+                     pachExpName, cchExpName, &pWld->Exported, NULL);
+    if (!pSymExp)
         return NULL;
 
@@ -1966 +2007 @@
      * Is the exported symbol already exported?
      */
-    if (pSym->fFlags & WLDSF_EXPORT)
-    {
-        if (    (pSym->fExport & WLDSEF_DEF_FILE)
+    if (pSymExp->pAliasFor)
+    {
+        if (pSymExp->pAliasFor != pSymInt)
+            modWarn(pMod, "Export '%s' (int '%s') is already defined with a different resolution '%s'.", 
+                    pSymExp->pszName, pSymInt->pszName, pSymExp->pAliasFor->pszName);
+        else if (    (pSymExp->fExport & WLDSEF_DEF_FILE)
+                 &&  (fExport & WLDSEF_DEF_FILE))
+            modWarn(pMod, "Export '%s' (int '%s') is already defined.", pSymExp->pszName, pSymInt->pszName);
+        
+        if (    !(pSymExp->fExport & WLDSEF_DEF_FILE)
             &&  (fExport & WLDSEF_DEF_FILE))
-            modWarn(pMod, "Export '%s' is already defined.", pSym->pszName);
-        if (    !(pSym->fExport & WLDSEF_DEF_FILE)
-            &&  (fExport & WLDSEF_DEF_FILE))
-            pSym->fExport = fExport;
-    }
-    else
-    {
-        PWLDSYM     pSymAlias;
-
-        pSym->fFlags |= WLDSF_EXPORT;
-
-        /*
-         * Add internal name.
-         */
-        pSymAlias = symAdd(pWld, pMod, WLDSF_UNDEF | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                           pachIntName, cchIntName, NULL);
-        if (!pSymAlias)
-            return NULL;
-        if (pSymAlias != pSym && (pSym->fFlags & WLDSF_ALIAS) && pSym->pAliasFor != pSymAlias)
-        {
-            modErr(pMod, "Can't export an alias!.");
-            pSym = NULL;
-        }
-        else
-        {
-            if (pSym != pSymAlias)
-            {
-                pSym->fFlags |= WLDSF_ALIAS;
-                pSym->fFlags &= ~WLDSF_UNDEF;
-                pSym->pAliasFor = pSymAlias;
-            }
-            pSym->fExport   = fExport;
-            pSym->cExpWords = cExpWords;
-            pSym->uExpOrd   = uOrdinal;
-        }
-    }
-
-    return pSym;
+            pSymExp->fExport = fExport;
+        return pSymExp;
+    }
+    
+    pSymExp->pAliasFor = pSymInt;
+    pSymExp->fExport   = fExport;
+    pSymExp->cExpWords = cExpWords;
+    pSymExp->uExpOrd   = uOrdinal;
+
+    return pSymExp;
 }
 
@@ -2031 +2051 @@
 
     pSym = symAdd(pWld, pMod, WLDSF_PUBLIC | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                  pachName, cchName, NULL);
+                  pachName, cchName, &pWld->Global, NULL);
     if (!pSym)
         return NULL;
@@ -2055 +2075 @@
 
     pSym = symAdd(pWld, pMod, WLDSF_UNDEF | WLDSF_UNCERTAIN | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                  pachName, cchName, NULL);
+                  pachName, cchName, &pWld->Global, NULL);
     if (!pSym)
         return NULL;
@@ -2084 +2104 @@
      */
     pSym = symAdd(pWld, pMod, WLDSF_PUBLIC | WLDSF_ALIAS | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                  pachAliasName, cchAliasName, &eAction);
+                  pachAliasName, cchAliasName, &pWld->Global, &eAction);
     if (!pSym)
         return NULL;
@@ -2095 +2115 @@
             {
                 PWLDSYM pSym2 = symAdd(pWld, pMod, WLDSF_UNDEF | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                                       pachName, cchName, NULL);
+                                       pachName, cchName, &pWld->Global, NULL);
                 if (!pSym2)
                     return NULL;
@@ -2146 +2166 @@
      */
     pSym = symAdd(pWld, pMod, WLDSF_COMM | (fLibSearch ? WLDSF_LIBSEARCH : 0),
-                  pachName, cchName, &eAction);
+                  pachName, cchName, &pWld->Global, &eAction);
     if (!pSym)
         return NULL;
@@ -2175 +2195 @@
 
     return pSym;
+}
+
+
+/**
+ * Destroys a symbol table, freeing all symbols 
+ *
+ * @param   pSymTab     The symbol table to destroy.
+ */
+static void symDestroyTab(PWLDSYMTAB pSymTab)
+{
+    unsigned        uHash;
+    for (uHash = 0; uHash < sizeof(pSymTab->ap) / sizeof(pSymTab->ap[0]); uHash++)
+    {
+        PWLDSYM     pSym = pSymTab->ap[uHash];
+        while (pSym)
+        {
+            PWLDSYM pNext = pSym->pHashNext;
+            if (pSym->paReferers)
+                free(pSym->paReferers);
+            free(pSym);
+            pSym = pNext;
+        }
+        pSymTab->ap[uHash] = NULL;
+    }
 }
 
@@ -2632 +2676 @@
     PWLDMOD     pObj;
     PWLDLIB     pLib;
-    unsigned    uHash;
 
     if (!pWld)
@@ -2665 +2708 @@
 
     /* free symbols */
-    for (uHash = 0; uHash < sizeof(pWld->Global.ap) / sizeof(pWld->Global.ap[0]); uHash++)
-    {
-        PWLDSYM     pSym = pWld->Global.ap[uHash];
-        while (pSym)
-        {
-            PWLDSYM pNext = pSym->pHashNext;
-            if (pSym->paReferers)
-                free(pSym->paReferers);
-            free(pSym);
-            pSym = pNext;
-        }
-    }
+    symDestroyTab(&pWld->Global);
+    symDestroyTab(&pWld->Exported);
 
     /* members and finally the instance structure. */
@@ -2809 +2842 @@
                 uOrdinal = pStmt->import.ordinal;
             pSym = symAddImport(pParam->pWld, pParam->pMod, 0,
+                                pStmt->import.internalname[0] ? pStmt->import.internalname : pStmt->import.entryname, -1,
                                 pStmt->import.entryname[0] ? pStmt->import.entryname : pStmt->import.internalname, -1,
-                                pStmt->import.internalname, -1,
                                 pStmt->import.modulename, -1,
                                 uOrdinal);
@@ -3460 +3493 @@
             PWLDSYM     pSymExp;
 
-            pSymExp = symLookup(pParam->pWld, pStmt->export.entryname);
+            pSymExp = symLookupExport(pParam->pWld, pStmt->export.entryname);
             if (pStmt->export.internalname[0])
                 pSymInt = symLookup(pParam->pWld, pStmt->export.internalname);
@@ -3703 +3736 @@
                         {
                             if (0)//pWld->fFlags & WLDC_LINKER_WLINK)
-                                rc = symEnum(pWld, &pWld->Global,
-                                             WLDSF_EXPORT | WLDSF_EXPORT_DEF | WLDSF_WEAK, WLDSF_EXPORT | WLDSF_EXPORT_DEF | WLDSF_WEAK | WLDSF_WEAKALIASDONE,
+                                rc = symEnum(pWld, &pWld->Exported,
+                                             WLDSF_EXPORT_DEF | WLDSF_WEAK, WLDSF_EXPORT_DEF | WLDSF_WEAK | WLDSF_WEAKALIASDONE,
                                              wldGenerateDefExportEnum, &param);
                             else
-                                rc = symEnum(pWld, &pWld->Global,
-                                             WLDSF_EXPORT | WLDSF_WEAK, WLDSF_EXPORT | WLDSF_WEAK | WLDSF_EXPORT_DEF | WLDSF_WEAKALIASDONE,
+                                rc = symEnum(pWld, &pWld->Exported,
+                                             WLDSF_WEAK, WLDSF_WEAK | WLDSF_EXPORT_DEF | WLDSF_WEAKALIASDONE,
                                              wldGenerateDefExportEnum, &param);
                         }