Changeset 1768

Timestamp:

Jan 17, 2005, 3:40:14 AM (21 years ago)

Author:

bird

Message:

A bit of instructional logging. A couple of todos.

File:

• trunk/src/emx/src/lib/sys/tcpipver.c (modified) (4 diffs, 1 prop)

trunk/src/emx/src/lib/sys/tcpipver.c

@@ -231 +231 @@
     else if (rc > 0)
     {
+        /** @todo socket duplication within the same process! A per process reference counting is required too! */
+
         /*
          * Someone is using the socket, we'll remove it from the list of
@@ -336 +338 @@
     LIBCLOG_ENTER("pFH=%p:{iSocket=%d} fh=%d pfhNew=%p\n", (void *)pFH, ((PLIBCSOCKETFH)pFH)->iSocket, fh, (void *)pfhNew);
     LIBC_ASSERTM_FAILED("Duplication of sockets aren't supported yet.\n");
+    /** @todo In order to properly support this we need to have per process reference counting
+     * of the sockets too. This should be done in a high heap block and done on allocation to
+     * get the exec/spaw inheritance right. */
     LIBCLOG_RETURN_INT(-ENOSYS);
 }
@@ -1196 +1201 @@
 static int     TCPNAME(imp_soclose)(int s)
 {
+    LIBCLOG_ENTER("iSocket=%d\n", s);
     static int (*TCPCALL pfn)(int s);
     if (!pfn && TCPNAME(get_imp)(ORD_SOCLOSE, (void **)(void *)&pfn))
-        return -1;
-    return pfn(s);
+        LIBCLOG_RETURN_INT(-1);
+    int rc = pfn(s);
+    LIBCLOG_RETURN_INT(rc);
 }
 
@@ -1238 +1245 @@
 static int     TCPNAME(imp_addsockettolist)(int s)
 {
+    LIBCLOG_ENTER("iSocket=%d\n", s);
     static int (*TCPCALL pfn)(int s);
     if (!pfn && TCPNAME(get_imp)(ORD_ADDSOCKETTOLIST, (void **)(void *)&pfn))
-        return -1;
-    return pfn(s);
+        LIBCLOG_RETURN_INT(-1);
+    int rc = pfn(s);
+    LIBCLOG_RETURN_INT(rc);
 }
 
 static int     TCPNAME(imp_removesocketfromlist)(int s)
 {
+    LIBCLOG_ENTER("iSocket=%d\n", s);
     static int (*TCPCALL pfn)(int s);
     if (!pfn && TCPNAME(get_imp)(ORD_REMOVESOCKETFROMLIST, (void **)(void *)&pfn))
-        return -1;
-    return pfn(s);
+        LIBCLOG_RETURN_INT(-1);
+    int rc = pfn(s);
+    LIBCLOG_RETURN_INT(rc);
 }