Changeset 1019

Timestamp:

Jan 22, 2004, 4:11:28 AM (22 years ago)

Author:

bird

Message:

Reversed pointer check on malloc result. (buh, bad bad me)

File:

• trunk/src/emx/src/lib/app/setenv.c (modified) (6 diffs, 1 prop)

trunk/src/emx/src/lib/app/setenv.c

@@ -18 +18 @@
 #include <emx/time.h>           /* _tzset_flag */
 
-           
+
 /**
  * Set environment variable.
@@ -26 +26 @@
  * @param   envname     Name of environment variable to set.
  *                      Shall not be NULL, empty string or contain '='.
- * @param   envval      The value to set.     
+ * @param   envval      The value to set.
  * @param   overwrite   If set any existing variable should be overwritten.
- *                      If clear return successfully without changing any 
+ *                      If clear return successfully without changing any
  *                      existing variable.
- *                      If there is not existing variable it is added 
+ *                      If there is not existing variable it is added
  *                      regardless of the state of this flag.
  * @author  knut st. osmundsen <bird-srcspam@anduin.net>
@@ -55 +55 @@
 
   /* search for existing variable iinstance  */
-  lenname = strlen (envname);        
+  lenname = strlen (envname);
   p = environ;
   env_size = 0;
@@ -86 +86 @@
         {
           p = malloc ((env_size+2) * sizeof (char *));
-          if (p == NULL) 
+          if (p == NULL)
               return -1;
           environ = p;
@@ -95 +95 @@
         {
           p = realloc (environ, (env_size+2) * sizeof (char *));
-          if (p == NULL) 
+          if (p == NULL)
               return -1;
           environ = p;
@@ -107 +107 @@
   /* Allocate space for new variable and assign it. */
   *p = malloc(lenname + lenval + 2);
-  if (*p)
+  if (!*p)
     return -1;
   memcpy(*p, envname, lenname);