Changeset 77

Timestamp:

Jun 22, 2016, 7:03:55 PM (9 years ago)

Author:

bird

Message:

prof/dbg: uninitialized variable, missing printf args, pedantic formatting types.

Location:

trunk

Files:

• kDbg/kDbgHlpCrt.cpp (modified) (1 diff)
• kProfiler2/kPrf2Read.cpp (modified) (1 diff)
• kProfiler2/prfreader.cpp.h (modified) (3 diffs)

trunk/kDbg/kDbgHlpCrt.cpp

@@ -158 +158 @@
         kDbgHlpSeek(pFile, offCur);
     }
+    else
+        cbFile = -1;
     return cbFile;
 }

trunk/kProfiler2/kPrf2Read.cpp

@@ -221 +221 @@
         { \
             fprintf(pOut, "cb" #MemBaseName " was expected to be %#x but is %#x. Probably a format change, rebuild.\n", \
-                    (pHdr->Hdr32.cFormatBits == 32 ? cb32 : cb64), pHdr->Hdr32.cb##MemBaseName); \
+                    (unsigned)(pHdr->Hdr32.cFormatBits == 32 ? cb32 : cb64), pHdr->Hdr32.cb##MemBaseName); \
             return false; \
         }\

trunk/kProfiler2/prfreader.cpp.h

@@ -64 +64 @@
         {
             fprintf(pOut, "The module segment record at 0x%x has an invalid path length 0x%x it the actual length is 0x%x\n",
-                    pCur->cchPath, strlen(pCur->szPath));
+                    off, pCur->cchPath, strlen(pCur->szPath));
             return false;
         }
@@ -1228 +1228 @@
                 fprintf(pOut,
                         "    <td><a href=\"#Func-%u\">",
-                        pReportFunc - pReport->paFunctions);
+                        (unsigned)(uintptr_t)(pReportFunc - pReport->paFunctions));
                 if (pReportFunc->pSym)
                     fprintf(pOut, "%s</a></td>\n", pReportFunc->pSym->szName);
@@ -1559 +1559 @@
                 "<a name=\"Mod-%u\">\n"
                 "<tr><td class=\"BlankRow\" colspan=7><a name=\"Module-%u\">&nbsp;</a></td></tr>\n",
-                iMod);
+                iMod, iMod);
         KPRF_NAME(HtmlWriteRowU32)(pOut, "Module No.", iMod, NULL);
         KPRF_NAME(HtmlWriteRowString)(pOut, "Name", "Name", "%s", pMod->pFirstSeg->pModSeg->szPath);