Changeset 108 for hacks

Timestamp:

Dec 11, 2017, 1:04:59 PM (8 years ago)

Author:

bird

Message:

fritzboxdect.py: better diags

File:

• hacks/munin/fritzboxdect.py (modified) (4 diffs)

hacks/munin/fritzboxdect.py

@@ -63 +63 @@
 
 
+## Wheter to display debug messages.
+g_fDebug = len(os.environ.get('debug', '')) > 0;
+
 
 class FritzBoxConnection(object):
@@ -73 +76 @@
 
     def __init__(self, sServer, sPassword, iPort = 80):
-        self.fDebug = len(os.environ.get('debug', '')) > 0;
-
         #
         # Connect to the fritz!box.
@@ -143 +144 @@
             sName, sValue = sArg.split('=')
             sUrl += '&' + urllib_quote(sName) + '=' + urllib_quote(sValue);
-        if self.fDebug:
+        if g_fDebug:
             print('debug: sUrl: %s' % (sUrl,));
 
@@ -161 +162 @@
         asRet = [];
         asIps       = os.environ.get('fritzboxdect_ip', '10.42.2.1 10.42.1.50').split();
+        if len(asIps) == 0:
+            raise Exception('environment variable fritzboxdect_ip is empty')
         asPasswords = os.environ.get('fritzboxdect_password', '').split();
+        if len(asPasswords) == 0:
+            raise Exception('environment variable fritzboxdect_password is empty')
+        if g_fDebug:
+            print('debug: asIps=%s asPasswords=%s' % (asIps, asPasswords,));
+
         for i, sIp in enumerate(asIps):
             sPassword = asPasswords[i] if i < len(asPasswords) else asPasswords[-1];