Changeset 733

Timestamp:

Dec 17, 2006, 5:42:54 AM (19 years ago)

Author:

bird

Message:

check for buffer overflow.

Location:

trunk

Files:

• kBuild/bin/win.x86/kDepIDB.exe (modified) ( previous)
• kBuild/bin/win.x86/kDepPre.exe (modified) ( previous)
• src/lib/kDep.c (modified) (1 diff)

trunk/src/lib/kDep.c

@@ -206 +206 @@
                 memcpy(psz, FindFileData.cAlternateFileName, cch);
             else
-            {
-                memmove(psz + cchAlt, pszEnd, strlen(pszEnd) + 1);
-                pszEnd -= cchDelta;
-                memcpy(psz, FindFileData.cAlternateFileName, cchAlt);
+            {   int cbLeft = strlen(pszEnd) + 1;
+                if ((psz - pszPath) + cbLeft + cchAlt <= _MAX_PATH)
+                {
+                    memmove(psz + cchAlt, pszEnd, cbLeft);
+                    pszEnd -= cchDelta;
+                    memcpy(psz, FindFileData.cAlternateFileName, cchAlt);
+                }
+                else
+                    fprintf(stderr, "kDep: case & space fixed filename is growing too long (%d bytes)! '%s'\n",
+                            (psz - pszPath) + cbLeft + cchAlt, pszPath);
             }
         }