Changeset 3389 for trunk/src/kmk/main.c

Timestamp:

Jun 26, 2020, 7:16:26 PM (5 years ago)

Author:

bird

Message:

kmk: Avoid setting umask just to get it, store the current value in a global variable (g_fUMask). The umask(0777) call in cp.c raced other code (kmk_append) that created files and directories, leaving us with read-only files sometimes.

File:

• trunk/src/kmk/main.c (modified) (2 diffs)

trunk/src/kmk/main.c

@@ -821 +821 @@
 struct output make_sync;
 
+#ifdef KMK
+/** Current umask() value. */
+mode_t g_fUMask = 0022;
+#endif
+
 
 
@@ -1769 +1774 @@
 #endif
 
+#ifdef KMK
+  /* Get the incoming umask so we don't have to modify it later to get it. */
+  umask(g_fUMask = umask(0077));
+#endif
+
 #ifdef CONFIG_NEW_WIN32_CTRL_EVENT
   /* bird: dispatch signals in our own way to try avoid deadlocks. */