Changeset 3389 for trunk/src/kmk/kmkbuiltin/setmode.c

Timestamp:

Jun 26, 2020, 7:16:26 PM (5 years ago)

Author:

bird

Message:

kmk: Avoid setting umask just to get it, store the current value in a global variable (g_fUMask). The umask(0777) call in cp.c raced other code (kmk_append) that created files and directories, leaving us with read-only files sometimes.

File:

• trunk/src/kmk/kmkbuiltin/setmode.c (modified) (2 diffs)

trunk/src/kmk/kmkbuiltin/setmode.c

@@ -100 +100 @@
 #endif /* !S_ISTXT */
 
+extern mode_t g_fUMask; /* Initialize in main() and keep up to date. */
+
+
 /*
  * Given the old mode and an array of bitcmd structures, apply the operations
@@ -223 +226 @@
         (void)sigprocmask(SIG_BLOCK, &signset, &sigoset);
 #endif
-        (void)umask(mask = umask(0));
+        mask = g_fUMask;
+        assert(mask == umask(g_fUMask));
         mask = ~mask;
 #ifndef _MSC_VER