Changeset 3389 for trunk/src/kmk/kmkbuiltin/chmod.c

Timestamp:

Jun 26, 2020, 7:16:26 PM (5 years ago)

Author:

bird

Message:

kmk: Avoid setting umask just to get it, store the current value in a global variable (g_fUMask). The umask(0777) call in cp.c raced other code (kmk_append) that created files and directories, leaving us with read-only files sometimes.

File:

• trunk/src/kmk/kmkbuiltin/chmod.c (modified) (1 diff)

trunk/src/kmk/kmkbuiltin/chmod.c

@@ -278 +278 @@
 
 #ifdef KMK_BUILTIN_STANDALONE
+mode_t g_fUMask;
 int main(int argc, char **argv, char **envp)
 {
     KMKBUILTINCTX Ctx = { "kmk_chmod", NULL };
+    umask(g_fUMask = umask(0077));
     return kmk_builtin_chmod(argc, argv, envp, &Ctx);
 }