Changeset 3389 for trunk/src/kmk/function.c

Timestamp:

Jun 26, 2020, 7:16:26 PM (5 years ago)

Author:

bird

Message:

kmk: Avoid setting umask just to get it, store the current value in a global variable (g_fUMask). The umask(0777) call in cp.c raced other code (kmk_append) that created files and directories, leaving us with read-only files sometimes.

File:

• trunk/src/kmk/function.c (modified) (2 diffs)

trunk/src/kmk/function.c

@@ -5665 +5665 @@
     }
 
-  u = umask (002);
-  umask (u);
+  u = g_fUMask;
+  assert (u == umask (g_fUMask));
 
   if (symbolic)
@@ -5734 +5734 @@
       if (argv[1] != NULL)
           OS (error, reading_file, _("$(%s ) too many arguments for octal mode"), funcname);
+
+      umask (u);
+      g_fUMask = u;
   }
   else
   {
-      u = umask(0);
-      umask(u);
       OS (error, reading_file, _("$(%s ) symbol mode is not implemented"), funcname);
   }
-
-  umask(u);
 
   return o;