Changeset 3162 for trunk/src/kmk/kmkbuiltin

Timestamp:

Mar 20, 2018, 4:13:12 AM (7 years ago)

Author:

bird

Message:

kmk/win: Pretty sure I made this lpReserved2 mistake before. Duh.

File:

• trunk/src/kmk/kmkbuiltin/redirect.c (modified) (2 diffs)

trunk/src/kmk/kmkbuiltin/redirect.c

@@ -979 +979 @@
         StartupInfo.cb = sizeof(StartupInfo);
         GetStartupInfoA(&StartupInfo);
+        StartupInfo.lpReserved2 = 0; /* No CRT file handle + descriptor info possible, sorry. */
+        StartupInfo.cbReserved2 = 0;
         StartupInfo.dwFlags &= ~STARTF_USESTDHANDLES;
 
@@ -1034 +1036 @@
                 /*
                  * Start the process in suspended animation so we can inject handles.
-                 *
-                 * We clear the reserved 2 pointer + size to avoid passing the wrong
-                 * filehandle info to the child.  We may later want to generate this.
                  */
-                StartupInfo.cbReserved2 = 0;
-                StartupInfo.lpReserved2 = 0;
-
                 if (CreateProcessA(pszExecutable, pszCmdLine, NULL /*pProcAttrs*/, NULL /*pThreadAttrs*/,
                                    FALSE /*fInheritHandles*/, CREATE_SUSPENDED, pszzEnv, pszCwd, &StartupInfo, &ProcInfo))