Changeset 1854 for trunk/src/kmk/incdep.c

Timestamp:

Oct 13, 2008, 3:50:33 AM (17 years ago)

Author:

bird

Message:

kmk: offload hashing of strcache entries to the includedep thread(s).

File:

• trunk/src/kmk/incdep.c (modified) (13 diffs)

trunk/src/kmk/incdep.c

@@ -85 +85 @@
 *   Structures and Typedefs                                                    *
 *******************************************************************************/
+struct incdep_strcache_entry
+{
+    unsigned int length;
+    unsigned int alignment;
+    unsigned long hash1;
+    unsigned long hash2;
+    char str[1];
+};
 
 struct incdep_variable_in_set
@@ -90 +98 @@
     struct incdep_variable_in_set *next;
     /* the parameters */
-    char *name;                     /* xmalloc'ed -> strcache */
-    unsigned int name_length;
+    struct incdep_strcache_entry *name_entry;
     const char *value;              /* xmalloc'ed */
     unsigned int value_length;
@@ -106 +113 @@
     /* the parameters */
     const struct floc *flocp;       /* NILF */
-    char *name;                     /* xmalloc'ed -> strcache */
-    unsigned int name_length;       /* (not an actual parameter) */
+    struct incdep_strcache_entry *name_entry;
     char *value;                    /* xmalloc'ed, free it */
     unsigned int value_length;
@@ -120 +126 @@
 
     /* the parameters */
-    struct nameseq *filenames;      /* only one file? its name needs be strcache'ed */
+    struct nameseq *filenames;      /* One only, its name is a strcache entry. */
     const char *pattern;            /* NULL */
     const char *pattern_percent;    /* NULL */
-    struct dep *deps;               /* names need to be strcache'ed */
+    struct dep *deps;               /* All the names are strcache entries. */
     unsigned int cmds_started;      /* 0 */
     char *commands;                 /* NULL */
@@ -665 +671 @@
 
 #ifdef PARSE_IN_WORKER
+/* Flushes a strcache entry returning the actual string cache entry.
+   The input is freed! */
+static const char *
+incdep_flush_strcache_entry (const void *pv_entry)
+{
+  struct incdep_strcache_entry *entry = (struct incdep_strcache_entry *)pv_entry;
+  const char *result;
+  result = strcache_add_prehashed (entry->str, entry->length, entry->hash1, entry->hash2);
+  free (entry);
+  return result;
+}
+
 /* Flushes the recorded instructions. */
 static void
@@ -681 +699 @@
       {
         void *free_me = rec_vis;
-        define_variable_in_set (strcache_add_len (rec_vis->name, rec_vis->name_length),
-                                rec_vis->name_length,
+        unsigned int name_length = rec_vis->name_entry->length;
+        define_variable_in_set (incdep_flush_strcache_entry (rec_vis->name_entry),
+                                name_length,
                                 rec_vis->value,
                                 rec_vis->value_length,
@@ -690 +709 @@
                                 rec_vis->set,
                                 rec_vis->flocp);
-        incdep_xfree (cur, rec_vis->name);
         rec_vis = rec_vis->next;
         incdep_xfree (cur, free_me);
@@ -705 +723 @@
         void *free_me = rec_vd;
         do_variable_definition_2 (rec_vd->flocp,
-                                  strcache_add_len(rec_vd->name, rec_vd->name_length),
+                                  incdep_flush_strcache_entry (rec_vd->name_entry),
                                   rec_vd->value,
                                   rec_vd->value_length,
@@ -713 +731 @@
                                   rec_vd->flavor,
                                   rec_vd->target_var);
-        incdep_xfree (cur, rec_vd->name);
         rec_vd = rec_vd->next;
         incdep_xfree (cur, free_me);
@@ -728 +745 @@
         void *free_me = rec_f;
         struct dep *dep;
-        const char *newname;
 
         for (dep = rec_f->deps; dep; dep = dep->next)
-          {
-            newname = strcache_add (dep->name);
-            free ((char *)dep->name);
-            dep->name = newname;
-          }
-
-        newname = strcache_add (rec_f->filenames->name);
-        incdep_xfree (cur, (char *)rec_f->filenames->name);
-        rec_f->filenames->name = newname;
+          dep->name = incdep_flush_strcache_entry (dep->name);
+        rec_f->filenames->name = incdep_flush_strcache_entry (rec_f->filenames->name);
 
         record_files (rec_f->filenames,
@@ -790 +799 @@
   else
     {
-      /* Duplicate the string. The other recorders knows which arguments
-         needs to be added to the string cache later. */
-      char *newstr = incdep_xmalloc (cur, len + 1);
-      memcpy (newstr, str, len);
-      newstr[len] = '\0';
-      ret = newstr;
+      /* Allocate a strcache record for it, pre-hashing the string to save
+         time later on in the main thread. */
+      struct incdep_strcache_entry *entry = incdep_xmalloc (cur, sizeof (*entry) + len);
+      memcpy (entry->str, str, len);
+      entry->str[len] = '\0';
+      entry->length = len;
+      strcache_prehash_str (entry->str, &entry->hash1, &entry->hash2);
+
+      ret = (const char *)entry;
     }
   return ret;
@@ -823 +835 @@
     {
       struct incdep_variable_in_set *rec = incdep_xmalloc (cur, sizeof (*rec));
-      rec->name = (char *)name;
-      rec->name_length = name_length;
+      rec->name_entry = (struct incdep_strcache_entry *)name;
       rec->value = value;
       rec->value_length = value_length;
@@ -863 +874 @@
       struct incdep_variable_def *rec = incdep_xmalloc (cur, sizeof (*rec));
       rec->flocp = flocp;
-      rec->name = (char *)name;
-      rec->name_length = name_length;
+      rec->name_entry = (struct incdep_strcache_entry *)name;
       rec->value = value;
       rec->value_length = value_length;