Changeset 1423 for trunk/src

Timestamp:

Mar 19, 2008, 7:06:36 PM (17 years ago)

Author:

bird

Message:

Fixed bug in the CreateProcess failure handling, should now fail correctly with exit code 127 if for example a command cannot be found. Fixes #30.

File:

• trunk/src/kmk/w32/subproc/sub_proc.c (modified) (3 diffs)

trunk/src/kmk/w32/subproc/sub_proc.c

@@ -596 +596 @@
                         pproc->last_err = GetLastError();
                         pproc->lerrno = E_FORK;
+#ifdef KMK
+                        if (pproc->last_err == ERROR_FILE_NOT_FOUND)
+                                pproc->exit_code = 127; /* see execve failure in job.c. */
+#endif
                         fprintf(stderr, "process_begin: CreateProcess(%s, %s, ...) failed.\n",
                                 exec_path ? exec_path : "NULL", command_line);
@@ -940 +944 @@
                 pproc->sv_stderr[0] = 0;
         }
+
+#ifdef KMK
+        if (childhand == NULL || childhand == INVALID_HANDLE_VALUE) {
+                goto done2;
+        }
+#endif
 
         /*
@@ -1328 +1338 @@
     if (!((sub_process*) hProcess)->last_err)
       ((sub_process*) hProcess)->last_err = -1;
-    ((sub_process*) hProcess)->exit_code = process_last_err(hProcess);
+#ifdef KMK
+    if (!((sub_process*) hProcess)->exit_code)
+#endif
+      ((sub_process*) hProcess)->exit_code = process_last_err(hProcess);
 
 #ifndef KMK