Changeset 395 for trunk/openjdk

Timestamp:

Jul 18, 2012, 9:37:38 PM (13 years ago)

Author:

dmik

Message:

Make sure BEGINLIBPATH is not necessary when loading JVM.

BEGINLIBPATH is not necessary at all now: neither when loading the JVM
with standard launchers (like java.exe) nor when doing JVM.DLL directly.

Location:

trunk/openjdk

Files:

• hotspot/src/os/os2/vm/os_os2_init.cpp (modified) (3 diffs)
• jdk/src/windows/bin/java_md.c (modified) (2 diffs)

trunk/openjdk/hotspot/src/os/os2/vm/os_os2_init.cpp

@@ -28 +28 @@
 // the Windows DllMain() and registers the DLL with Odin
 
+#define INCL_DOS
+#define INCL_ERRORS
 #include <os2wrap.h> // Odin32 OS/2 api wrappers
 #include <odinlx.h>
@@ -36 +38 @@
 #include <emx/startup.h>
 #endif
+
+#include <string.h>
 
 extern "C" BOOL WINAPI DllMain(HINSTANCE hinst, DWORD reason, LPVOID reserved);
@@ -72 +76 @@
         CheckVersionFromHMOD(PE2LX_VERSION, hModule);
 
+        // Assuming that JVM.DLL is stored in a bin/<type>/ subdirectory (where
+        // type is e.g. "client"), we add this directory, as well as its parent
+        // (which contains all other Java DLLs), to BEGINLIBPATH so that the OS2
+        // DLL loader can satisfy DLL dependencies (i.e. find DLLs referred to
+        // by other DLLs through their import module table) when some Java DLLs
+        // (e.g. JAVA.DLL, JZIP.DLL) are dynamically loaded later by JVM.DLL.
+        // Note that despite the fact that JVM.DLL is already loaded at this
+        // point, we still need to add its directory to BEGINLIBPATH. This is
+        // bcause most likely it's been loaded by full path which does NOT make
+        // it locatable by the loader when referred to by name from the import
+        // table of some other DLL (like JAVA.DLL).
+
+        char dllpath[CCHMAXPATH + 16 /* ";%BEGINLIBPATH%" */];
+        if (DosQueryModuleName(hModule, sizeof(dllpath), dllpath) == NO_ERROR)
+        {
+            char *end = strrchr(dllpath, '\\');
+            if (end)
+            {
+                strcpy(end, ";%BEGINLIBPATH%");
+                DosSetExtLIBPATH(dllpath, BEGIN_LIBPATH);
+                end = strrchr(dllpath, '\\');
+                if (end)
+                {
+                    strcpy(end, ";%BEGINLIBPATH%");
+                    DosSetExtLIBPATH(dllpath, BEGIN_LIBPATH);
+                }
+            }
+        }
+
 #ifdef ODIN_FORCE_WIN32_TIB
         // enable __try/__except support

trunk/openjdk/jdk/src/windows/bin/java_md.c

@@ -234 +234 @@
 #ifdef __WIN32OS2__
     /*
-     * Native OS/2 LX DLLs support importing functions from other DLLs using
-     * relocation fixup records which differs from the Win32 PE format that does
-     * this through the IAT (import address table - a table of function
-     * pointers). As a result, if DLL_A imports something from DLL_B, then when
-     * DLL_A is loaded by a process, it will load a particular version of DLL_B
+     * Native OS/2 LX DLLs import functions from other DLLs using relocation
+     * fixup records which differs from the Win32 PE format that does this
+     * through the IAT (import address table - a table of function pointers).
+     * As a result, if DLL_A imports something from DLL_B then when DLL_A is
+     * loaded by a process, it will load a particular version of DLL_B
      * to call its functions and all other processes that load DLL_A will get
-     * the same calls to that particular version of DLL_B (from within DLL_A)
-     * even though they supply their own version of DLL_B. In case of Java this
-     * means that if there is a Java process using e.g. server/JVM.DLL and
-     * another process is requesting client/JVM.DLL, this second process will
-     * eventually crash because all Java DLLs statically linked to JVM.DLL (e.g.
+     * the same calls to that particular version of DLL_B even though they
+     * supply their own version of DLL_B (because relocation only happens once
+     * and it is system-wide, as opposed to Win32 where IAT tables are per-
+     * process). In case of Java this means that if there is a Java process
+     * using e.g. server/JVM.DLL and another process is requesting
+     * client/JVM.DLL, this second process will eventually crash because all
+     * Java DLLs statically linked to JVM.DLL through the import table (e.g.
      * JVERIFY.DLL, JZIP.DLL) which it loads later will be calling functions
      * from server/JVM.DLL but that DLL is *not* initialized within this process
-     * (no surprise, it loaded and initialized client/JVM.DLL instead). In order
-     * to avoid such crashes we have to give a corresponding error message and
-     * terminate, there is no other solution so far.
+     * (no surprise, the process has loaded and initialized client/JVM.DLL
+     * instead). In order to avoid such crashes we have to give a corresponding
+     * error message and terminate, there is no other solution so far.
      */
     {
@@ -281 +283 @@
             return JNI_FALSE;
     }
-
-    /*
-     * Add the JRE bin path to BEGINLIBPATH to make sure that other DLLs
-     * statically linked to the various JRE DLLs (so that they refer to them by
-     * name in the import tables) are able to find it. This is necessary because
-     * on OS/2, loading a DLL by full path does NOT make it available to other
-     * DLLs by name -- a normal procedure of searching it in LIBPATH and
-     * BEGINLIBPATH/ENDLIBPATH is always performed in this case.
-     */
-    if (GetJREPath(crtpath, MAXPATHLEN)) {
-        char *dir = (char *)malloc(strlen(crtpath) + 4 + 32);
-        strcpy(dir, crtpath);
-        strcat(dir, "\\bin;%BEGINLIBPATH%");
-        if (_launcher_debug) {
-             printf("Adding %s to BEGINLIBPATH\n", dir);
-        }
-        DosSetExtLIBPATH(dir, BEGIN_LIBPATH);
-        free(dir);
-    }
-
-    /*
-     * Do the same for the Java VM DLL which is located in a separate directory.
-     */
-    char *jvmdir = (char *)malloc(strlen(jvmpath) + 1 + 32);
-    strcpy(jvmdir, jvmpath);
-    char *sep = strrchr(jvmdir, '\\');
-    if (sep) {
-        strcpy(sep, ";%BEGINLIBPATH%");
-        if (_launcher_debug) {
-             printf("Adding %s to BEGINLIBPATH\n", jvmdir);
-        }
-        DosSetExtLIBPATH(jvmdir, BEGIN_LIBPATH);
-    }
-    free(jvmdir);
 #endif