Changeset 1103

Timestamp:

Aug 2, 2008, 10:30:53 PM (17 years ago)

Author:

Gregg Young

Message:

Make sure pszTemp is freed on PostMsg failure

File:

• trunk/dll/notebook.c (modified) (2 diffs)

trunk/dll/notebook.c

@@ -1270 +1270 @@
     {
       char * pszTemp = xmalloc(WinQueryDlgItemTextLength(hwnd, CFGT_ENVVARLIST) + 1, pszSrcFile, __LINE__);
-      if (pszTemp)
-      {
+      if (pszTemp) {
         WinQueryDlgItemText(hwnd, CFGT_ENVVARLIST, MaxComLineStrg, pszTemp);
         strupr(pszTemp);
@@ -1292 +1291 @@
         pszTemp = xstrdup(pci->pszFileName, pszSrcFile, __LINE__);
         if (pszTemp) {
-          PostMsg(hwndTree, UM_SHOWME, MPFROMP(pszTemp), MPVOID);
+          if (!PostMsg(hwndTree, UM_SHOWME, MPFROMP(pszTemp), MPVOID))
+            free(pszTemp);
           /* pszTemp is freed in the UM_SHOWME code */
         }