Skip to content

/ react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable Profiler commit hooks flag #19900

Merged
merged 2 commits into from Sep 30, 2020
Merged

Temporarily disable Profiler commit hooks flag #19900

merged 2 commits into from Sep 30, 2020
+4 −1

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 24, 2020 •
edited

This will enable us to enable/disable it on www to see if it causes a regression.

At first I thought I'd make this flag static. Converting a static flag to dynamic isn't great, but this particular flag doesn't add any additional fields to a Fiber. However it would add an additional runtime check to a hot path so I'm going to just disable it entirely for now.

This PR does not need to land to take this measurement. I'll do an out-of-band sync with it.
@bvaughn bvaughn requested review from gaearon and rickhanlonii Sep 24, 2020
@codesandbox
Copy link

@codesandbox codesandbox bot commented Sep 24, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d548a66:

Sandbox Source
React Configuration
@sizebot
Copy link

@sizebot sizebot commented Sep 24, 2020 •
edited

Details of bundled changes.

Comparing: 9198a5c...d548a66

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 909.09 KB 909.09 KB 206.59 KB 206.59 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 375.25 KB 375.25 KB 69.65 KB 69.65 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% 0.0% 138.57 KB 138.57 KB 36.58 KB 36.59 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 122.35 KB 122.35 KB 39.41 KB 39.41 KB NODE_PROD
ReactDOMForked-profiling.js -1.4% -1.0% 389.81 KB 384.45 KB 72.22 KB 71.49 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 144.73 KB 144.73 KB 36.77 KB 36.77 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.66 KB 20.66 KB 7.65 KB 7.65 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 13.71 KB 13.71 KB 5.32 KB 5.32 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 911.89 KB 911.89 KB 205.34 KB 205.34 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 66.29 KB 66.29 KB 18.84 KB 18.84 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.52 KB 5.52 KB 1.84 KB 1.84 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 13.7 KB 13.7 KB 5.27 KB 5.27 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 5.25 KB 5.25 KB 1.78 KB 1.78 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.17 KB 1.17 KB 666 B 668 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.22 KB 1.22 KB 712 B 713 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 4.78 KB 4.78 KB 1.68 KB 1.68 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 955.29 KB 955.29 KB 209.17 KB 209.17 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.01 KB 1.01 KB 616 B 617 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 122.17 KB 122.17 KB 40.14 KB 40.14 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 127.42 KB 127.42 KB 41.79 KB 41.79 KB UMD_PROFILING
ReactDOMForked-dev.js -0.7% -0.5% 971.13 KB 964.78 KB 215.88 KB 214.89 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 127.78 KB 127.78 KB 41.09 KB 41.1 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 20.34 KB 20.34 KB 7.55 KB 7.55 KB UMD_PROD
ReactDOM-dev.js -0.7% -0.5% 960.98 KB 954.26 KB 214.69 KB 213.66 KB FB_WWW_DEV
react-dom-server.browser.development.js 0.0% 0.0% 137.3 KB 137.3 KB 36.33 KB 36.33 KB NODE_DEV
ReactDOM-profiling.js -1.3% -0.9% 387.21 KB 382.21 KB 71.77 KB 71.11 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 20.24 KB 20.24 KB 7.5 KB 7.5 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 141.48 KB 141.48 KB 36.28 KB 36.29 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 46.44 KB 46.44 KB 10.83 KB 10.83 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 71.48 KB 71.48 KB 19.36 KB 19.36 KB UMD_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% -0.0% 232.81 KB 232.81 KB 41.29 KB 41.29 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 691.05 KB 691.05 KB 146.43 KB 146.43 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 111.3 KB 111.3 KB 34.6 KB 34.61 KB UMD_PROD
react-art.development.js 0.0% 0.0% 592.21 KB 592.21 KB 128.57 KB 128.58 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 76.18 KB 76.18 KB 23.69 KB 23.69 KB NODE_PROD
ReactART-dev.js -1.1% -0.8% 618.74 KB 612.02 KB 131.43 KB 130.36 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against d548a66

@sizebot
Copy link

@sizebot sizebot commented Sep 24, 2020 •
edited

Details of bundled changes.

Comparing: 9198a5c...d548a66

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 873.54 KB 873.54 KB 200.05 KB 200.06 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.06 KB 137.06 KB 36.37 KB 36.37 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 117.78 KB 117.78 KB 38.04 KB 38.05 KB NODE_PROD
ReactDOMForked-profiling.js -1.3% -1.0% 401.18 KB 395.82 KB 73.94 KB 73.22 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 143.14 KB 143.14 KB 36.57 KB 36.57 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.2 KB 20.2 KB 7.58 KB 7.58 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 13.7 KB 13.7 KB 5.31 KB 5.32 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% -0.0% 940.23 KB 940.23 KB 210.82 KB 210.82 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 66.28 KB 66.28 KB 18.84 KB 18.84 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 13.68 KB 13.68 KB 5.26 KB 5.26 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 917.98 KB 917.98 KB 202.59 KB 202.59 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 117.68 KB 117.68 KB 38.73 KB 38.73 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 121.58 KB 121.58 KB 39.95 KB 39.95 KB UMD_PROFILING
ReactDOMForked-dev.js -0.6% -0.5% 996.71 KB 990.36 KB 220.64 KB 219.64 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 121.85 KB 121.85 KB 39.22 KB 39.22 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 19.88 KB 19.88 KB 7.46 KB 7.46 KB UMD_PROD
ReactDOM-dev.js -0.7% -0.5% 986.57 KB 979.85 KB 219.37 KB 218.34 KB FB_WWW_DEV
react-dom-server.browser.development.js 0.0% 0.0% 135.79 KB 135.79 KB 36.12 KB 36.12 KB NODE_DEV
ReactDOM-profiling.js -1.3% -0.9% 398.51 KB 393.52 KB 73.42 KB 72.76 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 19.78 KB 19.78 KB 7.42 KB 7.42 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 145.51 KB 145.51 KB 37.29 KB 37.3 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 47.3 KB 47.3 KB 11.04 KB 11.04 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 71.47 KB 71.47 KB 19.35 KB 19.35 KB UMD_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% -0.0% 239.97 KB 239.97 KB 42.55 KB 42.55 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 664.14 KB 664.14 KB 141.44 KB 141.44 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 108.38 KB 108.38 KB 33.74 KB 33.75 KB UMD_PROD
react-art.development.js 0.0% 0.0% 566.58 KB 566.58 KB 123.67 KB 123.67 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 73.33 KB 73.33 KB 22.85 KB 22.85 KB NODE_PROD
ReactART-dev.js -1.1% -0.8% 628.75 KB 622.03 KB 133.45 KB 132.4 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against d548a66

@bvaughn bvaughn changed the title Make the Profiler commit hooks flag dynamic Temporarily disable Profiler commit hooks flag Sep 24, 2020
@bvaughn bvaughn removed request for gaearon and rickhanlonii Sep 24, 2020
@bvaughn bvaughn marked this pull request as draft Sep 24, 2020
@bvaughn bvaughn changed the title Temporarily disable Profiler commit hooks flag [draft] Temporarily disable Profiler commit hooks flag Sep 24, 2020
@bvaughn bvaughn force-pushed the bvaughn:make-profiler-commit-hooks-flag-dynamic branch from 54292ad to 8f13427 Sep 30, 2020
@bvaughn
Temporarily disable Profiler commit hooks flag to verify it does not …
Loading status checks…
f412961 
…cause a regression.
@bvaughn bvaughn force-pushed the bvaughn:make-profiler-commit-hooks-flag-dynamic branch from 8f13427 to f412961 Sep 30, 2020
@bvaughn
Add TODO
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d548a66
@bvaughn bvaughn marked this pull request as ready for review Sep 30, 2020
@bvaughn bvaughn changed the title [draft] Temporarily disable Profiler commit hooks flag Temporarily disable Profiler commit hooks flag Sep 30, 2020
@acdlite
acdlite approved these changes Sep 30, 2020
View changes
@bvaughn bvaughn merged commit 5427b46 into facebook:master Sep 30, 2020
1 of 3 checks passed
1 of 3 checks passed
ci/circleci: setup CircleCI is running your tests
Details
ci/codesandbox Building packages...
Details
Facebook CLA Check Contributor License Agreement is valid!
Details
@bvaughn bvaughn deleted the bvaughn:make-profiler-commit-hooks-flag-dynamic branch Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@bvaughn @sizebot @acdlite @facebook-github-bot
You can’t perform that action at this time.