Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly call Profiler onRender if we performed work #19885
Merged
+54
−28
Conversation
bvaughn
changed the title
codesandbox
bot
commented
Sep 22, 2020
•
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7e4db65:
|
sizebot
commented
Sep 22, 2020
•
sizebot
commented
Sep 22, 2020
•
If we didn't perform any work in the subtree, skip calling onRender.
bvaughn
force-pushed the
bvaughn:onRender-only-if-PerformedWork
branch
from
feffd94
to
7e4db65
bvaughn
merged commit 87c023b
into
facebook:master
34 checks passed
34 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bvaughn commentedSep 22, 2020
Builds on top of PR #19863