gh-89004: add attribute filemode in zipinfo by Akasurde · Pull Request #120999 · python/cpython

Akasurde · 2024-06-25T14:51:23Z

Add attribute zipfile.ZipInfo.filemode.

Fixes: #89004

Issue: filemode in repr of ZipInfo, but is not a ZipInfo attribute #89004

📚 Documentation preview 📚: https://cpython-previews--120999.org.readthedocs.build/

Misc/NEWS.d/next/Library/2024-06-25-07-49-16.gh-issue-89004.uJfz2B.rst

Lib/zipfile/__init__.py

Add attribute zipfile.ZipInfo.filemode. Fixes: python#89004 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

eendebakpt

@Akasurde Two more comments, but the overall approach looks good.

Please do not use force push on the branch, it makes it hard for other reviewers the follow the history.

eendebakpt · 2024-07-01T05:36:02Z

Lib/zipfile/__init__.py

        self.external_attr = 0          # External file attributes
        self.compress_size = 0          # Size of the compressed file
        self.file_size = 0              # Size of the uncompressed file
+        self.file_mode = b""            # External attributes of the uncompressed file


Why is this line needed?

eendebakpt · 2024-07-01T05:36:34Z

Lib/zipfile/__init__.py

    def _compresslevel(self, value):
        self.compress_level = value

+    @property


The new property needs unit testing for different modes

…python#121126) asyncio earlier relied on subprocess module to send signals to the process, this has some drawbacks one being that subprocess module unnecessarily calls waitpid on child processes and hence it races with asyncio implementation which internally uses child watchers. To mitigate this, now asyncio sends signals directly to the process without going through the subprocess on non windows systems. On Windows it fallbacks to subprocess module handling but on windows there are no child watchers so this issue doesn't exists altogether.

…ython#119816) 1. Use pkg-config to check for ncursesw/panelw. If that fails, use pkg-config to check for ncurses/panel. 2. Regardless of pkg-config output, search for curses/panel headers, so we're sure we have all defines in pyconfig.h. 3. Regardless of pkg-config output, check if libncurses or libncursesw contains the 'initscr' symbol; if it does _and_ pkg-config failed earlier, add the resulting -llib linker option to CURSES_LIBS. Ditto for 'update_panels' and PANEL_LIBS. 4. Wrap the rest of the checks with WITH_SAVE_ENV and make sure we're using updated LIBS and CPPFLAGS for those. Add the PY_CHECK_CURSES convenience macro.

…121195) When creating the JUnit XML file, regrtest now escapes characters which are invalid in XML, such as the chr(27) control character used in ANSI escape sequences.

) Use the _Py__has_attribute() macro in timemodule.c and bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5 on s390x).

…hon#120894) Example: ```pycon >>> import ctypes >>> ctypes.__STDC_IEC_559_COMPLEX__ 1 >>> libm = ctypes.CDLL('libm.so.6') >>> libm.clog.argtypes = [ctypes.c_double_complex] >>> libm.clog.restype = ctypes.c_double_complex >>> libm.clog(1+1j) (0.34657359027997264+0.7853981633974483j) ``` Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>

…ython#121191) dash_R_cleanup() now calls _abc_registry_clear() before calling again register().

Use subTest() to log the pwd entry in test_expanduser_pwd2() of test_posixpath to help debugging.

…621 in /Tools (python#121215) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1216) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

….20240627 in /Tools (python#121217) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…HANDSHAKE (pythonGH-117785) With this change, builds with OpenSSL forks that don't have this functionalty (like AWS-LC or BoringSSL) will require less patching.

…vy (python#121221) Mark test_threaded_weak_value_dict_copy() and test_threaded_weak_key_dict_copy() of test_weakref as CPU-heavy tests

…read safe (pythonGH-120490)

…#121228) Call getpwnam() to get pw_dir, since it can be different than getpwall() pw_dir.

Soft deprecate os.popen() and os.spawn*() functions.

…time behavior (python#121175)

…set_each (pythongh-121236) This will allow Py_TRACE_REFS builds to pass the test suite, until the underlying issue can be resolved.

…ython#120914) Refactor the fast Unicode hash check into `_PyObject_HashFast` and use relaxed atomic loads in the free-threaded build. After this change, the TSAN doesn't report data races for this method.

…121197)

…while(0) (python#121166)

…ymtable (python#121273)

…1244) Avoids the extra conversion from stack refs to PyObjects.

… dark/light modes. (pythonGH-121265)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

bedevere-app bot mentioned this pull request Jun 25, 2024

filemode in repr of ZipInfo, but is not a ZipInfo attribute #89004

Open

bedevere-app bot added the awaiting review label Jun 25, 2024

eendebakpt reviewed Jun 28, 2024

View reviewed changes

Misc/NEWS.d/next/Library/2024-06-25-07-49-16.gh-issue-89004.uJfz2B.rst Outdated Show resolved Hide resolved

eendebakpt reviewed Jun 28, 2024

View reviewed changes

Lib/zipfile/__init__.py Outdated Show resolved Hide resolved

Akasurde force-pushed the zip_filemode branch from 5619649 to 2c56b15 Compare June 29, 2024 02:50

eendebakpt reviewed Jun 29, 2024

View reviewed changes

Lib/zipfile/__init__.py Outdated Show resolved Hide resolved

pythongh-89004: add attribute filemode in zipinfo

5712032

Add attribute zipfile.ZipInfo.filemode. Fixes: python#89004 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Akasurde force-pushed the zip_filemode branch from 2c56b15 to 5712032 Compare July 1, 2024 00:26

eendebakpt reviewed Jul 1, 2024

View reviewed changes

kumaraditya303 and others added 21 commits July 2, 2024 17:16

pythongh-121188: Sanitize invalid XML characters in regrtest (python#…

a95fdf1

…121195) When creating the JUnit XML file, regrtest now escapes characters which are invalid in XML, such as the chr(27) control character used in ANSI escape sequences.

pythongh-121199: Use _Py__has_attribute() in timemodule.c (python#121203

ae955a1

) Use the _Py__has_attribute() macro in timemodule.c and bootstrap_hash.c to fix a build error on old GCC versions (GCC 4.8.5 on s390x).

pythongh-121084: Call _abc_registry_clear() when checking refleaks (p…

da14728

…ython#121191) dash_R_cleanup() now calls _abc_registry_clear() before calling again register().

pythongh-121200: Log pwd entry in test_expanduser_pwd2() (python#121207)

29341d2

Use subTest() to log the pwd entry in test_expanduser_pwd2() of test_posixpath to help debugging.

build(deps-dev): bump types-psutil from 5.9.5.20240516 to 6.0.0.20240…

7673061

…621 in /Tools (python#121215) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps-dev): bump mypy from 1.10.0 to 1.10.1 in /Tools (python#12…

86e28f3

…1216) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps-dev): bump types-setuptools from 70.0.0.20240524 to 70.1.0…

2fe7063

….20240627 in /Tools (python#121217) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

pythongh-117784: Only reference PHA functions ifndef SSL_VERIFY_POST_…

939ef43

…HANDSHAKE (pythonGH-117785) With this change, builds with OpenSSL forks that don't have this functionalty (like AWS-LC or BoringSSL) will require less patching.

pythongh-121220: Mark test_threaded_weak_value_dict_copy() as CPU-hea…

ba03963

…vy (python#121221) Mark test_threaded_weak_value_dict_copy() and test_threaded_weak_key_dict_copy() of test_weakref as CPU-heavy tests

pythongh-117657: Use critical section to make _socket.socket.close th…

e339506

…read safe (pythonGH-120490)

pythongh-121200: Fix test_expanduser_pwd2() of test_posixpath (python…

fa8fc30

…#121228) Call getpwnam() to get pw_dir, since it can be different than getpwall() pw_dir.

pythongh-120743: Soft deprecate os.popen() function (python#120744)

42ea99b

Soft deprecate os.popen() and os.spawn*() functions.

pythongh-114104: clarify asynchronous comprehension docs to match run…

df4fc8a

…time behavior (python#121175)

pythongh-121110: Temporarily Skip test_basic_multiple_interpreters_re…

954a1c1

…set_each (pythongh-121236) This will allow Py_TRACE_REFS builds to pass the test suite, until the underlying issue can be resolved.

pythongh-117657: Fix data races reported by TSAN in some set methods (p…

6c7d265

…ython#120914) Refactor the fast Unicode hash check into `_PyObject_HashFast` and use relaxed atomic loads in the free-threaded build. After this change, the TSAN doesn't report data races for this method.

pythonGH-116017: Get rid of _COLD_EXITs (pythonGH-120960)

d7dedc3

pythongh-121196: Document dict.fromkeys params as pos-only (python#…

ab15da2

…121197)

pythonGH-119726: Use LDR for AArch64 trampolines (pythonGH-121001)

26a4df5

picnixz and others added 6 commits July 2, 2024 17:16

pythongh-121165: protect macro expansion of ADJUST_INDICES with do-…

3908aed

…while(0) (python#121166)

pythongh-121272: move __future__ import validation from compiler to s…

f767f75

…ymtable (python#121273)

pythongh-117139: Add _PyTuple_FromStackRefSteal and use it (python#12…

d19d6db

…1244) Avoids the extra conversion from stack refs to PyObjects.

pythongh-115773: Add sizes to debug offset structure (python#120112)

5a91a46

pythongh-121035: Further improve logging flow diagram with respect to…

0f795b6

… dark/light modes. (pythonGH-121265)

CI fixes

27eb05e

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Akasurde closed this Jul 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-89004: add attribute filemode in zipinfo#120999

gh-89004: add attribute filemode in zipinfo#120999
Akasurde wants to merge 33 commits intopython:mainfrom
Akasurde:zip_filemode

Akasurde commented Jun 25, 2024 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eendebakpt left a comment

Uh oh!

eendebakpt Jul 1, 2024

Uh oh!

eendebakpt Jul 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

Akasurde commented Jun 25, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eendebakpt left a comment

Choose a reason for hiding this comment

Uh oh!

eendebakpt Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

eendebakpt Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Akasurde commented Jun 25, 2024 •

edited by github-actions bot

Loading