Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 #117030

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 19, 2024

@zooba zooba requested a review from sethmlarson as a code owner March 19, 2024 19:39
@terryjreedy
Copy link
Member

terryjreedy commented Mar 20, 2024

@chrstphrchvz knows about tcl/tk changes.
@serhiy-storchaka is tkinter/ttk code and test maintainer.

Windows x86 test https://github.com/python/cpython/actions/runs/8349119889/job/22852588108?pr=117030

*** test tkinter 2 failures: lines 2001-2061
condensed failure:

FAIL: test_itemconfigure (test.test_tkinter.test_widgets.ListboxTest.test_itemconfigure)
  File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 1002, in test_itemconfigure
    self.assertEqual(widget.itemconfigure(0, 'background'),
AssertionError: Tuples differ: ('background', '', '', '', 'red') != ('background', 'background', 'Background', '', 'red')

FAIL: test_configure_tabs (test.test_tkinter.test_widgets.TextTest.test_configure_tabs)
  File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 662, in test_configure_tabs
    self.checkParam(widget, 'tabs', '10.2 20.7 1i 2i',
AssertionError: Tuples differ: (10.2, 20.7, <string object: '1i'>, <string object: '2i'>) != ('10.2', '20.7', '1i', '2i')

*** test audit 1 failure, lines 980-1070: Broken pipe error
I know nothing about this. It passed on rerun, same fail, OK on x64, no failure on free-threading builds.
Perhaps ignore for now.

*** test_ttk failed (8 failures) lines 2066-2265
All are same quoting issue: actual (0,) expected as ('0',).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants