Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Block flow into flow sources #15483

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

hmac
Copy link
Contributor

@hmac hmac commented Jan 31, 2024

This restricts alert paths to the minimum necessary.

@github-actions github-actions bot added the Ruby label Jan 31, 2024
@@ -34,6 +34,8 @@

override predicate isSink(DataFlow::Node sink) { sink instanceof Sink }

predicate isBarrierIn(DataFlow::Node node) { isSource(node) }

Check warning

Code scanning / CodeQL

Missing override annotation Warning

Configuration.isBarrierIn overrides
Configuration.isBarrierIn
but does not have an override annotation.
@@ -40,4 +40,6 @@
super.isSanitizer(node) or
node instanceof Sanitizer
}

predicate isBarrierIn(DataFlow::Node node) { isSource(node) }

Check warning

Code scanning / CodeQL

Missing override annotation Warning

Configuration.isBarrierIn overrides
Configuration.isBarrierIn
but does not have an override annotation.
@@ -34,6 +34,8 @@

override predicate isSink(DataFlow::Node sink) { sink instanceof Sink }

predicate isBarrierIn(DataFlow::Node node) { isSource(node) }

Check warning

Code scanning / CodeQL

Using implicit `this` Warning

Use of implicit this.
@@ -40,4 +40,6 @@
super.isSanitizer(node) or
node instanceof Sanitizer
}

predicate isBarrierIn(DataFlow::Node node) { isSource(node) }

Check warning

Code scanning / CodeQL

Using implicit `this` Warning

Use of implicit this.
This restricts alert paths to the minimum necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant