src: updates functionality for .env files #51130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds heredocs, string interpolation, triple quotes, control codes. Updates for backticks, single and double quotes.
|
Review requested:
|
nodejs-github-bot
added
build
anonrig
reviewed
Dec 15, 2023
| }; | ||
| class EnvStream { | ||
| size_t index_ = 0; | ||
| std::string* data_ = nullptr; |
There was a problem hiding this comment.
Why do we have a string pointer, but not std::string_view?
| @@ -32,6 +35,170 @@ class Dotenv { | |||
|
|
|||
| } // namespace node | |||
|
|
|||
| namespace cppnv { | |||
There was a problem hiding this comment.
We should move this inside node namespace.
| return own_buffer != nullptr; | ||
| } | ||
|
|
||
| void set_own_buffer(std::string* buff) { |
There was a problem hiding this comment.
Lack of documentation on these functions make it really hard to review/approve this PR
| return ret; | ||
| } | ||
|
|
||
| bool cppnv::EnvStream::good() const { |
There was a problem hiding this comment.
The naming convention makes it really hard to understand what this function does.
| return end_of_stream_key; | ||
| } | ||
|
|
||
| int EnvReader::get_white_space_offset_left(const std::string* value, |
There was a problem hiding this comment.
We should use std::string_view instead of std::string* in everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
.env parser
Notable Changes
All previous features including backtick quotes work the same. It passes all previous tests and I've add quite a few more. Runs quickly as I minimalized the amount of allocations by reusing a string buffer and only copying when I need to. I avoided string split and trim as well to avoid more allocs. On average in debug mode on my machine it took about 14ms to run. Mileage may vary and I know I can squeeze a little more out of it if needed.
note Because of my love of granular checkpoint commits and a misunderstanding of the docs when it came to messages (subsystems vs update,fix) I deleted my original fork and just created a new one instead of wrestling with a huge rebase that could unlink me from the upstream. This is the same code as before.
Link to new tests
Context: The current env parser doesn't have full .env compatibility. It lacks heredocs and interpolation. After a conversation with @anonrig I decided to pursue adding this to node.