Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak fix for RefBase::Delete(RefBase* reference) #44339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Memory leak fix for RefBase::Delete(RefBase* reference) #44339

wants to merge 1 commit into from
+1 −0

Conversation

nagendra5
Copy link

@nagendra5 nagendra5 commented Aug 22, 2022 •
edited

This is to fix the memory leak. Calling finalizer() and not setting _finalize_ran to true will cause a memory leak. This _finalize_ran check is being used at the RefBase::Delete().

@nagendra5
Update js_native_api_v8.cc
76ce7bb 
This is to fix the memory leak. calling finalizer and not setting _finalize_ran to true will cause a memory leak.
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Aug 22, 2022

Review requested:

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 22, 2022
@legendecas
Copy link
Member

legendecas commented Aug 22, 2022

Would you mind sharing a re-production with the memory leak?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nagendra5 @nodejs-github-bot @legendecas