build: enable Clang-cl Windows builds #35433

targos · 2020-09-30T18:33:36Z

This is very hacky at the moment. I'm trying to find out what needs to be done to enable it and where.
I'm opening a PR to discuss the changes and seek some help, because it doesn't work yet!

To try it: .\vcbuild.bat

targos · 2020-09-30T18:36:59Z

deps/icu-small/source/tools/toolutil/pkg_genc.cpp

 #   else
-        *pCPU = IMAGE_FILE_MACHINE_UNKNOWN;
+        *pCPU = IMAGE_FILE_MACHINE_AMD64;


This is for #34201

targos · 2020-09-30T18:38:00Z

deps/zlib/crc_folding.c

+#include <smmintrin.h>
+#include <tmmintrin.h>


I opened https://chromium-review.googlesource.com/c/chromium/src/+/2281008 for this

targos · 2020-09-30T18:39:29Z

node.gypi

+      # 'msvs_precompiled_header': 'tools/msvs/pch/node_pch.h',
+      # 'msvs_precompiled_source': 'tools/msvs/pch/node_pch.cc',
+      # 'sources': [
+      #   '<(_msvs_precompiled_header)',
+      #   '<(_msvs_precompiled_source)',
+      # ],


I get an error about non-portable includes if precompiled headers are enabled.

targos · 2020-09-30T18:39:57Z

tools/gyp/pylib/gyp/generator/msvs.py

@@ -2799,7 +2799,7 @@ def _GetMSBuildLocalProperties(msbuild_toolset):
  if msbuild_toolset:
    properties = [
        ['PropertyGroup', {'Label': 'Locals'},
-          ['PlatformToolset', msbuild_toolset],
+          ['PlatformToolset', 'ClangCL'],


This obviously has to come from configuration in the end

targos · 2020-09-30T18:43:18Z

With all the above hacks, I am blocked on this error:

lld-link : error : undefined symbol: public: virtual __cdecl v8::internal::Relocatable::~Relocatable(void) [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]

Related warning in the build output:

..\..\deps\v8\src/objects/objects.h(818,18): warning : inline function 'v8::internal::Relocatable::~Relocatable' is not defined [-Wundefined-inline] [D:\a\node\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
..\..\deps\v8\src/objects/string.h(821,25): message : used here [D:\a\node\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

node/deps/v8/src/objects/objects.h

Lines 815 to 833 in 4a6005c

    
           class Relocatable { 
        
            public: 
        
             explicit inline Relocatable(Isolate* isolate); 
        
             inline virtual ~Relocatable(); 
        
             virtual void IterateInstance(RootVisitor* v) {} 
        
             virtual void PostGarbageCollection() {} 
        
             static void PostGarbageCollectionProcessing(Isolate* isolate); 
        
             static int ArchiveSpacePerThread(); 
        
             static char* ArchiveState(Isolate* isolate, char* to); 
        
             static char* RestoreState(Isolate* isolate, char* from); 
        
             static void Iterate(Isolate* isolate, RootVisitor* v); 
        
             static void Iterate(RootVisitor* v, Relocatable* top); 
        
             static char* Iterate(RootVisitor* v, char* t); 
        
            private: 
        
             Isolate* isolate_; 
        
             Relocatable* prev_; 
        
           };

node/deps/v8/src/objects/string.h

Lines 821 to 836 in 4a6005c

    
           class V8_EXPORT_PRIVATE FlatStringReader : public Relocatable { 
        
            public: 
        
             FlatStringReader(Isolate* isolate, Handle<String> str); 
        
             FlatStringReader(Isolate* isolate, Vector<const char> input); 
        
             void PostGarbageCollection() override; 
        
             inline uc32 Get(int index); 
        
             template <typename Char> 
        
             inline Char Get(int index); 
        
             int length() { return length_; } 
        
            private: 
        
             Address* str_; 
        
             bool is_one_byte_; 
        
             int length_; 
        
             const void* start_; 
        
           };

targos · 2020-10-02T08:28:22Z

/cc @nodejs/v8

gengjiawen · 2020-10-02T14:56:11Z

Another tricky thing is that we can't even test this on github action due to space limit https://github.com/nodejs/node/pull/35433/checks?check_run_id=1189469828 LIB : LLVM error : IO failure on output stream: no space on device.

dennisameling · 2020-10-03T20:08:43Z

Regarding the disk space issue: the D:\ drive on Windows VMs apparently has 14GB available - this is also described in the official docs. A workaround is to move things to the C:\ drive which has 80GB+ as described in actions/runner-images#1341 (comment)

gengjiawen · 2020-10-19T00:45:45Z

@targos Can you rebase this, so we can working on new V8 ?

gengjiawen · 2020-10-19T01:14:00Z

Regarding the disk space issue: the D:\ drive on Windows VMs apparently has 14GB available - this is also described in the official docs. A workaround is to move things to the C:\ drive which has 80GB+ as described in actions/virtual-environments#1341 (comment)

I investigate a little bit, looks like not an easy thing to do: actions/checkout#197.

Also, below won't work either on windows CI on github action.

    defaults:
      run:
        working-directory: C:/nodejs

Not sure why they default to drive D with such a limited disk space.

targos · 2020-10-19T06:09:02Z

Rebased on #35700

targos · 2020-10-19T06:23:38Z

I don't know if CI has clang-cl. Let's try: https://ci.nodejs.org/job/node-test-commit-windows-fanned/38888/

Edit: well, it doesn't 😄

08:23:59 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(411,5): error MSB8020: The build tools for ClangCL (Platform Toolset = 'ClangCL') cannot be found. To build using the ClangCL build tools, please install ClangCL build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C:\workspace\node-compile-windows\node\node_etw.vcxproj]

targos · 2020-10-19T06:29:42Z

@nodejs/build-infra Would it be easy to install ClangCL build tools on the Windows machines?

gengjiawen · 2020-10-19T06:45:46Z

@nodejs/build-infra Would it be easy to install ClangCL build tools on the Windows machines?

Not sure this will help: https://github.com/appveyor/build-images/blob/27bde614bc60d7ef7a8bc46182f4d7582fa11b56/scripts/Windows/install_vs2019.ps1#L192.

targos · 2020-10-19T06:52:23Z

So I tried to build it on my local machine.

There's one warning that is very noisy (I think it's printed for every V8 source file:

..\..\deps\v8\src/base/safe_conversions_impl.h(158,46): warning : implicit conversion from 'long long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion] [D:\Git\no 
dejs\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
..\..\deps\v8\src/base/safe_conversions_impl.h(213,52): message : in instantiation of member function 'v8::base::internal::DstRangeRelationToSrcRangeImpl<long long, double, v8::base::internal::INTEGER_REPRESENTATION_SIGNE 
D, v8::base::internal::INTEGER_REPRESENTATION_SIGNED, v8::base::internal::NUMERIC_RANGE_NOT_CONTAINED>::Check' requested here [D:\Git\nodejs\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
..\..\deps\v8\src/base/safe_conversions.h(44,21): message : in instantiation of function template specialization 'v8::base::internal::DstRangeRelationToSrcRange<long long, double>' requested here [D:\Git\nodejs\node\tools 
\v8_gypfiles\v8_base_without_compiler.vcxproj]
..\..\deps\v8\src/base/platform/time.h(228,20): message : in instantiation of function template specialization 'v8::base::saturated_cast<long long, double>' requested here [D:\Git\nodejs\node\tools\v8_gypfiles\v8_base_wit 
hout_compiler.vcxproj]

Then it fails with 3 errors (related warnings included):

lld-link : error : undefined symbol: public: virtual __cdecl v8::internal::Relocatable::~Relocatable(void) [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-win.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\mksnapshot.obj
  >>> referenced by v8_base_without_compiler.lib(stack-guard.obj)

..\..\deps\v8\src/objects/objects.h(818,18): warning : inline function 'v8::internal::Relocatable::~Relocatable' is not defined [-Wundefined-inline] [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
..\..\deps\v8\src/objects/string.h(832,25): message : used here [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]

lld-link : error : undefined symbol: public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int) const [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-win.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\mksnapshot.obj
  >>> referenced by v8_base_without_compiler.lib(flush-instruction-cache.obj)

..\..\deps\v8\src/objects/fixed-array.h(102,17): warning : inline function 'v8::internal::FixedArray::get' is not defined [-Wundefined-inline] [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
..\..\deps\v8\src/objects/ordered-hash-table.h(88,23): message : used here [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]

lld-link : error : undefined symbol: public: void __cdecl v8::internal::FixedArray::set(int, class v8::internal::Smi) [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-win.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\mksnapshot.obj
  >>> referenced by v8_base_without_compiler.lib(flush-instruction-cache.obj)

..\..\deps\v8\src/objects/fixed-array.h(134,15): warning : inline function 'v8::internal::FixedArray::set' is not defined [-Wundefined-inline] [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
..\..\deps\v8\src/objects/ordered-hash-table.h(210,5): message : used here [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]

gengjiawen · 2020-10-19T06:59:02Z

Looks like all related to inline function on windows platform.

gengjiawen · 2020-11-09T07:46:16Z

Now stucks with

  ..\..\out\Release\obj\v8_libsampler\\deps\v8\src\libsampler\sampler.obj: no such file or directory
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1309,5): error MSB6006: "llvm-lib.exe" exited with code 1. [D:\code\node\tools\v8_gypfiles\v8_libsampler.vcxproj]
  ..\..\out\Release\obj\v8_zlib\\deps\v8\third_party\zlib\adler32.obj: no such file or directory
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1309,5): error MSB6006: "llvm-lib.exe" exited with code 1. [D:\code\node\tools\v8_gypfiles\v8_zlib.vcxproj]

Maybe related: https://developercommunity.visualstudio.com/content/problem/1110835/clangcl-ltcg-is-passed-to-llvm-lib.html

This occurred when I update my visual studio to latest.

I also get some ideas to patch V8 to make the windows build works.

dennisameling · 2020-11-11T08:41:42Z

Just for the record, Visual Studio 16.8 was released yesterday and has the following mentioned in its release notes:

Support for ARM64 projects using clang-cl.

Thought I'd mention it here as it might help for this PR. I have a Surface Pro X based on the arm64 architecture, let me know if you'd like me to test something 👍

dennisameling · 2020-11-11T10:28:05Z

Just tried to build using .\vcbuild.bat noetw on x64 with Visual Studio 16.8, getting the same errors as @targos regarding mksnapshot, but there are actually quite some things that build correctly, so that's promising 🚀

@gengjiawen Does it make any difference if you update to Visual Studio 16.8, which was released yesterday?

gengjiawen · 2020-11-11T11:00:46Z

@gengjiawen Does it make any difference if you update to Visual Studio 16.8, which was released yesterday?

I forget to remove '/P'. I should try my build now.

I have a Surface Pro X based on the arm64 architecture

Have you tried the official arm64 build for windows. Will it run ? (I have no device to test it)

dennisameling · 2020-11-11T11:17:12Z

Have you tried the official arm64 build for windows. Will it run ? (I have no device to test it)

Yes (see nodejs/build#2450 (comment)), and it's blazing fast 🚀 I use it on a daily basis and to work on things like an arm64 build for GitHub Desktop: desktop/desktop#9691

gengjiawen · 2020-12-01T09:04:53Z

This is more likely a bug from what I test (refactor the inline implementation). Not sure this need to reported to clang team or msvc team.

targos · 2022-10-22T14:18:10Z

This warning appears thousands of times:

..\..\deps\v8\src/objects/fixed-array.h(105,17): warning : inline function 'v8::internal::FixedArray::get' is not defined [-Wundefined-inline] [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]

targos · 2022-10-22T15:44:38Z

The build ended up failing with "No space left on device" 😞

bnoordhuis · 2022-10-22T21:01:31Z

Hm, that's regrettable. Maybe it's possible to build on C:\ instead of D:?

GitHub's machines have two disks/mounts. The second one has about 10-15 GB free space, the first one is about twice the size when you remove a couple of big packages; .NET SDK + Android SDK + GHC is around 30 GB.

A full list is here: https://github.com/actions/runner-images/blob/main/images/win/Windows2019-Readme.md

targos · 2022-11-20T14:01:26Z

I was able to try it on my Windows PC. It errors here:

lld-link : error : undefined symbol: public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int) const [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-aix.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-generic.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-mac.obj

lld-link : error : undefined symbol: public: static void __cdecl v8::internal::TaggedField<class v8::internal::Object, 0, class v8::internal::V8HeapCompressionScheme>::Relaxed_Store(class v8::internal::HeapObject, int, class v8::internal::Object) [D:\Git\nodejs\node\ 
tools\v8_gypfiles\mksnapshot.vcxproj]
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-aix.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-generic.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-mac.obj

lld-link : error : undefined symbol: public: virtual __cdecl v8::internal::Relocatable::~Relocatable(void) [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj]
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-win.obj
  >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\mksnapshot.obj
  >>> referenced by v8_base_without_compiler.lib(local-isolate.obj)

BTW at this point the out directory takes 16GB on disk.

targos · 2022-11-20T16:49:49Z

I think I found a way to fix precompiled headers. Same errors.

targos · 2023-01-07T16:15:15Z

Next step will be to port asm_to_inline_asm

TODO: upstream change to Chromium

targos · 2023-12-05T13:59:41Z

Rebased in case someone wants to help with this.

lemire · 2023-12-05T17:08:47Z

@targos See PR targos#8

It illustrates how to silence some warnings by clearing the C++ flags in the C dependencies.

lemire · 2023-12-08T01:37:55Z

The warnings regarding the c++17 flag have to do with the fact that the current configuration sets the C++ standard in this manner...

         'AdditionalOptions': [
          '/Zc:__cplusplus',
          '-std:c++17'
         ]

So this is set unconditionally, irrespective of whether we are building C or C++ code. I think that a proper approach would set the language standards for each programming language, like so:

      "ClCompile": {
        'LanguageStandard': 'stdcpp17',
        'LanguageStandard_C': 'stdc17'
      }

lemire · 2023-12-14T16:12:40Z

@targos I will have a PR soon that should help.

lemire · 2023-12-14T17:39:40Z

See targos#9

I think that this is enough to build all dependencies. It should be good enough.

I have stopped short of fixing the v8 assembly error. When v8 builds itself under Windows, it calls deps/v8/tools/snapshot/asm_to_inline_asm.py. I do not think that the Node build does that yet, and if not we probably should. This will pass the assembly directly to clang and should avoid the build errors.

1. To avoid many warnings, this PR declares the C and C++ standards separately. 2. This PR extends gyp so that we can build with AVX-512. Nevertheless, getting runtime dispatching with ClangCl through Visual Studio is challenging, so we disable it. It only affects base64 and one component of zip, so the effect on runtime performance should be negligible. Note that other dependencies such as simdutf do not need to this build support for runtime dispatching (so you still get AVX2, AVX-512 support in these dependencies).

lemire · 2023-12-15T19:33:57Z

The challenge regarding assembly when building with clangcl under Windows is related to a documented issue with gn. The assembly files in gn are assembled by MASM on Windows builds, but this causes difficulties with LLVM. However, clang (and clangcl) is happy to build inline assembly, so you don't need to mess around with assembly files at all.

So the v8 workaround is this Python function...

import argparse
import sys

def asm_to_inl_asm(in_filename, out_filename):
  with open(in_filename, 'r') as infile, open(out_filename, 'wb') as outfile:
    outfile.write(b'__asm__(\n')
    for line in infile:
      # Escape " in .S file before outputing it to inline asm file.
      line = line.replace('"', '\\"')
      outfile.write(b'  "%s\\n"\n' % line.rstrip().encode('utf8'))
    outfile.write(b');\n')
  return 0

... which just embeds the assembly code (.s) into a C++ (.cc) file.

You'd only need to do this conditionally, when under Windows assuming that Windows builds move to clangcl. However, it should work everywhere....

Concretely, you want a file like...

./out/Release/obj/tools/v8_gypfiles/v8_snapshot.gen/embedded.S

... to be transformed into fake C++ (C++ embedding inline assembly)...

./out/Release/obj/tools/v8_gypfiles/v8_snapshot.gen/embedded.cc

and then you want to compile and assemble that and not the assembly file.

It is simple enough and probably a matter of adding a few well placed lines of code.

In the v8 gn file... we have

deps = [ ":run_mksnapshot_" + name ]
sources = [ "$target_gen_dir/embedded${suffix}.S" ]
outputs = [ "$target_gen_dir/embedded${suffix}.cc" ]

In node, the snapshooting is somewhat different. The easiest route would be to find someone who is already familiar with how tools/snapshot works under Node.

@joyeecheung @addaleax : any idea?

lemire · 2023-12-15T22:37:57Z

At a glance, the target asm_to_inline_asm needs to be added to tools/v8_gypfiles/v8.gyp. Hopefully, it is a simple as just adding an entry and hooking it up.

nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. zlib Issues and PRs related to the zlib subsystem. labels Sep 30, 2020

targos commented Sep 30, 2020

View reviewed changes

targos added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Sep 30, 2020

targos force-pushed the clang-cl branch from e0b3e1c to 647f0a6 Compare October 19, 2020 06:08

This comment has been minimized.

Sign in to view

gengjiawen mentioned this pull request Oct 23, 2020

tools: add msvc /P output to .gitignore #35735

Closed

gengjiawen mentioned this pull request Jan 5, 2021

Use Clang on Windows nodejs/node-gyp#2295

Open

targos mentioned this pull request Oct 25, 2022

deps: update zlib to upstream 926ac23 #44412

Closed

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49

targos force-pushed the clang-cl branch from e63aacd to 5133d6f Compare November 20, 2022 14:01

targos force-pushed the clang-cl branch from 63f1e1c to 083288c Compare January 7, 2023 15:53

targos mentioned this pull request Dec 5, 2023

Fix simdjson update script and update to v3.6.1 #50986

Closed

targos added 9 commits December 5, 2023 14:55

tools: hack gyp to generate clang-cl solutions

1587765

deps: add missing zlib includes

b045b8c

TODO: upstream change to Chromium

hack ICU

3eb11c2

hack: sse on win

99a9012

disable some workflows

9cc4af7

additional options

c1d1878

remove macros

edb4036

set clang to 1

52b5858

fix pch

d7cc22d

targos force-pushed the clang-cl branch from 083288c to d7cc22d Compare December 5, 2023 13:59

lemire mentioned this pull request Dec 8, 2023

fix some clang-cl warnings regarding unused parameters targos/node#8

Closed

build: enable Clang-cl Windows builds #35433

build: enable Clang-cl Windows builds #35433

targos commented Sep 30, 2020 •

edited

targos Sep 30, 2020

targos Sep 30, 2020

targos Sep 30, 2020

targos Sep 30, 2020

targos commented Sep 30, 2020 •

edited

targos commented Oct 2, 2020

gengjiawen commented Oct 2, 2020

dennisameling commented Oct 3, 2020

gengjiawen commented Oct 19, 2020

gengjiawen commented Oct 19, 2020 •

edited

targos commented Oct 19, 2020

targos commented Oct 19, 2020 •

edited

targos commented Oct 19, 2020

gengjiawen commented Oct 19, 2020

targos commented Oct 19, 2020

gengjiawen commented Oct 19, 2020

This comment has been minimized.

gengjiawen commented Nov 9, 2020 •

edited

dennisameling commented Nov 11, 2020

dennisameling commented Nov 11, 2020

gengjiawen commented Nov 11, 2020

dennisameling commented Nov 11, 2020 •

edited

gengjiawen commented Dec 1, 2020

targos commented Oct 22, 2022

targos commented Oct 22, 2022

bnoordhuis commented Oct 22, 2022

targos commented Nov 20, 2022 •

edited

targos commented Nov 20, 2022 •

edited

targos commented Jan 7, 2023

targos commented Dec 5, 2023

lemire commented Dec 5, 2023 •

edited

lemire commented Dec 8, 2023

lemire commented Dec 14, 2023

lemire commented Dec 14, 2023

lemire commented Dec 15, 2023 •

edited

lemire commented Dec 15, 2023 •

edited

		#include <smmintrin.h>
		#include <tmmintrin.h>

build: enable Clang-cl Windows builds #35433

Are you sure you want to change the base?

build: enable Clang-cl Windows builds #35433

Conversation

targos commented Sep 30, 2020 • edited

targos Sep 30, 2020

Choose a reason for hiding this comment

targos Sep 30, 2020

Choose a reason for hiding this comment

targos Sep 30, 2020

Choose a reason for hiding this comment

targos Sep 30, 2020

Choose a reason for hiding this comment

targos commented Sep 30, 2020 • edited

targos commented Oct 2, 2020

gengjiawen commented Oct 2, 2020

dennisameling commented Oct 3, 2020

gengjiawen commented Oct 19, 2020

gengjiawen commented Oct 19, 2020 • edited

targos commented Oct 19, 2020

targos commented Oct 19, 2020 • edited

targos commented Oct 19, 2020

gengjiawen commented Oct 19, 2020

targos commented Oct 19, 2020

gengjiawen commented Oct 19, 2020

This comment has been minimized.

gengjiawen commented Nov 9, 2020 • edited

dennisameling commented Nov 11, 2020

dennisameling commented Nov 11, 2020

gengjiawen commented Nov 11, 2020

dennisameling commented Nov 11, 2020 • edited

gengjiawen commented Dec 1, 2020

targos commented Oct 22, 2022

targos commented Oct 22, 2022

bnoordhuis commented Oct 22, 2022

targos commented Nov 20, 2022 • edited

targos commented Nov 20, 2022 • edited

targos commented Jan 7, 2023

targos commented Dec 5, 2023

lemire commented Dec 5, 2023 • edited

lemire commented Dec 8, 2023

lemire commented Dec 14, 2023

lemire commented Dec 14, 2023

lemire commented Dec 15, 2023 • edited

lemire commented Dec 15, 2023 • edited

targos commented Sep 30, 2020 •

edited

targos commented Sep 30, 2020 •

edited

gengjiawen commented Oct 19, 2020 •

edited

targos commented Oct 19, 2020 •

edited

gengjiawen commented Nov 9, 2020 •

edited

dennisameling commented Nov 11, 2020 •

edited

targos commented Nov 20, 2022 •

edited

targos commented Nov 20, 2022 •

edited

lemire commented Dec 5, 2023 •

edited

lemire commented Dec 15, 2023 •

edited

lemire commented Dec 15, 2023 •

edited