Skip to content

Fix specification for mailing-list in configuring-notifications.md#30958

Merged
guntrip merged 2 commits intogithub:mainfrom
mortax:patch-1
Jan 8, 2024
Merged

Fix specification for mailing-list in configuring-notifications.md#30958
guntrip merged 2 commits intogithub:mainfrom
mortax:patch-1

Conversation

@mortax
Copy link
Contributor

@mortax mortax commented Jan 5, 2024

Why:

The description of mailing-list is erroneous. Git includes a List-Id mail header.

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updated the table and included an example.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Jan 5, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

The description of `mailing-list` is erroneous. Git includes a `List-Id` mail header.

Updated the table and included an example.
@nguyenalex836
Copy link
Contributor

@mortax Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review account-and-profile Content relating to account and profile and removed triage Do not begin working on this issue until triaged by the team labels Jan 5, 2024
…ations-on-github/setting-up-notifications/configuring-notifications.md
Copy link
Contributor

@guntrip guntrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR, @mortax! ✨ I made one tiny change, just to update the type of placeholders used, and I'll get this merged.

Thanks again for contributing to our docs!

@guntrip guntrip enabled auto-merge January 8, 2024 15:38
@guntrip guntrip added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 8, 2024
@guntrip guntrip added this pull request to the merge queue Jan 8, 2024
Merged via the queue into github:main with commit 271d7f6 Jan 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@mortax mortax deleted the patch-1 branch January 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants