Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation about escaping values for $GITHUB_ENV file #21582

Merged
merged 4 commits into from Oct 26, 2022
Merged

Added documentation about escaping values for $GITHUB_ENV file #21582

merged 4 commits into from Oct 26, 2022

Conversation

riadhlaabidi
Copy link
Contributor

Why:

Closes #10788

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added documentation about escaping environment variables' values written to the GITHUB_ENV environment file.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Oct 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2022 •
edited

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@riadhlaabidi Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team. labels Oct 24, 2022
jhosman
jhosman reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@jhosman jhosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riadhlaabidi Thanks for opening this PR! I consulted the team, and we made some edits to add further context about single versus double quotes.

I'll go ahead and apply those changes for you, and we'll get this merged! 🎉

content/actions/using-workflows/workflow-commands-for-github-actions.md Outdated Show resolved Hide resolved
@jhosman jhosman added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 26, 2022
@docubot docubot added this to Triage in Docs open source board Oct 26, 2022
@jhosman jhosman enabled auto-merge (squash) October 26, 2022 23:23
@jhosman jhosman merged commit e3ba165 into github:main Oct 26, 2022
Docs open source board automation moved this from Triage to Done Oct 26, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Aknc34 Aknc34 mentioned this pull request Oct 26, 2022
Closed
@cmwilson21 cmwilson21 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2022
nrz77 added a commit to nrz77/docs that referenced this pull request Oct 28, 2022
@nrz77
Merge pull request #1 from github/main
c10e132 
Added documentation about escaping values for $GITHUB_ENV file (github#21582)
nrz77 added a commit to nrz77/docs that referenced this pull request Oct 29, 2022
@nrz77
Revert "Added documentation about escaping values for $GITHUB_ENV file (
91b1e4a 
github#21582)"
nrz77 added a commit to nrz77/docs that referenced this pull request Oct 29, 2022
@nrz77
Merge pull request #2 from nrz77/revert-1-main
0aa7097 
Revert "Added documentation about escaping values for $GITHUB_ENV file (github#21582)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhosman jhosman jhosman approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge
Projects
Docs open source board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to properly escape values for $GITHUB_ENV file
3 participants
@riadhlaabidi @cmwilson21 @jhosman