Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 cpp string concatenation library #14954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bdrodes
Copy link
Contributor

@bdrodes bdrodes commented Nov 29, 2023

Adding a new general purpose StringConcatenation library to allow us to locate general string concatenation operations, grab their operands, and grab the result dataflow node.

@bdrodes bdrodes requested a review from a team as a code owner November 29, 2023 21:05
@github-actions github-actions bot added the C++ label Nov 29, 2023
class StringConcatenation extends Call {
StringConcatenation() {
// sprintf-like functions, i.e., concat through formating
exists(FormattingFunctionCall fc | this = fc)

Check warning

Code scanning / CodeQL

Expression can be replaced with a cast Warning

The assignment to
fc
in the exists(..) can replaced with an instanceof expression.
Comment on lines +66 to +68
this.(FormattingFunctionCall)
.getTarget()
.(FormattingFunction)

Check warning

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
FormattingFunction
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant